From nobody Sun May 24 20:35:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 682593D75B6 for ; Thu, 21 May 2026 14:22:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373330; cv=none; b=GcdkAZIo6Kr6QOUmtoaPYXPMet2tfn8mA78K4RHuHyzL35/5Xsw9RbnlVTL2oteX1sZ+/yUvTf5Re9iK83K+ATX3DTyk9vOPEwy75J7a8kiSE4EXwF6mtlqMkHy2tTgNpLbYzbivZHeI+HPLzODQUznYGK9MUMd+RnTLl3mT2xU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373330; c=relaxed/simple; bh=1rat9CVwl4Niea8fgGERMdP4TdfM0tYDE6ELOJ13qUk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=VA2uaker2bev8RXaxsdRC1ntyYPcCL89NZL+XAQUhiEBiyBPuXCA5jEWO2WCCAKK712VoXGGowGhFX1eJj+MU1tXM46EnM8s4bYue8HbST3rRHDRQzgP0x78uCq1YlBfttP7aF7lkxTg7YlSXekpTPavGgedyqugqTJPqGZ16os= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kRFjpJA5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Fv17U/tO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kRFjpJA5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Fv17U/tO" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L99oQR3009546 for ; Thu, 21 May 2026 14:22:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=tjQZHonofPoPkduzjXR9qz XB3BrD17EPQfqK72P+4m8=; b=kRFjpJA5a6oyulsn8g2fmcZsdMJhEKJcP6hjv9 DzKSSKwnQ7/GCiUyLbMOp5pnATbPKk+iRtkT7Dpee49B9HvheWLGRSNSDora7zzy /vnkqN5CGqw+X11pAMotMBe4izG5L/Nd3fRw2qL2JXWCWw1I7hgjpMx9xUkT1m0f Buzt45Br+tZOlFcfPp+cRYw4fgx2nDH6CdcO2BlYLTrpW4Revjt90Jx99ztw1R3l tvFrM4sXhh0t2ChNCqH6XFI7av/1+HgU0eeYL8Bx4gpP3lQigIvdQIX5L0X73LM/ wK6IoI0yPCBR3Z+R6QFDlbSDe4Yl+fEeO1Zy2nL/ZzTOuUnw== Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9sr32mps-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 14:22:07 +0000 (GMT) Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-47018d3424fso11964820b6e.2 for ; Thu, 21 May 2026 07:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779373327; x=1779978127; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=tjQZHonofPoPkduzjXR9qzXB3BrD17EPQfqK72P+4m8=; b=Fv17U/tOpLvR58NoUjLGGJmrIiH29fthXKQL0Ufnfq+wuayW+Wxgc9p6VBi5vKNFkg mMWSufx4yxPjjhF4LCJre74pnND15K18v4n4+usSI5UybLUk3iexTEg56elfEGYkB/Tt 2/GEhnzbz53qsEKsBzyIKoksGjd/fn1oeICy/Op+xG8E68jyC4gm7skPQcZHdSstnNJr DsbK4v96h0VNGSEzfHhsatMRE4vVR60hkhJ5qDl0F6/kPUrUP9HKhQLeuQAuzgCSJcST JkqR1sePw476qWlpYqfAyKsMd1MSYlkj2w2Y7n3/9Mli+9MdFwMvPO1FJ2Keo67TPIm6 BiTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779373327; x=1779978127; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tjQZHonofPoPkduzjXR9qzXB3BrD17EPQfqK72P+4m8=; b=Emt54bq1trKwwV9Bk5sFAcWGHMzfRSvD0wWa5PxW7Brmzxa4CN0WGL9im4lutPZFw5 igRAQ+XGHgZNk34twRHTDpJW6uonK+rV0Vx2n6fWAujaeTvZB+J/SsUtSvYEnGhUnqnV rDsEgrdk6GZK8bUvyX64dQXIq0FhWKD6gDOrVK4l/ENfNpnL2XwWnIhwfQhMi2QVDABK F6bVMqOMGUNJ7jVdWYQZXT7LlSerJbc+hCYUP1Nv2GnZPTE/oJjV+bwMck/I33UaP7RY RbG8+GeK0i9ERKeNLDvOB4B4WZYtMS660NH4Oizd1zQS7k2gT3RnFxvoGRrr7g1YMozl g0oQ== X-Forwarded-Encrypted: i=1; AFNElJ942VS8e9epi5nD6DKDmpZRSl5Icq4ggrMLHY05Y7deJ/dYowaBN+lFR9Cak3uYaU+v5Q9pzaS4LollOBI=@vger.kernel.org X-Gm-Message-State: AOJu0YwC+YMioqccUHyV/zJ0HyegDVBljQ+xy+NttEVEVV4PyqWVUPUB EQvRW5Lsf0NkQ3Zxj364XhPi3Jq7/k2rRDI/nCKSxx7HzbRUHnh/8qlrg0fXb8NE/TTAFxRoTn0 QdXhdFQfB2lB9zU28d3TyXZvCrgkxfIw6unW/82sPZo2z+UudVpnX4/xG9zVAzJa2YJc= X-Gm-Gg: Acq92OHsOnZDaJSu4SSjMwLXrE/icVADiAsQkQSWGETpOweG82JvG7D9chPmSGCpRhB 4HocTxGZ0W0lqeW1liI+GN0th+2Qu3WxbSb0AGlJWQ5CmF3x6XAPFK0P4HqkF7RwSJrV42ihRz9 j/WyY5DX7swlV8IesQMLTnS4HsdrqLjgZy7ADSTVb5H/Lc4X11GL/QHoSlqJdf+vcq9EJt3zlKy oStUNpj+UxYzykKUvr4lgDp4omPK/2LSB7eXdSy7GDnuX2Mu1tae8aLim2hzueVN3X77JvJqzQv Ug0E7l3mjrhxioCb1768ftu6YqhnFLfNwlcvUVdNFq1g9gaoT0bo9Cdw0TUkgraiof25VW5vQsm 1u8jfPctgUg2lOUYq26JPhWAVMhpUqle/GPgjuC2TqMt3w6MO4FE= X-Received: by 2002:a05:6809:1d3:10b0:485:403d:9b92 with SMTP id 5614622812f47-485403da2ebmr483394b6e.22.1779373326614; Thu, 21 May 2026 07:22:06 -0700 (PDT) X-Received: by 2002:a05:6809:1d3:10b0:485:403d:9b92 with SMTP id 5614622812f47-485403da2ebmr483328b6e.22.1779373325408; Thu, 21 May 2026 07:22:05 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:bb10:ae82:b7c3:d15a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49033d3515asm77835655e9.1.2026.05.21.07.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 07:22:04 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 21 May 2026 16:21:55 +0200 Subject: [PATCH v2] gpio: shared: undo the vote of the proxy on GPIO free Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260521-gpio-shared-free-vote-v2-1-7d948edfdbde@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAAIVD2oC/4WNQQ6CMBBFr0Jm7RBooVFX3sOwqDCFSYRCBxsN4 e5WLuDmJ+8n//0NhAKTwDXbIFBkYT8lUKcM2sFOPSF3iUEVyhS1KrCf2aMMNlCHLhBh9CuhM0p rbR+Vcw7Sdg7k+H14703igWX14XPcxPLX/jPGEks0bV1djKnPmtTNi+TLyz5bP455Cmj2ff8Cn jRbRMEAAAA= X-Change-ID: 20260520-gpio-shared-free-vote-f62333ab4fff To: Linus Walleij , Bartosz Golaszewski , Marek Vasut Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2177; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=1rat9CVwl4Niea8fgGERMdP4TdfM0tYDE6ELOJ13qUk=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqDxUHV5v8hUac6HLEvYQXkTatbtsuwpfb6fJo1 uspQdUZ3t+JAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCag8VBwAKCRAFnS7L/zaE w0yUD/9mgwuMNoqcp3xQCZrP9Fi6lKeKgbt5otASRC027wvX9/q+X++d5sXfE31iFsPSAuJGovw akDqVNx/qIfAkMM+wdBj4LfRLN8byup7bE9p7fNn1086l0uxuJ63OavrcWwml3I0hpak5EUbkAL Fl3Uy7g1TkUXtIMN06ptREQUggyo5aUujh55xPqA2fY9cVjsAy989LhAoLMlChJohNkbjh9iKez D7wHhPaN0xXd4d4Atbs2WherT6kDIKwKH57ToifliQ1QqFlYCC9+8/fn0qgna4IyPfeCtzv5z81 588rdK2efYGDfHmIi47jQvL0Y7WUPSD3dAx7zBCdmo0tERhcnpv7BDFgTTVAEMCY8mkrvceUEfY GOMzhA0g3CgkNJzDkJjV2Otni0zd/2QQeu7BhbVs5wQ61wy9O/aMXNy8Grf0vH8OKKxFIgJ5Mi8 ApK+tdGUw3JMhUmx7iLqIWchUtb9wcvBsRu+x2sh0vXRp4zn1Sd1tp7e9cMW9rYfKbPeKhHh9r3 ErGpGTo5YMcwZs4cW3uymzWivccd6K212W1JjyUMemzV0vb9T0oYMzkDBhisDPNQyFjvVl8/Atk 33Rc7Tfi69elwRmG/gNf2uolAgXrZ+Byfyr0FyhWXKMQ4TpkCOm4FwadIyjLT2U1Dn9o0seZjqM JEcFgj6UlUJ5wRw== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-GUID: SucTte8WA0ZW7DG0j0s2WuZwrYIb7lYd X-Proofpoint-ORIG-GUID: SucTte8WA0ZW7DG0j0s2WuZwrYIb7lYd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDE0NCBTYWx0ZWRfXypz5mFjON4lO Q0pyfSujIwQMuHg1P9iFMdNxooejGYvcNOFInbfeqN0t10DtPES9bo6lX5x2DjKMfmRl/+oIGuY yq+ch37fDy5yhoaPOHQNkGOPt3lFXb5gGMjvNfaNGIvRP3tuHsGWypcrv+0F3fvIZ8rX7GOdEEV 7YFK6gCvYCnF3eQ1F1LSCrI4jPGlBXtj0EBF5OqMBNXuEZ2thF57qWCdfJipujjPmBbQsj9nTw5 mFKw5Jy640oraY8VrY7R0iNCEKTQ0LUxgk8OKSi/Q3J1f7akzjfCk5KIgeDNN8COOZX4vXMtBKd Q6j6ede/1AoH1PX3aHSwrcoidDVRj7hLqfydd5eGI+9qEi4Fsug2JpXwoHritnx0SAIDkr/ZvOf tEKnDxSOAr5R/W6+QXFrUTMYrSUjSKFi6j5waqwclrO0LMMkxdWPRSQRRvAczPw5tFDSWR66n+q OI1tt5jiSRxVinDhvKg== X-Authority-Analysis: v=2.4 cv=L+YtheT8 c=1 sm=1 tr=0 ts=6a0f150f cx=c_pps a=AKZTfHrQPB8q3CcvmcIuDA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=c92rfblmAAAA:8 a=EUspDBNiAAAA:8 a=bC-a23v3AAAA:8 a=VwQbUJbxAAAA:8 a=C00im2qEfLC3rBLg9RsA:9 a=QEXdDO2ut3YA:10 a=pF_qn-MSjDawc0seGVz6:22 a=GvGzcOZaWPEFPQC_NcjD:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210144 When the user of a shared GPIO managed by gpio-shared-proxy calls gpiod_put() to release it, we never undo the potential "vote" for driving the shared line "high". In the free() callback, check if this proxy voted for "high" and - if so - decrease the number of votes and potentially revert the value to low if this is the last user. Cc: stable@vger.kernel.org Fixes: e992d54c6f97 ("gpio: shared-proxy: implement the shared GPIO proxy d= river") Closes: https://sashiko.dev/#/patchset/20260513-gpio-shared-dynamic-voting-= v1-1-8e1c49961b7d%40oss.qualcomm.com Signed-off-by: Bartosz Golaszewski --- Sashiko commented on this pre-existing issue under my patch changing the voting heuristic. --- Changes in v2: - When releasing the shared GPIO, restore the value to the "default" low using the existing interface to keep track of the votes correctly - Link to v1: https://patch.msgid.link/20260520-gpio-shared-free-vote-v1-1-= 6c54966583e2@oss.qualcomm.com --- drivers/gpio/gpio-shared-proxy.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpio/gpio-shared-proxy.c b/drivers/gpio/gpio-shared-pr= oxy.c index 29d7d2e4dfc02c34fb3f2abc343ee30b61579b66..c43a117de016af03282961ec843= ffa8cea00ec5a 100644 --- a/drivers/gpio/gpio-shared-proxy.c +++ b/drivers/gpio/gpio-shared-proxy.c @@ -103,9 +103,17 @@ static void gpio_shared_proxy_free(struct gpio_chip *g= c, unsigned int offset) { struct gpio_shared_proxy_data *proxy =3D gpiochip_get_data(gc); struct gpio_shared_desc *shared_desc =3D proxy->shared_desc; + int ret; =20 guard(gpio_shared_desc_lock)(shared_desc); =20 + if (proxy->voted_high) { + ret =3D gpio_shared_proxy_set_unlocked(proxy, gpiod_set_value_cansleep, = 0); + if (ret) + dev_err(proxy->dev, + "Failed to unset the shared GPIO value on release: %d\n", ret); + } + proxy->shared_desc->usecnt--; =20 dev_dbg(proxy->dev, "Shared GPIO freed, number of users: %u\n", --- base-commit: 687da68900cd1a46549f7d9430c7d40346cb86a0 change-id: 20260520-gpio-shared-free-vote-f62333ab4fff Best regards, --=20 Bartosz Golaszewski