From nobody Sun May 24 22:35:49 2026 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AB73375F9C for ; Wed, 20 May 2026 22:57:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779317842; cv=none; b=EeuaresjmwVZdZalRLxL75Dcfl1PdBlOHeJOhYLdrxubYJfhGsIGMhLOmLRAHg4BOT1E+525Mdmc29J23gzi+QvkJUn5EhWKwI1Fiwd6XUD/Mp/PSejHRW54apyyLYQLkaEQkFQdmIE77tGXRDAMXJJcL9qLzr9x6HoxLjrDlMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779317842; c=relaxed/simple; bh=9WDmz4mIk7d37pNF+Jf3V82CnN2ksLJhxTsJcZyYoPA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pp03E3SK31CeqALWy/iZXoBLT67cuw0PLoLDjs0UNaE+sp40wGIissPhPUs8YdsxGwa++ngDPdplfn4NaHhCA0XJIiJDDKa22g83G0ZsW2j419cKzal10wlWk00jFoNqB65jzW0GhSr6y1JI5aOt9aCdeIP59lNhAE1ouKIkU0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SC/CUCJt; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SC/CUCJt" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-687ed9aabb3so709348a12.1 for ; Wed, 20 May 2026 15:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779317839; x=1779922639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O5LTi7OvRi2audUUcgHNeX3CP0k1T7QcTMVWKqi+l/s=; b=SC/CUCJtKH32blGUdu8kFVrjcjBGb45otHujNLAnY0itPJHnV7NEcWihQUoVZiDAyS tmxfhH2uLd18VS/c636hFzr60VDqmibXz3eZRh/QLhamHy1NCzTKHdlYNtJOlDpeq1TE 4oulgBryY4e7e2mLvZhA2IsnMPzkDjbgFY1H6eH17cq1RBG+k5/KUE5uFQi521eXwuCn zu924dxshEHNdL0rC1MoUQYMCOUGY0uYUlyHMoqWRT+vYs2A0L+i6Y4CKTSJrhJFAn/H z211wZlr5KHqIHiJIrB+0DagwsjwNVW3eQUo0dW2JjDUgk/uD0GKa5xXqEnvBBGJpEHV xaqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779317839; x=1779922639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=O5LTi7OvRi2audUUcgHNeX3CP0k1T7QcTMVWKqi+l/s=; b=GKMMgxqNMjf0yZ3cssttjiMjf06AYy/rLFH9DbkdwDM7rAtYqu/HNfhu1rxsDkqnM/ VpUghTgvquAnAuVAY50wKEqSISBYUQwEo/6u70QlsqVHR2zfcYZjSmulg3ttLLIbbU65 QxhAUtSZoOF+KPikeDCIbhYhN9b88ZlZkfL12LynUqtmAy0KVef/nzKFeOT2HdqCejiB suqgJQnLmo58tJK9L1Am41M/TiQNygMwu/g/kuwM+18XOzEvBL89dFTHaQaMjiVlOr+n pRjvixT2V6QW4CNJS+tNnTd6pgLZYzkbGaDkCdnszYiz7kPgbn0540iKT/WiTE4Yp6aQ Jt+g== X-Gm-Message-State: AOJu0YyXViPxwWxhu0QxjF/CPZx5BL7rdoM4MQkXDfR3m7yV/fWU+IoR 55ci5OByeYmwwdS7FOYLHrQcpMvfpE4tY0W93baKLW9kV9vLiay7F6EUo0neDbQPfhMekE6g X-Gm-Gg: Acq92OGj+0I+UHkxoGoKHVMLzJi1YiQqZd5w4a0n+p4SGJh/F7o1/N3A/Dixwf5nj4i e2vsYiRQmRmv+/h2sVEnSX5q3wEz5zbCZFYl9tyqQ8ayk0yWjgp8uiI2nbPGlPb5dd5XkkrzLOm IsIfV38s7CVNmQuE2DDJbje8YfdHumQHQT04fXt1bMUdPMkBjzzwqA7Z+Kixv1W5PWCXfei3ywU bX0jevFrdV+//OfjP1FReB01SY6stupRu3fcqKfgsIz44Wtnf6hf1xahsofHrRmw1l0FUUZwudu uaP9L4Ehr9xb4A7SMUO976Dw2+woKoCPk9gPn3h6IbeNRvcou4HkmeORlsJOCp8WZ/G2RlSDhgP I4S/ubWFaakZIy8QNyxsS8pvhuQIw3RMx/TGRPqSKUkMJ797V6ErzQR3TQfbDFWAtJtOLZAZWz4 /sssIoEO+b63u5Z5d0oJG9s3g3LrzTKgXh1224jBW0A9SlkQgviN4dPKJSJkt/hrOOt/TJ7zHN/ hwn4Q== X-Received: by 2002:a17:907:3faa:b0:bae:d29c:4e28 with SMTP id a640c23a62f3a-bdc12aa6420mr10795366b.12.1779317838922; Wed, 20 May 2026 15:57:18 -0700 (PDT) Received: from node ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4ded99dsm903754266b.30.2026.05.20.15.57.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 15:57:18 -0700 (PDT) From: Muhammad Bilal To: linux-bluetooth@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Marcel Holtmann , Luiz Augusto von Dentz , Johan Hedberg , stable@vger.kernel.org, Muhammad Bilal Subject: [PATCH v3] Bluetooth: HIDP: fix missing length checks in hidp_input_report() Date: Wed, 20 May 2026 18:56:43 -0400 Message-ID: <20260520225643.35683-1-meatuni001@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" hidp_input_report() reads keyboard and mouse payload data from an skb without first verifying that skb->len contains enough data. hidp_recv_intr_frame() pulls the 1-byte HIDP header before dispatching to hidp_input_report(). If a paired device sends a truncated packet, the handler reads beyond the valid skb data, resulting in an out-of-bounds read of skb data. The OOB bytes may be interpreted as phantom key presses or spurious mouse movement. Replace the open-coded length tracking and pointer arithmetic with skb_pull_data() calls. skb_pull_data() returns NULL if the requested bytes are not present, eliminating the need for a manual size variable and the separate skb->len guard. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- v3: - Replace manual length checks and pointer arithmetic with skb_pull_data() per Luiz's review v2: - Add Cc: stable@vger.kernel.org per Greg KH's note --- net/bluetooth/hidp/core.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index 976f91eeb..70344bd32 100644 --- a/net/bluetooth/hidp/core.c +++ b/net/bluetooth/hidp/core.c @@ -179,12 +179,21 @@ static void hidp_input_report(struct hidp_session *se= ssion, struct sk_buff *skb) { struct input_dev *dev =3D session->input; unsigned char *keys =3D session->keys; - unsigned char *udata =3D skb->data + 1; - signed char *sdata =3D skb->data + 1; - int i, size =3D skb->len - 1; + unsigned char *udata; + signed char *sdata; + u8 *hdr; + int i; + + hdr =3D skb_pull_data(skb, 1); + if (!hdr) + return; =20 - switch (skb->data[0]) { + switch (*hdr) { case 0x01: /* Keyboard report */ + udata =3D skb_pull_data(skb, 8); + if (!udata) + break; + for (i =3D 0; i < 8; i++) input_report_key(dev, hidp_keycode[i + 224], (udata[0] >> i) & 1); =20 @@ -213,6 +222,10 @@ static void hidp_input_report(struct hidp_session *ses= sion, struct sk_buff *skb) break; =20 case 0x02: /* Mouse report */ + sdata =3D skb_pull_data(skb, 3); + if (!sdata) + break; + input_report_key(dev, BTN_LEFT, sdata[0] & 0x01); input_report_key(dev, BTN_RIGHT, sdata[0] & 0x02); input_report_key(dev, BTN_MIDDLE, sdata[0] & 0x04); @@ -222,7 +235,7 @@ static void hidp_input_report(struct hidp_session *sess= ion, struct sk_buff *skb) input_report_rel(dev, REL_X, sdata[1]); input_report_rel(dev, REL_Y, sdata[2]); =20 - if (size > 3) + if (skb->len > 0) input_report_rel(dev, REL_WHEEL, sdata[3]); break; } --=20 2.54.0