From nobody Sun May 24 22:35:57 2026 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98156375AB2 for ; Wed, 20 May 2026 21:41:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779313314; cv=none; b=F57h5OG3cqndFiumI+tpMXCQNav2meKUiWIM3t3LJsylbTYPtQjy/Ihzyljsm4jRL6IgK2JAR7s5x0rDeyOII5fV16wjJEaQYx3mSQFHMJ0gOLOOfVPv8JqQXWScCjZzjs26MbnbeIk0ngjGNN41u48JQCWh7/j3MPshqfV20GE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779313314; c=relaxed/simple; bh=q8FoWYVLPlkL+kH1MsFlOIr4cXjQCeHlCbdbANhazyg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nUEM/I22wJA2gmW7CF3nn5bxzxW7vDMqDV6lTYaG1jnsX0nkqWzBlAKNr/gm4ZYK+D95+BwIRFHkt8xGOkR53jKi65csahxXiR3HFJuRUm8xF9w3Sq78QcjPoCshNdrjfd9A80n50Gjw9s0k5s31Z3PAyveGy9QlyvIT/muJxaE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YQZxUipI; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YQZxUipI" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-687d82dd690so587661a12.2 for ; Wed, 20 May 2026 14:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779313312; x=1779918112; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h5t5r4M2iJCMhY9Y3g5BpbaSaxYN98wLxatFgP2FtCk=; b=YQZxUipIL3ZA2ejuNDHIE56BWxfIY+R8uUG57g9rLJbtSnMdABJFAUoySHBqN5VXJ4 yNvOspgMF2wU5INT9InKDCkY1g+3/04zfl2RNfWQBfeM+rKBpZ6dP9IQR1VA1GohhjAT otx7yWDrVP0/pMHSDr6O4g5C30AkRmvCVxJAftPX+bYyl8PpzyJ2q6JLz32jrPAlQSBk E2kilWioQ1hUTz3qfl0iZW9Bbg9RnuqG+QGycIXJuKF6KQZQFrqcwoU+cKDXBOOxP44q VKbl1OV5dWH0bjQ75tXhsYy8cC3vOGPKssNA2UcmVgb2lnh/MPbOj353K/OD6rg9MBm8 asVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779313312; x=1779918112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=h5t5r4M2iJCMhY9Y3g5BpbaSaxYN98wLxatFgP2FtCk=; b=iUM91doTPl8dqbg1vtIe0BZyvfI7sTvkuHLsMAi2mU/+XoawJpYsWafF+uV5HIcI31 g8YlV/6dm1T3aKw9R/C1g0jnUqyO2vncovFpq2CLEyX9bnp3arFw+m2MFEKODqvHeEsy mGFJjJNRV4nL45SVkpQ92M71mV3bUfdHnTbdpuKywRFR8xxWAyDPHYnVrWdC/vqNut80 IEZ41sviJhjAQLr4XjvDcSuHbWsRunWHZt3QQ8MZ1LrH5XkkDwaIzWOi7SuOJTY6+iWV 8NEvuzvpJBLoaXv2s3EMNnsD81UoKEHFpwbRkDoqByLWjwDameVh7YG+n628sX8bNjLk cwPA== X-Gm-Message-State: AOJu0Yz6kVqqEh7twntOErDFkoZf9lBuB94E/Her+FU3SYTjKhqreTZ+ THjNI/VoxYaQ8TLaO+sGKD2HNWZQ4M/t23/WtdhWrVVoVjz8jeBSrUMp X-Gm-Gg: Acq92OE7DhsePV/WK+GsOApIqCHaUBeGV9DUcjYbzAlwvDj+66MOaQ1dsh58h6PPh+S c1hShkWj+Vy7rl4IT0DVo9zpbRlUUhPnG6Rh5T6q7+ZASZA9uWchs4nyMaSA5ECMaYAiqyq6UiH w14s7ywY8IatmQylkXhcOOtF8lBXjE66Q0JlLuJsvDKMfgMy+q0LpkzUZSFm1cdsqQuyv6t0pIP SJbNCk3L7cwIvIF3L2lTv+niRDb5scbVbV9WoHOtZEyP3lG+vZkAZdvspea0Y4J/+bpLQOVlmyZ fTH76WTSSIU2u15Q3J7LdShF66AEmgCigkbQ8qIy7IEVTIfcXVg6T3p9UZ+zoZyue2tCJ5X+s5K CSa8F5gPb/AbV1gRkYWkRu0XJkFHmDjUg8aOlVS6xFzOP6Fi5CIn5+ftKKoH7FN/ea+ulgguU5O bYF4Vj/VdeHWtZEXoTr7GNasZkYnlnj1DbbzvjyIeiU3vIiWGyugbD/5Xx/sJVPRY8VpA6BoITG g== X-Received: by 2002:a05:6402:358e:b0:682:d56d:1de8 with SMTP id 4fb4d7f45d1cf-683bcd9f01emr13077801a12.14.1779313311894; Wed, 20 May 2026 14:41:51 -0700 (PDT) Received: from node ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6882442b03fsm114869a12.12.2026.05.20.14.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 14:41:51 -0700 (PDT) From: Muhammad Bilal To: linux-bluetooth@vger.kernel.org Cc: linux-kernel@vger.kernel.org, marcel@holtmann.org, luiz.dentz@gmail.com, johan.hedberg@gmail.com, Muhammad Bilal , stable@vger.kernel.org Subject: [PATCH v2] Bluetooth: HIDP: fix missing length checks in hidp_input_report() Date: Wed, 20 May 2026 17:41:33 -0400 Message-ID: <20260520214133.27746-1-meatuni001@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260517234805.116570-1-meatuni001@gmail.com> References: <20260517234805.116570-1-meatuni001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" hidp_input_report() reads keyboard and mouse payload data from an skb without first verifying that skb->len contains enough data. hidp_recv_intr_frame() pulls the 1-byte HIDP header before dispatching to hidp_input_report(). If a paired device sends a truncated packet, the handler reads beyond the valid skb data, resulting in an out-of-bounds read of skb data. The OOB bytes may be interpreted as phantom key presses or spurious mouse movement. Add a check that skb->len is non-zero before the type switch, and per-report-type minimum length checks before accessing the payload. Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- net/bluetooth/hidp/core.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index 976f91eeb..03838a6ff 100644 --- a/net/bluetooth/hidp/core.c +++ b/net/bluetooth/hidp/core.c @@ -179,12 +179,22 @@ static void hidp_input_report(struct hidp_session *se= ssion, struct sk_buff *skb) { struct input_dev *dev =3D session->input; unsigned char *keys =3D session->keys; - unsigned char *udata =3D skb->data + 1; - signed char *sdata =3D skb->data + 1; - int i, size =3D skb->len - 1; + unsigned char *udata; + signed char *sdata; + int i, size; + + if (!skb->len) + return; + + udata =3D skb->data + 1; + sdata =3D skb->data + 1; + size =3D skb->len - 1; =20 switch (skb->data[0]) { case 0x01: /* Keyboard report */ + if (size < 8) + break; + for (i =3D 0; i < 8; i++) input_report_key(dev, hidp_keycode[i + 224], (udata[0] >> i) & 1); =20 @@ -213,6 +223,9 @@ static void hidp_input_report(struct hidp_session *sess= ion, struct sk_buff *skb) break; =20 case 0x02: /* Mouse report */ + if (size < 3) + break; + input_report_key(dev, BTN_LEFT, sdata[0] & 0x01); input_report_key(dev, BTN_RIGHT, sdata[0] & 0x02); input_report_key(dev, BTN_MIDDLE, sdata[0] & 0x04); --=20 2.54.0