From nobody Sun May 24 22:39:33 2026 Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazon11011012.outbound.protection.outlook.com [52.101.125.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FEF3363086 for ; Wed, 20 May 2026 20:18:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.125.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779308316; cv=fail; b=f+vLyQA6EtDoAj8pzMPNNpH4c1ATbQglLkkZ4lj/zOtT05K/icepbJc8gMDs5gsRGHZPTxbEKt7WyZa95I/0s5+r6Qj0En6jLPXTp50QMei3DvKJX+7XizVRkE6ASfuH9C0rcsyJYc4FJgRO1vDDIF41wwyIBNktG/GPfepY//E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779308316; c=relaxed/simple; bh=AMjKOgENwkQ8kcpyMnMhynFzUXWYB5v8QjloHWHOeg8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=kGvp1I5Rv2ATqDIx4tjqNeNkfcYJQb8GznYLelTlneaVc54za1FHQmuFZFK54IRfkKjoj2hC22vtbUjhdN8qMSJ1ZujhuhdgZ6dM8WBswaVP+TsTX+ceW1PyWgmJtTOXMUL3WbbaVDaEDUZ43roPBGPDEpZKOP+SIi4jONRiIdI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com; spf=pass smtp.mailfrom=renesas.com; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b=oMvJzgQ3; arc=fail smtp.client-ip=52.101.125.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b="oMvJzgQ3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=a4ebZ3X3Bl/2w2g1hQJhEKO1FirWLoKBz98c6vAj4T3kxLAmvNo0D1G9Sd5jqk5ZNcdFQW11wewUDwsKKaGVWTBSNa7K1EXKNiiocGPr1zUIOSDd9wG70unSZYPK5m2iueHKxzQhkhc2noXw+Bu5uJj6dp207Ui8+rJyhVnV7LytdtctMAQTU2Ym5LkHc88tTLRONLt4AX47BsQPRHmcStgbiYwvzGQVYzFisaOBlFsjjfJB8Nr/pq15An4D3vW3DETswM9GZydR9sWf3hUNlmwg+K1iS1NgDNkFMWE+5BpCAXmzy//ly71Xk0ViVF6qVv7bS9FwT8l7Sxev1nT1uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c7CAFKlt5yPcBbGXsBWJDTpmgaczVFsnsd6tkhvnfQM=; b=ZGwwDUNF8vOIWb2AMZN1oIPhCdivfZ0jt2FkhA9uBGsVWg08iILbZO0qk0F1o6eudN7gtQCzJLyfG8uiqBj6Fm0XYP4TZMpuiCxa9K36KJmovby25oWQIwi+lhdwO1z3iV0IRv7hmTZ6ZE/tlPNL3yADgokksUGfqlz6FWEeIDw4MwnI57Kq+BnFs2Iq0msLrbdePji9yw+W7OGaAF1ozfjyX7HWcKK4HY06mFSXvZwaW0QYJ5wi3S7QGPOoH6HopGv46O4LegDdWNQOKXwxu+j+RuXahkh11Yc2HMZM6qv1tfq0nqjA1gIUS/2tGb9Os4ctWJfTyJWHf2/A+TOIKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 8.62.32.50) smtp.rcpttodomain=bp.renesas.com smtp.mailfrom=renesas.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=renesas.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c7CAFKlt5yPcBbGXsBWJDTpmgaczVFsnsd6tkhvnfQM=; b=oMvJzgQ3lleBBj2fTK/4PhCnQyKTpVvlxHkYB5H0+763DWXJuUtN1cxxFvBsPZJs83WSFh9W+1Jpb6JNAPJtSzHv2RpgOjMruCp9+QHJXVEQnRfJb3+ahYLhQg3jN6b118s4e28tPEa3osSxiWJWanUiSvw7U6DuxcIfbuw4ZzQ= Received: from OS7PR01CA0112.jpnprd01.prod.outlook.com (2603:1096:604:258::10) by OS7PR01MB17338.jpnprd01.prod.outlook.com (2603:1096:604:43e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.24; Wed, 20 May 2026 20:18:30 +0000 Received: from OS3PEPF0000003E.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:258:cafe::e) by OS7PR01CA0112.outlook.office365.com (2603:1096:604:258::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.16 via Frontend Transport; Wed, 20 May 2026 20:18:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 8.62.32.50) smtp.mailfrom=renesas.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=renesas.com; Received-SPF: Pass (protection.outlook.com: domain of renesas.com designates 8.62.32.50 as permitted sender) receiver=protection.outlook.com; client-ip=8.62.32.50; helo=ejcrelay005p.adwin.renesas.com; pr=E Received: from ejcrelay005p.adwin.renesas.com (8.62.32.50) by OS3PEPF0000003E.mail.protection.outlook.com (10.167.240.7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.11 via Frontend Transport; Wed, 20 May 2026 20:18:30 +0000 Received: from demon-pc.localdomain (DEU-5CG5050QD0.adwin.renesas.com [10.226.92.82]) by ejcrelay005p.adwin.renesas.com (Postfix) with ESMTP id A06543013CBE; Thu, 21 May 2026 05:18:28 +0900 (JST) From: Cosmin Tanislav To: Thomas Gleixner , Lad Prabhakar , Geert Uytterhoeven , Cosmin Tanislav Cc: linux-kernel@vger.kernel.org Subject: [PATCH] irqchip/renesas-rzv2h: unwind on IRQ setup error Date: Wed, 20 May 2026 23:17:36 +0300 Message-ID: <20260520201736.1509741-1-cosmin-gabriel.tanislav.xa@renesas.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PEPF0000003E:EE_|OS7PR01MB17338:EE_ X-MS-Office365-Filtering-Correlation-Id: aa923c9f-9894-4342-df04-08deb6acf5aa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|376014|82310400026|18002099003|56012099003|11063799006; X-Microsoft-Antispam-Message-Info: Ospje7C68CnduB8mMarKeou2bGqyZwh1oD+j8/5iFeIUfv1o53ruQSmsZSuo27v7ZOUHBf90QTypTCbsUyO/5HyvnX68nEdIAekpwzVxp1jdLUkaEG3X5XJqf6DlCU/tveFrzl7oxD9DP+G4KUgBxj9DwUe3arfIkbH6mVADmfcQvK7M/rYp5IeHwq5Pdf0hKPHVcsxCfQkXkzFLQRaBAJmccioa69d4UoeNeW69qruDf0Nwuxe+hM9O6ZYoSY3XEygei4v77cEn+SXhZSN4H57W7f/3ttlWrH38zIDdJYSZAjP15PATWmj77JQ+EH/48yacCDb9XDUR03NIkCL/mnpsagusVeVeGLdOZmwl9euBjeYV2zA742jb6ZDlxCV6FxWKgu+Dz4bU+S13VtzvHhSJ7nKdrt1K4aqFC/ArSFZQ8zVudR7WTnc/Ll63AS22i7G/aHI0Lx+0JzDq+7m2PsnotKX+01tN6pXzD3/vKkoVDriebits0r8hTNYNzexagW5YOwpn1P2g9ZxxI+wXJqqZvrQ2bwrb2MbE4kRv58eBSnrnJjrQOPI+T/K5g88ubZxjzNij1AMVY7oub+Mw80+gZXW0f5lYEKk9IH4VSBJQTlCPuo/+hfd4wJgsUhbHtIw3HCeFDbXAtgg3FYfx9HJlXwbsMWr8n84l40GhlGgtXPkX/kunvqRJOTf97tcPcquzOAbwP7ZBTIeLfrr70tGjt6ixxWbWi/OUm9pTWPk= X-Forefront-Antispam-Report: CIP:8.62.32.50;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ejcrelay005p.adwin.renesas.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(376014)(82310400026)(18002099003)(56012099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: tAWatZkFHjkfReM4MUGroJ5Q/7Z5CCQvnbNFQH2W+AANd9TGc2qv3TgsPAF2L2ZYEAcZFLQ9F+FwGv9g1YubfKBscLr95+ZNRZaj9RcMkhbhkANTAU+sCmT/FZ0+LxCUe3PCxOD46A7/8ZvRmsQLLYCRv4W+J6rOSaG8yhJoB9ROZa9qhlE8Zgk8AcCH6uIkJzbvLlBP9qn4eP7Iy4UxiRtgb3TLg8qfnhL7PL+wzhn8YZ07lCq6Wmc0Sj2VIRNX6VdcMN1uXPwQq0OocbLrjI8jcP8soqEl8Vb9+H5oH6AgF61ziUWdtuKfELr0uejAt2CKRstf3/7/ITsoVkIh4wx8Zfdd8E3emHcmiCEUpHP8L1soSJQMHtsn4MRYaULR03hRFDNZZZ446/UbyeIrps55SdGydjySXL2pFRDZCa9jBnbTzxCBfTVYguhqq4YI X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2026 20:18:30.4800 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa923c9f-9894-4342-df04-08deb6acf5aa X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=53d82571-da19-47e4-9cb4-625a166a4a2a;Ip=[8.62.32.50];Helo=[ejcrelay005p.adwin.renesas.com] X-MS-Exchange-CrossTenant-AuthSource: OS3PEPF0000003E.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS7PR01MB17338 Content-Type: text/plain; charset="utf-8" The call to rzv2h_icu_setup_irqs() may fail after the syscore ops have been registered and the IRQ domain has been created. In that case, only the runtime PM usage count is unwound. Unregister the syscore ops and remove the IRQ domain on this error path. Signed-off-by: Cosmin Tanislav --- drivers/irqchip/irq-renesas-rzv2h.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-rene= sas-rzv2h.c index 31c543c876b1..b11fa48c1996 100644 --- a/drivers/irqchip/irq-renesas-rzv2h.c +++ b/drivers/irqchip/irq-renesas-rzv2h.c @@ -865,7 +865,7 @@ static int rzv2h_icu_probe_common(struct platform_devic= e *pdev, struct device_no =20 ret =3D rzv2h_icu_setup_irqs(pdev, irq_domain); if (ret) - goto pm_put; + goto unregister_syscore; =20 /* * coccicheck complains about a missing put_device call before returning,= but it's a false @@ -873,6 +873,9 @@ static int rzv2h_icu_probe_common(struct platform_devic= e *pdev, struct device_no */ return 0; =20 +unregister_syscore: + unregister_syscore(&rzv2h_irqc_syscore); + irq_domain_remove(irq_domain); pm_put: pm_runtime_put_sync(dev); return ret; --=20 2.54.0