dd LED support for fbnic

[PATCH net-next 0/3] dd LED support for fbnic

Posted by mike.marciniszyn@gmail.com 4 days, 1 hour ago

From: "Mike Marciniszyn (Meta)" <mike.marciniszyn@gmail.com>

Add support for fbnic leds in three patches.

The first patch adds the trigger support for the higher
fbnic speeds.

The second patch stors the max speed from the firmware dialog
to give the LED code a way to determine if the led needs to show
amber (not full speed) or blue (at full speed).

The third patch adds the fbnic specific code to manipulate the LEDS
as well as the /sys/class/leds support for user space access.

Mike Marciniszyn (Meta) (3):
  leds: trigger: netdev: Extend speeds up to 100G
  net: eth: fbnic: Store max_speed from firmware dialog
  net: eth: fbnic: Add led support

 drivers/leds/trigger/ledtrig-netdev.c         |  46 +++-
 drivers/net/ethernet/meta/Kconfig             |   8 +
 drivers/net/ethernet/meta/fbnic/Makefile      |   2 +
 drivers/net/ethernet/meta/fbnic/fbnic.h       |  13 +
 drivers/net/ethernet/meta/fbnic/fbnic_csr.h   |  15 ++
 .../net/ethernet/meta/fbnic/fbnic_devlink.c   |   4 +
 .../net/ethernet/meta/fbnic/fbnic_ethtool.c   |  59 +++++
 drivers/net/ethernet/meta/fbnic/fbnic_fw.c    |   3 +
 drivers/net/ethernet/meta/fbnic/fbnic_fw.h    |   3 +
 drivers/net/ethernet/meta/fbnic/fbnic_led.c   | 228 +++++++++++++++++
 drivers/net/ethernet/meta/fbnic/fbnic_mac.c   | 239 ++++++++++++++++++
 drivers/net/ethernet/meta/fbnic/fbnic_mac.h   |  62 +++++
 drivers/net/ethernet/meta/fbnic/fbnic_pci.c   |   8 +
 .../net/ethernet/meta/fbnic/fbnic_phylink.c   |   2 +
 include/linux/leds.h                          |   4 +
 15 files changed, 695 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/ethernet/meta/fbnic/fbnic_led.c

-- 
2.43.0

Re: [PATCH net-next 0/3] dd LED support for fbnic

Posted by Andrew Lunn 4 days, 1 hour ago

On Wed, May 20, 2026 at 04:03:34PM -0400, mike.marciniszyn@gmail.com wrote:
> From: "Mike Marciniszyn (Meta)" <mike.marciniszyn@gmail.com>

The Subject: of this email has an off 'dd' in it.

> The second patch stors the max speed from the firmware dialog

stores

  Andrew

Re: [PATCH net-next 0/3] dd LED support for fbnic

Posted by Mike Marciniszyn 3 days, 7 hours ago

On Wed, May 20, 2026 at 10:14:46PM +0200, Andrew Lunn wrote:
> On Wed, May 20, 2026 at 04:03:34PM -0400, mike.marciniszyn@gmail.com wrote:
> > From: "Mike Marciniszyn (Meta)" <mike.marciniszyn@gmail.com>
>
> The Subject: of this email has an off 'dd' in it.
>
> > The second patch stors the max speed from the firmware dialog
>
> stores
>
>   Andrew

"dd" should have read "Add" (truncated by copy/paste).

Correcting the subject I think would mess up subsequent revisions unless
I retract the series, consolidate the ID mechanisms into a separate patch
and follow up with the led class patch wrapped in a better cover sheet.

Mike

Re: [PATCH net-next 0/3] dd LED support for fbnic

Posted by Andrew Lunn 3 days, 7 hours ago

> Correcting the subject I think would mess up subsequent revisions unless
> I retract the series

Revisions are pretty much considered independent of each other.

You can include a link in v2 pointing to v1, if want to make it easier
to go backwards.

   Andrew

Re: [PATCH net-next 0/3] dd LED support for fbnic

Posted by Lee Jones 3 days, 10 hours ago

On Wed, 20 May 2026, Andrew Lunn wrote:

> On Wed, May 20, 2026 at 04:03:34PM -0400, mike.marciniszyn@gmail.com wrote:
> > From: "Mike Marciniszyn (Meta)" <mike.marciniszyn@gmail.com>
> 
> The Subject: of this email has an off 'dd' in it.
> 
> > The second patch stors the max speed from the firmware dialog
> 
> stores

It's also just a cover-letter.

-- 
Lee Jones

Re: [PATCH net-next 0/3] dd LED support for fbnic

Posted by Andrew Lunn 3 days, 9 hours ago

On Thu, May 21, 2026 at 12:03:24PM +0100, Lee Jones wrote:
> On Wed, 20 May 2026, Andrew Lunn wrote:
> 
> > On Wed, May 20, 2026 at 04:03:34PM -0400, mike.marciniszyn@gmail.com wrote:
> > > From: "Mike Marciniszyn (Meta)" <mike.marciniszyn@gmail.com>
> > 
> > The Subject: of this email has an off 'dd' in it.
> > 
> > > The second patch stors the max speed from the firmware dialog
> > 
> > stores
> 
> It's also just a cover-letter.

It depends on the Maintainers workflow, but for netdev, a patch series
is imported into a branch, and the cover letter is used for the text
of the merge commit into net-next.

A well written cover letter contains the big picture, what does this
set of patches do, so it has useful information in it, so we want to
have it in the git history.

	Andrew

Re: [PATCH net-next 0/3] dd LED support for fbnic

Posted by Lee Jones 3 days, 8 hours ago

On Thu, 21 May 2026, Andrew Lunn wrote:

> On Thu, May 21, 2026 at 12:03:24PM +0100, Lee Jones wrote:
> > On Wed, 20 May 2026, Andrew Lunn wrote:
> > 
> > > On Wed, May 20, 2026 at 04:03:34PM -0400, mike.marciniszyn@gmail.com wrote:
> > > > From: "Mike Marciniszyn (Meta)" <mike.marciniszyn@gmail.com>
> > > 
> > > The Subject: of this email has an off 'dd' in it.
> > > 
> > > > The second patch stors the max speed from the firmware dialog
> > > 
> > > stores
> > 
> > It's also just a cover-letter.
> 
> It depends on the Maintainers workflow, but for netdev, a patch series
> is imported into a branch, and the cover letter is used for the text
> of the merge commit into net-next.
> 
> A well written cover letter contains the big picture, what does this
> set of patches do, so it has useful information in it, so we want to
> have it in the git history.

Interesting.  This is new to me.  As you were.

-- 
Lee Jones