iio: imu: bno055: terminate dev_err() strings with a newline

[PATCH] iio: imu: bno055: terminate dev_err() strings with a newline

Posted by Stepan Ionichev 4 days, 2 hours ago

Two dev_err() calls in bno055_ser_write_reg() and bno055_ser_read_reg()
are missing the trailing newline, so the kernel log buffer continues
the next message on the same line.

Add the missing \n.

Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
---
 drivers/iio/imu/bno055/bno055_ser_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/imu/bno055/bno055_ser_core.c b/drivers/iio/imu/bno055/bno055_ser_core.c
index 48669dabb..733f9112d 100644
--- a/drivers/iio/imu/bno055/bno055_ser_core.c
+++ b/drivers/iio/imu/bno055/bno055_ser_core.c
@@ -288,7 +288,7 @@ static int bno055_ser_write_reg(void *context, const void *_data, size_t count)
 	struct bno055_ser_priv *priv = context;
 
 	if (count < 2) {
-		dev_err(&priv->serdev->dev, "Invalid write count %zu", count);
+		dev_err(&priv->serdev->dev, "Invalid write count %zu\n", count);
 		return -EINVAL;
 	}
 
@@ -306,7 +306,7 @@ static int bno055_ser_read_reg(void *context,
 	struct bno055_ser_priv *priv = context;
 
 	if (val_size > 128) {
-		dev_err(&priv->serdev->dev, "Invalid read valsize %zu", val_size);
+		dev_err(&priv->serdev->dev, "Invalid read valsize %zu\n", val_size);
 		return -EINVAL;
 	}
 
-- 
2.43.0

Re: [PATCH] iio: imu: bno055: terminate dev_err() strings with a newline

Posted by Maxwell Doose 4 days, 1 hour ago

On Wed, May 20, 2026 at 2:27 PM Stepan Ionichev <sozdayvek@gmail.com> wrote:
>
> Two dev_err() calls in bno055_ser_write_reg() and bno055_ser_read_reg()
> are missing the trailing newline, so the kernel log buffer continues
> the next message on the same line.
>
> Add the missing \n.
>
> Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
> ---
>  drivers/iio/imu/bno055/bno055_ser_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/bno055/bno055_ser_core.c b/drivers/iio/imu/bno055/bno055_ser_core.c
> index 48669dabb..733f9112d 100644
> --- a/drivers/iio/imu/bno055/bno055_ser_core.c
> +++ b/drivers/iio/imu/bno055/bno055_ser_core.c
> @@ -288,7 +288,7 @@ static int bno055_ser_write_reg(void *context, const void *_data, size_t count)
>         struct bno055_ser_priv *priv = context;
>
>         if (count < 2) {
> -               dev_err(&priv->serdev->dev, "Invalid write count %zu", count);
> +               dev_err(&priv->serdev->dev, "Invalid write count %zu\n", count);
>                 return -EINVAL;
>         }
>
> @@ -306,7 +306,7 @@ static int bno055_ser_read_reg(void *context,
>         struct bno055_ser_priv *priv = context;
>
>         if (val_size > 128) {
> -               dev_err(&priv->serdev->dev, "Invalid read valsize %zu", val_size);
> +               dev_err(&priv->serdev->dev, "Invalid read valsize %zu\n", val_size);
>                 return -EINVAL;
>         }
>

Sashiko seems fine with it. Also did a quick visual check and looks
fine (not compiled, but I wouldn't count this as a functional change).

Reviewed-by: Maxwell Doose <m32285159@gmail.com>

best regards,
max


> --
> 2.43.0
>
>

Re: [PATCH] iio: imu: bno055: terminate dev_err() strings with a newline

Posted by Jonathan Cameron 2 days, 6 hours ago

On Wed, 20 May 2026 15:13:41 -0500
Maxwell Doose <m32285159@gmail.com> wrote:

> On Wed, May 20, 2026 at 2:27 PM Stepan Ionichev <sozdayvek@gmail.com> wrote:
> >
> > Two dev_err() calls in bno055_ser_write_reg() and bno055_ser_read_reg()
> > are missing the trailing newline, so the kernel log buffer continues
> > the next message on the same line.
> >
> > Add the missing \n.
> >
> > Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
> > ---
> >  drivers/iio/imu/bno055/bno055_ser_core.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/imu/bno055/bno055_ser_core.c b/drivers/iio/imu/bno055/bno055_ser_core.c
> > index 48669dabb..733f9112d 100644
> > --- a/drivers/iio/imu/bno055/bno055_ser_core.c
> > +++ b/drivers/iio/imu/bno055/bno055_ser_core.c
> > @@ -288,7 +288,7 @@ static int bno055_ser_write_reg(void *context, const void *_data, size_t count)
> >         struct bno055_ser_priv *priv = context;
> >
> >         if (count < 2) {
> > -               dev_err(&priv->serdev->dev, "Invalid write count %zu", count);
> > +               dev_err(&priv->serdev->dev, "Invalid write count %zu\n", count);
> >                 return -EINVAL;
> >         }
> >
> > @@ -306,7 +306,7 @@ static int bno055_ser_read_reg(void *context,
> >         struct bno055_ser_priv *priv = context;
> >
> >         if (val_size > 128) {
> > -               dev_err(&priv->serdev->dev, "Invalid read valsize %zu", val_size);
> > +               dev_err(&priv->serdev->dev, "Invalid read valsize %zu\n", val_size);
> >                 return -EINVAL;
> >         }
> >  
> 
> Sashiko seems fine with it. Also did a quick visual check and looks
> fine (not compiled, but I wouldn't count this as a functional change).
> 
> Reviewed-by: Maxwell Doose <m32285159@gmail.com>
Applied. 
Thanks,

J
> 
> best regards,
> max
> 
> 
> > --
> > 2.43.0
> >
> >  
>