From nobody Sun May 24 22:39:33 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAAF434E779 for ; Wed, 20 May 2026 15:57:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779292637; cv=none; b=MqNce8ay+jDHfDEOL/OsxAKO8IhiakaKZgMF1LcC3QyO/6CpAm4jXieY+DJupPQVHhyDc57ODIgg/8gK9i5ECWEKGPpJ3FFqy6kaOk5HIEUUO1mw8h4sjg2CBA/sSgE+l2qPvDfoxG0S2B9W6uT5sTXv4Gve2N1f7vQ9Pt4lgYs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779292637; c=relaxed/simple; bh=rqyRx5gO71Dktn8ezRmaXkqLcnP7Er+WU3nc/ne/gNw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fBrBFD49IJlUgr0Qyv9/oJc1C7CG7wMfZNrfjGBwdsNhwTFE51v/54beMYbIm+T0Pn3pXVkRy2z4Pvvt4HBTUQez4clt9eEpev90uiH71kIFBF0G2D5X/kF5qg4s24UfPp6LG25bP9SB+66V5dWYBBWjPiOhEsDgRjtYt92s4qk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZFBG2bGv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GyJgx65J; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZFBG2bGv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GyJgx65J" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64KCe2k0316412 for ; Wed, 20 May 2026 15:57:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=adYT/N5M5dNlxa9BWmKih7rxkcOkwwxxkH5 7o6+h97A=; b=ZFBG2bGvIVn/ggym+QDhL+e5G5+lCF/9bArEyg21gkvQkB5YL6b Mr+y59+1KU0XE2HWa8ppQavCSn0djstQMXpDEvwBQYQ/5sqHCVlBU2c6wOwDWX13 AO0lZih/3DY9VudmDI0YaVwhFcDOM4WQprmzCDETGJbA0a+9WCbJKQGkeAj9Cbp4 rl5bf7QpIw9OM2BFY7qto4O4KnYxDn1gCxMjj+QGbiYaK3pUn9nwTfssTf44CDW1 PWR1YiJLZLe4gxSf4/IIVTIuY8UMYSt5sE7EOFoPAvo+vEucLri/VBZyiXREUJWd 8ZSqdfNEQeG9ZarPm8WRMjscxLVFFXrhdjQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9d5qrt0s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 15:57:12 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2bd1dbcccf6so77621155ad.2 for ; Wed, 20 May 2026 08:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779292632; x=1779897432; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=adYT/N5M5dNlxa9BWmKih7rxkcOkwwxxkH57o6+h97A=; b=GyJgx65Ju6ZbMInIXwWAdO5Yq0j324UWs/pZf1yvsNEvdss2Z5nejCsdwrjRsKf1Hr Pzd0ZT1ySPKpc1vmXaAw5m1h96vtWlMZYXH5q8j4SK+Dyvp5wHnOqcELWRYor+CypEDY SuEIHt6BHNWPa8RpDUsAe8BqwQlc1SBo7CxZrCgIgCOWIggHC8NfFYrfZgyoUzglx7AU Jpbka9g8M18wO0f4XflsZa6J/aChHRQB69qVaS4Ya6V3CSM/bAL96U4LsSvPz6/5/t/4 5/i2oSyv9h8iF1yB2snge62B9D8HoqrntGaHv5MUJPIGa2fsQ+GeFFQxzb9OJ5Y1oNPz DAUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779292632; x=1779897432; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=adYT/N5M5dNlxa9BWmKih7rxkcOkwwxxkH57o6+h97A=; b=M9lfvBeENJy+MGVgDGBRq3UIIZz6mLxe+JSQydNc6koxa18m/Y1VS9qO9NoPNK+Q+h xtqLVwDhSZeo3shd6e51Lj7ozF0XrvBRz3SQo/9CTYjte9CJ0iT6MCilaaXVJEATSYvj 25j/4y1XIjva6zCO1/aU5QGzz7xXzYP5nFb00J/q/UMrQCm9odHG2b+8yEEAD2ZJZgwB ggak2RUb0Dq/SI69kFyKo9JpxAEYh2paMMJKaQaiMKbrNkotULyxqTH6b8qiOYIQ544N GhOk8gjQBDz+WcCiKuKl1SXvhSSb86e4qd15wmFzgMFKSKLAz8to4GKXsGeMLKKrJtdy aNrA== X-Forwarded-Encrypted: i=1; AFNElJ+ejatO8UyIJcYZOW4J/sAndjDxOVyBIhztfnEJg7r4HklJpSzhOhpjLUn8LtDhDLWz+EPdUhTHGCmfSKQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzv60dqGK/5coPcXFsrM6HUe6XBtYn4Li+2MQc7eqL7kbWnAn5A 7ccVMULkcIjTLh+ZaDSWykaiKSgUmq9PStNh5qWVtOvZdF/0nFSqrFXSyGP7YPLzSdjjM9XSHHp FvwxIU4gaC3sldWJkqlIkWs2mk3FKVr25a6p5nOS5rTPYyfaL0YjODr0whlAGPPoF050= X-Gm-Gg: Acq92OEotEIraj8QGozvgXlC9drlvyqrNNkPZlTGuA0LM+c/Qy9IOFnS9U9MuHV+UAE cZW0aIeTD0FtB6lpPpEBPsgL7vHM8Hl4brvXAEYeeXxT8aY2YJQXTd7lulliuEMne880t3y5DIm aF6vaEDJxV/yCQWgVn0zcjYVLONayUdRS/WqGsrdTH+/W+pDBqMXRyKb96phxIBeNhEDlJBnOqO PMPReZ96F5Dh/sZHi4V/mDaEjrMrIUS4PJHl++55L/LOGGzHA1sH9O4gFOA/G8+z1rOS1wN7AV+ oEs1kRHfVUi0JJ9fDbElNmU1l7Q4wrYMk7Q6ScqLEJHleJP9i2S3k5811miRkfboDk+fHOti+PK 0HPbd8XV9BW0RDNrn+EJdRYFIZbPyuNB2AcBEQgHX9D189g== X-Received: by 2002:a17:902:c943:b0:2b9:7ad1:bf2b with SMTP id d9443c01a7336-2bd7e927ae1mr277089195ad.29.1779292631572; Wed, 20 May 2026 08:57:11 -0700 (PDT) X-Received: by 2002:a17:902:c943:b0:2b9:7ad1:bf2b with SMTP id d9443c01a7336-2bd7e927ae1mr277088825ad.29.1779292630975; Wed, 20 May 2026 08:57:10 -0700 (PDT) Received: from work.lan ([2409:4091:a0f4:6806:bdc1:b9f2:288:db46]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d0fd279sm224915175ad.62.2026.05.20.08.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 08:57:10 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, konradybcio@kernel.org Cc: mani@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Marek Szyprowski Subject: [PATCH] soc: qcom: ice: Fix the error code when 'qcom,ice' property is not found Date: Wed, 20 May 2026 21:27:04 +0530 Message-ID: <20260520155704.130803-1-manivannan.sadhasivam@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDE1NSBTYWx0ZWRfX4lnRceZoyQSN tVu+4K6aSPYjiurFhdIozRhK6QTKmHNb09CkYauqOrH3ioPJHrBfJDhgVxHhMtStml74jzImE4+ 1tA8IN53/lta983AjDKgKC/6+fjBIQdk7HbC+9q15mbEw08JhgNsJfFUREo/X55aQmNjGdCsPa3 ICon4VhNhdRL+1nj7l2eh4o2Xmw7cK0lVCRPQcqL9dxhenPoHGMbOZbtRmj3uMOnhmxsI7dTYa5 zbxnbYDW56U/ADhCgMbYPxPbPX80Zy2r+vUPIJC4XnSO08dhz6VlOMhUvgrtz+oy/M36Pd78Hvj CzXCwtYCJ1Si7J/8EQpYMROl4rhlQ1/q1CpLCRLT7wBzOMYZA6khanzIuE3MIG/oU7fTsgeepA4 cpQ5ot43OI341IWrFtdODIiwhBPuu8EpwwS/IXs4N4sSWMha6iizUMJMlCWrjcifUtZK0Myzae7 3hPvbome6U2+A/8ITBg== X-Authority-Analysis: v=2.4 cv=QshuG1yd c=1 sm=1 tr=0 ts=6a0dd9d8 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=hD80L64hAAAA:8 a=EUspDBNiAAAA:8 a=vOGu-D3ClsUDJ8L96bsA:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: CFZPTplAeSPcIyIiLQTaoHUXhpzyY2V2 X-Proofpoint-ORIG-GUID: CFZPTplAeSPcIyIiLQTaoHUXhpzyY2V2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200155 Content-Type: text/plain; charset="utf-8" When both 'ice' reg entry and 'qcom,ice' property are not found in DT, then it implies that ICE is not supported. So return -EOPNOTSUPP instead of -ENODEV to client drivers to specify ICE functionality is not supported. Fixes: b9ab7217dd7d ("soc: qcom: ice: Return proper error codes from devm_o= f_qcom_ice_get() instead of NULL") Reported-by: Marek Szyprowski Closes: https://lore.kernel.org/linux-arm-msm/8bac0358-9da0-4cbb-98ee-333b8= 5ba4908@samsung.com Signed-off-by: Manivannan Sadhasivam --- Bjorn: Please squash this fix with the offending commit. drivers/soc/qcom/ice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c index e26d5a64763c..5f20108aa03e 100644 --- a/drivers/soc/qcom/ice.c +++ b/drivers/soc/qcom/ice.c @@ -658,7 +658,7 @@ static struct qcom_ice *of_qcom_ice_get(struct device *= dev) struct device_node *node __free(device_node) =3D of_parse_phandle(dev->of= _node, "qcom,ice", 0); if (!node) - return ERR_PTR(-ENODEV); + return ERR_PTR(-EOPNOTSUPP); =20 pdev =3D of_find_device_by_node(node); if (!pdev) { --=20 2.51.0