[PATCH] soc: qcom: ice: Fix the error code when 'qcom,ice' property is not found

Manivannan Sadhasivam posted 1 patch 4 days, 5 hours ago
drivers/soc/qcom/ice.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] soc: qcom: ice: Fix the error code when 'qcom,ice' property is not found
Posted by Manivannan Sadhasivam 4 days, 5 hours ago
When both 'ice' reg entry and 'qcom,ice' property are not found in DT, then
it implies that ICE is not supported. So return -EOPNOTSUPP instead of
-ENODEV to client drivers to specify ICE functionality is not supported.

Fixes: b9ab7217dd7d ("soc: qcom: ice: Return proper error codes from devm_of_qcom_ice_get() instead of NULL")
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Closes: https://lore.kernel.org/linux-arm-msm/8bac0358-9da0-4cbb-98ee-333b85ba4908@samsung.com
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---

Bjorn: Please squash this fix with the offending commit.

 drivers/soc/qcom/ice.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c
index e26d5a64763c..5f20108aa03e 100644
--- a/drivers/soc/qcom/ice.c
+++ b/drivers/soc/qcom/ice.c
@@ -658,7 +658,7 @@ static struct qcom_ice *of_qcom_ice_get(struct device *dev)
 	struct device_node *node __free(device_node) = of_parse_phandle(dev->of_node,
 									"qcom,ice", 0);
 	if (!node)
-		return ERR_PTR(-ENODEV);
+		return ERR_PTR(-EOPNOTSUPP);
 
 	pdev = of_find_device_by_node(node);
 	if (!pdev) {
-- 
2.51.0
Re: [PATCH] soc: qcom: ice: Fix the error code when 'qcom,ice' property is not found
Posted by Bjorn Andersson 1 day, 19 hours ago
On Wed, 20 May 2026 21:27:04 +0530, Manivannan Sadhasivam wrote:
> When both 'ice' reg entry and 'qcom,ice' property are not found in DT, then
> it implies that ICE is not supported. So return -EOPNOTSUPP instead of
> -ENODEV to client drivers to specify ICE functionality is not supported.
> 
> 

Applied, thanks!

[1/1] soc: qcom: ice: Fix the error code when 'qcom,ice' property is not found
      commit: 462a85f9f887a4fef36550bb76c7f7d7a0fa296c

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>