From nobody Sun May 24 22:42:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B58F332571D for ; Wed, 20 May 2026 15:50:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779292210; cv=none; b=IObepJAicUMdhZ3jdSEdFeuv9xb2IGNEuUiGphUr3lR4skc8jkys1EDcyjoxf05S9tgnzgOG4oPO4adS0rpQiK0zedBs7XsbdIxxjJwK+Bqj62vMhmtc1XdIiWo+droTgMCbVIsnGAOi/nIqeutMdU8zkIROUVjtcU70kDsbgSA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779292210; c=relaxed/simple; bh=HkU/7lXMz5wfYek/EI2tdTIHBH9Dr4vHBbktDpM05Gg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OZdqR0yhw8G/8vfQHtoqItA2laYAT9tRfebWy9jTA3uz1K4+OkUdj0OQzGqknHlsSh9dxAQ7JS20YHwnY46omUKXfZHtMavL+EIMLqLCO9OWJDYv/8MD6ZesNYxJ2lUoJI71fxq3vZ4IN/UpENIgEdLhVtM21rcyA+Cpd35//EQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IQ+bcpSS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VUVfbBIt; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IQ+bcpSS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VUVfbBIt" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64KBZR453084906 for ; Wed, 20 May 2026 15:50:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=GBFFGkFdfck ErYoEXWb+kPuoHFw2RVA+L0aYz+HJKO4=; b=IQ+bcpSSVcDoooGZBqHLlt7+nag jP49nyhb2InE2RI0qGdIAYPM70jBlKJwgGwlKBkKDpWUH4iwfiXxGpO2QEphGgD2 3qPQcnEONPha/gcfJdn8/W5Tn9tK9p8frttVV8xNGLMgwDEqoXGGAziAlsC2jhyn vQcKp9qYnNXnti4FBsAqhm19YElYvcCvaF7RW+SUGNV7732n7QOZh9NEWvWuCK8U iHmAh5+j9Bp9PwqEfElBu29TcVipQ630zEEz+h1Oqpd6boYaERJo2fNUVvOf2VGM S9X/Nn50t0OBk02lz0l6wzCwSinROsMWVtkcqvxGKH/KG+L75Kn/xt1MNwA== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9c7f0yv5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 15:50:07 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-95d5e1bcb8eso3200396241.0 for ; Wed, 20 May 2026 08:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779292207; x=1779897007; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GBFFGkFdfckErYoEXWb+kPuoHFw2RVA+L0aYz+HJKO4=; b=VUVfbBItCX9A4D4yyDb298+nIP+qBvrqWV3Rk/5fzU0HlFbP0kNhGc5fW6xDhjeduk Q4kxXPPl6VrHtw3UxMo8A2cqSJ0gOyYha7B11bMDR7yGUxjM9jqxoinBRbzjwc8hkWS5 9OGHivg4KE+9CBcobDB7ep/Ti8Uko8vmHiNYbpGUlEK9M4FqbaFbOKeoyeeYXsurn963 JF2ZSrtvZqzhhRmEqA16f1rsxFM5eZuQ2eVAp7T8ki5x6jEZkoAzVUdwxIizzGDORjo8 Z4tHRxmrk0JquiajbgsYK2cXyOjF3h22atba+WCbuj4Xuv0KURfzq5WqcLbVhhciEY/A 7sqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779292207; x=1779897007; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GBFFGkFdfckErYoEXWb+kPuoHFw2RVA+L0aYz+HJKO4=; b=EqiZzJDq1GNmbMTEJeX/yh++SmxLEYmpgywa2iycIfvoSOwAM1CgZK/2mPGo4dDwUD DQY7FUvkTetVpxUh1mLX2amdVSe8SVgFwfRGdmS8/RIkFpOXfo8pQYWmIwj1PB9yy1GG cjJiGJpuE5jH3x4LvdIGP7otkB9v8BuSNW8V6WXgL+tyBsn2krJoGEz/GqyZi7Jiewh1 263V2QBZB7xaIYAevfU+TiUMfQDDgR4uDbApAdLqOS9gQ6VQ2FIYL9Cf092RWx2KL6XO GigOUhh/zjA7OMCOexktRLFHpyxvETJUAOWCXFY7RFMoPBlRiWizC9dQRHOfXZLqhVYU +oDw== X-Forwarded-Encrypted: i=1; AFNElJ87yBM+YdH0D/hqDuddfSefqx/zC3bro6SjaXzmorSuFysPAbPWyRtbSZj9VuGdRlNIAtridz0FUDOFXD8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8oque2N5SanupyjzLrZZA7oU/7eOUCqhaeouG8euL5qMCbVHq rYkUVJoeJ82pMgPeewUvrTu/wMQGbHGIyQUOS88tBUdV09uhsfcLOeCIqLf/inlrxjLmWpZo5IO Z35NxbU5G/r1p0ndpRoiLjsG+w1CxsEgUNkkTNdWRBwetHA9y+rIXzS5mtyy9eYu58vc= X-Gm-Gg: Acq92OGuANB2NzOg7O4b9detsnviEoQ3yD/KEFr67aNulTDHSGkpvmXilvwI11Gyx21 f4yDVmG1ru1iKlEYikPZBHFlNHb7KbnxZgeQ30X96bBuIKAPC6BZI4MXgu6yH50xQnw7EKaCwSo /XhqIw5sg3hJd4frS8qNSx8x00WtUI+uTGhefQYsdDvVgrym1XRGm8u/Qj5oJrUxZJwoP2jm+3G RVM57tmF14rxy3yttHrzj1JWMycFDuNbcwIR/5PjxvtbWouxcgbqFT4ehyXeZxZIAgJMzHmLI8U AUW2brAF/5+HQy7o9gg0eovx9BGQDS7lIqEnBcoCepKnj4P8WrJBGMQbwLmgj+6ojExTF9OeLYe 5QfdFxTudgXh+3rbkg8ATwrSVVbBEh+qCdNK3BWj613vOdcb4UfH0GJI= X-Received: by 2002:a05:6102:6051:b0:639:6533:65a0 with SMTP id ada2fe7eead31-63a3ee7eb93mr11334746137.18.1779292206990; Wed, 20 May 2026 08:50:06 -0700 (PDT) X-Received: by 2002:a05:6102:6051:b0:639:6533:65a0 with SMTP id ada2fe7eead31-63a3ee7eb93mr11334723137.18.1779292206579; Wed, 20 May 2026 08:50:06 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48febe585absm136746445e9.19.2026.05.20.08.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 08:50:05 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, sharq0406@gmail.com, kuninori.morimoto.gx@renesas.com, ckeepax@opensource.cirrus.com, srinivas.kandagatla@oss.qualcomm.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 1/2] ASoC: mt8173-max98090: use standard callback to set jack Date: Wed, 20 May 2026 15:50:01 +0000 Message-ID: <20260520155002.145306-2-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260520155002.145306-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260520155002.145306-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=c/ibhx9l c=1 sm=1 tr=0 ts=6a0dd82f cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=eZ2NLjhSbWgmPKGfaEYA:9 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-GUID: tVoqLKne6R1qssatr2l_To3xWPUcRyh5 X-Proofpoint-ORIG-GUID: tVoqLKne6R1qssatr2l_To3xWPUcRyh5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDE1MyBTYWx0ZWRfX/YcatSCrHPXV hv/LWyMVGQC+eju7M9jMT4hISeXTXOW4qbR6ahpx9DfK8J5bIrdkoyHWlQO6C46jqcaTn5keQda 0wRqijTeNlzN1FIUw8+EfS396r2NetE0XR7J2O4LTG32urKwT2skvryGCjNRX5il8LKQXDDoAMn fVW93Y5tPORxMUr6BE4AQ29979V8wcOWjq3kSFx70St2E5QZdv7k/hpa9TJuEjOG0P3/lCvZ3CT duPM2NG+3x5TRSjJH+5dPlkYi+BT8oTekPhL0iBtawQqYqZO1ZH+NP8G1MqJ9BPOlELjOKZ/OEW Kot2dk+GILxt0Ww22Iz1qDyb/WKHpu2Rbo7Nch9Z0jN6vYQ+eTfH/gbxlpjJrLaQX6hYKl6Qt0d 8ZSGDLCMjDBtd+eWsjBXmhc989h4x3QUBjth6XfpLy116s9wGfr3Wqb14LE/hi7+JSjdr4+caqM Mwfkn+6t0wDHatb+0/Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 priorityscore=1501 phishscore=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200153 Content-Type: text/plain; charset="utf-8" use snd_soc_component_set_jack() instead of custom callback to max98090 codec. This will help other drivers using the standard callback to exercise the standard path instead of custom callback. Signed-off-by: Srinivas Kandagatla --- sound/soc/mediatek/mt8173/mt8173-max98090.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8173/mt8173-max98090.c b/sound/soc/mediat= ek/mt8173/mt8173-max98090.c index 49ebb67c818a..7533c6e4955b 100644 --- a/sound/soc/mediatek/mt8173/mt8173-max98090.c +++ b/sound/soc/mediatek/mt8173/mt8173-max98090.c @@ -1,3 +1,4 @@ + // SPDX-License-Identifier: GPL-2.0 /* * mt8173-max98090.c -- MT8173 MAX98090 ALSA SoC machine driver @@ -9,7 +10,6 @@ #include #include #include -#include "../../codecs/max98090.h" =20 static struct snd_soc_jack mt8173_max98090_jack; =20 @@ -78,7 +78,7 @@ static int mt8173_max98090_init(struct snd_soc_pcm_runtim= e *runtime) return ret; } =20 - return max98090_mic_detect(component, &mt8173_max98090_jack); + return snd_soc_component_set_jack(component, &mt8173_max98090_jack, NULL); } =20 SND_SOC_DAILINK_DEFS(playback, --=20 2.47.3 From nobody Sun May 24 22:42:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39CED2C15AB for ; Wed, 20 May 2026 15:50:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779292213; cv=none; b=WLAjEE4ziuI0N3xUaQT4uHXco/DLb5cim2dDsXppomM/X65Fe3c7cdpd+oLF+7vbMVfWIqEF1HMetU4aG2jaWEArA9VMlCeylfKyxxPwlyCr5M1wMfMn/MkDV/UbEK0SLgyalKf9wnmNj+bVVrmYQGR8HY1lyxDP4CPha/SomXU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779292213; c=relaxed/simple; bh=Uu5uyr3S4DAMsxnmTADNGWT4hBVCfQbf19BrUcKIb60=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=huGjg6eHY7VD7MNHdlXU1brMvaOphvwBjpdmQAdgO7haM3jnixmc0VnKUjVWJt7bhSftvp3PpoZHHUksMFq/Gvfp06M6tBCMXGVOSSoRCRnO99aBSIVQNiC3g3P/QExKBJAqayMrUJEElevtQqSGHsWIVFuA3CLxNKOB+iUzXwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ph0F43BP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fGOcVRPO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ph0F43BP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fGOcVRPO" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64K9oR3q1178126 for ; Wed, 20 May 2026 15:50:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=7pajX5xu6Zp Ncsmp1hBoCRrNWBQ+y3y7lGXM9b2dJyw=; b=ph0F43BPpiJ3LSL7PyxFoDj884Z zYdQ6LHVh5DQADqWnvGTquoS5NYVMLmTSlWoOEjvqxzS7r6u9L3S77BsFL4JYdt0 YqCCbrGLib2lrUqLMyi5rgLviAdrD4XrE4/bGbG99H1uURi7jAx2toiMGlxLkHFi Ens/6Sb5B4kKoVS3TGhaHGS91PnxY9OOskTWtsp9CpexXacnZjl3hKSwdwWmiuzE keWwzFI8xPvj0r618tNgu6hSsm1awffSgbn5izcpuDcdAcuXRcKU0tMbTRGdE1SB jNQ+a+jzDw5sIA5HjOGHG1KB7xSiR2n1VAhK9QEqx3oXy+XgWpfHXZDPfRQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9ap6sbx5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 15:50:11 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-516458449d4so38095101cf.1 for ; Wed, 20 May 2026 08:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779292210; x=1779897010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7pajX5xu6ZpNcsmp1hBoCRrNWBQ+y3y7lGXM9b2dJyw=; b=fGOcVRPOAWXThnmQpmaeiWSbFOp5Bu8ouY/BS+zajxJXdVF7beG8fjRB1SnoDqSGZw Q+AYnd8AMULubXLm9HRfuj7j5Nv/obvJVXjk6j5rvjUWph41Oe/SeDJpZ75Dbl/7PlNj L8r9yo1kwU8YqTsFbzSiBzX1MPyUAWY/WPu1GgUAIgadXBFGVZlhnfHKsFEXmT1OleCc 27XjZVmmMrspt0Xmy2MWEy73zo6s0vs5dDT8RnK+7Ri9w1BvDZhj3BWDi2qgfBURUHlr 0HJ4THk1vRsXnQ4D92RPkMwOtXY+2ZA3wCqxJ0rKxXBQSus3re9Lc/SDd9yI9MFVpfao RudA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779292210; x=1779897010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7pajX5xu6ZpNcsmp1hBoCRrNWBQ+y3y7lGXM9b2dJyw=; b=qvbsFYsPsy1NT6mG4SxRnwuiOJpem16+qMwVk5M7gwA4CqW+0IgEXlsLDW3tNKrUht 9ZlhuFZQtvhNYaPgn/6ZMJWvYs2eh3wDKqO/VBcbqSmVSgb0E+ASOeAB58p7+y6dnu+r BTkHrtQ/patOmj7NSs3/ee15ONXB9QdSXt/ksNa5ORi4544b5qIEXtMvRhYH9oikrCTx O5UeM9mpuf4C0asrHon8e4imbma3s9/MLeqW6Mpy0xPhVuV/i1Ip/gUiy+ZdzSuR/NGi O0hjb+tBSdwTe3AdhUcsryO7UwHtimf6VAorZdLDvJlysm8LlPy4Ckb18jZFoqgYmn5a rTPA== X-Forwarded-Encrypted: i=1; AFNElJ/GnY3nL9xSN8LtnnflkvLtxHhgt/9Cg080YhT4k8CUylgL5G6A+A+QmrH/naJoWHQG98vIKHRVsF+ExqQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyoCMw7tYNiFM1DVTNjbonemfNKf1C501oRVvszT+zQRqLXpWPx cnS6m9clLinBYcAp7Qe3MvvXMPOHObh/uz2me4W7DCWj6NZYXh35bbpZk4MyE0wO2ysCbzQK8PW 6af9z1cVE1P4h1+B9vWb9tPqLIsEWNW5BKcJ3iPTuhgmXpDMG5KJ0egG3a1FtS2gbw2E= X-Gm-Gg: Acq92OElKPjjTMlfLR8X27JTxv34uxlJkAksZcZE0qJqb+QWA7es0wNs6QaE77LDl2t NeMSuCVVP8k+Q23N4wd35BDoLlTJb4PQYX2EE8Y6F7v3oiK/M8bjUVs63iXMryqJLt0Q+/GLFqG qjUCL10LqpzgkSLQBVG+3sMU2fWdetF4oInmSodb4VTJ629QppLv5DvikLe0kICCUgs4N38UE5Y 0gvrZ+DSjRSFm0grqcEyMGBXuVTiXNcmE9FotlYxottWvSB4de2nVhVfoyuwdcbvtAOvq3546r6 c6ld5XlAWac705g5pnRsuhTLFSneuLw/NMDFGHYINzev0B1GurTIojLBVBsl5JwzUtYZ/LwOH9K Uh3zeIaCCC8oS/cTR8qMJ2l5BYuYoc7TSZC1zjJjfhZjmuett5l35V4dKplzO7ZJwCw== X-Received: by 2002:ac8:7f8e:0:b0:50f:b9e7:3031 with SMTP id d75a77b69052e-51659fde5fcmr353912871cf.7.1779292209944; Wed, 20 May 2026 08:50:09 -0700 (PDT) X-Received: by 2002:ac8:7f8e:0:b0:50f:b9e7:3031 with SMTP id d75a77b69052e-51659fde5fcmr353910841cf.7.1779292208033; Wed, 20 May 2026 08:50:08 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48febe585absm136746445e9.19.2026.05.20.08.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 08:50:07 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, sharq0406@gmail.com, kuninori.morimoto.gx@renesas.com, ckeepax@opensource.cirrus.com, srinivas.kandagatla@oss.qualcomm.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 2/2] ASoC: codecs: max98090: use component set_jack callback Date: Wed, 20 May 2026 15:50:02 +0000 Message-ID: <20260520155002.145306-3-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260520155002.145306-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260520155002.145306-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: mWOUqvijo2ghJOnsKSBWj5gz_rBkyr55 X-Proofpoint-ORIG-GUID: mWOUqvijo2ghJOnsKSBWj5gz_rBkyr55 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDE1MyBTYWx0ZWRfX/StFXAd4+j+q cTE1ygkfqXiIwiWFjNcDPOopKOS3w64O9AvLSDDfgQwz8bSJSxfKeuJHcG0Mza/QmNl8Ea/teHF W5HVkSw1CqWV74a91lsXgY5xM2vK6YUZi2vsCrLaPiJOdMGI+jyDqakg/jWz3zLHnLM+a+othFW awI1NQ6CFtyC658u/nuii5dCj+aEGHAn+l1prfRaPeySHLbpfOZweC1RNJHDHmo1bUDt/aF0gMx mRE4FTkB6JJQYLr3PydYVJZa+1qqcXsCJmjwT7l7by12ltfVEkREKN9OmNfJAOUxhicZicPm2eP 2uzSyieD1ubac0qSiCy3/LjbSA2ajrOZ7Y5f3tCIBDMxYliVY4v5Gkx7Fj7qhThVkZxdzo94gCR UzY6B77Fhk1IPTxNy/eL5g00FmMWuz72Xp3Bq4HlrGXAGaP8K/xXxESOJ4DYyUyu/CEP4R2MLxn 20eGFKueRiCyCyfFeLA== X-Authority-Analysis: v=2.4 cv=FesHAp+6 c=1 sm=1 tr=0 ts=6a0dd833 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=yuX1osHPGoIBqVCarmwA:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200153 Content-Type: text/plain; charset="utf-8" The MAX98090 driver provides a custom max98090_mic_detect() helper for machine drivers to register a jack. This can be implemented using the standard component set_jack callback instead. Doing so allows machine drivers to use snd_soc_component_set_jack(), which is also the interface used by machine drivers including Qualcomm ones. Convert max98090_mic_detect() to a component set_jack callback and remove the exported helper. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/max98090.c | 10 +++++----- sound/soc/codecs/max98090.h | 3 --- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index 13a15459040f..bd3bfa1d3402 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -2337,7 +2337,7 @@ static irqreturn_t max98090_interrupt(int irq, void *= data) } =20 /** - * max98090_mic_detect - Enable microphone detection via the MAX98090 IRQ + * max98090_set_jack - Enable microphone detection via the MAX98090 IRQ * * @component: MAX98090 component * @jack: jack to report detection events on @@ -2349,12 +2349,12 @@ static irqreturn_t max98090_interrupt(int irq, void= *data) * * If no jack is supplied detection will be disabled. */ -int max98090_mic_detect(struct snd_soc_component *component, - struct snd_soc_jack *jack) +static int max98090_set_jack(struct snd_soc_component *component, + struct snd_soc_jack *jack, void *data) { struct max98090_priv *max98090 =3D snd_soc_component_get_drvdata(componen= t); =20 - dev_dbg(component->dev, "max98090_mic_detect\n"); + dev_dbg(component->dev, "%s\n", __func__); =20 max98090->jack =3D jack; if (jack) { @@ -2377,7 +2377,6 @@ int max98090_mic_detect(struct snd_soc_component *com= ponent, =20 return 0; } -EXPORT_SYMBOL_GPL(max98090_mic_detect); =20 #define MAX98090_RATES SNDRV_PCM_RATE_8000_96000 #define MAX98090_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_L= E) @@ -2554,6 +2553,7 @@ static const struct snd_soc_component_driver soc_comp= onent_dev_max98090 =3D { .remove =3D max98090_remove, .seq_notifier =3D max98090_seq_notifier, .set_bias_level =3D max98090_set_bias_level, + .set_jack =3D max98090_set_jack, .idle_bias_on =3D 1, .use_pmdown_time =3D 1, .endianness =3D 1, diff --git a/sound/soc/codecs/max98090.h b/sound/soc/codecs/max98090.h index 6ce8dd176e48..048af4a1376f 100644 --- a/sound/soc/codecs/max98090.h +++ b/sound/soc/codecs/max98090.h @@ -1543,7 +1543,4 @@ struct max98090_priv { bool shdn_pending; }; =20 -int max98090_mic_detect(struct snd_soc_component *component, - struct snd_soc_jack *jack); - #endif --=20 2.47.3