From nobody Sun May 24 23:29:10 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DF4C3ED3A9 for ; Wed, 20 May 2026 14:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288279; cv=none; b=SsY5/TA+4Qz3t7QLsfks7MWNQija0sNsRdEad96QYQknzJPg+0StHlK6uRPliu0YMEpTCxSCClohPwXc8ghlLqewIiFxk+GU76VJT45erIkQ20zso6TiIUvaK5nkc70p48c03+G307XgNKnPACJ0hS1sYp1svqo4XMSR4MxJzoc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288279; c=relaxed/simple; bh=QoJWm/3mSCQyJ7pv7kqCoZT1CjVBricok0rWZC7RHi8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JEN33jdwzt12sd2nJmnANUK/s4t0NjJiZiTi26wN+v4pHzgvvPl8UhXzZCAsh5Hhdj6py2qfaKR/jXvTF+IA461Y+rlyBUhfGt4Idawzz6BkduppVSb4LXb4nXyTqTT4CKl5iLQiQgrA1eBIsyoV2zZU1zb+7UYyHgK2Jg56kqg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QRKG0WC2; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=L8ypGoOo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QRKG0WC2"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="L8ypGoOo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779288277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U4Enrm/0uD8DgwkKH3p6R8Ja1LHOxuGNVtv+gNgR3pY=; b=QRKG0WC2R5Mzr5vlIDwhN5kse3uTnZDv/FcEnijk4VlKs3qS9J19MnEYjxaSvImyzZB+zy TrIhWmZ0J+EWCFCDvp/4LK6QVWcPHM6dCXl0JNPKqujI1cyUQI71bOenWUD2vAxm98ljLn DC8Q+tVOp9+pLr7iJy3nT/+bn9AnS2k= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-mI9t3gCJOzCU0P3RRsqFSg-1; Wed, 20 May 2026 10:44:34 -0400 X-MC-Unique: mI9t3gCJOzCU0P3RRsqFSg-1 X-Mimecast-MFC-AGG-ID: mI9t3gCJOzCU0P3RRsqFSg_1779288273 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4411a2c034fso4618074f8f.3 for ; Wed, 20 May 2026 07:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779288271; x=1779893071; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U4Enrm/0uD8DgwkKH3p6R8Ja1LHOxuGNVtv+gNgR3pY=; b=L8ypGoOo0+7lX6cs1qfgnoVg2qQz1wbZvzHuIRu6+YWB0wZOAkz9uV0pOgqbCDOO/1 cK/Xt14hsVoVM/j8tg/eWNaFyhDP5xDq28KudAt55TcBwsEgmx/cWQMZ3Qopda68/ram nDOUIIvhpmxE/1TfIx0m1nQAbHlYL8CaOOM3uAzberMpPMrxsG7HOL5q+PVmJhEmtw2N LHPDxKMlpihABSKb0RZMOD64aw3SZTtj6+fQCuj/gnW+yutgkJIgpMnn6+9/cJri4Myr 2J5f2zjIIwSCT+JNryHVO9DLSlR35SW7sKymL3cSvxP9Q4Y/mg/p4pAcEV0wn+Mt89Jt j/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779288271; x=1779893071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U4Enrm/0uD8DgwkKH3p6R8Ja1LHOxuGNVtv+gNgR3pY=; b=SZma2cyt1H0YqerqbJxYozesaCl1hAokPw1Nu1xQJjJbKHNeNVr6FYeMK7RIrLSSh8 kwePV0t1+HfwoIP5p0dzR2A+8egSSNwDVyNSgorKp0S2C5HgCeL5/UoR268qlSjpm2DO osUs0Rjn2uywTr5CzU6ChN07BdBkXhsa+qGwVweoyusswLuPWWJsOkqos96c2z9gLHI3 bCayioWSI3i00G8reG8X3FPhQGYyCdEjS3sZl5/hEAxt9KTgvhE20mQmi8DwbCsqWddN 1As9VZUGjeUrO3Jgw8MUsDn3XZ9pBiMYJ5xsXJWCT8Qi7I6l9EBlufqWyRjh/TQOh4on gUjQ== X-Gm-Message-State: AOJu0YyYlZ/0KEBuhk5KAK/BjscF28U7oLVLmhNQg32PSOW+M4TMV1OG nD5AbRzN3toxlQIDb9tXJfnu6HBlUPTOGqt9/X1Lk8VaBRISEnFkbCljjoZ5dwsHLOn0JNZAAro OSDtTKI/hlcZs23lR7hL42oo16h+88dSYFXdapu92b1sL4nZAQF05IWjjQ1oeIMCVZTwrs9ktyk s5OFmqOtoeTJElHkyd9TBwjPOdDJGYPOVMdr7PfhIFLAYo8VGd X-Gm-Gg: Acq92OGsfYrPpslu14gZF1j+XW9pWpM6DAwMUo/HjeZygXJz02HznR7Wk5Y4K5TjSEP cWy8AeGOdh/gHbkNCW63RnS8tf4jfbRtAo+f/yHowe2O8BQe0kyE7uo2d86/tZpgSlcVZDUOOM0 9SGwV6iuhLgjhiOzxtj3zyfXkbTuZDDwVlqEx2Bvax52JG06IkWA8cwTUdA8hyDtyj9fMyakAOt +kh3HdHSGCqUei5/vmRwLG+YziFdWSLRoFrTUXVtSxP0jT/RoQYs1jt9kAkSAcrWvnOB8wVxrzK W80vH/Cz+uaLWbW5xSohFyYuEMWH/rnrhx484rYId+F2k47bF8xU/JZDCh9cTXRDRVbxsKRfE75 2RJO6KI6PxajJj7uB6Z71Zs79xx7HkVRvW74WmOMf5cy+Fk0= X-Received: by 2002:a05:6000:2087:b0:43d:69ff:6898 with SMTP id ffacd0b85a97d-45e5c362cccmr39206499f8f.9.1779288270920; Wed, 20 May 2026 07:44:30 -0700 (PDT) X-Received: by 2002:a05:6000:2087:b0:43d:69ff:6898 with SMTP id ffacd0b85a97d-45e5c362cccmr39206452f8f.9.1779288270420; Wed, 20 May 2026 07:44:30 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a19c2dsm55442337f8f.21.2026.05.20.07.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 07:44:29 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Heiko Stuebner Subject: [PATCH v2 1/8] video/hdmi: Add common TMDS character rate constants Date: Wed, 20 May 2026 16:43:37 +0200 Message-ID: <20260520144424.1633354-2-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520144424.1633354-1-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Several DRM drivers already define their own constants for minimum and maximum TMDS character rates. By defining common rate constants in a shared header, drivers can just use them instead of having driver local define macros or use magic numbers. The values defined in the header correspond to maximum TMDS character rates defined by each HDMI specification version: - HDMI_TMDS_CHAR_RATE_MIN_HZ: 25 MHz (minimum for all versions) - HDMI_1_0_TMDS_CHAR_RATE_MAX_HZ: 165 MHz (HDMI 1.0 maximum) - HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ: 340 MHz (HDMI 1.3 maximum) - HDMI_2_0_TMDS_CHAR_RATE_MAX_HZ: 600 MHz (HDMI 2.0 maximum) Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Heiko Stuebner Reviewed-by: Dmitry Baryshkov Reviewed-by: Maxime Ripard Reviewed-by: Neil Armstrong --- Changes in v2: - Change naming convention to HDMI_$SPEC_TMDS_CHAR_RATE_MAX_HZ (Maxime). - Define the constants in (Dmitry). include/linux/hdmi.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h index 96bda41d9148..8dab78e1f61b 100644 --- a/include/linux/hdmi.h +++ b/include/linux/hdmi.h @@ -50,6 +50,12 @@ enum hdmi_infoframe_type { HDMI_INFOFRAME_TYPE_DRM =3D 0x87, }; =20 +/* HDMI spec maximum TMDS character rates, in Hz */ +#define HDMI_TMDS_CHAR_RATE_MIN_HZ 25000000 +#define HDMI_1_0_TMDS_CHAR_RATE_MAX_HZ 165000000 +#define HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ 340000000 +#define HDMI_2_0_TMDS_CHAR_RATE_MAX_HZ 600000000 + #define HDMI_IEEE_OUI 0x000c03 #define HDMI_FORUM_IEEE_OUI 0xc45dd8 #define HDMI_INFOFRAME_HEADER_SIZE 4 --=20 2.54.0 From nobody Sun May 24 23:29:10 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3EEA3EC2FB for ; Wed, 20 May 2026 14:44:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288282; cv=none; b=JKV7DWv7rjySWOYGnh1B6u99LV9LG7LzrvzZIb2TjrxMRcAfvr61HYzgvDfEvPCrg77O9PnZtjNBiMqozWDm/8O0Pxqkr6kyiDfRWtc2M2q9Q+yEwqR+KDZrOyPAEMZJyDrGPpYGg3uxy5gp0wok6zCy4s2DiGmXV30pRdOmTEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288282; c=relaxed/simple; bh=DkzllpKWjnd26gBnyQF7wWmb8cVdPFyb/a5Eng97BA0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g3JpMZ6uxrAL/Hva5A19hymZWgkYTIpQ3Pyy1itOK9VwLMK/4pD/F8w9KcZMS5Bo0W23lc316+gYBuL7HGYFo6sBL+V+X/9FXRLrNOZlxI0HQVscWu8Jzq24XqufeTqP6MrnU8WcFTN1+3uapflutLmaQJWpiWq2h8nEs6AKIHo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AgKnEJuy; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=PS7B9HsO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AgKnEJuy"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="PS7B9HsO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779288279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yg6ugDawgWn5QsRCnVPpHRqRu0HM07HRxwmRFu7Ahbk=; b=AgKnEJuyH6xGJZBInH3fIHN78TYO9HCUcgLDSiKHfFv2AQUvbD4qmao5hO9HiA/MhU0C3m AGD4ESY130t/KE/L+qALnv2GM42mJFe87PkEuy56tAxpDU/9MhabGA+9EY01+SDq3Lpt1K +8TLvKB5kH/HhHz/2q/vdNJ+B+AuHnk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-474-OknMES8gMSuPtzlCk1CgMA-1; Wed, 20 May 2026 10:44:38 -0400 X-MC-Unique: OknMES8gMSuPtzlCk1CgMA-1 X-Mimecast-MFC-AGG-ID: OknMES8gMSuPtzlCk1CgMA_1779288276 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4900f69197fso17742835e9.2 for ; Wed, 20 May 2026 07:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779288275; x=1779893075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yg6ugDawgWn5QsRCnVPpHRqRu0HM07HRxwmRFu7Ahbk=; b=PS7B9HsO9dr9JvAbPKMDrnHPc+kyzVFh4xkWLg1MUYcxSHaEfS/CycNE6PyHVHrcjT 9gPcqqoenRDcSxP8J/GlsM71AEn/Dk5qqXNRnTwkRAUAnaTlp44nzkvUSgya01Pw4TXf 0veYFxWfjtSaA52PFG9SAtBpCCCnPuGnufl9Hj90FPqRCCXfT75h3mgdMZwpiXxhc68W GdUqch4cmkqPyWLhe+4iGaLIZ4iaBEP+A83/iTGvH65dJge8tNrj48nwxd+7t8CA3mOZ gH6GyrITNMoeXWjRPLXlvYXibHS72d7cz+VXwWz8o0F4NIIVf3LioGZtFiO5hbxGDtlS vv+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779288275; x=1779893075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yg6ugDawgWn5QsRCnVPpHRqRu0HM07HRxwmRFu7Ahbk=; b=Cy4ShoCYapZnl8BSrQh2M4aL8IXBAEEy8vMyp6Kf3eW2jx1oUDl/1MEvBrc8grG/50 TY0RsH7WuKmMzQmqfXyoor3eyQEdLpEf/LUHxW+g1VEi1hyzlNwneU1aOmc1jF4eBbdX RtZnhpBsEPxuj/plCvYZJPhRK4NVO+RSPgEkFmja5wY+fMmyWJY0+wL+mEXJR8fUXMja MkfraJI4zavsrfNExO5SN8yfWxgOcmMiZL5WnI/Itcnqw7BoJK2m+0hFBCsA16RhPrnV 4wzQ0+HycXAXHjbtIcVMM7nLvU2912858c754bD91ZuqNXBPqgiDTj/xEgvMKrfwgmE8 ++2w== X-Gm-Message-State: AOJu0YxAbmF9vHPvXjAr4k8yZZKgIFofazQ+Tff1amy2HGyI0/MsDYQf JkbBbNDy1Hmm1ORahruzDX2rA0JJf7vCRcQy/kac1ubDiI/V8RjpMQbq6ojYBSJgvukcYgAsADQ vCHlk7WOAMpcO+lBnuWMIo9ohMc/cXs3mJytRkPDTC4UiQ2Nf0Xx4JQc3RxvCoTFz5wP7K1Af+6 4dOPrPSSdE+GNDtRn6EDM34sjT8wTyfNDUL9yDLeGNc3fpNRbe X-Gm-Gg: Acq92OGviEeQYGtXuDcmgJhQRYanZaGTRzbXOMFKm/8jOHXJXf5EDBu0RvosLF+v61K pbwO9hiOHtHOOwFRVIVLhfeIS1fD1UhbGmMn6zSGFXadmEv+2yJJ5pMuY8PpctSaG5CsMk/03f/ VxhNtwce5U/y04lJKVn3kljIHzO0eVSWtQLp5sH8uck86WRz9umyO1lQWs5DLCGXdIHChCAbjOB j4J4adD4MdgwVHcs4wE3s/0nuJUrPO2iCl+4B8NpMDGOb0wJrZIfJ6eqmeLN1haGm5mu+O63B8N fzsqVAaHJEprRATLi2VfB2ZsPbmXks7tNBX/cTk1CMWeX7mU2MftiM1qD36Ovb4BesFUfy+pvgu bX+piCfzZrsFjm2vqs+mJABdmuw+JaN2i8EtNLmyoZ1qH1NQ= X-Received: by 2002:a05:600c:848c:b0:48a:563c:c8c0 with SMTP id 5b1f17b1804b1-48fe60e51c6mr377331065e9.7.1779288274931; Wed, 20 May 2026 07:44:34 -0700 (PDT) X-Received: by 2002:a05:600c:848c:b0:48a:563c:c8c0 with SMTP id 5b1f17b1804b1-48fe60e51c6mr377330385e9.7.1779288274397; Wed, 20 May 2026 07:44:34 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe53ab6aasm432985425e9.2.2026.05.20.07.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 07:44:31 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Heiko Stuebner , Neil Armstrong , Andrzej Hajda , David Airlie , Dmitry Baryshkov , Jani Nikula , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Liu Ying , Luca Ceresoli , Maarten Lankhorst , Robert Foss , Shengjiu Wang , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v2 2/8] drm/bridge: dw-hdmi: Use the common TMDS char rate constant Date: Wed, 20 May 2026 16:43:38 +0200 Message-ID: <20260520144424.1633354-3-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520144424.1633354-1-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the driver local HDMI14_MAX_TMDSCLK define with the shared constant defined in the header. The local define incorrectly referenced HDMI 1.4, but the 340 MHz maximum TMDS character rate was actually introduced in HDMI 1.3. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Heiko Stuebner Reviewed-by: Neil Armstrong Reviewed-by: Maxime Ripard --- (no changes since v1) drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/br= idge/synopsys/dw-hdmi.c index 41b3a9cfa2f5..17d5caedb32e 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -51,8 +51,6 @@ /* DW-HDMI Controller >=3D 0x200a are at least compliant with SCDC version= 1 */ #define SCDC_MIN_SOURCE_VERSION 0x1 =20 -#define HDMI14_MAX_TMDSCLK 340000000 - static const u16 csc_coeff_default[3][4] =3D { { 0x2000, 0x0000, 0x0000, 0x0000 }, { 0x0000, 0x2000, 0x0000, 0x0000 }, @@ -1426,7 +1424,7 @@ void dw_hdmi_set_high_tmds_clock_ratio(struct dw_hdmi= *hdmi, =20 /* Control for TMDS Bit Period/TMDS Clock-Period Ratio */ if (dw_hdmi_support_scdc(hdmi, display)) { - if (mtmdsclock > HDMI14_MAX_TMDSCLK) + if (mtmdsclock > HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ) drm_scdc_set_high_tmds_clock_ratio(hdmi->curr_conn, 1); else drm_scdc_set_high_tmds_clock_ratio(hdmi->curr_conn, 0); @@ -1671,7 +1669,7 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi, } =20 /* Wait for resuming transmission of TMDS clock and data */ - if (mtmdsclock > HDMI14_MAX_TMDSCLK) + if (mtmdsclock > HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ) msleep(100); =20 return dw_hdmi_phy_power_on(hdmi); @@ -2032,7 +2030,7 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi, /* Set up HDMI_FC_INVIDCONF */ inv_val =3D (hdmi->hdmi_data.hdcp_enable || (dw_hdmi_support_scdc(hdmi, display) && - (vmode->mtmdsclock > HDMI14_MAX_TMDSCLK || + (vmode->mtmdsclock > HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ || hdmi_info->scdc.scrambling.low_rates)) ? HDMI_FC_INVIDCONF_HDCP_KEEPOUT_ACTIVE : HDMI_FC_INVIDCONF_HDCP_KEEPOUT_INACTIVE); @@ -2100,7 +2098,7 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi, =20 /* Scrambling Control */ if (dw_hdmi_support_scdc(hdmi, display)) { - if (vmode->mtmdsclock > HDMI14_MAX_TMDSCLK || + if (vmode->mtmdsclock > HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ || hdmi_info->scdc.scrambling.low_rates) { /* * HDMI2.0 Specifies the following procedure: --=20 2.54.0 From nobody Sun May 24 23:29:10 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 979B93EEACD for ; Wed, 20 May 2026 14:44:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288285; cv=none; b=R5TTtFtnHyJ+9Tnfzyb5jWl+q1bDY26Fj2aS82G1vQPHe/8F+yMyBVX8+JhzA/rdYL8mtJV6IApNZ3QlRdVPcpz7Dj6410oau35NkI8uhgKnl+MknBljSpPhWSO8VuiE0ksGtLOHjvbpwD9smCvUGbHmNYy5hwZMLgrZCJerZfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288285; c=relaxed/simple; bh=fE+igeL/j/LsOzA/g5PlS4vH35q42svJOZSnbALq3V0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B37xi1V3eqRBRZpOEwUQZ+kxHCjUd21GCJJrizuHa2yU1Al1MjNCcwnkyeq4Yod+N3N4iL+XlV/Qkr1J7uuInHdvibkVi7ABfmrDLI/8EmzAf5t9Dks2yMR4rQeHnt5s508TN9grj8xjubFK68glu+/9ROGJxN9DxRdg7JK/Dto= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HcR/Rvgx; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=toHvXTsV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HcR/Rvgx"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="toHvXTsV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779288282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JrxzAdgBYytRoIJpGeZZBDTthna9I+jFkH7rD3Jxpxs=; b=HcR/RvgxLKOHL6zl6bJjSiCZNx8+abiqQvSs5zH/lPS/rnP9MIG/vfKP3MIzpkv0gw1IHs zhnSnENdDpgihdseKyedwpLiQ/pULv8neG7tDVrnhmNHvWazj7eZW1qDbbPCGRg7BqviMC ywLrJ1NLeFNirGJUgqXsKA/OV/x7udo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-6hBrAYoCNbafc561JdTpwQ-1; Wed, 20 May 2026 10:44:40 -0400 X-MC-Unique: 6hBrAYoCNbafc561JdTpwQ-1 X-Mimecast-MFC-AGG-ID: 6hBrAYoCNbafc561JdTpwQ_1779288278 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48fe3e73da6so24744095e9.2 for ; Wed, 20 May 2026 07:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779288277; x=1779893077; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JrxzAdgBYytRoIJpGeZZBDTthna9I+jFkH7rD3Jxpxs=; b=toHvXTsVNgbClZRQmgBewbFx3m6ETtDI9J6rAlORxRERp4+BPdMWqRU8pEgLVanuRU o1nbFkF30a0bVwWGJhq7XM48uyIu65KQmjIqXdJa4OTHYZ88SI9mjKcmGmG+aoZfJmCl nRjaE4WG8lI8En8xNtXagBQYaMW16HHPmzxDwpjvgnDoA2kHnwXUh5NMOhu+VymjvfwF KeYAzO7oVouLLR/80ukCvOhHovxa68wx3POC07/oaaD1xhmUXCNE1FReTIQ1abg+1hKq F1rzXo3MdA6EbsSkGFM++DqfxFdZ4RfiTekrRjTFDaQcM00BHfCyicW3FAqObGt5pFwV fHHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779288277; x=1779893077; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JrxzAdgBYytRoIJpGeZZBDTthna9I+jFkH7rD3Jxpxs=; b=LoAZt16U6bqw2gwIpJAqgFdBVnX5Rk8FLmyZ4Irr5laWmyRHAIh4FGeS7GJdI5n0w7 W5vtAT3wpLM12DxVwYAEJe4Ixrxwse4aQYz8jLlLdY7tGoLvEsGkIM1sV6YJJg7q1FAp QqGeNG3GKAuiT9EzVUmZeLH4x4ir2D2DZPmIADwjoBIa5Ok8+9SNr8cL/LMP5LEzML5M ea1njWw7GbNSbqL155E96YUKBpCJV0DcyWwqznfr8WaFM+smN/DgA1nCPFRvnF7aHbC7 EAz+cdJm4WVBSOfwDHZrSoULBqWRV1UF+TED7GUFZcIlCQ6WvmEnvU7G9wBJQ60blaQ0 x/mg== X-Gm-Message-State: AOJu0YwkE7C3AEaGi/T4Z+kmod3dIV/p8h2eovBQ2Rh9izEybqggVPtm BFBSVKd+v/ob22LPXZV9dd5Zx8vXsO+IqgNa8TMBNJgOtRZCeQgBwbXl9a4hTwzgHER+fqHnyYF hbRGWnk23A5mtlIXRGw8pzyD6ZPsXxJ0n/AI3AlSO0Hq537XpoFbyi1tv0J9s/bf5lzYgqVB7er rrUWyU4c2ig+QF16g1ExxfvyBGWxG/KJA6lCq8470RXRuni3Q2 X-Gm-Gg: Acq92OGz8iWQBcY9dP7s41G3YByTsTkwlpBU6I+5Mzf5RDgW0Yc3mqNHjja5xnfYBAK ZCHN65PcRsvUZQ2zHL2cFJqz+BL2c86qCO9xmluvwPXq+dMORWqS95DlcyO/CO2WzSsGwCaNJ9j vRrvRVyJvTznOm5D7lKWSSGGeq8P/ShGcaLhbclJvKWcXZ1h0Oi0aTcjw1gVnGtQ/GZUlu/IwNc Jsxu+D4NQOUJS8xOAmGI80YuvuddHvK3o8gD8QYkpqYTjnjE1iMWC7ULrQvYcGXgTGxsItzsGa3 NOulYNJS+blJrEJM8eK9BMhCApy9FDnPpBV5sNdgLKuo+e9vkr+pk3k/FnL0703VJdwG1xNjZhZ lX+bYdrboEPp2d8bpDlRaOrgakWBBJZrbH0TgFMB3RcJu+w0= X-Received: by 2002:a05:600c:350b:b0:48a:58ae:9938 with SMTP id 5b1f17b1804b1-48ff3346102mr294157685e9.19.1779288276982; Wed, 20 May 2026 07:44:36 -0700 (PDT) X-Received: by 2002:a05:600c:350b:b0:48a:58ae:9938 with SMTP id 5b1f17b1804b1-48ff3346102mr294156915e9.19.1779288276391; Wed, 20 May 2026 07:44:36 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ec3acf7sm55247030f8f.12.2026.05.20.07.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 07:44:35 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Neil Armstrong , Andrzej Hajda , Andy Yan , Chris Morgan , Cristian Ciocaltea , Daniel Stone , David Airlie , Dmitry Baryshkov , Heiko Stuebner , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Robert Foss , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v2 3/8] drm/bridge: dw-hdmi-qp: Use the common TMDS char rate constant Date: Wed, 20 May 2026 16:43:39 +0200 Message-ID: <20260520144424.1633354-4-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520144424.1633354-1-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the driver local HDMI14_MAX_TMDSCLK define with the shared constant defined in the header. The local define incorrectly referenced HDMI 1.4, but the 340 MHz maximum TMDS character rate was actually introduced in HDMI 1.3. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Neil Armstrong Reviewed-by: Heiko Stuebner Reviewed-by: Maxime Ripard --- (no changes since v1) drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm= /bridge/synopsys/dw-hdmi-qp.c index 0dbb12743609..1c214a8e6dc2 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -38,8 +38,6 @@ #define DDC_CI_ADDR 0x37 #define DDC_SEGMENT_ADDR 0x30 =20 -#define HDMI14_MAX_TMDSCLK 340000000 - #define SCRAMB_POLL_DELAY_MS 3000 =20 /* @@ -835,9 +833,9 @@ dw_hdmi_qp_bridge_tmds_char_rate_valid(const struct drm= _bridge *bridge, /* * TODO: when hdmi->no_hpd is 1 we must not support modes that * require scrambling, including every mode with a clock above - * HDMI14_MAX_TMDSCLK. + * HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ. */ - if (rate > HDMI14_MAX_TMDSCLK) { + if (rate > HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ) { dev_dbg(hdmi->dev, "Unsupported TMDS char rate: %lld\n", rate); return MODE_CLOCK_HIGH; } --=20 2.54.0 From nobody Sun May 24 23:29:10 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31ED83EEAEF for ; Wed, 20 May 2026 14:44:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288286; cv=none; b=RvKO2Tnc0LILzqIDd2+K+TeVdlxjzaqdi2DGVLIQqxy7gyTANPbAdhP2o4uQSomXsIedWYmX6mUcjfw92JxrSO7zsXCROWUqM4VAw71UQ19pLsf112TEyGwYxPx8D7k5K18BWj3yIYARE7c8313mFhAJtOEHn2trWSRq00BLp6M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288286; c=relaxed/simple; bh=4HL2snIFitlzDd9WaCKAohtWGHwXjTf79KDAPZEhoPs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iHfVGDA0KOcqKqNnI7v0lglcvtfeAcXiRsXAsXv94Au53JKkAhWWzMcnsbILHQeaYmd1tSADRg6I/z0GWGbP/NnvLqQ2plhKYU+F8VCyWqdCgz3hjzONJr7YOd7HRcz+6bfUi3trwEQX1GdNiEuDLc0ExEwI7IPL1s8S67u1XtU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DXvWK869; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z1mkgDID; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DXvWK869"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z1mkgDID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779288284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DzTvpH43hpdC78r5E1lFxVLsz0tO9A+WLlws2ErA588=; b=DXvWK869T339iIlJp0LYChncBbrKmneMSZbZH2wqzYymjjGjPunnxF2FYKKdPCLdNxiDf6 sOgSoSQJPGkfW7Em+8ITvMJGkrIxmUlaEUxeZy6cwLDICFbR4AdCqwcPgiy0pYv5a7UF9z fcbhN4xB9RIkDVedgFiKFOqLQTwunkI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-V_RyzJSmPk-_nR8-ESpQCQ-1; Wed, 20 May 2026 10:44:41 -0400 X-MC-Unique: V_RyzJSmPk-_nR8-ESpQCQ-1 X-Mimecast-MFC-AGG-ID: V_RyzJSmPk-_nR8-ESpQCQ_1779288280 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48a589c7879so39086155e9.1 for ; Wed, 20 May 2026 07:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779288279; x=1779893079; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DzTvpH43hpdC78r5E1lFxVLsz0tO9A+WLlws2ErA588=; b=Z1mkgDIDQ7SP1fkr5UnFuaXy5hhmOE9Y4xo1F+TURgPrJH9GpXR/2fV6M2R9xlL3Wx KDmw8QsXrbX4AZwJxrQlSs0Dks3+8QD0oY49m6dPji2w75AWj88YlgKWbpOM5hpl5i5n XqpFy9HFhVfMzjyzk6zsQ3JQodvJnIMRg5FgCeI6oesTnO1hXpbkAljdqXlnARwKb0r8 6jUOxzjwoX1GDLu1triBhaQvXzkiQfA2xD2gmT/begSnuoYT7J1K3643nwle2CZQbxtt YC/PhuQpzCBAkUYUfwTye5dSuwjSS3EHr38eh3XEwj17Lgy4Zc2VnARGHWkn2bqY8uJN a91w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779288279; x=1779893079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DzTvpH43hpdC78r5E1lFxVLsz0tO9A+WLlws2ErA588=; b=CbsIvxVLgWVP+gFcr9zbc/rF0ndqfzFzbJrjpbmaZPeCRkPFdq7fBJlNLXlS4xkxlb CIRGwR/DanXjx/xNrsbGUZBzznG5Yz30qmnR5EEFJE4Zzo8O1A4DnFQ59nlXNUAhCcnL C3nFCKPb1bkaJfcvJv34MIOsl9UBHspbY6t/BXAH4YoeB2Z0en/Q9XROYy8UTERqlHdH Bll+1lekQX9e2astjZPBaGfiiaanmWqDicPfFAQpn3NCWzanxr87Gi/uqh1PQhmtCbUW /05xZsxy0ogy+uGffB+T1F0nNT7XHQ37J+kh1OLv3K1u1yCa8aTsOSpc+7HMsIMIrT6m yJDw== X-Gm-Message-State: AOJu0YwI4UtW0IhLDU8EsLBW5neZgqCvXHGOsKIw1Y10FJEzFvHAoCj4 rEUojCfoFXJmaJA7dRBVtAEAxxsBgNFgtSc8M9reGSS7txn4s1mI5/Z3/bSIRTfAg4VwK274QN2 PuPpt8HjKQ7YweOUO7YOFdVHCqM0lffOn8xXmhTwtfXyL9GZKFwmZykmAmWSefPxSEeZdGAPR+u fhPv6HCLas0sl3IeZJfRvCfba7hfdkbVN0F7xhnUag45xCAUcK X-Gm-Gg: Acq92OGO6hw5Rw4LTJa+zstXG4UOmpJmkUCUXgFu7ZzUzzkn0yLllXUuX+8YqTW1nRq cNpyuvLabOCuhmOwCmp6EixOA9/sO7c9/BY6b8mVUkyEiERbrg2oiQ5+Q38lQ/ZREGSj4jCH4QD fhn8Wqvd7T3CmNRgXaT28Y9BVb84MMYkNaAqhxgwc66a1n2+FdQKeQmbiIFn8QfzN3ScThLu7YD qAPg1h0G8W9h1SZtO5bwhQe/78ydOh4m6d2yRh2G2EiKwivfSA0Mvla22GFHQPBj7mbggGoCTsr fHocG5c0jMT+AmywFRZCIrhibYFeIMMNZ61/9r/d2DVPnHkhhuMGtG4Zh7+VMo5ZBlNDDgfMSue U1qkB0nwAPKhu/P/x127WpKyQUO9Z2flxM/OQ3MorEPfdiEE= X-Received: by 2002:a05:600c:3222:b0:48a:5236:7f38 with SMTP id 5b1f17b1804b1-48fd6367eb8mr270547935e9.14.1779288278940; Wed, 20 May 2026 07:44:38 -0700 (PDT) X-Received: by 2002:a05:600c:3222:b0:48a:5236:7f38 with SMTP id 5b1f17b1804b1-48fd6367eb8mr270547505e9.14.1779288278432; Wed, 20 May 2026 07:44:38 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9e768c4fsm55177883f8f.8.2026.05.20.07.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 07:44:37 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Heiko Stuebner , Andrzej Hajda , Andy Yan , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Neil Armstrong , Robert Foss , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v2 4/8] drm/bridge: inno-hdmi: Use the common TMDS char rate constant Date: Wed, 20 May 2026 16:43:40 +0200 Message-ID: <20260520144424.1633354-5-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520144424.1633354-1-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the driver local INNO_HDMI_MIN_TMDS_CLOCK define with the shared constant defined in the header. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Heiko Stuebner Reviewed-by: Maxime Ripard --- (no changes since v1) drivers/gpu/drm/bridge/inno-hdmi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/inno-hdmi.c b/drivers/gpu/drm/bridge/in= no-hdmi.c index 1091af29ad8f..5fa533a4eb34 100644 --- a/drivers/gpu/drm/bridge/inno-hdmi.c +++ b/drivers/gpu/drm/bridge/inno-hdmi.c @@ -31,8 +31,6 @@ #include #include =20 -#define INNO_HDMI_MIN_TMDS_CLOCK 25000000U - #define DDC_SEGMENT_ADDR 0x30 =20 #define HDMI_SCL_RATE (100 * 1000) @@ -820,7 +818,7 @@ static enum drm_mode_status inno_hdmi_bridge_mode_valid= (struct drm_bridge *bridg =20 mpixelclk =3D mode->clock * 1000; =20 - if (mpixelclk < INNO_HDMI_MIN_TMDS_CLOCK) + if (mpixelclk < HDMI_TMDS_CHAR_RATE_MIN_HZ) return MODE_CLOCK_LOW; =20 if (inno_hdmi_find_phy_config(hdmi, mpixelclk) < 0) --=20 2.54.0 From nobody Sun May 24 23:29:10 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FE883EEAEF for ; Wed, 20 May 2026 14:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288291; cv=none; b=sa4IPPq/Ifw2RDxeTxk2+W3+M8R7wA5O6cR4eNFT5zlZs+bpmK6cKBafjN8wmCzEiEauvlD8pxh/zRhk9xm9XhvyCvU2qNee3tc2s3RXStJdmB1ejIo1xVpTpKDbEsEZ1zQYOW+ct9bwUeolR7+rVpr/LxF1wLwUtQ5HztzZmww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288291; c=relaxed/simple; bh=BWDgrp7aESrJNyeD2w8fhppTlyybn0tSzOuGHnaXICo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XE9Qd1nndOTPCku3jKndD4+c2zeDuj6L+QP3+yp4PGrPAPLOIN3E82plgKP5+o/EciyMUvAZa7lhPiqVimnU+A42p8cSrZ/KQ1YbxdrbwHFvhf0dikCZkDGQzEyU5HZp+7uDlriIkqts1G2yq7hDDtpWrWiQKP1GqDbKJo8OmqU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=D6uB3Syz; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=kxVHOUbU; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="D6uB3Syz"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="kxVHOUbU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779288289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cJ50i4VAT7koucsYp09rCZ4i+eT1/vUOKhdV9aKMINU=; b=D6uB3SyzhBAjOZFJceDKM9+U5n8oH295wUZqHz4dlr2doj7YDy31UspPpLnqvU1oy9xh2Z PoSjNJs9ekdQVF+KGuIWw9v1swbDJoemKU0Mml0bGutR2wMoB0cVoligp4WnIbaGX186Fq +/iaDidQdaEi78D2eEIUwSof+agImdQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-Sii0P4ycPyqlDerKo-12VA-1; Wed, 20 May 2026 10:44:43 -0400 X-MC-Unique: Sii0P4ycPyqlDerKo-12VA-1 X-Mimecast-MFC-AGG-ID: Sii0P4ycPyqlDerKo-12VA_1779288282 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48fda34ed0aso19705815e9.1 for ; Wed, 20 May 2026 07:44:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779288281; x=1779893081; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cJ50i4VAT7koucsYp09rCZ4i+eT1/vUOKhdV9aKMINU=; b=kxVHOUbUGNbTehA86nfSeQTBNskrbrJmJ0B58lnUdZ6va+pxpGRW3k4/B6+dVTQAZo Xhzx7kKTrDTXhX/B/v4f0cHx0A8oHmDMJlk6v3QgnQHRBDGIxGLBWVM+ZIT0qQDegvOo dj2BqQkDx3gUwud1lqGRICEe1Ja70hqON+zTzUFVF9Ed7MO/Jz57a+F1JCfTmp84Azbc fMwnx49UdfLytOEQSlGD2jPhGKnKPWXWwdaU1D9JAstR0WPwWB9zmBZ9Y3YzEgp5ZWhb MRALira8R+3t6uhxMwEb6IVyq3xQBWHny4DdDB9/ABTDcWj6dUNiMoA0DipH9uuDNc25 wzgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779288281; x=1779893081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cJ50i4VAT7koucsYp09rCZ4i+eT1/vUOKhdV9aKMINU=; b=QkMJPNci3Xna2bFIv+ZrNzsBOL9F7TxbQR0ZcNlHrAad/Db3W7veMWDgVLhQisYo1e QR39VQNJtvU16bPBagkUe3jKQUMieBiBjadpUCzna7AIbidxMa2gVv7CQfMVGWwJw5cW QXumENFl6786tHzH98LAcnawMZeJGyq6moGRQlWElUZW5yk/Y45vWgHbgo2euZLjahLK v4MrRjBBw9VLYNhT18wByI4Rs0fOr+Oj7RyervrHynbV4Se8F38R8N+Muqk4dGBZZapB UNL2WaKu7QZyD+J373ryTuzO80ctaKfOBjeAW+8dyMA+BS6bhq8gfkd5ZlGRQqXzjF73 qg4g== X-Gm-Message-State: AOJu0Yw4krVQbwR2SeLiyRnJPcEkuoxw9Xl4klrDUnpX/PRoUBdeOB4g dvpjGbn3AN8OJMss6NZ+NNUx1rki8HPYKm2Z4Znw0zHAonsAzQuSEfNaamPotUfSce7wD5+CMPq a/pqPYsd5vDScOX+VmUL14cFGa4BK4okhgYJvTI9Quikr+KJZ39D+JFs0ARkFzYkjdNvRQxj1Cy YQqbzFN3CVqIILaK+W6lVZlyusAAifjn/AVr3f2GG/ZZ3SSme1 X-Gm-Gg: Acq92OEI6kGWNv7dkN33HHjttfaWxst9hk0oJubfq0Q/4ecGhKN7CsxL7dVFO3n/mKV WrOgeRNhhjyyuz1Z65bvpNV6QayymteYrhgdhKYZb7KgU4mCLcHvjfqkW4DqGodEl/o8gN6tV49 KwTCnVJyGdKoI0YrUfHmD//8YPpGvwWDKT+/R1EGDpQ6jXWxPhvdSrXbqHSD3+2d97N6OM7Ss3C AnXEtO2MGug9K3o2BCd4NkiavB0j/sKCFjGFvX9Dfyp+6F5lY71Nwh+dwwbwhCgm57i98s+uAQe Dl91wGS/ybIi+HfR9XtZBzeiW2bwphVDVb2lxErDVsCrAWI0FXkbL5kdxmG31Z3//r2bSnoYOPl Mz9QrtwCeCSrm39h4g9sDsqTJC+3oOPl72UUcwxAP3oJXJZo= X-Received: by 2002:a05:600c:a30a:b0:48a:568f:ae8a with SMTP id 5b1f17b1804b1-48fe5fda35fmr290659195e9.8.1779288281137; Wed, 20 May 2026 07:44:41 -0700 (PDT) X-Received: by 2002:a05:600c:a30a:b0:48a:568f:ae8a with SMTP id 5b1f17b1804b1-48fe5fda35fmr290658585e9.8.1779288280584; Wed, 20 May 2026 07:44:40 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe57944c1sm439641105e9.7.2026.05.20.07.44.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 07:44:39 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Alain Volmat , David Airlie , Maarten Lankhorst , Raphael Gallais-Pou , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v2 5/8] drm/sti: hdmi: Use the common TMDS char rate constants Date: Wed, 20 May 2026 16:43:41 +0200 Message-ID: <20260520144424.1633354-6-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520144424.1633354-1-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the 340000000 and 165000000 magic numbers with the shared constants defined in the header. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Maxime Ripard --- (no changes since v1) drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c b/drivers/gpu/drm/s= ti/sti_hdmi_tx3g4c28phy.c index d25ecd4f4b67..4fe0c54a096f 100644 --- a/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c +++ b/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c @@ -4,6 +4,8 @@ * Author: Vincent Abriou for STMicroelectronics. */ =20 +#include + #include =20 #include "sti_hdmi_tx3g4c28phy.h" @@ -102,7 +104,7 @@ static bool sti_hdmi_tx3g4c28phy_start(struct sti_hdmi = *hdmi) tmdsck =3D ckpxpll; pllctrl |=3D 40 << PLL_CFG_NDIV_SHIFT; =20 - if (tmdsck > 340000000) { + if (tmdsck > HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ) { DRM_ERROR("output TMDS clock (%d) out of range\n", tmdsck); goto err; } @@ -135,7 +137,7 @@ static bool sti_hdmi_tx3g4c28phy_start(struct sti_hdmi = *hdmi) HDMI_SRZ_CFG_EN_BIASRES_DETECTION | HDMI_SRZ_CFG_EN_SINK_TERM_DETECTION); =20 - if (tmdsck > 165000000) + if (tmdsck > HDMI_1_0_TMDS_CHAR_RATE_MAX_HZ) val |=3D HDMI_SRZ_CFG_EN_SRC_TERMINATION; =20 /* --=20 2.54.0 From nobody Sun May 24 23:29:10 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E36B23ED5C5 for ; Wed, 20 May 2026 14:44:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288290; cv=none; b=XlTjNpZjDotgTHcGP1qmv8E79i4RIK5Ew6phvY/z3rzrjMPsA1mK43XUsm6hXungokiBMDuGUt4JB6rhdQU90h2+mfKJ24Ptoh9WBMu1qws3QsYKEq9pYjBp1zEfJWwj+4L5dxduJSv6WIt0hm9D4oag1FGvtwdIwQdChokRsOU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288290; c=relaxed/simple; bh=QCHcVbwq0371QGOnwI+lDNZxJI2XqC1NlU75KLnG7Ps=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uu82O9cjTON+AUTSxY9MEqiXx7dx3Bz2mvdLjJnXDuO2L1rSrXkm4Qpa3fz4VE403+sn3MIhp/XAZ1HPY+XpIdezFcTU1Z/10nQ3+dVwVbEF5dn0B0EP8npM/cUgBzHhTyqktOyT23rSuzIWDGXLqkY7rHIHhPn8KSDIhUphk5A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HdNVbuW2; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=k9dncQhe; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HdNVbuW2"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="k9dncQhe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779288288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U1tSo1G68Ra9imzMIPMx7cCxGvcqmHD7eyQZ4RzsS9c=; b=HdNVbuW2lb2rNkHZPDRRRjOuylqst+qHyXvDoYjR8fqpQF1DiKzct5F8ss9XIYRbfZB5Mi jlNq5Q/6/MN7ikhk6nBM1Py4n86BLVcSvHO2zwP5UEiHV6zazzprTSv5VBt/jqgB/vHGcO sTfJkDZaAVCr4bxt7SHqvYGrEVZelbs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-75-ftqO0mIVMUCXUnuyJaGfIw-1; Wed, 20 May 2026 10:44:45 -0400 X-MC-Unique: ftqO0mIVMUCXUnuyJaGfIw-1 X-Mimecast-MFC-AGG-ID: ftqO0mIVMUCXUnuyJaGfIw_1779288285 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-44ffa15dc8cso3046452f8f.1 for ; Wed, 20 May 2026 07:44:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779288284; x=1779893084; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U1tSo1G68Ra9imzMIPMx7cCxGvcqmHD7eyQZ4RzsS9c=; b=k9dncQheIDcj8WOJUYGlzaDqpt7f1cQa/Lt5pqNENOjpLzzFCel5zhMW1nQpdPHuzU tmG+eVDxJTDyE30DAgQzVN4igmKro2FuWrFzYFHCNik7DOGBz2ktxsseFUzT338NIdV2 GRdPlf8Tel8w2KiIjOHRsHm07WyN0RfCwhGGn9sR8lTy+i/2nZ10KrawvDqjAyh9D45+ LNMkayLvqEaZfbux3/CtBmCGA4mEGZ8x6rdQSwNby/oJPV1jvlC34TY87eMB01Lumhds Sa6zXAEDunwkNNJeSg8Ot84soT+T2nuNVHL1SctHugfVqjiArqcP+ZfB3QT0TeUrOOlo Pe9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779288284; x=1779893084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U1tSo1G68Ra9imzMIPMx7cCxGvcqmHD7eyQZ4RzsS9c=; b=MnXwfwhrIPTKCYhCzOx1SdxxRO6sK5aV1ElHrip70T87gsHlpoTXsU18xU+yHtkksX +Y89X5+bEi5t0eBGn69FPMwqXc+6lzS+wZdb/SI3Eusi4gMVj4WNX6TGNcYpffe0Zpvq ooqVwwMZ55nLnq8aFMuMy7IfBuBGCAp/Jbq8FvR2RMTpQ3+vWxRSn8wI6+A5DFftoZYb UComR5K+Nn4XsrVzwluY5Sqx0h8xhCWF9sgyJn68J/4tkCn9+Z+xSI4cqKvXkWcXXDLd LrFRAyX8pU8xnHPOyzcfA1RV5TIPz2YSrXSwNgbfhu7tWNyVJMD6NnOyY9DM4yozMmI4 36Tg== X-Gm-Message-State: AOJu0YyVs81BYPutHQ/EDaox3jOv0oEFYAY/23NaxFpLtCL4B/cP6CMq QtJiVbGObs/Cr1rKTi6zV2aB0P6QemuL+hazjqwQEBlTJYofJjrtH204B8Wv0lv3KA29ODWIj9h tqAtWJaCa6/SbWT5Hm/MXMweYhBMP+oswPcGjKdEyU/vB5W6RoIsKDEvM2FTavC1SdSsIJKxhCo 5PBFKZ0769BJgvfV/MW5BB6Fb9b4BddFoY7uoml6Zs0BDlJR0E X-Gm-Gg: Acq92OGsQkn/gxGcq2HN9dKVqOacbrpT1P1Bs6YPf4qLpIoCxtQrTWYQwWTHlnYfJsl mCY8U3lcIAbgWSTTkaH1fQ1KPDWbimQzK2ufTPefwo3zM2s2uIWLh7/b121wyMq4RWZJvkbB0ct bOv/Zh34pkHYr0ZzBrGGQhhDRwb15DQyI1GkFjFu4MWhdPsH0kspm8d0+XfYDoP/Rucj9ETzQ2c iXHhdert8droWzntmLwlgOzSOf3URgawNBJ8LHkb+QqoGnSf42qOHPhbwIi/n/nQrlY/8X/mecG W/dGUtURQwyoUYzHWs7uTnrxgadvtJlq9ZiwKMaGdZw9lj88YLh2l6r8A8PII39Do1nbZMXsWV3 GzOKQiW84V2BdgNNL4vFZlrUDxAVR1Eckw/dspifJ/yThOPE= X-Received: by 2002:a05:6000:4301:b0:45e:93d5:7bf2 with SMTP id ffacd0b85a97d-45e93d57c00mr5545596f8f.15.1779288283733; Wed, 20 May 2026 07:44:43 -0700 (PDT) X-Received: by 2002:a05:6000:4301:b0:45e:93d5:7bf2 with SMTP id ffacd0b85a97d-45e93d57c00mr5545510f8f.15.1779288283160; Wed, 20 May 2026 07:44:43 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ec3b18fsm50145145f8f.11.2026.05.20.07.44.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 07:44:41 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Chen-Yu Tsai , David Airlie , Jernej Skrabec , Maarten Lankhorst , Samuel Holland , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH v2 6/8] drm/sun4i: hdmi: Use the common TMDS char rate constant Date: Wed, 20 May 2026 16:43:42 +0200 Message-ID: <20260520144424.1633354-7-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520144424.1633354-1-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the 165000000 magic number with the shared constant defined in the header. The old comment referenced "HDMI <=3D 1.2" but 165 MHz is actually the maximum TMDS character rate defined by the HDMI 1.0 spec. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Chen-Yu Tsai Reviewed-by: Maxime Ripard --- (no changes since v1) drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i= /sun4i_hdmi_enc.c index 07e2afcb4f95..74c7c3720ba8 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c @@ -189,8 +189,8 @@ sun4i_hdmi_connector_clock_valid(const struct drm_conne= ctor *connector, if (mode->flags & DRM_MODE_FLAG_DBLCLK) return MODE_BAD; =20 - /* 165 MHz is the typical max pixelclock frequency for HDMI <=3D 1.2 */ - if (clock > 165000000) + /* HDMI 1.0 max TMDS character rate */ + if (clock > HDMI_1_0_TMDS_CHAR_RATE_MAX_HZ) return MODE_CLOCK_HIGH; =20 rounded_rate =3D clk_round_rate(hdmi->tmds_clk, clock); --=20 2.54.0 From nobody Sun May 24 23:29:10 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DE4E3EC2CD for ; Wed, 20 May 2026 14:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288291; cv=none; b=sfkDIqHgdWi1fv8+3CB/v5HgOzijQQTcLulk2Cjxn0h5Q0GJ8b+H3Er7UumUOqb4wk3XPxJvLTZloE46a5wNjupXnMwxfD+FA6aDkMHR97odnsR0OsEm47uH9YTIuSG1IBPTVnFMb2hgx2n+exR0CsnZXuQspygD80ErHaHg+ec= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288291; c=relaxed/simple; bh=MenNASaSpX/A8DK7imp5VmknvIT3hXGOI33HP3Epa3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sOlqziPXLxGJ3hnfNFElcNgj11Q9HXa3LFvW7zwUEEReflL2XZOOUmDwLw3L1q7RhZwYfTp1ZTdSORiKC9I2+mq0sPzODptvfGcvx+X4Ws8GtiHRZD//XdkFFz8z0UHpj7Q9xMXc+lOPtQxxO0gVWawVHBN1j7rewnH8LfTBoAY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JUpZFb9s; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UTyhdSZ4; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JUpZFb9s"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UTyhdSZ4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779288289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7doYKg7uNXVfPcHfcWD2JJnnh8uBK1RxSsGyXu0nvLQ=; b=JUpZFb9s40L3op0M6j/rtVM50QVZQ2vELqIV17Sl+ZVPy5m3zuHNjU4jlkvZ4mTOdc/8Gx 3YaZP58x2IBaRKYyrI0KPeg0fE8tFz3++rZvwgS+IIDjhAsG8E6ApnuFUZGUXqs0hjr86e CWG/tNxwEd2fTzRhIrkSBZjcvqdPihY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-526-cKao5GrXNSirH8SSLEuuXw-1; Wed, 20 May 2026 10:44:47 -0400 X-MC-Unique: cKao5GrXNSirH8SSLEuuXw-1 X-Mimecast-MFC-AGG-ID: cKao5GrXNSirH8SSLEuuXw_1779288287 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-488d1b5bca0so20411195e9.2 for ; Wed, 20 May 2026 07:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779288286; x=1779893086; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7doYKg7uNXVfPcHfcWD2JJnnh8uBK1RxSsGyXu0nvLQ=; b=UTyhdSZ4sp63E3YjLJVVTLMWALtS/X4eEb9bE9OAFsfH89EOnAVhwNsnQg3omAwqmE h31L3hPT9J8c3c6A0dRsiWKqaBi9AXeOz5vSYYwwbNjIn5RRhq5lOOLN8eIiM9/IDe0O O/8++s8iW/98CoQVOD8gpmo7AQEBanKUsWimqxmjQ69RaOwIjQk8l7Xvhz7pilq0T8U4 LKq9gIwWEfdFdKQauOQkiDzixYvsec3xlGWkhQhUpOnoJIZrA16sbspgy1MPCgW0DZP3 HOGkNodDAIgjEax7IctP7jlLPxlLBZbQcpLwYSeL7h5XNxCB53DDWwCJ1YA2HxiBC+1n 9qvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779288286; x=1779893086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7doYKg7uNXVfPcHfcWD2JJnnh8uBK1RxSsGyXu0nvLQ=; b=HKwGTTnU0U7ySVwyGOMkc32B3fQ0ioItHv24dLRt+LoSrA6n6El9s23XEHOK/8ssj5 AZK7OT9TFjOBsHzkp19dDOYWUNBztnHQtEbZz/B9lOnP2qNXJTsNEPmx2MEyFQOLTgcU Bh/Ysv3t0P/9kAK7XKe9QebrBiuySU1lHYGQFl8CFJJ2Hx2b3u8ewQJuWVjAGBBxvYvK c53KQH3ezU9uBGy8una9dOB0txIkf5GrF7DxXfyf0l7kCfBTXpoiwNawbAJMMNUZywj5 OFLFLQviRnas+uPUxfCmkNSQ6+zMMI5+nMBRADvVavQdA3Zy+kD9u4pDxGrxIiaEvQC1 Z/Gg== X-Gm-Message-State: AOJu0Yz2FZ5eCnPCzv+QbFFF/Cxny7bCrthxgl32d80i5PkZ8AyWE9yS 6gZRMmm11sMyEHvCdN5aDVL5ZzDufG5JcTu8cI7OWujLjecO9EHNlV0vjjjBBOQbhnGuhrcxuw2 JGaComy4Bo4FGK4V2qOcf62i35vUqWmTRvhQD+ctpnjjFgnMkBkIZYvBcYe781a7DJQnTvQTxP+ DzcTEku/xcm2s0OGkTuEkCcls+ZBK9OY5aVilEeszU9OtuoFmc X-Gm-Gg: Acq92OFZHQYrNDOTQeFx2J6/kswkjILrHkykNw/9VsEWq9a2ABnd/Si/IY+WQnPIRIn VN6cL5yx+otWz62pnQhx5xKI5/SMrKOA52So4cSkEzNgIMOCmSZDZoqlSMGrBzUVzdlMrldI1ki Kg6ZzjPv+yikly/3wqLDAB1piRYDYl9q40QlNVClfFl1A2O6Spfq/kwifs4ZPkMOnwd8YJhsPC+ ip0lh9bqilGBa9sl6rr4NKV+2CtdQhfgcqPb42J4OBXshsHWNQpD2zH2eaMbJHAw7vFF5ibMe7Q yT2/emY7RnBMZq3QoS1ixS1fPO7JmB1HuHtiA/6prKsvjo/LE5mCimhxBX/5RtWCkYJIyzkrlQi VqJMArN8do1pq3XX6G98e1sZcvFJpw7LPo2W39ZaU3jZmnaL63g/geziTcA== X-Received: by 2002:a05:600c:c10b:b0:489:1cd2:610a with SMTP id 5b1f17b1804b1-48fe60d55c4mr267397375e9.9.1779288285913; Wed, 20 May 2026 07:44:45 -0700 (PDT) X-Received: by 2002:a05:600c:c10b:b0:489:1cd2:610a with SMTP id 5b1f17b1804b1-48fe60d55c4mr267396555e9.9.1779288285203; Wed, 20 May 2026 07:44:45 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe4862209sm398446965e9.0.2026.05.20.07.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 07:44:44 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Dmitry Baryshkov , Abhinav Kumar , Brian Masney , David Airlie , Dmitry Baryshkov , Jessica Zhang , Konrad Dybcio , Marijn Suijten , Rob Clark , Sean Paul , Simona Vetter , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 7/8] drm/msm/hdmi: Use the common TMDS char rate constants in 8996 PHY Date: Wed, 20 May 2026 16:43:43 +0200 Message-ID: <20260520144424.1633354-8-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520144424.1633354-1-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the driver local defines with the shared constants defined in the header for the minimum and maximum TMDS character rates. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Dmitry Baryshkov Reviewed-by: Maxime Ripard --- (no changes since v1) drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c b/drivers/gpu/drm/msm= /hdmi/hdmi_phy_8996.c index 36e928b0fd5a..71da20322b3d 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c @@ -11,9 +11,6 @@ #define HDMI_VCO_MAX_FREQ 12000000000UL #define HDMI_VCO_MIN_FREQ 8000000000UL =20 -#define HDMI_PCLK_MAX_FREQ 600000000 -#define HDMI_PCLK_MIN_FREQ 25000000 - #define HDMI_HIGH_FREQ_BIT_CLK_THRESHOLD 3400000000UL #define HDMI_DIG_FREQ_BIT_CLK_THRESHOLD 1500000000UL #define HDMI_MID_FREQ_BIT_CLK_THRESHOLD 750000000UL @@ -632,7 +629,8 @@ static int hdmi_8996_pll_prepare(struct clk_hw *hw) static int hdmi_8996_pll_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { - req->rate =3D clamp_t(unsigned long, req->rate, HDMI_PCLK_MIN_FREQ, HDMI_= PCLK_MAX_FREQ); + req->rate =3D clamp_t(unsigned long, req->rate, HDMI_TMDS_CHAR_RATE_MIN_H= Z, + HDMI_2_0_TMDS_CHAR_RATE_MAX_HZ); =20 return 0; } --=20 2.54.0 From nobody Sun May 24 23:29:10 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92A563EE1E0 for ; Wed, 20 May 2026 14:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288292; cv=none; b=nXkr5kWp2HaI6Um7T8Xq2mJkHK4tvj9gEnza3miJfG6geVjMiga9gJ+Nbrdr5hjvrQH6tKeT7Q8V+T5jduzysOW6XnnxKhuZG04xXPHUdfvgqbsSCYfJaglTDZsgZdeyGxUy+X0pOPsVIljlGRM0z3jE1C2PulkDPShLgWgc9t0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288292; c=relaxed/simple; bh=jEfZUqFY074Lw5sfn5a4E2fvpuL3y1rjjmlZE/QrIhY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N6zdMWz/WXazp1HUDr3H2bz2PU7sqO1vnYG24nR4CAza8UfaHOY6BT0V6LlV/W6ZH0eNJb9Rs5QFCM0DXiKcUBlVzxFR6iD8bmD3LGLYuVjLoPBh7lcZszJl7v472oUtX+vhX9BIpbdWhcbaNUbh834/o16+inHu4Ab5dCc4tYw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=h0G2ZyII; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=aoQ1Su8U; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h0G2ZyII"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="aoQ1Su8U" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779288290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kn/KwXlRjqhIt+wQ6tJp71uiYnDltrIKBv46ZENJaNM=; b=h0G2ZyIIIaPaB9b9f3Bb/jPMk5GGwOO+7WohoegObM1ffRoDq8BLxORJVqs9jdZzE6yKJ1 45qvr5yyZ+I5uPap2cE2QhpYukIkJ8etfXWSrXtaQotU+dZi9JkjOKAYlo2NqTtScxQ61y ++PEBk3llXYD0OX7IaUsthgKLfoYmC8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-ErZ1aXp7Mo2EGxUnejksMA-1; Wed, 20 May 2026 10:44:49 -0400 X-MC-Unique: ErZ1aXp7Mo2EGxUnejksMA-1 X-Mimecast-MFC-AGG-ID: ErZ1aXp7Mo2EGxUnejksMA_1779288288 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48fe6894f3fso29544705e9.2 for ; Wed, 20 May 2026 07:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779288288; x=1779893088; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kn/KwXlRjqhIt+wQ6tJp71uiYnDltrIKBv46ZENJaNM=; b=aoQ1Su8UXifJFaamXIHxbmq2WSYxpOo8d93rUZmm9MZ+F2xuoKSpt5B2cMa7HEWFXb wwThCw4vieEAnYcQR+qQaWatWU6GhGBO9WqX4LuxTmJpqhpCWbWBeDXWjv2utmpzNWdT AnBLs6M0+5OovsVdgaTvP9NK/bWUHRpNjeADrU9mIFJtEjYgp+nV8lNGYP74Om1cauyz irP/Yfg+r1htVO8HcMJh5Wtzt67G2o1SIFv5cnVjAGKI6DHLeA2PG5mHu7pD2Zbon1xU b8Edu63I8gzx1o5QtH+3pAyuW9qIsQfsoyDpXR4ZKgSKH2kDs2XkD8Nx3hB+31N+Xglx W+VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779288288; x=1779893088; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kn/KwXlRjqhIt+wQ6tJp71uiYnDltrIKBv46ZENJaNM=; b=pdeWRohOvRY3vwUhRx2z9MY4LV3tbgqez3WWVViSPeo+F9Qustsbtk7586VNf7GWYH yTuzXZNvwJX0w4uOgO6xbkmJSO0eedWUNQ9vD0ehwLBG/cCLp0F8gQ3QsZN2faHmOIxg w2CxPr+6753FKPh35muNb+KMrAtsuyT8hChbQmNdT4gdEc5zt9CN/aIiYsQpMmzyfj/w ClK/iQcihxF8LmNivmFu91lYgyc2etQ/18IlYyL3YSiJVh2+21Lfxd/nUyZ0HyWOJZMZ ADaO9L1RWzyaRq2sRkFYddSMkChT5mIOcaR1alWmZscG96i4JnIRS3R9Yd5yvjs9Iqii D0lg== X-Gm-Message-State: AOJu0Yx3XiqU6bvUf63qsIYvXmfEOEn9Y941eOLzwdZgAfpx4BR/foN0 F/TEpB52JI8ho386YlemW4RzMdb7e5NV/KOAZyHsOZKOtwYbeD5RMvSugBQLsj1iPtWjrA63iMn sMscgOU1zRPZxSAaq4A/t7tFt/jqmO2TMkw6Up9HdEA22j8x4sukR/JcmXRGnWHonvJg07aipdg uJAAPfNQJ73ztlJx8d/ytzsflUQX2at68N8SHfczWknhPQw3q5 X-Gm-Gg: Acq92OGAIkGxA1Fq4xRKaioYosCq4q8oYtsK8zkJeJQcTgMs/zpaXoTHIrMxHLF1aCL oMq5KfPavcgYCJaXZkozM0XxmIa+2Ci54QMCzY2cdGmjcaoqHRwQmUbIBV0sl+hwZjPRZPE2LNP lR9q/vSYzsik7B/EzcyVWsuW/eOqvE/rwVJ8YvnLqi1ckQeT+ufbaLIjqphmnyCZ4A7ByyOw5Q6 jkqHj8OtnVQH0+zxsg2qRfJhIpRYrST/UT65TxZZqwzYbEyaXZBUgF+QzlzEmhX7J10uMj+53bx NlQfUAf7DPb/c6+PLsLIFxsYwbTzdh4h/7Nm2H/fkFmcEVLYb6zjBziyUa/9jMDovZ9Q39+0hK5 pB6u6iGj1XAH2++9Cp/iM1vNtA3oLdKThLjqk0EsjZ1suxk9YzcBf0OVr4A== X-Received: by 2002:a05:600d:8496:10b0:48f:eb8b:997e with SMTP id 5b1f17b1804b1-48feb8b9ab1mr239050695e9.26.1779288288006; Wed, 20 May 2026 07:44:48 -0700 (PDT) X-Received: by 2002:a05:600d:8496:10b0:48f:eb8b:997e with SMTP id 5b1f17b1804b1-48feb8b9ab1mr239050115e9.26.1779288287373; Wed, 20 May 2026 07:44:47 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe4c88495sm394075225e9.4.2026.05.20.07.44.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 07:44:46 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Dmitry Baryshkov , Abhinav Kumar , Brian Masney , David Airlie , Dmitry Baryshkov , Jessica Zhang , Konrad Dybcio , Marijn Suijten , Rob Clark , Sean Paul , Simona Vetter , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 8/8] drm/msm/hdmi: Use the common TMDS char rate constants in 8998 PHY Date: Wed, 20 May 2026 16:43:44 +0200 Message-ID: <20260520144424.1633354-9-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520144424.1633354-1-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the driver local defines with the shared constants defined in the header for the minimum and maximum TMDS character rates. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Dmitry Baryshkov Reviewed-by: Maxime Ripard --- (no changes since v1) drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm= /hdmi/hdmi_phy_8998.c index a86ff3706369..05c3ffad858d 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c @@ -12,9 +12,6 @@ #define HDMI_VCO_MAX_FREQ 12000000000UL #define HDMI_VCO_MIN_FREQ 8000000000UL =20 -#define HDMI_PCLK_MAX_FREQ 600000000 -#define HDMI_PCLK_MIN_FREQ 25000000 - #define HDMI_HIGH_FREQ_BIT_CLK_THRESHOLD 3400000000UL #define HDMI_DIG_FREQ_BIT_CLK_THRESHOLD 1500000000UL #define HDMI_MID_FREQ_BIT_CLK_THRESHOLD 750000000UL @@ -649,7 +646,8 @@ static int hdmi_8998_pll_prepare(struct clk_hw *hw) static int hdmi_8998_pll_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { - req->rate =3D clamp_t(unsigned long, req->rate, HDMI_PCLK_MIN_FREQ, HDMI_= PCLK_MAX_FREQ); + req->rate =3D clamp_t(unsigned long, req->rate, HDMI_TMDS_CHAR_RATE_MIN_H= Z, + HDMI_2_0_TMDS_CHAR_RATE_MAX_HZ); =20 return 0; } --=20 2.54.0