From nobody Sun May 24 23:28:56 2026 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDA2A2D94B0 for ; Wed, 20 May 2026 13:34:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284043; cv=none; b=CroxoKk7H7nlTjroabPPOrmxPKwbehtXCzlF+QTYPWl/DOh7ZLgxaVdHShcuWCJgZvIvRm8nraqPesQJEVH3ck++6FdkcvXCwCZFw7UO+62Cd+1lXSGMANlQzQP+PNp75n/5E8vVtiyaMX+T0qKVEMaRIuXTL3AuBjmcbWBpQjI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284043; c=relaxed/simple; bh=BjdykeHS9BqEJZE1gE6CCOK/sLg66E2Y5BAmWKBD3Ho=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iwbk9imSj8ep1drsFWskw1B0CfrqQkuH1Ug+nArY4Y1x02iXdp9zBN8v5716sE3662OZl2RRowukpouLGScGeE/QNFmjuqp8GCA0LQGv0qubJ4eqwA8qTrPtABb9RSQRrSXNoS2SgBg5PaLykBJ0ln8sZe2PfRc64AkxC2cX+DE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oFE3njep; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oFE3njep" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-43587e63a8eso3169076fac.0 for ; Wed, 20 May 2026 06:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779284041; x=1779888841; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oAr9Tuamz6G4RMhF+mEaQvtccn86uYkrnM5/9wq0C+4=; b=oFE3njepusuwlDXbRrWVkht7doDMv8E3lbtntG/p1MVFNInt+/QSjvgK7hcJMVQZBK IKUaGMzPvkfeSxHh/tdzKvVLNO+/KU326x9HOzfCEA2hWOdq0wS4BJtDr/lLwacnAmwd kzFX3hGMY/Ov8jdTqSXDzbt/bDRRWtBittFh3JzbTgrirMbda4QA8fpEZ9n47HeqHxO4 T1Iqjzz1XbwvtyugGQkwi53/TGysByf+OtVH0DjZUXL5l2WoptKySbkftgg3ANzlDZMe 4Qq7+Ek9UrpBNBEQuBpu2yZM6OC6mc9saW3efbUNhPYtEQFRoazrTN4qI/PYSviHqMvd 8bZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779284041; x=1779888841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oAr9Tuamz6G4RMhF+mEaQvtccn86uYkrnM5/9wq0C+4=; b=hZgJulKeHUhZUxmeIAav+XgZ0xcofNuRuiiQAKJiAEmT9F5fTbrzNNxTI64/WtvuM6 SnaYxsaVJsiATSpO76Y1CwPDzevK0droEzlSjHsxSiEAzb1dAttnGcTUJyAXuddQ86nn T8N5ROcdP9Sdq9KxtEJcVBU9yzk411jhJQntoC5C93aqc6J+M3Up2UFnT42c4MQDrPXe J/z7Llv1IEny5aj6DQYbNyft4fMeVOXWzTxIMXj8piLJyTx4HP+pfovcKnmI3uvsd9EF H4FLsKCW3+d4iDziUA1jdm7HOtZORsUn11rDzgarh6lwwem4kECJUDO8TpiyiTGDe8r9 rgRA== X-Gm-Message-State: AOJu0YxwhM8q7DFFRV7GNE4kOFuOkgS6Y071IJ26ooxHRLkw+n8sGJ0M 1UhhO31S3chaDktLtDck46HCJVfmJAm4k8Jpx/Ct5E+q7XRznYtX568mgMmmbKYM X-Gm-Gg: Acq92OFJzTp2K7omyaKKW18J4hFD4sOEMHJEqwbeICvezod75kuRGRMAgbr2ai6jRJO PV0lCY2rfsQkQc1bHVAIve1V4nGBsCwbKQqLco8FGplvefls6BR3v4UT6n0CygbKoajYeh83Kbs zG43KhU0bbfsGwAPJKivAKC/62aF5SmGDuTwndhI5BPOSnFTzvSKpSGBdzg2+uLURIWqKBLtHt7 dn1CU7PPaHJOmOn/RnbPx28bAWkoD8CMXmErdyfF3VKRJzp+SuVWWb0+dSbI5DJewNdFr7nY9ea 8xDbuJ5IARi/pZSGaLhw3Z9VfRJcGQv4ZDPXOKKbWy9eEcdQoGXwNGdb3xpXB+rZUm+L1XaP3fD gefVQLYJR/CKH6UZhbvlAITXJcSEOpNuUSWMXVK0yFy8dS7jvsITQsEwHQ+DDxwuaqnCiDyq5kL G+TQR6GgBc2HpCR/JOaPCkhkm4O+rDBK/y5fPwvDI= X-Received: by 2002:a05:6871:5227:b0:42c:1786:2635 with SMTP id 586e51a60fabf-43a2df02a9bmr15292886fac.24.1779284040751; Wed, 20 May 2026 06:34:00 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a52:5b11:a58f:5208:2fa7:bba5]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43a956fa075sm10253951fac.10.2026.05.20.06.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 06:34:00 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan Subject: [PATCH v6 1/6] dt-bindings: leds: issi,is31fl32xx: convert the binding to yaml Date: Wed, 20 May 2026 21:33:38 +0800 Message-ID: <20260520133343.1423946-2-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520133343.1423946-1-jerrysteve1101@gmail.com> References: <20260520133343.1423946-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert leds-is31fl32xx to DT schema format. Co-developed-by: Lucca Fachinetti Signed-off-by: Lucca Fachinetti Co-developed-by: Pawel Zalewski Signed-off-by: Pawel Zalewski Signed-off-by: Jun Yan --- .../bindings/leds/issi,is31fl32xx.yaml | 151 ++++++++++++++++++ .../bindings/leds/leds-is31fl32xx.txt | 53 ------ 2 files changed, 151 insertions(+), 53 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/issi,is31fl32xx.= yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-is31fl32xx.= txt diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml b/= Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml new file mode 100644 index 000000000000..81f1e30e493d --- /dev/null +++ b/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml @@ -0,0 +1,151 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/issi,is31fl32xx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: IS31FL32xx and Si-En SN32xx LED controller + +maintainers: + - Lucca Fachinetti + - Pavel Machek + - Jun Yan + +description: | + The IS31FL32xx/SN32xx family of LED drivers are I2C devices with multiple + constant-current channels, each with independent 256-level PWM control. + Each LED is represented as a sub-node of the device. + + For more product information please see the links below: + https://www.lumissil.com/assets/pdf/core/IS31FL3216_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3293_DS.pdf + +properties: + compatible: + enum: + - issi,is31fl3216 + - issi,is31fl3218 + - issi,is31fl3235 + - issi,is31fl3236 + - issi,is31fl3293 + - si-en,sn3216 + - si-en,sn3218 + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@([1-9a-f]|1[0-9a-f]|2[0-4])$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + description: + LED channel number (1..N) + minimum: 1 + maximum: 36 + + required: + - reg + +allOf: + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3293 + then: + patternProperties: + "^led@": + properties: + reg: + maximum: 3 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3216 + - si-en,sn3216 + then: + patternProperties: + "^led@": + properties: + reg: + maximum: 16 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3218 + - si-en,sn3218 + then: + patternProperties: + "^led@": + properties: + reg: + maximum: 18 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3235 + then: + patternProperties: + "^led@": + properties: + reg: + maximum: 28 + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + +additionalProperties: false + +examples: + - | + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + led-controller@3c { + compatible =3D "issi,is31fl3236"; + reg =3D <0x3c>; + #address-cells =3D <1>; + #size-cells =3D <0>; + + led@1 { + reg =3D <1>; + color =3D ; + function =3D LED_FUNCTION_STATUS; + }; + + led@5 { + reg =3D <5>; + color =3D ; + function =3D LED_FUNCTION_POWER; + linux,default-trigger =3D "default-on"; + }; + }; + }; +... + diff --git a/Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt b/D= ocumentation/devicetree/bindings/leds/leds-is31fl32xx.txt deleted file mode 100644 index 7082ed186dd9..000000000000 --- a/Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt +++ /dev/null @@ -1,53 +0,0 @@ -Binding for ISSI IS31FL32xx and Si-En SN32xx LED Drivers - -The IS31FL32xx/SN32xx family of LED drivers are I2C devices with multiple -constant-current channels, each with independent 256-level PWM control. -Each LED is represented as a sub-node of the device. - -Required properties: -- compatible: one of - issi,is31fl3236 - issi,is31fl3235 - issi,is31fl3218 - issi,is31fl3216 - issi,is31fl3293 - si-en,sn3218 - si-en,sn3216 -- reg: I2C slave address -- address-cells : must be 1 -- size-cells : must be 0 - -LED sub-node properties: -- reg : LED channel number (1..N) -- label : (optional) - see Documentation/devicetree/bindings/leds/common.txt -- linux,default-trigger : (optional) - see Documentation/devicetree/bindings/leds/common.txt - - -Example: - -is31fl3236: led-controller@3c { - compatible =3D "issi,is31fl3236"; - reg =3D <0x3c>; - #address-cells =3D <1>; - #size-cells =3D <0>; - - led@1 { - reg =3D <1>; - label =3D "EB:blue:usr0"; - }; - led@2 { - reg =3D <2>; - label =3D "EB:blue:usr1"; - }; - ... - led@36 { - reg =3D <36>; - label =3D "EB:blue:usr35"; - }; -}; - -For more product information please see the links below: -http://www.issi.com/US/product-analog-fxled-driver.shtml -http://www.si-en.com/product.asp?parentid=3D890 --=20 2.54.0 From nobody Sun May 24 23:28:56 2026 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A4C036404D for ; Wed, 20 May 2026 13:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284047; cv=none; b=uWXWaDXEOI+TobqTeUtzSJfqL3k4ktqxYnGqwAAPpFMRjnaV4WS98Q8LELhADaoCK73I5A0LCzS/ix8lizpjYUuoJDr/3ZK7Z3weabXlEvthW4ngi6gnamEneM7sLdtNYeq98sU3tc3t+jjmuOkHjN2MXIEXltK8s3Q4wOhuoO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284047; c=relaxed/simple; bh=tqRyoaZBs1tvjQrY9z9TFd/uxGf92frpQLPL1VyfqU8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZDjEm0Ue4gSXnrRAY5uCdj/fD7/MIOgHVnXnI5DhPdpuNEwvmqnQp6MUL7VAx7A7SGjLD4tFMB/nv26t8cHKQYzAb/bjW8ZrJXZ3mbnRhWqjgLGBPE36LsGwtgT0yBvfxmX+klQt506ZNyqsDUtrlADMt8ighbeWukKGFnUeYQg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PPo4tzNs; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PPo4tzNs" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-479d85152c9so1823509b6e.2 for ; Wed, 20 May 2026 06:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779284045; x=1779888845; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qC2QIpvU6HmG8jsTK89YMedFfyyJiHf9gc9ctAYYQYk=; b=PPo4tzNsDul5DO7pRhIw1LxQf5+92zFVX//XoPor7PVXP2doiPEZUNUQwxM8hQrueP K8RQiV5XJ+skTuwndn1Qw302UjxGDCwI56HoIVAntgAGpzK1P3mpoI44qo7EAH4IBkMI sGw/u3M7j+luDuO0fGC2Ls6YwUUl7e2pSiQ0tcTJIWXUhFBsZxKIYRrg9th4CwKAk2DT +Vzk7pgGBigZ9rxmYQP4ge45SgbRKSErRZQAgcOI8PxcWPWTzbeI4Fd8LRVHtBc3ZFJ+ ACx2hi018O+xnbgbeCn3Ts21yPUWYYs6jTx2y9kRrT3bUX47ofZa5PYV3tzch7x2TYmB pfxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779284045; x=1779888845; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qC2QIpvU6HmG8jsTK89YMedFfyyJiHf9gc9ctAYYQYk=; b=BiXo2CHfbULzHjlTRmu+YIVLUi94pbbmLxmZHX7Qe4mld7eHkT6ZOMlUXdVOlM609y FYqtGWYmpZ3Pkljsw6IjaeB/88WfJ7VVWyzcLg2iXCWi8IxeQMJOM2cPGpvEPvzFXk0Q YB+W1ycWCBU4jd8rXO/VQUizbrLVRGBe4/vev4FPh9Tuvg0g8ODYHlo/xW9Q1XOuvO4A Rp5DKTzl9FfvUDIASc+eabbzP7S/x1JWEajW3r4GuyHcSM0n1U63v91jeGg1YGiV10ul QB+8hAICtStMo1bRO3GmI8MpoMqElaUQVF9hmWvMpYlgmq43SIvg+Oy4OC4aBjOteE+T gbmA== X-Gm-Message-State: AOJu0YyKIYCgO+Bj04SK9swMQd3+caoqQnhZJOgkvF+hjLuiJGCrk3B+ prdUl9KsM41cLJzDBu+ZDjSD/euxyb4thjf19zsRnxri1MCUUsYL9piOhIic1zHH X-Gm-Gg: Acq92OElfEhbEpMOBp+tGlo04dlDMZlzd1TSqv2jBPfLrsynswBLS8+tWqfrgrGfHGF hkZm2aJC865BCnw413ixujeTA2vNUOWuelOE/7yHtHGE1vfc09SG52ylacl8zTcKmT0Zj4XGjzu GG2ftX7wrmSLxtimVk3Er+qWTwOKXfaaKMNMohRKPOG/8UBDCiSJ7h4jsLqHTXsB5OvGMhFNzCh JRf+Pa1D39QtMcUI5KbbPJYw29Ky815ozdWdELxVIbV1EcSw7GZMt3UfykMgcX1lxImfoPPL4Ov kkBVHRqIipZIiFZm8OgLCqho6W56VmS4p+Yusr1ARfUPNFiEBdSu3DJmZP9wcka0jptMRA/4HuI Fvo3BzSsmdpQy1ygYT/ioZmyJFkNl27dKvkELO4NnTtx6RMLPK3esJ77NxrV1+iVWnH92KHGt1+ LCC+G5MD5jQ7zx6nGo8izdPHJwPigAIhoVBBKevCmw2nNTb5THGw== X-Received: by 2002:a05:6820:20e:b0:67c:1e60:3e90 with SMTP id 006d021491bc7-69c94331f33mr15734192eaf.6.1779284045276; Wed, 20 May 2026 06:34:05 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a52:5b11:a58f:5208:2fa7:bba5]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43a956fa075sm10253951fac.10.2026.05.20.06.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 06:34:05 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan Subject: [PATCH v6 2/6] dt-bindings: leds: issi,is31fl32xx: add support for is31fl3236a Date: Wed, 20 May 2026 21:33:39 +0800 Message-ID: <20260520133343.1423946-3-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520133343.1423946-1-jerrysteve1101@gmail.com> References: <20260520133343.1423946-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add an additional and optional control property for setting the output PWM frequency to 22kHz that exists on is31fl3236a. The default is 3kHz and this option puts the operational frequency outside of the audible range. Co-developed-by: Pawel Zalewski Signed-off-by: Pawel Zalewski Signed-off-by: Jun Yan Reviewed-by: Rob Herring (Arm) --- .../bindings/leds/issi,is31fl32xx.yaml | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml b/= Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml index 81f1e30e493d..5f22d8b77edd 100644 --- a/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml +++ b/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml @@ -21,6 +21,7 @@ description: | https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3236A_DS.pdf https://www.lumissil.com/assets/pdf/core/IS31FL3293_DS.pdf =20 properties: @@ -30,6 +31,7 @@ properties: - issi,is31fl3218 - issi,is31fl3235 - issi,is31fl3236 + - issi,is31fl3236a - issi,is31fl3293 - si-en,sn3216 - si-en,sn3218 @@ -37,6 +39,12 @@ properties: reg: maxItems: 1 =20 + issi,22khz-pwm: + type: boolean + description: + When present, the chip's PWM will operate at ~22kHz as opposed + to ~3kHz to move the operating frequency out of the audible range. + "#address-cells": const: 1 =20 @@ -60,6 +68,22 @@ patternProperties: - reg =20 allOf: + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3216 + - issi,is31fl3218 + - issi,is31fl3235 + - issi,is31fl3236 + - issi,is31fl3293 + - si-en,sn3216 + - si-en,sn3218 + then: + properties: + issi,22khz-pwm: false + - if: properties: compatible: --=20 2.54.0 From nobody Sun May 24 23:28:56 2026 Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 751522D837C for ; Wed, 20 May 2026 13:34:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284052; cv=none; b=Tn1kX8C1qI1E77J/3fA73gJDba+upy9GjNgGTBW43FlhXfOXqliFfPzEY9DSBnmCpBBL362Oxms5akdKs0xwwSK4gcJwtQ1jMBUXTzRn6rk622JZLqn7d55F7MvU1xQx/ubdEySwInP/TlsXJrzSt8Pv7693DqH8ywU/z1szh48= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284052; c=relaxed/simple; bh=K+tQdEa1w/oGtmN7/A0Fdc7GiMO7t+lg3h7hsUuhzkI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NwAwPv8B6VPQinOdTjurPJkxnLbyy3AbuI0PCit6Mh8mycUv9fsVcOO/+AX30etPe6kRgBKHNs4cIb33ILQ6bAkWDG4l4SArHLWKuBhEelabDQ95IfhA5xxPAc6u1x2Sbn7Ooq3t9FsCUIeilfP5WCN7KWrKuJojf1rFj60MQb8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A4n3BHX5; arc=none smtp.client-ip=209.85.160.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A4n3BHX5" Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-43a6faf8d1eso2094191fac.2 for ; Wed, 20 May 2026 06:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779284050; x=1779888850; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XGxu9nJ7AW3a2oAYSUYkb6lYeXmMA2jA36FeW8nwHiA=; b=A4n3BHX5azFO5a6qhD4oJ6jz5i5i4rDE4PoKzhoN1qumHAZDfXTKQDBBIcLVzibGSu FYZJGn1POvAeORJvzG7n9PxDxRxElV43q5I5LzJyYa3vsmiC2iPXO/NheU/WFGcTNt7T 8HU5Lw1vLFcMt9JASyTgkuhIKvkMbOEqtQ5HAfzwVFCCcEojwpqoZDYe5caFhWFTwREr 4/oIRV9v5d+9KLkhyY9d2C22w9bJ1I/kWZJlgplud2kPkjFryHEe3S5t9bpIhBvQ+Sg/ x4PdrTVNsDDVZEjl7BZ7Wz1YpNAjomN3M5aC+kRbDcRWJVbHApdw6pYQWmlM1WPgIFWI ZBfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779284050; x=1779888850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XGxu9nJ7AW3a2oAYSUYkb6lYeXmMA2jA36FeW8nwHiA=; b=GDffO8G9IPZao+gOphp2zlo17+ZZBYoZaHqmN6SAiWPblgszdjg7IJT4SpNJLUkIgc 5+WAOOGqp8YNnJt4MAr+oElGKlwYLS7EmCzoFaiHJQAHEriiygGppQhVLjCTcrw3bV8f vSxKg6O1lk/HuLil7PPefqBi60qZ3XbYpXvmKcJq/nzbrHTImczuNligMfTXZJEI4RPG 6w55O8UqCslduZBp+axYr+B+NphpeW+U2mGLZP4aDLWvw4kTq3HAa+mzGcfgTBRi4bax q9K94KsXvXFHefm4glYQlQyEIqRpWH1j28g4pcIFb+B15zBX7rum6RhEuZs5eGDY9eBj z1lQ== X-Gm-Message-State: AOJu0YxmJXjqIwb4Ip9Bhch2PXP0UkhIXnNY96MevWL7E3sIhstyKQ+p GonGQ04rbbP+P/hltsQ/fRj3NWsRe71Semxlath8Hc439AW4kL+bfn0G64TyMJIM X-Gm-Gg: Acq92OGZa5dBMoJdFgcmWmn0L+b7uNQLffEz5jnbmwq60ii2YXZ9nzz15U4sDIEgG4u XIAkm9CY4c4daideQCfEs9LiypxdUhqm5ZErnGfAD6DG4hcpF2ob0Twv9U0EqNWntNmD4eBbh9e bangA85g2jh/o179Zh8rPDmSzInOzMoRJTz3Qdew2MplgkYRgcxLL8+sdMIUgHuU3LHi1/jLRMs px58cXI88LBmAL8DdgRRjoILmwczbnhVz2/bIaRtM0bJbjfah8CEgxDT82n96OPK7D3id061R24 b9e+Yw0ITbTEHKHnoUG1wp5LuEHbxfsxb6Rr//SuAU7A+zvOLIc9Jxzjw/FF32NIzPGNK/XokPJ g9OBLCg6PfKrKzEHn36AnbCYG3xtWXGE7beQkg+7MwJr4WVZEIEtKvA2NvmMi7ZqI/77R3hzL3F QSkUS88rL8r95tSCIBuFrqYZumo96hB2PDHgQmr7w= X-Received: by 2002:a05:6870:21e8:b0:42c:2042:1652 with SMTP id 586e51a60fabf-43a2dcc3808mr15993070fac.24.1779284050251; Wed, 20 May 2026 06:34:10 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a52:5b11:a58f:5208:2fa7:bba5]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43a956fa075sm10253951fac.10.2026.05.20.06.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 06:34:10 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan Subject: [PATCH v6 3/6] dt-bindings: leds: issi,is31fl32xx: Add powerdown-gpios property Date: Wed, 20 May 2026 21:33:40 +0800 Message-ID: <20260520133343.1423946-4-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520133343.1423946-1-jerrysteve1101@gmail.com> References: <20260520133343.1423946-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IS31FL32XX series features an SDB shutdown pin. Driving it low (active low) places the chip into hardware shutdown mode for power saving, while all register contents are preserved and registers are not reset. Add powerdown-gpios property to describe the GPIO connected to the SDB pin of IS31FL32XX series LED controllers. Signed-off-by: Jun Yan Reviewed-by: Rob Herring (Arm) --- .../devicetree/bindings/leds/issi,is31fl32xx.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml b/= Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml index 5f22d8b77edd..f33c8305e464 100644 --- a/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml +++ b/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml @@ -45,6 +45,15 @@ properties: When present, the chip's PWM will operate at ~22kHz as opposed to ~3kHz to move the operating frequency out of the audible range. =20 + powerdown-gpios: + maxItems: 1 + description: + GPIO connected to the chip's SDB pin. + Driving this GPIO low places the chip into hardware shutdown mode + for power saving. All register contents are preserved and registers + are not reset during shutdown. The chip exits hardware shutdown mode + when the SDB pin is pulled high. + "#address-cells": const: 1 =20 @@ -145,6 +154,7 @@ additionalProperties: false =20 examples: - | + #include #include =20 i2c { @@ -157,6 +167,8 @@ examples: #address-cells =3D <1>; #size-cells =3D <0>; =20 + powerdown-gpios =3D <&gpio0 11 GPIO_ACTIVE_LOW>; + led@1 { reg =3D <1>; color =3D ; --=20 2.54.0 From nobody Sun May 24 23:28:56 2026 Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 625C123394B for ; Wed, 20 May 2026 13:34:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284057; cv=none; b=bfcZUPHYMiGpBxUaKIMoYVRZw6Ss1HbdeatrB7GLPk+PJCbyPYMmS889GFqOO0NuOyElYot+RuPfhMRY5McnxzCMJ1BmZR9PqhIq+6Qq9EVHxeZpLTUORGTK/Fm8CifeEYN8yphMJg1IoTFMacV48nZqCLx65w/VB3j+t8HVRow= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284057; c=relaxed/simple; bh=Ad8yPDRxvnBjx/qpAX9cAhi7tpYDFaAo7GPdeLtpqzg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NlwhC/uJTO7T5LHra6JXg3k/tnQRUWLfP+klJixfbIT8TylRxOBrGPHBljXI4q8I4tVkrSEU5h81AYe9sb0fWNrSAlwBA/kbcJ49FH239bllYhXIF2OLR6PvFFVuA7+UYR9AoxMPmKwI+EAQrMxc5uP67MeCXToWVzRdSIOaMpE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TkJ3nSos; arc=none smtp.client-ip=209.85.161.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TkJ3nSos" Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-68470763896so2539961eaf.1 for ; Wed, 20 May 2026 06:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779284055; x=1779888855; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xnWJZvYMA6qN0Zy8jazbsh97hf1g91RlijsDyV35hD8=; b=TkJ3nSosm6Kv4W+E595AYiW3Swq8Shawm6ZtaWLx2fbcCLEEeAgEjJ37QY+0agXVm8 6BtPn50XvIJN6q7eFyF6J4lTUecUMiGYt2lQ2dhbat1p8S7Ifb02mplQjwwQ9ImICKUS Wi1lpljRkFWcolCOcSZ5ohUO0LKe2LEem+zgLp2hX0Z+NjMwyQOIxSBbKfazqGf8xXxS 9/D4GYih3O7jPj1BzjdPxduCI/XUxp/ubOE7RBLUL2asjvEZYOlb/JK+CycjhfHOhNRT x9zrlNRAqYZk+PvcbQV1JqOP1HbxBJJ71VUCdmP2KiX8+3RsC6YGhdlZXmCiupbjdMbC FbSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779284055; x=1779888855; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xnWJZvYMA6qN0Zy8jazbsh97hf1g91RlijsDyV35hD8=; b=hr3kD8+1klmPm0as1MwW1u7p4J8CeKKayAIFnHxlPzA7eAuvLai7kSzapTodig57/5 9l1CjIFpB20pdiJHXCR9Yg9RoDE2/lK81NvhSCXsRZo1EhDQg0ScgK+I3up/g0LFbl6i 9DFrNNcb/47TTNrfkaJwEWuzO+CPH/5tqUjj4mdbQYzKBaKIWKASN56MbmhCjyZR3kJG 4m1MpuksdbK7dFiEb5K3XPM1BcqzHqyeEMC3o6tQ0hFUJKVHe9GtYPTEER3XTBHs+SK7 CN/iZ7AaG8Bux2uSyO1pth+nfhqgPY/wTuwhSsj/vWR7ydCexFPWXEeARG7WsjnWJk0J uCNw== X-Gm-Message-State: AOJu0YxFd6+sOmaMQE+n34b20qQxDneYtdlh8f2gXfzPdCZyOJDWkXct HLbpRxjsa6KzXOzeGa2Rd91XZk008POZyeRW4UOhxI7EOD+yEKmCbLWchnMsOITC X-Gm-Gg: Acq92OGMfgD0lgonKBUvTZrQVX6BaU+XYJM/SebP2vxGk50Gn6h/i13qjJI6qDwNL7x EdeX/RR8AKlTD2t1BK20MUbAmnYY68qnybT7qqAYfnrJHCOZljdlG/UOSMRzCvaaTzSIHRimL8C lAICjBQummMSawnwBLN24s71Tus9dSw40PaDi4/BTGD51wjwn5f7DTq2d6TVHufpGucrjFL85WD LQeoncWZ97oHJXb66UfR83s2aMXbQL2MVAerl7dOwXGud31rgRvNfWm4IqoiaXrNO/jLfO8/bw+ j3yA/+4wHqozNsCgniKO+zXt1rIFlFRGD2ashnbG5C9QeCQujOl7FunC+Il2bW2VsG1cI/Oyx0b sRBLR5tOxZ6KuLNOSLV8p3Y4vfRfmNT1AH0OEo+jWIaUxabAnCb4/l7RUCwyCSUkVktCsM8yvzC wSj2TpUVETs2qYVauXXnDDJd0/hLFeEDns17VlQm8= X-Received: by 2002:a05:6820:f005:b0:694:9fda:6366 with SMTP id 006d021491bc7-69c9429333emr13992078eaf.6.1779284055178; Wed, 20 May 2026 06:34:15 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a52:5b11:a58f:5208:2fa7:bba5]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43a956fa075sm10253951fac.10.2026.05.20.06.34.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 06:34:14 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan Subject: [PATCH v6 4/6] leds: is31fl32xx: Add powerdown pin for hardware shutdown mode Date: Wed, 20 May 2026 21:33:41 +0800 Message-ID: <20260520133343.1423946-5-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520133343.1423946-1-jerrysteve1101@gmail.com> References: <20260520133343.1423946-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IS31FL32XX series features an SDB shutdown pin. Driving it low (active low) places the chip into hardware shutdown mode for power saving, while all register contents are preserved and registers are not reset. Deassert/assert the pin accordingly during probe() and remove() to manage hardware shutdown mode. Signed-off-by: Jun Yan --- drivers/leds/leds-is31fl32xx.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index fe07acbb103a..b5207ad6ae96 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -10,6 +10,7 @@ */ =20 #include +#include #include #include #include @@ -60,6 +61,7 @@ struct is31fl32xx_led_data { struct is31fl32xx_priv { const struct is31fl32xx_chipdef *cdef; struct i2c_client *client; + struct gpio_desc *powerdown_gpio; unsigned int num_leds; struct is31fl32xx_led_data leds[]; }; @@ -421,6 +423,14 @@ static int is31fl32xx_parse_dt(struct device *dev, const struct is31fl32xx_chipdef *cdef =3D priv->cdef; int ret =3D 0; =20 + /* Driving this GPIO line low takes the chip out of shutdown, + * as it is flagged as GPIO_ACTIVE_LOW in provider (such as the device t= ree). + */ + priv->powerdown_gpio =3D devm_gpiod_get_optional(dev, "powerdown", GPIOD_= OUT_LOW); + if (IS_ERR(priv->powerdown_gpio)) + return dev_err_probe(dev, PTR_ERR(priv->powerdown_gpio), + "Failed to get powerdown gpio\n"); + if ((cdef->output_frequency_setting_reg !=3D IS31FL32XX_REG_NONE) && of_property_read_bool(dev_of_node(dev), "issi,22khz-pwm")) { =20 @@ -609,6 +619,9 @@ static void is31fl32xx_remove(struct i2c_client *client) if (ret) dev_err(&client->dev, "Failed to reset registers on removal (%pe)\n", ERR_PTR(ret)); + + if (priv->powerdown_gpio) + gpiod_set_value(priv->powerdown_gpio, 1); } =20 /* @@ -643,4 +656,4 @@ module_i2c_driver(is31fl32xx_driver); =20 MODULE_AUTHOR("David Rivshin "); MODULE_DESCRIPTION("ISSI IS31FL32xx LED driver"); -MODULE_LICENSE("GPL v2"); +MODULE_LICENSE("GPL v2"); \ No newline at end of file --=20 2.54.0 From nobody Sun May 24 23:28:56 2026 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BF023DB311 for ; Wed, 20 May 2026 13:34:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284062; cv=none; b=OaHkOv0JEMZbFIORxCBokN5RwCk/tE0iGqThviegWSPmGSZi5/ecPTIBr5wl51/aJ9Fcp0amIK4PWm0B33yEZM2x6yI6miUwP/t90FGVWXfic5Qj6P13bpk+jA8CyEUyrRzOmatS3cZ2jM6IpfmORpHv2NVt2gLVgV49MKt65GE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284062; c=relaxed/simple; bh=V20CQxaKCMFh3UO3l2woC5YK6IhwIJ+mPrci8jkaja4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UBFe7Aea34nbD91oxOyijCOrIG/jM4wkiBvBFWGynoTcVU1lKsN4roNVhz8drrP4EwGWVzgh56Dx1T1dF8SzSl1t5CvAtQc21/ni02pO0OD1iJZdfyARIApSsEPddRc8bbSg7ne7KI9lILH/gJJAtjTNEIMGtAerFCrzw+e1e2o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MJG/56Ar; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MJG/56Ar" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-439cae0dc81so1189801fac.1 for ; Wed, 20 May 2026 06:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779284060; x=1779888860; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vk3iqdN+UkfzfR0h+0cGZ9R4uYD5TaU9pbTe8/5a41c=; b=MJG/56Ark1rf9sUPEG2IP6qmDZmbcEN9H6RWc6FpRkemxwD7L6rJ2ePhCCfTBe61rX dWwR2T/+Eg+tCOB7ZhbKP14Bueh3lThBLCdsvSx1NE0BPaiynOdA5YfwjguG7Pgm+gvO syILnX5jgUZKl6zWj23g6xhOa4c+7Uhjgv6yZkMvGP1nc8JxgbdlWClVX0ZWsnkA8JOe gwh5nZZ6SJSUwWk/1V1K0V5OLvaWqGkp9K7jK7KhnRkpOOUAlEVIrV87COsIRp/fPQfJ WPW5sKup2pP8Y+54lhqXhYplvirJekwUoctPxRJs/1UI+N7grczzrF5nCgY1RFsQdtO9 FVCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779284060; x=1779888860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Vk3iqdN+UkfzfR0h+0cGZ9R4uYD5TaU9pbTe8/5a41c=; b=U7buz0NqADqNRPVt3LS9fUaUbdHnRgAYak2GXaTgGNz04mOVW1MePMWvluFIv/UqIw B5WOR0qp+knXpJFjaF5mO30PEzXfG28iQrMmORsHnnXJYqwg31qIHHOVsG+HqXjCGVkm kEV/rD57nw35eZ9SUkZYaztfXC9qlQlNxIIVlJZgB/7YARWy5hVEkRST2zL41ZnLIq6m 6dhphW+L8E2KlL9SKLyZnPmgEIS/DPGw7cwgjDz2KMpmHfQVsatRB29jlodtEES936PT 67tAIetX69ZrAo0O5MvmrJjQJkfy9FZIfseppH63ionEMuXrab9pge5QWN4zgEWJEGhN Lkjw== X-Gm-Message-State: AOJu0Yy1OB7MvbRmUHvWWgpNDLJLXqUr2FpEPvTVqLOWFtadN08o60W5 SFhi/5PRqNgolRhsR/c9cUQtfv0jToSyN1S+9G+aRGc5+SD2wSpcyfvDfXTCHO9o X-Gm-Gg: Acq92OHekJxUHMRdndh7EFxGwPFvu5tv4pIhqjlg4SI9+AZ/o0QyfJRmt4WwGSrcD2y igh0YJa8s9gnusA4qYHRNC+D/S08Snv2bEgsQlViXWkLeEueowDxHmo2qCgimhSpU7IHdDJb0xy B+NAaB5Ea7Nsp43/1dVYiK8b13LkoGvIVop3HizXC4X+e6AqZFp6JS0//YRqo8CKIJkwljb35R6 b2unrLoKQk9gdW2/cknJ2ntBHB3yc0yQcuSBDA4QKLWE8YXwglspRUOgYs70ydjHWAKkJfqMwkf 8131qvuYW6NnDiXRqvfMkL7SWwGEczShZtAUI9RRs6uejdr0cU/pLvW1gtLin0hhIgSghfHEuk7 E1CGOnvZN/TM9JlqsAXvC1uV559bvEuTEVS1T0rqXBoOJZeYq1LJ/H0fjNxPwzS4m3VZIo9IaEg 0kKtC6FAYqSK8dyHcfJ0jVACLcRh8ulnAghpGxJcQ= X-Received: by 2002:a05:6870:e86:b0:430:b7d:f248 with SMTP id 586e51a60fabf-43a2dd7c363mr15635339fac.24.1779284059756; Wed, 20 May 2026 06:34:19 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a52:5b11:a58f:5208:2fa7:bba5]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43a956fa075sm10253951fac.10.2026.05.20.06.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 06:34:19 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan Subject: [PATCH v6 5/6] leds: is31fl32xx: Fix missing brightness_steps for is31fl3236 Date: Wed, 20 May 2026 21:33:42 +0800 Message-ID: <20260520133343.1423946-6-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520133343.1423946-1-jerrysteve1101@gmail.com> References: <20260520133343.1423946-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add missing brightness_steps for is31fl3236 to fix brightness control. Fixes: a18983b95a61 ("leds: is31f132xx: Add support for is31fl3293") Signed-off-by: Jun Yan --- drivers/leds/leds-is31fl32xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index b5207ad6ae96..5678c2273bbd 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -491,6 +491,7 @@ static const struct is31fl32xx_chipdef is31fl3236_cdef = =3D { .pwm_register_base =3D 0x01, .led_control_register_base =3D 0x26, .enable_bits_per_led_control_register =3D 1, + .brightness_steps =3D 256, }; =20 static const struct is31fl32xx_chipdef is31fl3236a_cdef =3D { --=20 2.54.0 From nobody Sun May 24 23:28:56 2026 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 298F52D837C for ; Wed, 20 May 2026 13:34:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284067; cv=none; b=CSJ/KWgjXahfn/7BKFBcoUyAIS1c466iNbjidhqT0Tacya+Y6dtyAC+bSgV29g6SNhU5N8JWpZRBjRu74lCDdf8ATvXL0BrU52XJWCp3JyOquah9GeyV5XerkKlEm7LQZ6oVMZNNBl1NUJ6TdFtKmZpGIfk/lS1fs3IPu7uJCNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284067; c=relaxed/simple; bh=33+ik9qldfzElfwEbUFdDRSw3s77jyByMHu+q2J05gI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DcXL/kPrn1tfhGtXWVf6DrHWiBRXkHG0Ra59sASY1OmkLDHGdt3cESqkaAaJJVMlXV4bgGJwNKsDNad7rp7kFucHMbqQUo8D0SsZYDwB8Uz7h84gNQTdoJX44hj43JRGhQhdCDTDvdRLcjNmeRdFIP07nxhqDZYLKfIqrgy2mm4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VGQkL1Tj; arc=none smtp.client-ip=209.85.167.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VGQkL1Tj" Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-479d85152c9so1823706b6e.2 for ; Wed, 20 May 2026 06:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779284065; x=1779888865; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vDbe/ecn+aILq8lwi+Q4VCno4aximoHPHL06TCJTUbc=; b=VGQkL1TjfYqFkDOBcz9/aqaw3XxRpnBGYZLrhrtR0RcVLgAhX76mrx9dJAWhh90XhT d8yp+vCO+o4U66bc18nYe1u378LR+s6cE1kEOvifD10kI+S3nXr/0/crP/FszsJ9nSrQ YdaW29FY1gIcEej5szMCuFiexjLR+udmIQlBBdZRW1lNuzYkjpjf1kf3pR2QOloUChHv yMTT8fphMroh4Sj5IAkOI+KZx++4dFssSNImWPxCXjl1babT7C4HUqrzWNZE0MRgeZ7a lCGiKseoPWu8CdVcUh3hPF5F/DPw4Bw0YOD5bFcwNCiZ5E5mHmusySyQ9OkvQWrwomjT thMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779284065; x=1779888865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vDbe/ecn+aILq8lwi+Q4VCno4aximoHPHL06TCJTUbc=; b=GXqc51jpXapYfb64ohuX/0OEdLRe11M0oBhh9mNCGNeXhvBT4ETe323Cz+Ghi5XOd/ i5UoY5Tbv/1vHg8mvhjSjHAdMlSUCjyOHbI6mLlWPi914cHmOvhCaDsj+ty088Ixxyzl X3uC9XrZoP0VKVKeestzJbXnHBp+9PE+z6ssE3VD+FQYIvB+CU6VrOpBYGb3MbdNuFXw V+gHy3Hbhs83jaRIN0nwRrPA6Gs3kTGX9YjFggiyN+RhGC0MOMfQ3fRTPhozFea52q0q 0vc1rS9ZJb31I1CS8nOm7Y5yPHV7f6QVsGBxhRFdIxqAd5LK2gJzQObvrT0Nc7S/jxCB 57PA== X-Gm-Message-State: AOJu0YyGfJt2Kv+tmkCfc9IweN20nJEZpy1RwfSgISNwPwRsp0VLwynV G3Mee6yJ8NgRYY3o9DhudNWdN4+++OQCQtQ+roRAPsEIbSUdOaPhsOqP6VZXkTNa X-Gm-Gg: Acq92OG5NjaESobjSYF83FzPIC0k5/e+4RPRhe9boiYhJDteNMnPraG65jVy7e/vzUy V2UxZnVq1dmDSs2nIW/W/v9W+TeiuZB0mO9aBlE4BK50ChEIAlf46pKf7lEZ7UT3ttalqUO4Hq5 n7zNKaFIi2K73iqoEW9vN9rQ/RLWRd21n8KI4OP6WwgWh054SwC7eZyNYfRJUia2ltEhJ5aajO3 7hV/UFzhHSFWRJUlwdwpWG6/Q/mYX6jsV1781CQIV0IJZ9HT71etA6vCqHBfZWB4eELyzPBszu1 KtxiieTppGj32bb4sqWBJOftFWzFaB9fvgsdxX5QTIBqk3vs6BJxs3sV84vREv7e9LAtcpC/9NF q8q4AtgDygIWrGKdTu6p73wCWxmIbgbx4mOTj2OCenhf7DWWez+hbZLAH3sqh5pvEpjGgcaQKox SehbvybV+hQFz8Eju023yLwpnXjXFiWa6iZQ31Grc= X-Received: by 2002:a05:6808:3986:b0:482:dae4:23cd with SMTP id 5614622812f47-482e564d54cmr16908898b6e.10.1779284065074; Wed, 20 May 2026 06:34:25 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a52:5b11:a58f:5208:2fa7:bba5]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43a956fa075sm10253951fac.10.2026.05.20.06.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 06:34:24 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan Subject: [PATCH v6 6/6] leds: is31fl32xx: Move pwm frequency setting to init_regs() Date: Wed, 20 May 2026 21:33:43 +0800 Message-ID: <20260520133343.1423946-7-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520133343.1423946-1-jerrysteve1101@gmail.com> References: <20260520133343.1423946-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit a18983b95a61 ("leds: is31fl32xx: Add support for is31fl3293") swapped the order of is31fl32xx_parse_dt() and is31fl32xx_init_regs(). This causes the PWM frequency configuration programmed in is31fl32xx_parse_dt() to be overwritten by the register reset operation performed in is31fl32xx_init_regs(). Move the PWM frequency setting logic from is31fl32xx_parse_dt() to is31fl32xx_init_regs() and separates device tree parsing from hardware initialization. Fixes: a18983b95a61 ("leds: is31f132xx: Add support for is31fl3293") Signed-off-by: Jun Yan --- drivers/leds/leds-is31fl32xx.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index 5678c2273bbd..3e86e414c532 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -63,6 +63,7 @@ struct is31fl32xx_priv { struct i2c_client *client; struct gpio_desc *powerdown_gpio; unsigned int num_leds; + bool pwm_22khz; struct is31fl32xx_led_data leds[]; }; =20 @@ -346,6 +347,14 @@ static int is31fl32xx_init_regs(struct is31fl32xx_priv= *priv) if (ret) return ret; =20 + if ((cdef->output_frequency_setting_reg !=3D IS31FL32XX_REG_NONE) && + priv->pwm_22khz) { + ret =3D is31fl32xx_write(priv, cdef->output_frequency_setting_reg, + IS31FL32XX_PWM_FREQUENCY_22KHZ); + if (ret) + return ret; + } + /* * Set enable bit for all channels. * We will control state with PWM registers alone. @@ -420,7 +429,6 @@ static struct is31fl32xx_led_data *is31fl32xx_find_led_= data( static int is31fl32xx_parse_dt(struct device *dev, struct is31fl32xx_priv *priv) { - const struct is31fl32xx_chipdef *cdef =3D priv->cdef; int ret =3D 0; =20 /* Driving this GPIO line low takes the chip out of shutdown, @@ -431,17 +439,7 @@ static int is31fl32xx_parse_dt(struct device *dev, return dev_err_probe(dev, PTR_ERR(priv->powerdown_gpio), "Failed to get powerdown gpio\n"); =20 - if ((cdef->output_frequency_setting_reg !=3D IS31FL32XX_REG_NONE) && - of_property_read_bool(dev_of_node(dev), "issi,22khz-pwm")) { - - ret =3D is31fl32xx_write(priv, cdef->output_frequency_setting_reg, - IS31FL32XX_PWM_FREQUENCY_22KHZ); - - if (ret) { - dev_err(dev, "Failed to write output PWM frequency register\n"); - return ret; - } - } + priv->pwm_22khz =3D of_property_read_bool(dev_of_node(dev), "issi,22khz-p= wm"); =20 for_each_available_child_of_node_scoped(dev_of_node(dev), child) { struct led_init_data init_data =3D {}; --=20 2.54.0