[PATCH v2] memory: omap-gpmc: Silence W=1 kerneldoc warnings

Krzysztof Kozlowski posted 1 patch 4 days, 11 hours ago
drivers/memory/omap-gpmc.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
[PATCH v2] memory: omap-gpmc: Silence W=1 kerneldoc warnings
Posted by Krzysztof Kozlowski 4 days, 11 hours ago
Recent W=1 builds print kerneldoc warnings, even though a correct
kerneldoc is there:

  Warning: drivers/memory/omap-gpmc.c:441 Excess function parameter 'cs' description in 'get_gpmc_timing_reg'

Drop additional inline comments for arguments to fix that.  They are
anyway not that useful.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Changes in v2:
1. Drop clang/LLVM references
---
 drivers/memory/omap-gpmc.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index d9e13c1f9b13..958d2b0ea54a 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -432,13 +432,9 @@ static unsigned int gpmc_clk_ticks_to_ns(unsigned int ticks, int cs,
  *
  */
 static int get_gpmc_timing_reg(
-	/* timing specifiers */
 	int cs, int reg, int st_bit, int end_bit, int max,
 	const char *name, const enum gpmc_clk_domain cd,
-	/* value transform */
-	int shift,
-	/* format specifiers */
-	bool raw, bool noval)
+	int shift, bool raw, bool noval)
 {
 	u32 l;
 	int nr_bits;
-- 
2.53.0
Re: [PATCH v2] memory: omap-gpmc: Silence W=1 kerneldoc warnings
Posted by Krzysztof Kozlowski 3 hours ago
On Wed, 20 May 2026 13:16:31 +0200, Krzysztof Kozlowski wrote:
> Recent W=1 builds print kerneldoc warnings, even though a correct
> kerneldoc is there:
> 
>   Warning: drivers/memory/omap-gpmc.c:441 Excess function parameter 'cs' description in 'get_gpmc_timing_reg'
> 
> Drop additional inline comments for arguments to fix that.  They are
> anyway not that useful.
> 
> [...]

Applied, thanks!

[1/1] memory: omap-gpmc: Silence W=1 kerneldoc warnings
      https://git.kernel.org/krzk/linux-mem-ctrl/c/83c1d176fbac3c3ffbeaddbc37e11e083f19cebc

Best regards,
-- 
Krzysztof Kozlowski <krzk@kernel.org>