From nobody Mon May 25 00:08:05 2026 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A68563DA5B4 for ; Wed, 20 May 2026 11:05:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779275120; cv=none; b=NUdkd5r7IEWFM7qadsvR6CR8my2dusmG0prYFZza35kb8M0D6V50exzfGLjJoBx4YdjG8yPiFnFl7yOeektk7UUj2o9V4yrBVx3hC9waIVXoKl6kUAmgpjtblQGvDb8BL3y6rzqCt7absOE3Dd/ZHJEV+n4kdkAdVZ+Yq4Un0eE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779275120; c=relaxed/simple; bh=mDSDYiGBy8xYz5JmDiA1s6oWYSl6J/LaLj9wYdnQ3MA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=IOJYUXgV9GMqFaeCkHRUuwXegliuhn/nknwwWL2iUJPQa6KmmsKSQNS7yHK8VEYmLNlEFPb3fRwvxlZjR6Es39xnlvlJmHguUm2fuHH1AGvNoqKif1TmGboeYJ76ago1PkVJq+YAa5UEe3A8xImdMOV02CvYdQ6yG1kkLNNNX/A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UPlfSe96; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UPlfSe96" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5a41a9a97d3so394883e87.1 for ; Wed, 20 May 2026 04:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779275117; x=1779879917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QPGbqHEiYmUBrYYcp6+N4mVxHnjR3wjfgDM8RhieGjQ=; b=UPlfSe96qIDShFmFg8AMWyuXUznSm47HDb0QfaGQ2zE1ZD2QGAcrxlerpgPLdh0/Wu rlVaaW6C8pn6pdJJFnU+GMnCTLWl+puokEjP7gLW20YcY1iPFt77UE0pTugfS+6zFYYs dZJnjeVnA9XMMVbyg5sA8uIzbk3Jf3jp2VMaavxLjJjd0yCUmFqxc2KmMD7FQnLq8h50 QsiC728RyO6nyZhIgUUmZFqVkrwhpsVoxfL91SZ6qnJ2c0MEKEMzgtkXkNtUav3D4xOH weA1k4Z/gvqY8XO3UH/wfPbHQOueu/n3IT55Rvvm1dtAz3VvrwneuQLbXkBtZiROD80W NnBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779275117; x=1779879917; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QPGbqHEiYmUBrYYcp6+N4mVxHnjR3wjfgDM8RhieGjQ=; b=Qb4MiE5Ht3fA2Bbl50pEE7u1uGLkWVP5Xc7j00t149zA42wubF52Cbk2MngetYNzGl dfLLm8U8yi9hIr/FrCI1Ei2AduBF3KlyAxYziZwNuBJ3aIt4ul0rcQkyhDYHoV7ISvl+ TMEumZVy6au5ELCQ2PgGazXhcSh0egiI540ocSGo8NoueB9GAUjQyK/Zy9lQZfCNxfTv MiuPJOcrMKaLzvHPgEjJk78Y8moFNLP3MJEDjkA5Ue41kOn1Qhk+PALSIxlfbZlxFZ6f g1cmbzdWWRbCC5WGQVj/xM2XMmaMzuogaoZNJTSv62MPVcbiBZO1AboUGgQ4Y/1PpM+C yA/Q== X-Forwarded-Encrypted: i=1; AFNElJ95KgPrSmTO6BiGYi9OiTjy+xKcSYAZSpVJoiPYDsjKI3QUqOYNM1Ct8ICoM4iwOWwevenxKE26JHWY95k=@vger.kernel.org X-Gm-Message-State: AOJu0YxDLPA0hKMPQpZz9PCaRRM24PPPsgSok6f/IV8pkcYi7qQKcv8B y9tV8Spk68GguE09p7KQTF85wQ3EiMXjpw9y16xrSWqrK4IPCz4qaUDN X-Gm-Gg: Acq92OF6wQTVlSv3NeJi4aRRuj37VNSNydcLK+So3w8GDCxS91UEDLsR1m212Dw5MuJ poCMCW7F4bQH3ZEnbN7b+pKm3xdpHNhETYjr5vkblJirwrWcACcOU1KmbmBZ4X3dtENPTacbHmB V4intUFhgJO8SjcNSVLxMpjL39JmGSCliI2tvUpmQRA+rpj0IVy0sS0ie87q7RpqGgZvxjTfWx7 OJB0q2x1jNsA7gGSxRxf6NiXJtDk1VxwG6tHQvI2/FCadBr2f29gtdFBJvCVE7ggRUsJQOMU+BV hNz+Qv6Qa6V2IEwl9fsIJaa2+Frj2w+y5o833Kg8wmlRMQFa7AiJrzQT23gwYbHiW3tNhENOCKb 5jIvT8BR1jd2GpVNrn8/pOdK0ev0BHXGgr11SwJKm5/RgSL52po+NcYy6KT0HaGZLgkOEpTX0Na n14JIsMmq6OJl5QBVfec90aeSeJhz1BtR2NkUCayH5j/8KSqZJZwEHzbGXdw== X-Received: by 2002:a05:6512:33c5:b0:5a8:7317:540b with SMTP id 2adb3069b0e04-5aa0e74eb18mr3046668e87.7.1779275116754; Wed, 20 May 2026 04:05:16 -0700 (PDT) Received: from localhost.localdomain ([213.230.116.218]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a9164cd939sm4910827e87.70.2026.05.20.04.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 04:05:16 -0700 (PDT) From: Stepan Ionichev To: brgl@bgdev.pl Cc: linus.walleij@linaro.org, andy@kernel.org, hcazarim@yahoo.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, sozdayvek@gmail.com Subject: [PATCH] gpio: pca953x: propagate regulator_enable() error from resume Date: Wed, 20 May 2026 16:05:04 +0500 Message-Id: <20260520110504.13969-1-sozdayvek@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pca953x_resume() returns 0 when regulator_enable() fails, dropping the real error code and masking the failure as a successful resume. The caller then proceeds as if the chip is powered, while the regulator is in fact disabled. Return ret so PM core sees the actual failure. Signed-off-by: Stepan Ionichev --- drivers/gpio/gpio-pca953x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 52e96cc5f..b9c905a0f 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -1411,7 +1411,7 @@ static int pca953x_resume(struct device *dev) ret =3D regulator_enable(chip->regulator); if (ret) { dev_err(dev, "Failed to enable regulator: %d\n", ret); - return 0; + return ret; } } =20 --=20 2.43.0