[PATCH] ntfs: Validate error in ntfs_lookup()

Hongling Zeng posted 1 patch 4 days, 12 hours ago
There is a newer version of this series
fs/ntfs/namei.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[PATCH] ntfs: Validate error in ntfs_lookup()
Posted by Hongling Zeng 4 days, 12 hours ago
Check that MREF_ERR returns non-zero before using as error pointer.
This prevents potential ERR_PTR(0) when error code is zero

Fixes: af0db57d4293 ("ntfs: update inode operations")
Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
---
 fs/ntfs/namei.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/ntfs/namei.c b/fs/ntfs/namei.c
index 10894de519c3..b72839575fa8 100644
--- a/fs/ntfs/namei.c
+++ b/fs/ntfs/namei.c
@@ -236,7 +236,9 @@ static struct dentry *ntfs_lookup(struct inode *dir_ino, struct dentry *dent,
 	}
 	ntfs_error(vol->sb, "ntfs_lookup_ino_by_name() failed with error code %i.",
 			-MREF_ERR(mref));
-	return ERR_PTR(MREF_ERR(mref));
+	if (MREF_ERR(mref))
+		return ERR_PTR(MREF_ERR(mref));
+	return NULL;
 handle_name:
 	{
 		struct mft_record *m;
-- 
2.25.1