From nobody Mon May 25 00:08:04 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DA0133D6DD for ; Wed, 20 May 2026 10:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779272169; cv=none; b=oZOcFkVsDpYSGX1R18JX7Zlz6uKA6HJLFM74tO5i2BnK1yQsA8WqdkZeDq7M9urxSm16eEhKcMqHtrXJKLa4QBSFA4B6fOKZogMEIntRbAgFvO6Uh9km5mOKAu2IZDcgioWvXySQG6VlfMSsJn+P29xjaoQdMl8Mbjuh/RgyS+E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779272169; c=relaxed/simple; bh=yOwq5aoSFnjnN3Up3p5A2+W0ZtUmWYLdUCmFe7WlAws=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=REjuu6Zx72P4jNc8E+jPL0Mo4QcoQ8iUtNJOkze5oBUeDnxY1LYVaUjEAtliAZmWWAlJA7aTHRuK9S1+Tfge38cnEtYPwUdYWEhvSwMhFS8jcEwgMx2XZlxhNBZinWHRGSC5O1A7bqVIC+++yWED0tpNhqVAuLi5lm/nA5Ajyx8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BY2Ovabh; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BY2Ovabh" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-36900945df5so2293867a91.0 for ; Wed, 20 May 2026 03:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779272163; x=1779876963; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lDEM2k2NQQ7Lfsm22fLEr6Z5c9noFsO+7k3QetROgeA=; b=BY2OvabhVu5sA+7PAbozBdcAdj8GwU2Cgu8iJZe/iSdzN8U41SlCey3qcA9EN42PS3 uQ0nZ/jp3OXxzBnn2MsW9zKCfHmzLtjfnVZvG5wkjqLC0K+RR7nJJgmggkEztasucAQB kIQu43ZU72IktCJlzz1fKsp6VbU82/73XlbxwR3j0Nx9mACex7q1lhWovv6nvaw+dIyK CLdfe3T+JeszkLIjw6+jlmeTZ9T9C/YDqL0LOZ4yEwJGe8RoPDHSQnaU7HEq3U3RR0QN MB74cHcVBiC5THGtVzmiJsFqMqMXdq5lA3m8nrdXqSxhaPEQf3wxVgF2HXxUP6HLMkpk zt6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779272163; x=1779876963; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lDEM2k2NQQ7Lfsm22fLEr6Z5c9noFsO+7k3QetROgeA=; b=CAez1UN6IGQW0S0SwzUZxuN3zMAPLhLU3FtE455LtHNHSN0usycFmOlet3kSvX4ab3 AV7883CnJv33/fBqD7x+1zWpOdBmB7a//QOajO5V+DYK5aleE4iQIXM8YBTOLvxWJ/po ah9Qc+3wE3L4uYTNuZDSO/F4IwuoA+LQjo+5Lt8QLRPcwXyES9ZcOLiAqbZdGDJxOBC5 SzmKcRhL1awRJzi88wJjXnQMCnOJDqEFfv/eLLJThqSpg50XsPZzY4k2pOYZp6Q3Pn5d wPPgHrjFK+yANjdHLZvopuD1JYnSAYL+gJJ3TA3GB7vJ7n/pvWpNFlk1sZvrvOLvfI4S f2iQ== X-Forwarded-Encrypted: i=1; AFNElJ/d7A9b9+YtBMj5Ftvw4fxqa+Tq5IDHaok2sY7BCml+coDn3uNRf5OYTNMSipe2NpcEpOHIMbYJUKsdRX4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl6lnZaBHNMwFCz74GtDtLD6Ovt2KOrtEV5AS2DQpSw+WIFlDN aRnrROSjl8jLsZyzTzVom8UjQFuIO2vq9BE6ysiceQY59SbS3pMWiES8 X-Gm-Gg: Acq92OH3nvZtOITgGSgOJ3Wm9U8DQlNAV35P0QiLiW3LdcwyEN3C4mMgGIsLTnFKY8Q R11iRCIISVjGLGYvQFLBCf/gGnfXEBgoim6lKzUoEppStWoTj1/EXRJAuKNNLw/9klha1HM3qvA /1ZoMAF//t2DmBb2Y7Vy84eplvxi71lgBDUdAzoAuv7ZIAr1S0DLJcc4AdhdqDd+qSeMcX8Pjhe /MCQHxqvA9RY/LsQ0g+w4ilxJV3QISHhguGqWIB7yXTMoAW7LNfS+CRThKFaUyGdpfZVmNlzklf Zj+dHHiR1O/aAKKpHFxdzPBZ2gzf9svQ5f8U0Pv5JziTRp5SbXGkmB9yT/BbDXezYrF21aKBXeF 8ew0JmDoNn3j+foegehQUcSdnMD34eGSVi6NpmMfIOodgObq5VWfklTcIyXnRW5ojuTxPWNqyI1 3xNMSbwpjfQBo9fMLbZenz/RQ7VCFx71rzaxFJeL/tu6XzFQR1TiJSKkQdiH8= X-Received: by 2002:a17:90b:4b8c:b0:368:6159:980c with SMTP id 98e67ed59e1d1-36951b84f49mr23228425a91.20.1779272163166; Wed, 20 May 2026 03:16:03 -0700 (PDT) Received: from carrot.devel.local (madb688455.ap.nuro.jp. [219.104.132.85]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36959fa9d84sm6453027a91.8.2026.05.20.03.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 03:16:02 -0700 (PDT) From: Ryusuke Konishi To: Viacheslav Dubeyko Cc: linux-nilfs , LKML , Hongling Zeng Subject: [PATCH] nilfs2: Fix return in nilfs_mkdir Date: Wed, 20 May 2026 19:15:47 +0900 Message-ID: <20260520101600.19734-1-konishi.ryusuke@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Hongling Zeng Return NULL instead of passing zero to ERR_PTR. Fixes smatch warning: - fs/nilfs2/namei.c:261 nilfs_mkdir() warn: passing zero to 'ERR_PTR' Fixes: 88d5baf69082 ("Change inode_operations.mkdir to return struct dentry= *") Signed-off-by: Hongling Zeng Signed-off-by: Ryusuke Konishi --- Hi Viacheslav, Please add this to the queue for the next cycle. This is one of the fixes by Hongling Zeng, a patch that individually corrects a semantic issue (which is harmless in execution) related to the use of the ERR_PTR macro that arose from a recent VFS change. Thanks, Ryusuke Konishi fs/nilfs2/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c index 40ac679ec56e..e2fe95de3d71 100644 --- a/fs/nilfs2/namei.c +++ b/fs/nilfs2/namei.c @@ -258,7 +258,7 @@ static struct dentry *nilfs_mkdir(struct mnt_idmap *idm= ap, struct inode *dir, else nilfs_transaction_abort(dir->i_sb); =20 - return ERR_PTR(err); + return err ? ERR_PTR(err) : NULL; =20 out_fail: drop_nlink(inode); --=20 2.43.0