From nobody Mon May 25 00:08:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 064F8288C2F; Wed, 20 May 2026 07:51:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779263492; cv=none; b=tXOTPFgRIaCgMZ3OdBG/8dZmZ6R1JDtdXCQ/6S2tqvaBzZgv8bQIaX2wobcASwzhjwL+Ane4ITv8aAT+pkmFnjmanuQkC8JFpzNm7tLaMNA4aM+nJSVmTOEHkk+4nYyJaspnCcdXoPbIWKleQ6J8CnP+QejJQmFBShu82/jdEw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779263492; c=relaxed/simple; bh=QqZjQUMtvphhIdozodgs3IDhzTkoY3ES0FICL4++UAM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=U+VAuRRd0kGy2lSAMnq12f3wWPZAS1Dcrf2R2IzxXVW4tANT5jld1C0/8BECMJK/qoRCUUHin1yvW53ursSWV6rmEVHjvQoJDE0fKqlKhc6dD4IsEuyGGmDQl8DZY6pPG23JiGVS8TuNkhP8nKirP1zhJ4YgbHYisA+fzFutGNM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bYbvvDc3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bYbvvDc3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D0F11F000E9; Wed, 20 May 2026 07:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779263490; bh=gjQmv/w5eq+BKgE/daZQXNBNMdpJtU+6pPBR+7Zmt+A=; h=From:To:Cc:Subject:Date; b=bYbvvDc364xWid1DdcNn0uMDr/d84X79C7yNQ4yvnaQb2l5d5kf10lIfR7gEgdEBk MMK4tGkUNkzhqR0jsZbpgafiNzIB4bcRUVNeE0WXliJmgfItBGn2okHf2Q3Dy/PpO4 TwA/othEPlAkgdbW006ZWFuSoSXn3+ZemgMRzNnPbOfozqyii4JXwe4VyMcmHUbnfq RAqyA/S+VY68UH0BqqTLGgCR5DbX/BkqMK/mUuAn8MQn1rLmL34AzTDJ/+lwbJ8DPq X28/oL1cbE5J9SqbUCvUFnwlkXNopB5dJo4LqRjiIKKDGWrTmok3BgxeOfYoDqnkj5 8vklzIFyOSyGQ== From: Arnd Bergmann To: Linus Walleij , Frank Li , Conor Dooley Cc: Arnd Bergmann , Andy Shevchenko , Dan Carpenter , AKASHI Takahiro , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: avoid duplicate function definitions Date: Wed, 20 May 2026 09:51:14 +0200 Message-Id: <20260520075125.1514312-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The pinctrl_generic_to_map() and pinctrl_generic_pins_function_dt_node_to_m= ap() functions are built whenever CONFIG_GENERIC_PINCTRL is enabled, including configurations without CONFIG_OF. When CONFIG_OF is disabled, the dummy definitions are also present in the h= eader, which causes the build to fail: drivers/pinctrl/pinctrl-generic.c:20:5: error: conflicting types for 'pinct= rl_generic_to_map'; have 'int(struct pinctrl_dev *, struct device_node *, s= truct device_node *, struct pinctrl_map **, unsigned int *, unsigned int *,= const char **, unsigned int, const char **, unsigned int *, unsigned int)' 20 | int pinctrl_generic_to_map(struct pinctrl_dev *pctldev, struct devi= ce_node *parent, | ^~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-generic.c:16: drivers/pinctrl/pinconf.h:193:1: note: previous definition of 'pinctrl_gene= ric_to_map' with type 'int(struct pinctrl_dev *, struct device_node *, stru= ct device_node *, struct pinctrl_map **, unsigned int *, unsigned int *, co= nst char **, unsigned int, const char **, unsigned int *, void *)' 193 | pinctrl_generic_to_map(struct pinctrl_dev *pctldev, struct device_n= ode *parent, | ^~~~~~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-generic.c:130:5: error: redefinition of 'pinctrl_ge= neric_pins_function_dt_node_to_map' 130 | int pinctrl_generic_pins_function_dt_node_to_map(struct pinctrl_dev= *pctldev, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinconf.h:184:1: note: previous definition of 'pinctrl_gene= ric_pins_function_dt_node_to_map' with type 'int(struct pinctrl_dev *, stru= ct device_node *, struct pinctrl_map **, unsigned int *)' 184 | pinctrl_generic_pins_function_dt_node_to_map(struct pinctrl_dev *pc= tldev, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Removing either set of definitions is sufficient to avoid the problem. Remove the copy from the header for simplicity. Fixes: aaaf31be0426 ("pinctrl: extract pinctrl_generic_to_map() from pinctr= l_generic_pins_function_dt_node_to_map()") Fixes: 43722575e5cd ("pinctrl: add generic functions + pins mapper") Signed-off-by: Arnd Bergmann Acked-by: Conor Dooley --- drivers/pinctrl/pinconf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinconf.h b/drivers/pinctrl/pinconf.h index fa8fb0d290d1..60c0e9ac0464 100644 --- a/drivers/pinctrl/pinconf.h +++ b/drivers/pinctrl/pinconf.h @@ -167,7 +167,7 @@ pinconf_generic_parse_dt_pinmux(struct device_node *np,= struct device *dev, } #endif =20 -#if defined(CONFIG_GENERIC_PINCTRL) && defined (CONFIG_OF) +#if defined(CONFIG_GENERIC_PINCTRL) int pinctrl_generic_pins_function_dt_node_to_map(struct pinctrl_dev *pctld= ev, struct device_node *np, struct pinctrl_map **maps, --=20 2.39.5