From nobody Mon May 25 01:16:41 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4570364EAF for ; Wed, 20 May 2026 06:51:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779259862; cv=none; b=rs9JCDklyzF4xrPbKS9DVyQht64IUX0WkJ6QHcXVDZQJgjW5hU5/cbaauhUZK5IhLIeBCswloOL4i5Nm8o0RXRd6cqgvIAZL7O9qJ0IWhwV4t0vQL9V6v4hqz7c7oPTPLJjV2/6r9clGqHZEW/Po1zpVU1wLCSgkzsAJl8A045Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779259862; c=relaxed/simple; bh=piLYdD9sfLzUWIAhuoTrNVSPwdPYc9JpO7ZO/zYiMIk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=md1xpTq5xFFOV3Jh+rQZAKFr0AQ1GrQdKvNf8Gl3woYBYWQ6mCd0jjyLGFgnE/o5fNESyTZVLd/AQY6VyrgoIz2unfr5oDFsJCE3gxtO0C1b7Lgb2wy9fRxeCHjjQcuy93aVvghv7guZXPPJuOTnsdKDwvPQ/LR4lgUykO/apOo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FEb0ib7l; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HDaubYdD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FEb0ib7l"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HDaubYdD" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64JMT8vx2143879 for ; Wed, 20 May 2026 06:51:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=hmDUYWP981+ QEsAdC4yYWGwxCIUyaTrbIpAPDTEiCGc=; b=FEb0ib7lWqn0d0YTeFBkTMSpWgn oXWjr/nDAodLynC3DNsPwDf+m4gMm8L0aweTMZcrqRsHhQvUPdES38xuy4vwb9Y/ +cJRF6oLOcwWyIH1cANqHz2zxBjXrxKPtHxcQ+m7VFnN5Lkuhprqzjy5reUbB33Q 26BXA+vUKRVSWlk3zNYRkFQgRzCcm2aOJX/oU7/OSXgb48ukHrSXVrEZrxu0MEWG MPQbJkyoRNeN5YPQZ+imNpEVq7KGBbRaSojrHCDVPsTlBsSg27z4RiPYparXdBHI hcQImL9gl1bEz9S1IQcB0wIAQ6ahsy1B0p6fhmLmn17+tOQp1FH0KIBNFfA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8t3tkdah-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 06:50:59 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ba054e0304so42744575ad.0 for ; Tue, 19 May 2026 23:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779259858; x=1779864658; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hmDUYWP981+QEsAdC4yYWGwxCIUyaTrbIpAPDTEiCGc=; b=HDaubYdDGFtFtjVTrxtQLTXKKhfAO9yZzNKxF1eC6sQkx76lIhkIIqNME4WZPOGT51 LRkBbUkDADghFGeLorAIFwhlmVmjvYo4Ekzbgr301DWzQ9EetomxbGm+hRloBX36k2NE ueCXjFh7uAJ6l1XsCNc2Q2iVEqsFYKkiTHzkwrwsOphfN53eqh/7i70M3ASgcH0rdX8D 1AQnxTk711CBqmqm+ynSnQJuPGFPd2iG6sFVMF39FQ7ziOg4a2yQP3VJLwi0cERraPz7 bwYbOivAAca6xieOc4DQdXYb/AFro1gDszVzotb3Wkm1J3rKLgUZnGom5tXLPvVd7kaV YkiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779259858; x=1779864658; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hmDUYWP981+QEsAdC4yYWGwxCIUyaTrbIpAPDTEiCGc=; b=pWHbG+NHy9aK9BzG4lnv+O0NVRLiEohRBFDc9N9Wqix6zcOHsKVaEGPkjXaZLmd+Ev tWdXLzzO9ugYOHfP9c4IjP93h+w9HLSxVtNyvesB3Gv9jQ+LcotVFDTUFgZv5W5SVqcM 0DmfTqgZIsDCtAHaTOL9k34ODzuAHGTHvpiWb9rqNVMyVcdOlEW0H2pjQvT1lyitub1U rv06A04+Rf05Q/kxtnqkB7/nB+Q4UD2CaXB2Ajx824ZjfhNz+LYQqIduYgBDkw/Dwp2K qlMXClvNw2F53kLUyoLeGOpU2rw9rDQ3PxNi/pRtcvI/00/iVxvuwqBUR65FjwbIkrje Juhg== X-Forwarded-Encrypted: i=1; AFNElJ9Ct6uEx8H2gFTWQRkgl7ex3nZfmhAetJS67lyOO0JsL2iikGL4TkXhXnsQnMdVX8O2rD8StdIzHmCcrCU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3ZRR7ZLIcb0BI0GNNb8Y12A73QEmiNrcSDi0QIusRO3JlryjB y6i9QqFv7Cam3vPD5/a7rFgq6e9cDkmUG72BOF64Nm+LI9CDxXHbh74mkHiAIqQCVpi9BqsmRAx 0ySjtXIDLl4rxKzTky0WLFx5QQ2E94uMUFKOLXSAMcL8J6ObqPmOpdt2IOUNyaSRs1HWQDoLr4G s= X-Gm-Gg: Acq92OHG5HyVzTDZnOlDP+AHpG/HQF3BFkdFukh/JKYrW0k8/7oUG4nlgpS+Cv8rlF7 b5MPkIDjgxPuLQHqhY1y2eGPZc7fRZ9T0xpkpKkqB9a5LH0VPDNioNbRt13m+UTXMSikKeqHjp1 1cjnHCnO1iilhw+8mNy+tT/2Y8VUb9V/O8QJ7aWbi5hZZ2jM4zKHTH3gIajjK9XAqXzR6Af+kFf /ecLouSXCybOeO3fbCU+pEdRuHEHRSnxj0vxgWVosjMwDsFfExfrGaExUOYKqgQ2ehJpF07gr2d 9zv1DFVJ/tqXmB6ocl6R2kepeykYcDlDCt8u0JAIUGx2JWA4CSAtOMfqoZitAU2a8mvEbSCL1s3 S6dkrk5fHy1pLOHWLYiz7LE3VeAPMiqOLPPlsOajt/B0Gs84mzDHwZw== X-Received: by 2002:a17:903:2c08:b0:2bc:8e7d:3dce with SMTP id d9443c01a7336-2bd52b54312mr225423685ad.27.1779259858131; Tue, 19 May 2026 23:50:58 -0700 (PDT) X-Received: by 2002:a17:903:2c08:b0:2bc:8e7d:3dce with SMTP id d9443c01a7336-2bd52b54312mr225423565ad.27.1779259857616; Tue, 19 May 2026 23:50:57 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5fe51sm206410165ad.2.2026.05.19.23.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 23:50:56 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v11 1/4] misc: fastrpc: Move fdlist to invoke context structure Date: Wed, 20 May 2026 12:20:44 +0530 Message-Id: <20260520065047.3415790-2-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260520065047.3415790-1-ekansh.gupta@oss.qualcomm.com> References: <20260520065047.3415790-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=feCdDUQF c=1 sm=1 tr=0 ts=6a0d59d3 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=HL6mAI18knL3XnPGOeUA:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: Y6UpJeYV9SQ7sRCmcRGTk1p2N5OfsXk- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDA2MyBTYWx0ZWRfX+Hf1905f8uLS KYPYE9oAPEd0fJieiDxJAV18Iq3yuheAzOBzAUaYmBTODL6/OHZIwifYGCJeuBTEPFUveyjmxVW aO0RWiSKNlBKOI0mSZ8+SAuIZRMW6xr0w7rxH3BgBPfjYqactAC7x/KDqHQ48sFbXBwYiMy/0hu VJ4khsWzUeRGxrlM2riLo4ZW7MzvPBF8iVak7+1qT64YbhL2u1mnQRylewSHhKI1QYQ0HwpF33T sYE8zX6kRRw97rWoeancdp1ccUJhTH0hZzd1lJ8BKYl/+dD6CIwaizQFTKxsr0i/uk+3KBB2igR PiPsXTpLzXyoCDAdTX7Zf9miFztROI9+Qxl6Vn6x9OcBbt55WSivMNUuArVdM8/3B5R+XdzNXam JEpJ3olzx4i/qkboOfwV8G1DurtQm9/Kf9z5UGCciXU6BRsn0cfM1cldW2/BWBYWQQQX0Q7xlvo PZoCZvVWpbeTK6cQ6og== X-Proofpoint-GUID: Y6UpJeYV9SQ7sRCmcRGTk1p2N5OfsXk- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200063 Content-Type: text/plain; charset="utf-8" The fdlist is currently part of the meta buffer which is set during fastrpc_get_args(), this fdlist is getting recalculated during fastrpc_put_args(). Move fdlist to the invoke context structure to improve maintainability and reduce redundancy. This centralizes its handling and simplifies meta buffer preparation and reading logic. Reviewed-by: Dmitry Baryshkov Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 1080f9acf70a..a9f507a88c67 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -233,6 +233,7 @@ struct fastrpc_invoke_ctx { int pid; int client_id; u32 sc; + u64 *fdlist; u32 *crc; u64 ctxid; u64 msg_sz; @@ -1016,6 +1017,7 @@ static int fastrpc_get_args(u32 kernel, struct fastrp= c_invoke_ctx *ctx) rpra =3D ctx->buf->virt; list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); pages =3D fastrpc_phy_page_start(list, ctx->nscalars); + ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); args =3D (uintptr_t)ctx->buf->virt + metalen; rlen =3D pkt_size - metalen; ctx->rpra =3D rpra; @@ -1118,18 +1120,11 @@ static int fastrpc_put_args(struct fastrpc_invoke_c= tx *ctx, union fastrpc_remote_arg *rpra =3D ctx->rpra; struct fastrpc_user *fl =3D ctx->fl; struct fastrpc_map *mmap =3D NULL; - struct fastrpc_invoke_buf *list; - struct fastrpc_phy_page *pages; - u64 *fdlist; - int i, inbufs, outbufs, handles; + u64 *fdlist =3D ctx->fdlist; + int i, inbufs; int ret =3D 0; =20 inbufs =3D REMOTE_SCALARS_INBUFS(ctx->sc); - outbufs =3D REMOTE_SCALARS_OUTBUFS(ctx->sc); - handles =3D REMOTE_SCALARS_INHANDLES(ctx->sc) + REMOTE_SCALARS_OUTHANDLES= (ctx->sc); - list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); - pages =3D fastrpc_phy_page_start(list, ctx->nscalars); - fdlist =3D (uint64_t *)(pages + inbufs + outbufs + handles); =20 for (i =3D inbufs; i < ctx->nbufs; ++i) { if (!ctx->maps[i]) { --=20 2.34.1 From nobody Mon May 25 01:16:41 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4FAA3659F9 for ; Wed, 20 May 2026 06:51:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779259866; cv=none; b=jWChbzLMeUtD17Eb1u5n//5Pko0EqQ63XBhfF9HMPf01a/MnKg4S3QG0GAg04kSqY28kLUxLtSWNzSWLYiBcXMXoO+UjPi6moQov1mxIOQX7s/xmnJLs2cUUwK203I32qWrGQmu4owfwaVttRAZkZ0fhS0vcJ61lHYEKwnhopiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779259866; c=relaxed/simple; bh=1ddE0U7h9weXbIaT7HOzewRICM+9yO0cSWfl91aUt5Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=t/zYdt0OrdiPE9vEFdlliFb89w9AkKnY7f6v/8pFVnGt69lyU+eVFfcY7tDJmVYWqzfuhLjOJt6vH8GXgufMTjQNSOe4QnKqdcMNoRZrdaoS6ESrHSJVf14iP2hLC4w0vmYrnzaqEAX3XJUxlFqAv2u6QxrjmQg6KKXR0iVWOTg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KP0Oc6fO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c4NqtMjU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KP0Oc6fO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c4NqtMjU" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64JMYo3r1739609 for ; Wed, 20 May 2026 06:51:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=JIaEBu2fXti OblnnO/rwwIoef8J83XO0Fyvu0X3nK9Q=; b=KP0Oc6fOQHckMwDl6aAK7+IENbO ipvK9YVfmudylkelSt3tGvElGMtCmLp9mievydU48ADgv0v/Dm0Cob3yv9Q0bTrT jdiZMckl3kyFLvFbuC1EyVPGIuP94a1yGFB/ByKkphYIo5yPURTR34kqTtIQOH7F TwQSAaScP2sP01UZxnjXnKtb3uXdLYAgURpGFO/j/SRlUqfeWwScnAMgVmtz2+rT Ynsrwmf7gIJ42966ZYFhRFFrCi9tF1aeYDrJpOkfbYHgDRfOqd1tI5j/vrKfQ5cr MlO+3DX9k+dBSI+gfNCpqnVWpmmzVk1LAr9id4OdBSwHK0MWirsnphgHnKg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8t3qbba7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 06:51:03 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2bd5b20aaa6so49189935ad.2 for ; Tue, 19 May 2026 23:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779259863; x=1779864663; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JIaEBu2fXtiOblnnO/rwwIoef8J83XO0Fyvu0X3nK9Q=; b=c4NqtMjUGrNAubYULb+Nl7NRVOGVn3ml9n8ofupfHM98uPNmAx4SRTHeyg9Lu0dBuS jVjIXjHPnUgg+K0fkYrC+Ypzy+n4YDpDeeaf1QBgEQhiK4KkqtaKg0TRS1nJvSrtSWVf AJLQGEyX6lJZ6dL2N1baW5BVyjgo8ED7ITVC+njKrXKdBv015RmFjvSSrLnSaZwRJlGa txkh8YY5jz6BLnr61eP29S0DvwMaTgib9Zirbz0n9coZJw2H2dEXjRIaJQYHKHx3VcGG rMDFeaWinq+icC58g6Q7SnBnA3T0cHiTUPB5e7wTYAQnaA3fyrWcHPPa6ktkCtR0CMAQ KUbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779259863; x=1779864663; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JIaEBu2fXtiOblnnO/rwwIoef8J83XO0Fyvu0X3nK9Q=; b=m25RRInW9mYRqA8OQkuG293IJ6PfCYXgxd4N6yegTM7Juj6mCajNIuXb9FN7fd8FKm 1KYiofT5iRILdr+y7D+b98PW1CVWKsBvxGownYbB4IMBFNLKxh4FP+pihRK+r4luGTiV jT7gImJhfLCVrhk5+JgKIOvfwnTz2Mfb18sQKmDSVg8dfSM61paVQImPL8fI/q9isDP5 +ey8k3US1gB9yk7Re0FCM5hgkHA0yArYQGOHdn6K1Ko69wQjdh6vt8rW7G83liAij4Ae mJTO57SEUtjctwY/cTAr2+g4IIijklidyt+IAAV1uMU866QveiwEeJ7nh9/H1Tf0PfpQ uMOA== X-Forwarded-Encrypted: i=1; AFNElJ8QW7TaoAqAQTNcbW29uS5qg3iZm5KmPCZ9m1skEp90kSJdtaTSjQbNsd5mBlIlLo7zRq3atzJ3gdGF6BM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1Dsn4JK34N9ETTF8gNUXwuaqq0PRLqKTHEiAUlq5rY1qnsXlD Tp9Zur0IBhALiaMyRCwd2iEplLmTCm06FZVLqJ2V5vRGgXu/zb5A7vcsW0VZzGgyimP3U9DWAAi 82d7YNSL1sahMHVYWfrkBoWKnamBI229gQlQbHdCUDXNUIfJ8owl8nQtEJWnVI0rjCnA= X-Gm-Gg: Acq92OGu0eKtSScbOPTsp8DixZqOjqzP4LW6+jXQbtDscNOj4habOoqIRKVVAnAtUs9 YckBOQQ9CChR9usZC0dlWDVPxi6mrDfgj2usBWU5BPaLf73OdRi2/lUGovxHUUYpexAHtkvt2qN aJxzoQ+ChZ21hIGvLk12KgjBbIRiAtZaOTcC6QKpkhx+Ml/lMKmMVl0psDQbkOZcMNt6oDO6kmT gDN2KHo46xd+IW+oOhuEEZWoN3QuAXsBZKBqHx/AqcqGcbRKt5GhXa255fXocFrgn4/V4/TeZdB 5iBW8F61Z5sb88xibGiLtHNzRl9Z8WqF5I8GSntla96tVgPdEhg+1eIAevSg51fYu/2GUA5mV4Q NZr6LLqqE+1hnDqL8QKkvmY8RV4cor3PmM1Vgkx04ZJA+3TDBIgXckQ== X-Received: by 2002:a17:903:3c6b:b0:2ae:825b:49a5 with SMTP id d9443c01a7336-2bd7e415675mr232877115ad.0.1779259862408; Tue, 19 May 2026 23:51:02 -0700 (PDT) X-Received: by 2002:a17:903:3c6b:b0:2ae:825b:49a5 with SMTP id d9443c01a7336-2bd7e415675mr232876855ad.0.1779259861917; Tue, 19 May 2026 23:51:01 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5fe51sm206410165ad.2.2026.05.19.23.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 23:51:01 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, Konrad Dybcio Subject: [PATCH v11 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Date: Wed, 20 May 2026 12:20:45 +0530 Message-Id: <20260520065047.3415790-3-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260520065047.3415790-1-ekansh.gupta@oss.qualcomm.com> References: <20260520065047.3415790-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: cA4U6dLuRRy9Em6kYc8IHMdr4Ph-2B9g X-Authority-Analysis: v=2.4 cv=LcMMLDfi c=1 sm=1 tr=0 ts=6a0d59d7 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=HL6mAI18knL3XnPGOeUA:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: cA4U6dLuRRy9Em6kYc8IHMdr4Ph-2B9g X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDA2MyBTYWx0ZWRfX9UWOF2hxFn47 aBgL+d21RJ1C2z1QbQrDGbwlfKziTeNsSe2zNUsH3Hsd80mUVqI0aMoqPfzq/RnU/03cvnTdwRp CF6rKzE0rSsPc1+L/rH8BTRzXsp8ezf4+j7AebVW4YIDu5WPWOiASQgdIXtcbVP8zKMsjsohR/A lFRAyVjSDFLeDB+S2Ohdw3C5iKTLtUB8Y65kjr0ERHh7MnyquN70XrJVIPJ3TsNSbxTCKUCM29M bqaL4feRT0pYxItrTyb4ediE0N5mXBzeht5uZWofkA8Kj9QVKVvuataXKeSS2RK+GZcjB4X5CJS T0ez1LktCWW0vmSn5FqD7ET0YwO3fS5TYmmOYNe5g6Rm4A5bP9iWy6ygnTFbqR0cM+IvjhwWqEt 9tHDenefaCs4OscK8w4XjCm2HqeNKXCGKQVifWolcg87ca2IHhV2rNvMF++96MnQTOBPtGoLPFZ zTtsE4WyhqvMnYo4fAg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 spamscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200063 Content-Type: text/plain; charset="utf-8" Replace the hardcoded context ID mask (0xFF0) with GENMASK(11, 4) to improve readability and follow kernel bitfield conventions. Use FIELD_PREP and FIELD_GET instead of manual shifts for setting and extracting ctxid values. Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index a9f507a88c67..3f5d5d73be5a 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -23,6 +23,7 @@ #include #include #include +#include =20 #define ADSP_DOMAIN_ID (0) #define MDSP_DOMAIN_ID (1) @@ -37,7 +38,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK (0xFF0) +#define FASTRPC_CTXID_MASK GENMASK(11, 4) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" @@ -515,7 +516,7 @@ static void fastrpc_context_free(struct kref *ref) fastrpc_buf_free(ctx->buf); =20 spin_lock_irqsave(&cctx->lock, flags); - idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4); + idr_remove(&cctx->ctx_idr, FIELD_GET(FASTRPC_CTXID_MASK, ctx->ctxid)); spin_unlock_irqrestore(&cctx->lock, flags); =20 kfree(ctx->maps); @@ -649,7 +650,7 @@ static struct fastrpc_invoke_ctx *fastrpc_context_alloc( spin_unlock_irqrestore(&cctx->lock, flags); goto err_idr; } - ctx->ctxid =3D ret << 4; + ctx->ctxid =3D FIELD_PREP(FASTRPC_CTXID_MASK, ret); spin_unlock_irqrestore(&cctx->lock, flags); =20 kref_init(&ctx->refcount); @@ -2508,7 +2509,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, if (len < sizeof(*rsp)) return -EINVAL; =20 - ctxid =3D ((rsp->ctx & FASTRPC_CTXID_MASK) >> 4); + ctxid =3D FIELD_GET(FASTRPC_CTXID_MASK, rsp->ctx); =20 spin_lock_irqsave(&cctx->lock, flags); ctx =3D idr_find(&cctx->ctx_idr, ctxid); --=20 2.34.1 From nobody Mon May 25 01:16:41 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B6D6364E98 for ; Wed, 20 May 2026 06:51:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779259869; cv=none; b=kZSxsQrEFHvKdTUJ22uiCOgGZiG94J4D3STcqEX5iEqq2o752mW2sn8LYzZUeC5Is8cP9we7dnqWpi+wBpoKAf6LtkcA+xKUFUVnOikVG2rjN0xRWMK5G82mEH2z5zTGB0oGBgQD5m+BJd2OUyN6hqoXdbRBy5vTWy+VYhnGIEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779259869; c=relaxed/simple; bh=wLHY1YKwTOtJ5TMOu7Sc4w4rQ5+KEfPEjuD58JrY/gw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pFeM9sxPEU3mMaNWd+OjvzCeY+TAfTKzDYeWoS8gryhRgoOjmcKBz4H/JqV2NhhCNQK7u9Ep5q7ZKOiy1tRvRyPVI/96UUm2vOJO6ihEsUNWrmkDeEvm4CvdRwkByCkvA7Cku/cXLCXETxczcJb+BncG7EEzvTdOpovb8lP2FGY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PY5IXu+Q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AmfpYWx3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PY5IXu+Q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AmfpYWx3" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64JNLBWE341468 for ; Wed, 20 May 2026 06:51:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=tFUu7w/Mdhl BRhU4Ur6TRUhTba4EbTByy053HqbjsgU=; b=PY5IXu+QmiipXKS5ptBVL/hfa6i irYkrRW5+36Ep7v/ipE3UqaybAj56aw7Ho3f2QaadkNBaqBO6tMu5dSQyu/DnUpl l28Pp5qpR/v9a/HQ7KBLkBqq/HRfOywC7Ewxs7z0dNzI7ExI7WJWUQk9d4VFrbEw iVRReHKhZJGDUAhAyP/t4x+kp0D/M/7SSyul/dgDBb4KR9xKlvkgWoVUXR5ohfhr eSnZgBSBAtJhowGrol/MWtMLfXU6/PMu2RpiFutLb4I09rRx8Ups60LXQGkh6n7F /7eN5F4mgOGpQIUIyqtxm+oq1Q5NNKKztAo9/gX5TvYFitKElfG5mpWrwaA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8t3vbcbw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 06:51:07 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ba224c3ffdso113783875ad.0 for ; Tue, 19 May 2026 23:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779259866; x=1779864666; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tFUu7w/MdhlBRhU4Ur6TRUhTba4EbTByy053HqbjsgU=; b=AmfpYWx3SW0xAPusrMrNcBEXNghkiYIyDeTaVauJGVplVdWi6KbbikN8JX3NkixR6Y jqMco7Q6Opgj26Q/XUmgLq/f1vbPUKgpKcta7V0rfE7asgLWRqTcd+DNYfjWJzRBT7PG xeneHJdsoEfvr5W6F/Jwjl5MHoX4EUPGHUt5hK2jcUgBWqIOAUMde67dpAChbdFC+3IG cnV/l7G33olqJl052xecjilUehUXo9Y7HzDnyfo0Go+0xLsXHeR2AXj+tVpazfHPDrLk CFj7s3knVmWAAnAzgDlvq7ing5C0HG/Tl88SyeCSgEMtgNplxFHsT1UDtfg+0VdIPJZT P/2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779259866; x=1779864666; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tFUu7w/MdhlBRhU4Ur6TRUhTba4EbTByy053HqbjsgU=; b=jgEya+tU4P6IIXTH5/AGxa6Go1DQnR/4JGn5QxhEXi0Nq8LgJK9ZQawIV2fdembfee fj3uy+WUy7oYrK79U4HpV8eZ9taIDIMbiBSLfBTLG+71KQwtQxMiA77OXqJjHdbip/LA sQG/H4vcEyxXLgDMJWhPQkpd4MRxt1wSwbsVXIpbXQ85pjQantEVORrdPicjz1cDSpQp kDQd0s8K0AlyDpJHzU+RM407NYJyfpSxfS1Wh2a4PKdqFADGueNFTLM6NNONZT/v5e+M CMxjcdVZRsvlabhenxC5+JaSpVJZDrpPW0Cz/jmhSMper19zGnJ5N626Ms1/Hfy4qNmK pWkQ== X-Forwarded-Encrypted: i=1; AFNElJ9V/IIlBPRil+q53jsCL4HmoURsp6AYR01j0N5sHV1nKXWKpBq4C1HfGU/EYRRpduQL3KYJxqyqZL0gmik=@vger.kernel.org X-Gm-Message-State: AOJu0YynYnX7wTYLx7119BsUWvdsKjct2NzfZ6HTwz7Sx4aDtO7ZFR4H /g7RuFUXL3QMtDQ4I3oYG98ELjPt5KwpqaHlvRRmsV6FVD0G+XIbx7RgtwvtByl0XE5fHc+UJl1 ZC4o8e+KctHZ3l55EXRgr4Fa5ypSTegeJqPcET8wZQZOS5Y9N1z3FNld8IAQSQwiHFZRcEP+gR6 I= X-Gm-Gg: Acq92OGOHCXIcngZQxIvkWs93k7GIgzCBFfVokUS8hlrqTFli8SVYJQHzt++//4wozF ZMwJvmIRr5YdiWxMKwF/9QSIMVToRc8nMALff6irR+foUhUpVc1jCsvECpJosAus/vvRUOOBCa6 3QVmdNq95DOagMUWanxwpv6liUd9wO8MuzlGSCCTcFdSPr8P+OR+c74Ho8cd/vbqF0JIJYMkDKy fXv1EQRgcM/oz9wvTGwMxQqmmeBRUAZEV+jjY2vjfyuDkT1ksS7DN+sjLowTfsKwL+FDfqB0IYQ pl83cKYOGWI/LDNy+Jsc4C8YjLqKv7Abf3wyExfBM2jrK7r4zaBc6yo/U9g7n0MwCVc6OBtrjye 6RQqaeSVUNH2m92b0+40asKmJB71ZrYviYjhjNWHBF+2rVLjhc6gHvw== X-Received: by 2002:a17:902:f64c:b0:2ba:fed:7891 with SMTP id d9443c01a7336-2bd7e92c24amr260092565ad.30.1779259866275; Tue, 19 May 2026 23:51:06 -0700 (PDT) X-Received: by 2002:a17:902:f64c:b0:2ba:fed:7891 with SMTP id d9443c01a7336-2bd7e92c24amr260092335ad.30.1779259865775; Tue, 19 May 2026 23:51:05 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5fe51sm206410165ad.2.2026.05.19.23.51.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 23:51:05 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v11 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support Date: Wed, 20 May 2026 12:20:46 +0530 Message-Id: <20260520065047.3415790-4-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260520065047.3415790-1-ekansh.gupta@oss.qualcomm.com> References: <20260520065047.3415790-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 80tKZj7RbtslNWfMxAleiPMuXTLb5HiE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDA2MyBTYWx0ZWRfX1r4qlbxp0t9j pvUU7or84Wmb5i4j6Xnj50CU37kuRVgcXKpXZLrkB7ndEPTf+iwlv8PoqGS2fVgwIjIAITChC7t 1taKbaOpGW72JH64lxB5NGO8so+TkDcyVeihdsXCr88TAg+CYI+Xh+Z5G/+rRaLbU9Rcxo+jv3A L0Qqoi2OoeOBBSe6ycxwdQMF5lv+EciG2v+OVjyMqfIMPrQVcr6tfCrqx4/DfIQ1fNFvNiYeaz2 7whUDIeeraUQPj4SdCk63jsrRF9WmVA1DzZES/CM3643WwPc9KXS2HmDonIneJTJVx3yBxGSEtU V/mQnsWEHW4QgtmJgtxliOHWDp3o7qDcUF/yQVrIGpqXBkc1cXYN1kWghUtC3lWMKwrmC6WVPXu YmKzoz6n/rz85xjqaJHfME3qPhA5e/ApXjf/AOaxaXaq0mXn6g8tF/GE1gG3HOvkJegSEksVgVb 5L7NnvsbovMAo0sAG3g== X-Authority-Analysis: v=2.4 cv=JuPBas4C c=1 sm=1 tr=0 ts=6a0d59db cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=JTa3dIKMUYn8LlmgGFYA:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: 80tKZj7RbtslNWfMxAleiPMuXTLb5HiE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200063 Content-Type: text/plain; charset="utf-8" Current FastRPC context uses a 12-bit mask: [ID(8 bits)][PD type(4 bits)] =3D GENMASK(11, 4) This works for normal calls but fails for DSP polling mode. Polling mode expects a 16-bit layout: [15:8] =3D context ID (8 bits) [7:5] =3D reserved [4] =3D async mode bit [3:0] =3D PD type (4 bits) If async bit (bit 4) is set, DSP disables polling. With current mask, odd IDs can set this bit, causing DSP to skip poll updates. Update FASTRPC_CTXID_MASK to GENMASK(15, 8) so IDs occupy upper byte and lower byte is left for DSP flags and PD type. Reserved bits remain unused. This change is compatible with polling mode and does not break non-polling behavior. Bit layout: [15:8] =3D CCCCCCCC (context ID) [7:5] =3D xxx (reserved) [4] =3D A (async mode) [3:0] =3D PPPP (PD type) Reviewed-by: Dmitry Baryshkov Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 3f5d5d73be5a..c4a3547a5c7f 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -38,7 +38,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK GENMASK(11, 4) +#define FASTRPC_CTXID_MASK GENMASK(15, 8) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" --=20 2.34.1 From nobody Mon May 25 01:16:41 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA523367B63 for ; Wed, 20 May 2026 06:51:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779259874; cv=none; b=ay5s3Q9WvuWHtQsPtAGIO3SR8oaQtuE3HyVVGrYwahCqI8SkZksSVBhYpiRGnpfmGXTeMQ17bMj967DITN7UXhnFBpAaUHNJntI3tP2q2ItdkGRgXBK/2oSEuITVyT9OSJ07OEZbcHiIea4P2GFNgjDnPAx19IbvUzY2Yo+U7jM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779259874; c=relaxed/simple; bh=IYe0jNIVlEQLnebUSCpvm4Ugxamg9eIeLgcgiWXam8s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Hf6yy+wjSvU37ZknQs5AF4nEqKLF9ZT3GS9abmGq1zYvExZlFDmUQVhaAcecOr/P7DF/+KYTv0eR1jeCI/v3BikOG+M0Y6t6nUJWcw+75wPrEKOUexgRIB+gmc/ascIqHmyLu1vT/e8CLkrJdEC4B8kk5hwTKYa6QIrXUm9QSME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=im9n3Jil; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=irytWGsh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="im9n3Jil"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="irytWGsh" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64JNLBWF341468 for ; Wed, 20 May 2026 06:51:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=orVCR6H6vjR l03w7Yllbu5y5Z07UKEr+6JQAjsXp5pw=; b=im9n3JiliYBKzXcY33I5qQA2A1V nlAslxKCrlfXn0uviEPvTtwuA8ymNvMi5ncP81M5meyAwu5wg7Gb37csAtG5UyT+ aPVi0556PWBCNfIvRSlyu4yAWvZeRnT58Bjy8mSwRzW1Hjfkp1mAJWxZHb+NCl30 KquSHiwhpeN8xmCV5UbeosIIshvvF7c6VYhmwqcZt5+Ni8/5j0BhAN/UUh+wQUJe ftbRVlwZNfq2yZ4HQP6oaZ7wAuloRsoTH/MtduUPuZkcRa5EPIxL1h++BcXUvMUK xHaVMAxgazTsfMpZDA1SxIldy7Z45SO0srBfqAuehfdy6XDpVGg1jYYrQUw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8t3vbcc8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 06:51:11 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b2ecc96a9aso50974145ad.1 for ; Tue, 19 May 2026 23:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779259871; x=1779864671; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=orVCR6H6vjRl03w7Yllbu5y5Z07UKEr+6JQAjsXp5pw=; b=irytWGshuz0LVvbmcZT9X1YhdSCiXD68eH2f36fvuTZmJBw35cdvXePm9Kv5aImGC2 KaiJZ7euxRIrTJFJcgL477925j8EIZavK66YxczO/2airWjuE/z8MkKCnBMxbyqdsxbw 3XLNqUfJsjsZJSzd/VHoifh2xtmSjoBAtXSh8zR1OH885HpdBR1eN9yzpNb1iEnbH6ij G0FJOh3YdcWaGPh/6X9gswTv6MgcwXmdQig5skzWyvpq3lnU4IuODbpvMnBh5gumLmkS SovPAKqDN5ZWuGjcDfjbAHJbcqa7JDxJzFH5jTdSP6naQWA9Nu1Bac+LzZ/5z0CBI+rR S7OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779259871; x=1779864671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=orVCR6H6vjRl03w7Yllbu5y5Z07UKEr+6JQAjsXp5pw=; b=h/GaP0ayX2EE3sYPsndXHv+l+zqMEzgaeTPRusDhhVIyjnrVsZbTSF/8RNPVrdgcHB 9emxsPtqrtrt2L2TqNwAh2GwiFzxZ7Tvu9Uo0BWit8yyvXyYR00Wb2rd0P0ZyFdD73Zv 4hZHQCAqyuYA6xR+tCrFiqNYONneKBxY+6C7xqK+WcHDgv+IS9Bp0ic/gtf1bxoJOckX 67pUekvaaubRGnNNU9fz0/maNXHZA5dRiBgF0Jxn3hCQu1QHqOrDLOiNYhI2eg1N8NWc GcbJGsGLmSdDC/hhgaukhGwffPProrcfREzQL3u7U1YVGwbK/J8+3Vo9FJVpuCij0cmh 6msQ== X-Forwarded-Encrypted: i=1; AFNElJ/PnAb+dMdci5C9P+KDlZLBwceucCqo709yn1ctcwLqK2AHZKttZKp2CLy9NT7HCEMsDjbGfb3BkBUpzdc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxf8XA3nw52CHgVcoCmWoTLHHljSvJQ2rUF30ckCHN8W6rDsr23 ToT34y3cFacMkj+C6uYzRMkGvXaxVZqbbiAkXipZsRBoGB6fDUwnWnd+GCJzNQu8d0B0YZN/574 TFI8iRLwdHDayhwMZN2+SEdw1ao1TmjWQe+piOFCSo3bhUDW5xVg+Uk3wvqgLhary8DY= X-Gm-Gg: Acq92OEB8OWCIadAygqlpH/1WRB1iP6Btb96Ow3QBBGqBVBA5SBEj8INmZHbYmAShNR gSlMk6CC7G8+g4ot+DKPaw45AV1Ec784y0AQgM99OyZRlOCbC7akpGXQBK9Hj0WL5oJz4QIwk0t KQe0kvZ1o0i1OlZPfkGss1OmGNxZc1LjZJ+0W5W6znhyOd+23T2XHqPiq20cLtvq9tpoKi0Dbca i0MZcWTNBdpz/SCgNsEro0ADGiT2rtPUBP8HVHLIKG0dVDWXHCVAT9SnWmA1/nczzpu0ZUKKCDH wpBcPJ0UjHnOiQAB8J0QWq8TmpeZk2Su9RkdaIwFS0UXDpab9i2jw5wybDxh6eS5s4wv+WTAWlt 2qj0nga90Eee8S8VyeXSBJvmJnCmFJ/wIzCP6QE4/or65dcemne0L2dxFYYi7rpGp X-Received: by 2002:a17:903:2f81:b0:2be:1c3c:72ba with SMTP id d9443c01a7336-2be1c3c73cemr90954145ad.32.1779259870546; Tue, 19 May 2026 23:51:10 -0700 (PDT) X-Received: by 2002:a17:903:2f81:b0:2be:1c3c:72ba with SMTP id d9443c01a7336-2be1c3c73cemr90953825ad.32.1779259869996; Tue, 19 May 2026 23:51:09 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5fe51sm206410165ad.2.2026.05.19.23.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 23:51:09 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v11 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Date: Wed, 20 May 2026 12:20:47 +0530 Message-Id: <20260520065047.3415790-5-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260520065047.3415790-1-ekansh.gupta@oss.qualcomm.com> References: <20260520065047.3415790-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 9Ouzg2EDMlMPLQRm-uADUehUlDzsuTMS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDA2MyBTYWx0ZWRfX1d6CsyepKMT+ Otkt8zg7C4VNvrqhqa/lHqhr7RZSdvGjqsSsmm4BLIhHLNjxoefce2sFwBKVmAP2DyP4VjkHKmN koTjNjDgCGcMKblbmDgvbtaRI4tB/AsBsn2DzXfZZoy4RBYOp/rzJ3KfTJq8KmYCkGxwp0g6sb+ JuOIHNKIXpMv04z7g4gPsJOD2aj2dxhWks6a6Jx2tM20qTrTeW/J6Z/fAQ/BxL9PabrJhMVUYlu E9kLT2R9fJqd5F8/cJw/nFKSodsU+zawziIaAzxalXw+CJD+ypdsYlYpGLr3o81Fxk9j1/l1nps fojhNsB3b4rmeMS8HzIIoJgkyqQgkO0ucXIHy4ig3BIy2s0TtKyFzw1oXt4DvgkcHRnMZlHR9kT DE+nnqu7KlsJ/vyldZitJ6+sX4dz3m1q5v25gSff7ZjqcRpApkiAcNB6SazsSbP7zO9r2mitZMz CS/yYSgIVjQwZWSsYCw== X-Authority-Analysis: v=2.4 cv=JuPBas4C c=1 sm=1 tr=0 ts=6a0d59df cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=Xak7btDuadOZULdqBEwA:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: 9Ouzg2EDMlMPLQRm-uADUehUlDzsuTMS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200063 Content-Type: text/plain; charset="utf-8" For any remote call to DSP, after sending an invocation message, fastRPC driver waits for glink response and during this time the CPU can go into low power modes. This adds latency to overall fastrpc call as CPU wakeup and scheduling latencies are included. Add polling mode support with which fastRPC driver will poll continuously on a memory after sending a message to remote subsystem which will eliminate CPU wakeup and scheduling latencies and reduce fastRPC overhead. In case poll timeout happens, the call will fallback to normal RPC mode. Poll mode can be enabled by user by using FASTRPC_IOCTL_SET_OPTION ioctl request with FASTRPC_POLL_MODE request id. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 167 ++++++++++++++++++++++++++++++++++-- include/uapi/misc/fastrpc.h | 29 +++++++ 2 files changed, 189 insertions(+), 7 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index c4a3547a5c7f..aab70947482d 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -24,6 +24,8 @@ #include #include #include +#include +#include =20 #define ADSP_DOMAIN_ID (0) #define MDSP_DOMAIN_ID (1) @@ -38,6 +40,12 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 +/* + * Maximum handle value for static handles. + * Static handles are pre-defined, fixed numeric values statically assigned + * in the IDL file or FastRPC framework. + */ +#define FASTRPC_MAX_STATIC_HANDLE (20) #define FASTRPC_CTXID_MASK GENMASK(15, 8) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) @@ -106,6 +114,12 @@ =20 #define miscdev_to_fdevice(d) container_of(d, struct fastrpc_device, miscd= ev) =20 +/* Poll response number from remote processor for call completion */ +#define FASTRPC_POLL_RESPONSE (0xdecaf) + +/* Polling mode timeout limit */ +#define FASTRPC_POLL_MAX_TIMEOUT_US (10000) + struct fastrpc_phy_page { dma_addr_t addr; /* dma address */ u64 size; /* size of contiguous region */ @@ -236,8 +250,14 @@ struct fastrpc_invoke_ctx { u32 sc; u64 *fdlist; u32 *crc; + /* Poll memory that DSP updates */ + u32 *poll_addr; u64 ctxid; u64 msg_sz; + /* work done status flag */ + bool is_work_done; + /* process updates poll memory instead of glink response */ + bool is_polled; struct kref refcount; struct list_head node; /* list of ctxs */ struct completion work; @@ -263,6 +283,7 @@ struct fastrpc_soc_data { u32 sid_pos; u32 dma_addr_bits_cdsp; u32 dma_addr_bits_default; + bool poll_mode_supported; }; =20 struct fastrpc_channel_ctx { @@ -285,6 +306,7 @@ struct fastrpc_channel_ctx { struct list_head invoke_interrupted_mmaps; bool secure; bool unsigned_support; + bool poll_mode_supported; u64 dma_mask; const struct fastrpc_soc_data *soc_data; }; @@ -308,6 +330,8 @@ struct fastrpc_user { int client_id; int pd; bool is_secure_dev; + /* Flags poll mode state */ + bool poll_mode; /* Lock for lists */ spinlock_t lock; /* lock for allocations */ @@ -923,7 +947,8 @@ static int fastrpc_get_meta_size(struct fastrpc_invoke_= ctx *ctx) sizeof(struct fastrpc_invoke_buf) + sizeof(struct fastrpc_phy_page)) * ctx->nscalars + sizeof(u64) * FASTRPC_MAX_FDLIST + - sizeof(u32) * FASTRPC_MAX_CRCLIST; + sizeof(u32) * FASTRPC_MAX_CRCLIST + + sizeof(u32); =20 return size; } @@ -1019,6 +1044,9 @@ static int fastrpc_get_args(u32 kernel, struct fastrp= c_invoke_ctx *ctx) list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); pages =3D fastrpc_phy_page_start(list, ctx->nscalars); ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); + ctx->poll_addr =3D (u32 *)((uintptr_t)ctx->fdlist + sizeof(u64) * FASTRPC= _MAX_FDLIST + + sizeof(u32) * FASTRPC_MAX_CRCLIST); + args =3D (uintptr_t)ctx->buf->virt + metalen; rlen =3D pkt_size - metalen; ctx->rpra =3D rpra; @@ -1188,6 +1216,71 @@ static int fastrpc_invoke_send(struct fastrpc_sessio= n_ctx *sctx, =20 } =20 +static u32 fastrpc_read_poll_addr(struct fastrpc_invoke_ctx *ctx) +{ + dma_rmb(); + return READ_ONCE(*ctx->poll_addr); +} + +static int poll_for_remote_response(struct fastrpc_invoke_ctx *ctx) +{ + u32 val; + int ret; + + /* + * Poll until DSP writes FASTRPC_POLL_RESPONSE into *ctx->poll_addr + * or until another path marks the work done. + */ + ret =3D read_poll_timeout_atomic(fastrpc_read_poll_addr, val, + (val =3D=3D FASTRPC_POLL_RESPONSE) || ctx->is_work_done, 1, + FASTRPC_POLL_MAX_TIMEOUT_US, false, ctx); + + if (!ret && val =3D=3D FASTRPC_POLL_RESPONSE) { + /* + * DSP writes FASTRPC_POLL_RESPONSE to signal successful + * completion via the poll path. + */ + ctx->is_work_done =3D true; + ctx->retval =3D 0; + } + + if (ret =3D=3D -ETIMEDOUT) + ret =3D -EIO; + + return ret; +} + +static inline int fastrpc_wait_for_response(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err =3D 0; + + if (kernel) { + if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) + err =3D -ETIMEDOUT; + } else { + err =3D wait_for_completion_interruptible(&ctx->work); + } + + return err; +} + +static int fastrpc_wait_for_completion(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err; + + if (ctx->is_polled) { + err =3D poll_for_remote_response(ctx); + if (!err) + return 0; + /* If polling timed out or failed, move to normal response mode */ + ctx->is_polled =3D false; + } + + return fastrpc_wait_for_response(ctx, kernel); +} + static int fastrpc_internal_invoke(struct fastrpc_user *fl, u32 kernel, u32 handle, u32 sc, struct fastrpc_invoke_args *args) @@ -1223,13 +1316,14 @@ static int fastrpc_internal_invoke(struct fastrpc_u= ser *fl, u32 kernel, if (err) goto bail; =20 - if (kernel) { - if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) - err =3D -ETIMEDOUT; - } else { - err =3D wait_for_completion_interruptible(&ctx->work); - } + /* + * Set message context as polled if the call is for a user PD + * dynamic module and user has enabled poll mode. + */ + if (handle > FASTRPC_MAX_STATIC_HANDLE && fl->pd =3D=3D USER_PD && fl->po= ll_mode) + ctx->is_polled =3D true; =20 + err =3D fastrpc_wait_for_completion(ctx, kernel); if (err) goto bail; =20 @@ -1813,6 +1907,35 @@ static int fastrpc_get_info_from_kernel(struct fastr= pc_ioctl_capability *cap, return 0; } =20 +static int fastrpc_set_option(struct fastrpc_user *fl, char __user *argp) +{ + struct fastrpc_ioctl_set_option opt =3D {0}; + int i; + + if (!fl->cctx->poll_mode_supported) + return -EOPNOTSUPP; + + if (copy_from_user(&opt, argp, sizeof(opt))) + return -EFAULT; + + for (i =3D 0; i < ARRAY_SIZE(opt.reserved); i++) { + if (opt.reserved[i] !=3D 0) + return -EINVAL; + } + + if (opt.request_id !=3D FASTRPC_POLL_MODE) + return -EINVAL; + + if (opt.value =3D=3D FASTRPC_POLL_MODE_ENABLE) + fl->poll_mode =3D true; + else if (opt.value =3D=3D FASTRPC_POLL_MODE_DISABLE) + fl->poll_mode =3D false; + else + return -EINVAL; + + return 0; +} + static int fastrpc_get_dsp_info(struct fastrpc_user *fl, char __user *argp) { struct fastrpc_ioctl_capability cap =3D {0}; @@ -2168,6 +2291,9 @@ static long fastrpc_device_ioctl(struct file *file, u= nsigned int cmd, case FASTRPC_IOCTL_MEM_UNMAP: err =3D fastrpc_req_mem_unmap(fl, argp); break; + case FASTRPC_IOCTL_SET_OPTION: + err =3D fastrpc_set_option(fl, argp); + break; case FASTRPC_IOCTL_GET_DSP_INFO: err =3D fastrpc_get_dsp_info(fl, argp); break; @@ -2323,6 +2449,7 @@ static const struct fastrpc_soc_data kaanapali_soc_da= ta =3D { .sid_pos =3D 56, .dma_addr_bits_cdsp =3D 34, .dma_addr_bits_default =3D 32, + .poll_mode_supported =3D true, }; =20 static const struct fastrpc_soc_data default_soc_data =3D { @@ -2331,6 +2458,29 @@ static const struct fastrpc_soc_data default_soc_dat= a =3D { .dma_addr_bits_default =3D 32, }; =20 +/* + * Exception list for older platforms that use default_soc_data but whose + * DSP firmware supports FastRPC polling mode. + * + * NOTE: This list is intentionally closed. + * Do NOT add new platforms here. New SoCs must advertise polling mode + * support via their soc_data. + */ + +static const struct of_device_id fastrpc_poll_supported_machines[] __maybe= _unused =3D { + { .compatible =3D "qcom,milos" }, + { .compatible =3D "qcom,qcs8300" }, + { .compatible =3D "qcom,sa8775p" }, + { .compatible =3D "qcom,sar2130p" }, + { .compatible =3D "qcom,sm8450" }, + { .compatible =3D "qcom,sm8550" }, + { .compatible =3D "qcom,sm8650" }, + { .compatible =3D "qcom,sm8750" }, + { .compatible =3D "qcom,x1e80100" }, + { .compatible =3D "qcom,x1p42100" }, + {}, +}; + static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) { struct device *rdev =3D &rpdev->dev; @@ -2397,6 +2547,8 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *r= pdev) secure_dsp =3D !(of_property_read_bool(rdev->of_node, "qcom,non-secure-do= main")); data->secure =3D secure_dsp; data->soc_data =3D soc_data; + data->poll_mode_supported =3D soc_data->poll_mode_supported || + of_machine_get_match(fastrpc_poll_supported_machines); =20 switch (domain_id) { case ADSP_DOMAIN_ID: @@ -2521,6 +2673,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, } =20 ctx->retval =3D rsp->retval; + ctx->is_work_done =3D true; complete(&ctx->work); =20 /* diff --git a/include/uapi/misc/fastrpc.h b/include/uapi/misc/fastrpc.h index c6e2925f47e6..ba1ea5ed426c 100644 --- a/include/uapi/misc/fastrpc.h +++ b/include/uapi/misc/fastrpc.h @@ -16,6 +16,7 @@ #define FASTRPC_IOCTL_INIT_CREATE_STATIC _IOWR('R', 9, struct fastrpc_init= _create_static) #define FASTRPC_IOCTL_MEM_MAP _IOWR('R', 10, struct fastrpc_mem_map) #define FASTRPC_IOCTL_MEM_UNMAP _IOWR('R', 11, struct fastrpc_mem_unmap) +#define FASTRPC_IOCTL_SET_OPTION _IOWR('R', 12, struct fastrpc_ioctl_set_o= ption) #define FASTRPC_IOCTL_GET_DSP_INFO _IOWR('R', 13, struct fastrpc_ioctl_cap= ability) =20 /** @@ -67,6 +68,28 @@ enum fastrpc_proc_attr { /* Fastrpc attribute for memory protection of buffers */ #define FASTRPC_ATTR_SECUREMAP (1) =20 +/** + * FASTRPC_POLL_MODE - Enable/disable poll mode for FastRPC invocations + * + * Poll mode is an optimization that allows the CPU to poll shared memory + * for completion instead of waiting for an interrupt-based response. + * This reduces latency for fast-completing operations. + * + * Restrictions: + * - Only supported for USER_PD (User Protection Domain) + * - Only applies to dynamic modules (handle > 20) + * - Static modules always use interrupt-based completion + * + * Values: + * - 0: Disable poll mode (use interrupt-based completion) + * - 1: Enable poll mode (poll shared memory for completion) + */ +#define FASTRPC_POLL_MODE (1) + +/* Values for FASTRPC_POLL_MODE request */ +#define FASTRPC_POLL_MODE_DISABLE 0 +#define FASTRPC_POLL_MODE_ENABLE 1 + struct fastrpc_invoke_args { __u64 ptr; __u64 length; @@ -133,6 +156,12 @@ struct fastrpc_mem_unmap { __s32 reserved[5]; }; =20 +struct fastrpc_ioctl_set_option { + __u32 request_id; /* Request type (e.g., FASTRPC_POLL_MODE) */ + __u32 value; /* Request-specific value */ + __s32 reserved[6]; +}; + struct fastrpc_ioctl_capability { __u32 unused; /* deprecated, ignored by the kernel */ __u32 attribute_id; --=20 2.34.1