From nobody Mon May 25 01:16:07 2026 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46E2E1DDA18 for ; Wed, 20 May 2026 06:31:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779258684; cv=none; b=ekfOlwCuNQqjttPIONnRyJgOUxMARfOz2rkkBTZMensJHurwqQCx7zeFDWd8SLDvHoCzcHhKTXuAp/sDb+Y7y3WGVDTNvM0/+kTT7aG4z4ZQFGygFVYVslhnpFVL2gvEj73G2Ps+FvfCItXA2UJC70D47N8pEWrxKVof2KnkKIQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779258684; c=relaxed/simple; bh=pyAy2+YyRiAExTLRaHDkQfxkzNEEiwc1UqBL7foD29c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=g2nC2mreiP8IhzQ42sgFGOROw7HCIIbvLNnb49j6NT1rqYts+CcaxpiZmvwYykZ4TXBVn2gLaS2zvKaK39WsLh1K7Xvcy5G4hqVARtgW06x5U/Nfcf0AUkUSHYWqJwbAaH2QlHSTU3A1tje56jE4VFJqMpmMWa51cwek/DaoDrY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=jCNrdsum; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="jCNrdsum" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b8f97c626aaso897956366b.2 for ; Tue, 19 May 2026 23:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1779258682; x=1779863482; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tJsm+vTaAtG3guEM9DFX3cDN+y8PVlBk+kArJ9s0GwU=; b=jCNrdsumSqLO6P2Ln3SRC915SkOpud0q3X62Daus5Zj7Hl1pgsAr8wmXfyFRZhJAPq VpmkNktbvNhK2B1+yPEndfFaKq/BdpeZF0O1wi9tuZQkBaF0SH77AP7cJiz/i3Euzkbu nnfxEIN9UZXHa0d+HXoB/tkgAO1VoxznW2cdk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779258682; x=1779863482; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tJsm+vTaAtG3guEM9DFX3cDN+y8PVlBk+kArJ9s0GwU=; b=k19rn+3wLO/AEuVHbuxHbOXq36/3ZEX0tftGAUNLzQyFlqR7rnmAbeYbwqYWN9pBH0 m5rHAPZ2BrhYGD+mNaw4y45L/PM+suahd/b5+yDyEKpWjILEoc1fCRLRd3FnesrQX9kz T/ustL13987SH5vlelGXFVo7VRWiyePhj5jsfStGkdLM683S4mV3hS8JSpriyRoNb7v3 XRFH18wOcOTtYEVlZIrHx7oy0PD8KtjBEWKdsT8teipxTzo0r50Ip/zWSMmRHi6uNUPX /AHfMKDof4TRQJ59FROhCQLN5rwFdQsJgiqbb0kVx4af+hvmno/OT9qjyGn3reAxaNZf WI1g== X-Forwarded-Encrypted: i=1; AFNElJ9z53WKvSXO0o9mwMgl+wFscbCZP9ftGSmX82N+86xGgLObk9oLVons0tCFQQyYZsEzSK5zlb2+pYfTCMg=@vger.kernel.org X-Gm-Message-State: AOJu0YxYHSw4YTCBG5Dgohleki4VZkJf/V5kR7P0e4PM/CN3HSp7NAZK FwPFblBY4XaIRAt09vACf2pYFDmcIJSBG0i2t8cuycCT/Culvc2mNPHqx+VVkbMRXzV7i2s+mkX QaGohB50= X-Gm-Gg: Acq92OGaOL1xgcRh814IiB6LkL0gufLRAZFCYd6dpwhUMmu3Z6XOnnRWmq6vA2FcsC6 x54+stK+CMA4veNSBADqivAERkDcq4WaP5kqnRcYZs+HUx4S0ydpV2wC+71yXLoV/p4e4Qq3RtT vSaPyjDFWSjeFI4/IZ3JA/z6XWo6HY5a/PSJOX81ISiQaizFfGAhH4XEpf3Iq5XyUzoQ3IkU0gJ wiB/QKDEWQG9lYyNAvSEahw/doKuUZ54Yc4IotDCEM32Muv44QRuQU6Q1qwkoZz2FNu5zmIuQ6+ Iv5xMrsSJLlJo8NHuSQ/KptL8kcqpw7KT/6yz84EtbTPk2wpbK3c838PtJrd34I9EuhKg1VKYne nAmcYH27wyCLKGlVJHp4BtqEESu6kf/14D6glVZqIMNPaUswqALtThW9UJEJcYtMmlmUKBX0X4i cSadkN6R7A+plAJ8aM6DHJIa86Ghvm7eRlSHowM4txHt8UkfhH9MvEpBN1k+WAXSAXkhOZrsgaz Afo3W9ArN/GWe6bXAO4gikL0A== X-Received: by 2002:a17:906:6207:b0:bd2:2852:683b with SMTP id a640c23a62f3a-bd5177c7dd5mr1325236266b.16.1779258681589; Tue, 19 May 2026 23:31:21 -0700 (PDT) Received: from fedora.tail032493.ts.net (98-215-98-95.ftth.glasoperator.nl. [95.98.215.98]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4c314f5sm807572866b.23.2026.05.19.23.31.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 23:31:20 -0700 (PDT) From: Andrea Calabrese To: brauner@kernel.org, oleg@redhat.com, akpm@linux-foundation.org, peterz@infradead.org, tglx@kernel.org, kexinsun@smail.nju.edu.cn, adrianhuang0701@gmail.com, elver@google.com, linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Andrea Calabrese Subject: [PATCH v2] kernel: refactor: shorten has_pending_signals Date: Wed, 20 May 2026 08:28:50 +0200 Message-ID: <20260520062849.183621-2-andrea.calabrese@amarulasolutions.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In has_pending_signals there was a switch/case used for optimizations. However, today's compilers perform loop unrolling efficiently, thus it is not needed anymore. put i inside the for declaration so we do not risk its escape from the scope. Moreover, i starts now from 0 and counts up, as it is a more usual pattern. Signed-off-by: Andrea Calabrese Acked-by: Oleg Nesterov --- The difference with V1 is in the description, now accurate thanks to the review. As before, the patch has been tested on gcc x86 and generates the same code. kernel/signal.c | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index 2d102e025883..799ee98cf03e 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -130,28 +130,10 @@ static bool sig_ignored(struct task_struct *t, int si= g, bool force) */ static inline bool has_pending_signals(sigset_t *signal, sigset_t *blocked) { - unsigned long ready; - long i; - - switch (_NSIG_WORDS) { - default: - for (i =3D _NSIG_WORDS, ready =3D 0; --i >=3D 0 ;) - ready |=3D signal->sig[i] &~ blocked->sig[i]; - break; - - case 4: ready =3D signal->sig[3] &~ blocked->sig[3]; - ready |=3D signal->sig[2] &~ blocked->sig[2]; - ready |=3D signal->sig[1] &~ blocked->sig[1]; - ready |=3D signal->sig[0] &~ blocked->sig[0]; - break; - - case 2: ready =3D signal->sig[1] &~ blocked->sig[1]; - ready |=3D signal->sig[0] &~ blocked->sig[0]; - break; - - case 1: ready =3D signal->sig[0] &~ blocked->sig[0]; - } - return ready !=3D 0; + unsigned long ready =3D 0; + for (long i =3D 0; i < _NSIG_WORDS; i++) + ready |=3D signal->sig[i] & ~blocked->sig[i]; + return ready !=3D 0; } =20 #define PENDING(p,b) has_pending_signals(&(p)->signal, (b)) --=20 2.54.0