From nobody Mon May 25 01:15:22 2026 Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0867630BBBF for ; Wed, 20 May 2026 02:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779245048; cv=none; b=m16vKXbOc0MZn76g+nr5G1RjoUEbz0s1Qf9PzS2hUp9FwAdM+pUGk2vfUIipj50p2UvJ447aDdqP1Pay6K7ySEGpFpKkl44Ixq/EDXCLxwBJCJNbAfvk2lcECs0qpSHPmXGkJODJazy+QDSLhZv62C2g2XCfJAsIbKTGFDjaG/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779245048; c=relaxed/simple; bh=6WiEvwmNN5itgkroxIolMeit6yFB79ORyzznRi4vnF4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=paudkHvPQ78fvv2s7kxuIdqqCrufL4J8EhhC/XCTKZV7fTcz/NKOrzPtyP6XjVcziVIkTqewRZ4OKOC0d69fxKKGBuZ2Wv80js57RvETWxDbp+T60OElCxLZc98qzNUPJHlMVUnBudsL53g5Dm52RVR6XLL1tVBuu4ABp6+rsAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yr1oIcly; arc=none smtp.client-ip=209.85.217.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yr1oIcly" Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-6312af106e3so3356939137.0 for ; Tue, 19 May 2026 19:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779245046; x=1779849846; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dp0vCDZPCe1rJMQjdKdJy1wpPdZpOogFV+3zlUS9uqk=; b=Yr1oIclyN+6gEcXID/PuNY7SE8CtYQRo51DggxBfP8InBe3mSuHuW7bxJNjbIdUiYk ZOst7ui1hQwfrPYXwWaerSb/QCvSrxZfT5EHriubwSrytQSJxE2tuQdXtA85DJXKVsFV QDk2R4c6S95uU3ysjjh95UQeGBuYU0vDfV7smCEMbEIRDwUMuw4Y0OUHInGxDn5bNowk bmcYK1c3Pgs2J763+BL9gM70nuscCfijhKnFMWi947lXcW1Eq6djkK1I96a2rSN7DOFJ dK7XL1W939KkUvSN4xxzZld/rKPRkvQ8VbYH7pUO5MVUSCLtjpj2BYJJvRWcnbZ3MVSE khQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779245046; x=1779849846; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dp0vCDZPCe1rJMQjdKdJy1wpPdZpOogFV+3zlUS9uqk=; b=KBSAmLdCan1QOTd/SPIv2yrccdo/X1o56D/P7Ogh3lmP656FncT7KBzisbzB4otRgj 2W/U73F77d20czeXun8TmCfwMkwH/3a1XrLzIgGDwA7D+vRhIYyUFbaSCGdiE7jZkP4r gsmWbhyxNyTe5fRqb8yB1640lFmlb3kRMZ1AqGvw0MsOkztltktF8TkH3W4aMW6U4PnZ /dhxyCMvwV5cFqgkeRtvk5Fsh5mhbjxkShUWPb2sMg2s0daK/YmSkskWQhik2RFo3cWp MWB7jRyF9zSB+AFRoimx3rcwgfTIOo8VN8jYT6yT/Zaxk5BBv9hwBBA9OqVPqFbnT5mA gLKA== X-Forwarded-Encrypted: i=1; AFNElJ/XVcEoDB73yrJY0bmRc8RG+jCshuI/F+50hJM2+3FZte4PgtTKPaspljogz1Y9RlFACWnUpn3cWFNiBRI=@vger.kernel.org X-Gm-Message-State: AOJu0YznkFSfB9HzBft1W4fb4fl6/bU3LF8NjaMJPBeuWLWFomVz8ULI 0nQrS+4WTN1a6mR7vegYX+pqHt3AltChmL+bNjm2dCTHwO4q3so9mOjs X-Gm-Gg: Acq92OGXFnFsjXdne7PlhGw5ZC8TqQ8H6bFFoEad0PzYAfnEWY5Dz9Qr4k+rFQGp3ko 2FCk2Gqm3h5DaLr8hQTozgvPPH3xJaqrjaWJpyI04FkZRR8rpnTtosBX16NyxjHUsA56nYcYWh8 4m20/O09be6fc4pzo5r8ys39EjXGZjzhHrHEeGIaTQ5wPTrt9UhYf5dYw8skI340Jk9F4NAK+TA N3PuHar8q33lh4fkr4CJEH8cSttfp22x6Ixv1eptqkfMW2YfCSdsznY7N9qDVwfCtbGt12KZV/Z V7v6NeXzddA4NtrjowxjYFT1CzxFJCTUyYAOizAjCdqlOFzcM0ZSRZbuu3O/uQ3IuGFvDDTKN6n Y4/Rr0Qj5PbZTWZ0/BBIQraKU1lXkcziaxqboVVtlYfpPDs2/Xs3zEI8YlLJgANdnAr/qRXgL5F VDmGo2DGrVkBhBMQ5ChZIJ X-Received: by 2002:a05:6102:6051:b0:634:8685:d335 with SMTP id ada2fe7eead31-63a3ec8c2efmr11368508137.14.1779245045997; Tue, 19 May 2026 19:44:05 -0700 (PDT) Received: from arch ([186.195.35.248]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-95fc2fbe40esm7063186241.11.2026.05.19.19.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 19:44:05 -0700 (PDT) From: AkaLuiz To: David Lin Cc: Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, AkaLuiz Subject: [PATCH] staging: greybus: uart: document locking and fix indentation Date: Tue, 19 May 2026 23:41:28 -0300 Message-ID: <20260520024128.68942-1-luizcarlosmdea@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add comments describing what the lock fields in struct gb_tty protect, and fix the indentation of the wait_for_completion_timeout() call. Signed-off-by: AkaLuiz --- drivers/staging/greybus/uart.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 7d060b4cd33d..85586e9a4341 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -50,12 +50,12 @@ struct gb_tty { unsigned int minor; unsigned char clocal; bool disconnected; - spinlock_t read_lock; - spinlock_t write_lock; + spinlock_t read_lock; /* protects iocount and oldcount for TIOCMIWAIT */ + spinlock_t write_lock; /* protects write_fifo and credits */ struct async_icount iocount; struct async_icount oldcount; wait_queue_head_t wioctl; - struct mutex mutex; + struct mutex mutex; /* protects disconnected during lookup and removal */ u8 ctrlin; /* input control lines */ u8 ctrlout; /* output control lines */ struct gb_uart_set_line_coding_request line_coding; @@ -318,7 +318,7 @@ static int gb_uart_wait_for_all_credits(struct gb_tty *= gb_tty) return 0; =20 ret =3D wait_for_completion_timeout(&gb_tty->credits_complete, - msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC)); + msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC)); if (!ret) { dev_err(&gb_tty->gbphy_dev->dev, "time out waiting for credits\n"); --=20 2.54.0