From nobody Sun May 24 22:43:18 2026 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D47D32B121; Wed, 20 May 2026 22:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779316388; cv=none; b=Dat0SlbRzV4caO/bR/8ecwAZhRztN5LaOdQ1ehSpmQApJs3hY3SifASZ1tB+lAkkymiNgDrnzPS+zB8r+j9zDPotY4yRSF4oyuM9pemkqriSL6SzoeeANymecAdWIN5KL/nDUUNl/v2JswMGz8FzL027sx5t0+7+LPUtktkrvQw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779316388; c=relaxed/simple; bh=RfXaP6M4keIK2c2f+aUEGkwysQSF85AepUYcr3maP38=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bwDTsL2+X21TQLdaKd5pAvYYR3Rq/4IUiQ/fjefGi3FALN1vXE5pL55LK8fm4FA2CIQmUhiF5ZSl8YzXiz8opthhoiTQFTBcBrncG1hBfknAp5ql4+HBWY1mtEKJcoIiQTh7yiPJBYSvBtBfFiqseNWLPCgAc5gdwzAnF7m17nE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=bMP+KuVG; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="bMP+KuVG" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=acQG2Ne0YBrGhFgX5ybV2ljWIOwgSpQAc7km9W2xD08=; b=bMP+KuVGzuIQcS9ojffwWCkO41 AOY8NFcAOeLBmWNlpL3zX1jJ/n7kxRneYVLjkl3Sfqt95NUe3oso3YDxBsrhZ1JMnEf4wankq/+iF HLkL1EtJp/BpGuoS+QW8WsEQd6CgvGKIiA4l8iZzAmJd9qtgLoGKKLN7uBwrdImNi3M4lL64sciUQ +zZBD9DluFx03sjuljDCBObtHptG7qAu0Kqu4t1HZ7ehslw8F5dCwFnHA/iwnS65soIyTrxe5rj3D UUtYwzV8dr3ZLD52R7RNUK0prlXj+uG7P5Dcb/nLo4X9H/ehWOCinPBpCW89T3VSAduRbWVw5XFs5 cdmqd6kw==; Received: from 186-249-145-161.shared.desktop.com.br ([186.249.145.161] helo=[192.168.1.68]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wPpTK-0043AI-7W; Thu, 21 May 2026 00:33:02 +0200 From: Mauricio Faria de Oliveira Date: Wed, 20 May 2026 19:32:50 -0300 Subject: [PATCH 1/2] usb: atm: ueagle-atm: use dev_dbg() for 'device found' message Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260520-ueagle-atm-cleanup-v1-1-010c8bc7b214@igalia.com> References: <20260520-ueagle-atm-cleanup-v1-0-010c8bc7b214@igalia.com> In-Reply-To: <20260520-ueagle-atm-cleanup-v1-0-010c8bc7b214@igalia.com> To: Matthieu CASTET , Stanislaw Gruszka , Greg Kroah-Hartman Cc: kernel-dev@igalia.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Mauricio Faria de Oliveira X-Mailer: b4 0.14.2 Convert dev_info() to dev_dbg(). Per 'Documentation/process/coding-style.rst': 13) Printing kernel messages ... When drivers are working properly they are quiet, so prefer to use dev_dbg/pr_debug unless something is wrong. While in there, correct the verb form and add 'with' for clarity. Suggested-by: Greg Kroah-Hartman Link: https://lore.kernel.org/all/2026051628-squatter-stature-c0e0@gregkh/ Signed-off-by: Mauricio Faria de Oliveira Acked-by: Stanislaw Gruszka --- drivers/usb/atm/ueagle-atm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index f3ae72feb5bfc313ccfa1ab6a9bb40fcd8f5800a..71559a934133a82ddb23d255e0f= 04d018c13c583 100644 --- a/drivers/usb/atm/ueagle-atm.c +++ b/drivers/usb/atm/ueagle-atm.c @@ -2590,7 +2590,7 @@ static int uea_probe(struct usb_interface *intf, cons= t struct usb_device_id *id) int ret; =20 uea_enters(usb); - uea_info(usb, "ADSL device founded vid (%#X) pid (%#X) Rev (%#X): %s\n", + uea_dbg(usb, "ADSL device found with vid (%#X) pid (%#X) Rev (%#X): %s\n", le16_to_cpu(usb->descriptor.idVendor), le16_to_cpu(usb->descriptor.idProduct), le16_to_cpu(usb->descriptor.bcdDevice), --=20 2.51.0 From nobody Sun May 24 22:43:18 2026 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FBB43BE645; Wed, 20 May 2026 22:33:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779316391; cv=none; b=CINFo+Beida6QwbLMth720IoAAPA4OhyOc72TjYNS1RjauFfsdkvDh3HplZb2v2i3nborTeenLIYQ3OrsU3KfFJvKdwwwOOut4VpldfxkqFJpo+eLLrapozEHn8abg9urcWzCbSmdKAqtNnpDqN3EInhsp8kSuIaaW+iVoothW4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779316391; c=relaxed/simple; bh=5/1R74shK3Tn8Bck/o5/nxjVx9PnnRDhcbkZzc/d5kg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ixIFUYuUhznNuM9DySicl3CHBfEAqEM+C5sHzL+GArWkzU5eJBBOybvUvWgKA9PCH5JKHx9qQyWOh4xCnyOOXEAccpmiwi5Zk0O+9ts54oF/PD9jpDZYPhvf0gX9KRHVSbZhCRVtOTiiPTZwJp8JUB8azuYIujv9QjMqjBHd3Tg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=crWfsvE8; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="crWfsvE8" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n83U7pzz5XNbi+6U2kC2vS+HbDYB7ASKXOCxhhwOLnk=; b=crWfsvE8qOzGgW+9r5nxuTdGAo GtGORhILPHDEfqwevZNw78Y/W4qXslGUuqBpHo3KkrxDOcJZcUWgSH6AJyJjLKuzq6o6AiRRfaVrH Xzccq9eVPNtUv/Ky1TctzjwEeRfaTNy0Ap1iuEDyE4ApOvOUuBMCGX7WMvO79X1zBYp0uRwx30vty XQVE6aU0ggvPV+Ds69Ro1eeAekkcdNfX52Qp3ymDTilc47jOx0xB/eSvDKQ1xkNEmiHEtUMmj+oFR 8OHIVi0HbS2lReaKXGes1/sabOQHy+/ziN+1IFpN/43N1PiY7FB0rEa5OxQP7ZjG1uSistM89osvl z0Pxwbfg==; Received: from 186-249-145-161.shared.desktop.com.br ([186.249.145.161] helo=[192.168.1.68]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wPpTM-0043AI-TI; Thu, 21 May 2026 00:33:05 +0200 From: Mauricio Faria de Oliveira Date: Wed, 20 May 2026 19:32:51 -0300 Subject: [PATCH 2/2] usb: atm: ueagle-atm: remove function entry/exit debug messages Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260520-ueagle-atm-cleanup-v1-2-010c8bc7b214@igalia.com> References: <20260520-ueagle-atm-cleanup-v1-0-010c8bc7b214@igalia.com> In-Reply-To: <20260520-ueagle-atm-cleanup-v1-0-010c8bc7b214@igalia.com> To: Matthieu CASTET , Stanislaw Gruszka , Greg Kroah-Hartman Cc: kernel-dev@igalia.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Mauricio Faria de Oliveira X-Mailer: b4 0.14.2 Remove the driver-internal function entry/exit debug messages in favor of existing kernel-level function tracing mechanisms. Suggested-by: Greg Kroah-Hartman Link: https://lore.kernel.org/all/2026051657-scruffy-embark-45ea@gregkh/ Signed-off-by: Mauricio Faria de Oliveira Acked-by: Stanislaw Gruszka --- drivers/usb/atm/ueagle-atm.c | 56 +++++-----------------------------------= ---- 1 file changed, 6 insertions(+), 50 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index 71559a934133a82ddb23d255e0f04d018c13c583..ed2611aacb252fce829b4a33589= c47912aadbe67 100644 --- a/drivers/usb/atm/ueagle-atm.c +++ b/drivers/usb/atm/ueagle-atm.c @@ -51,12 +51,6 @@ "[ueagle-atm vdbg] " format, ##args); \ } while (0) =20 -#define uea_enters(usb_dev) \ - uea_vdbg(usb_dev, "entering %s\n" , __func__) - -#define uea_leaves(usb_dev) \ - uea_vdbg(usb_dev, "leaving %s\n" , __func__) - #define uea_err(usb_dev, format, args...) \ dev_err(&(usb_dev)->dev , "[UEAGLE-ATM] " format , ##args) =20 @@ -606,7 +600,6 @@ static void uea_upload_pre_firmware(const struct firmwa= re *fw_entry, u32 crc =3D 0; int ret, size; =20 - uea_enters(usb); if (!fw_entry) { uea_err(usb, "firmware is not available\n"); goto err; @@ -670,7 +663,6 @@ static void uea_upload_pre_firmware(const struct firmwa= re *fw_entry, uea_err(usb, "firmware is corrupted\n"); err: release_firmware(fw_entry); - uea_leaves(usb); } =20 /* @@ -681,7 +673,6 @@ static int uea_load_firmware(struct usb_device *usb, un= signed int ver) int ret; char *fw_name =3D EAGLE_FIRMWARE; =20 - uea_enters(usb); uea_info(usb, "pre-firmware device, uploading firmware\n"); =20 switch (ver) { @@ -710,7 +701,6 @@ static int uea_load_firmware(struct usb_device *usb, un= signed int ver) else uea_info(usb, "loading firmware %s\n", fw_name); =20 - uea_leaves(usb); return ret; } =20 @@ -1137,7 +1127,6 @@ static int uea_cmv_e1(struct uea_softc *sc, struct cmv_e1 cmv; int ret; =20 - uea_enters(INS_TO_USBDEV(sc)); uea_vdbg(INS_TO_USBDEV(sc), "Function : %d-%d, Address : %c%c%c%c, " "offset : 0x%04x, data : 0x%08x\n", E1_FUNCTION_TYPE(function), @@ -1164,9 +1153,8 @@ static int uea_cmv_e1(struct uea_softc *sc, sizeof(cmv), &cmv); if (ret < 0) return ret; - ret =3D wait_cmv_ack(sc); - uea_leaves(INS_TO_USBDEV(sc)); - return ret; + + return wait_cmv_ack(sc); } =20 static int uea_cmv_e4(struct uea_softc *sc, @@ -1175,7 +1163,6 @@ static int uea_cmv_e4(struct uea_softc *sc, struct cmv_e4 cmv; int ret; =20 - uea_enters(INS_TO_USBDEV(sc)); memset(&cmv, 0, sizeof(cmv)); =20 uea_vdbg(INS_TO_USBDEV(sc), "Function : %d-%d, Group : 0x%04x, " @@ -1199,9 +1186,8 @@ static int uea_cmv_e4(struct uea_softc *sc, sizeof(cmv), &cmv); if (ret < 0) return ret; - ret =3D wait_cmv_ack(sc); - uea_leaves(INS_TO_USBDEV(sc)); - return ret; + + return wait_cmv_ack(sc); } =20 static inline int uea_read_cmv_e1(struct uea_softc *sc, @@ -1295,7 +1281,6 @@ static int uea_stat_e1(struct uea_softc *sc) u32 data; int ret; =20 - uea_enters(INS_TO_USBDEV(sc)); data =3D sc->stats.phy.state; =20 ret =3D uea_read_cmv_e1(sc, E1_SA_STAT, 0, &sc->stats.phy.state); @@ -1438,7 +1423,6 @@ static int uea_stat_e4(struct uea_softc *sc) u32 tmp_arr[2]; int ret; =20 - uea_enters(INS_TO_USBDEV(sc)); data =3D sc->stats.phy.state; =20 /* XXX only need to be done before operationnal... */ @@ -1805,7 +1789,6 @@ static int uea_start_reset(struct uea_softc *sc) u16 zero =3D 0; /* ;-) */ int ret; =20 - uea_enters(INS_TO_USBDEV(sc)); uea_info(INS_TO_USBDEV(sc), "(re)booting started\n"); =20 /* mask interrupt */ @@ -1873,7 +1856,6 @@ static int uea_start_reset(struct uea_softc *sc) return ret; =20 sc->reset =3D 0; - uea_leaves(INS_TO_USBDEV(sc)); return ret; } =20 @@ -1889,7 +1871,6 @@ static int uea_kthread(void *data) int ret =3D -EAGAIN; =20 set_freezable(); - uea_enters(INS_TO_USBDEV(sc)); while (!kthread_should_stop()) { if (ret < 0 || sc->reset) ret =3D uea_start_reset(sc); @@ -1898,7 +1879,7 @@ static int uea_kthread(void *data) if (ret !=3D -EAGAIN) uea_wait(sc, 0, msecs_to_jiffies(1000)); } - uea_leaves(INS_TO_USBDEV(sc)); + return ret; } =20 @@ -1911,8 +1892,6 @@ static int load_XILINX_firmware(struct uea_softc *sc) u8 value; char *fw_name =3D FPGA930_FIRMWARE; =20 - uea_enters(INS_TO_USBDEV(sc)); - ret =3D request_firmware(&fw_entry, fw_name, &sc->usb_dev->dev); if (ret) { uea_err(INS_TO_USBDEV(sc), "firmware %s is not available\n", @@ -1956,7 +1935,6 @@ static int load_XILINX_firmware(struct uea_softc *sc) err1: release_firmware(fw_entry); err0: - uea_leaves(INS_TO_USBDEV(sc)); return ret; } =20 @@ -1966,7 +1944,6 @@ static void uea_dispatch_cmv_e1(struct uea_softc *sc,= struct intr_pkt *intr) struct cmv_dsc_e1 *dsc =3D &sc->cmv_dsc.e1; struct cmv_e1 *cmv =3D &intr->u.e1.s2.cmv; =20 - uea_enters(INS_TO_USBDEV(sc)); if (le16_to_cpu(cmv->wPreamble) !=3D E1_PREAMBLE) goto bad1; =20 @@ -1990,7 +1967,6 @@ static void uea_dispatch_cmv_e1(struct uea_softc *sc,= struct intr_pkt *intr) if (cmv->bFunction =3D=3D E1_MAKEFUNCTION(E1_ADSLDIRECTIVE, E1_MODEMREADY)) { wake_up_cmv_ack(sc); - uea_leaves(INS_TO_USBDEV(sc)); return; } =20 @@ -2004,7 +1980,6 @@ static void uea_dispatch_cmv_e1(struct uea_softc *sc,= struct intr_pkt *intr) sc->data =3D sc->data << 16 | sc->data >> 16; =20 wake_up_cmv_ack(sc); - uea_leaves(INS_TO_USBDEV(sc)); return; =20 bad2: @@ -2012,14 +1987,12 @@ static void uea_dispatch_cmv_e1(struct uea_softc *s= c, struct intr_pkt *intr) "Function : %d, Subfunction : %d\n", E1_FUNCTION_TYPE(cmv->bFunction), E1_FUNCTION_SUBTYPE(cmv->bFunction)); - uea_leaves(INS_TO_USBDEV(sc)); return; =20 bad1: uea_err(INS_TO_USBDEV(sc), "invalid cmv received, " "wPreamble %d, bDirection %d\n", le16_to_cpu(cmv->wPreamble), cmv->bDirection); - uea_leaves(INS_TO_USBDEV(sc)); } =20 /* The modem send us an ack. First with check if it right */ @@ -2028,7 +2001,6 @@ static void uea_dispatch_cmv_e4(struct uea_softc *sc,= struct intr_pkt *intr) struct cmv_dsc_e4 *dsc =3D &sc->cmv_dsc.e4; struct cmv_e4 *cmv =3D &intr->u.e4.s2.cmv; =20 - uea_enters(INS_TO_USBDEV(sc)); uea_dbg(INS_TO_USBDEV(sc), "cmv %x %x %x %x %x %x\n", be16_to_cpu(cmv->wGroup), be16_to_cpu(cmv->wFunction), be16_to_cpu(cmv->wOffset), be16_to_cpu(cmv->wAddress), @@ -2040,7 +2012,6 @@ static void uea_dispatch_cmv_e4(struct uea_softc *sc,= struct intr_pkt *intr) if (be16_to_cpu(cmv->wFunction) =3D=3D E4_MAKEFUNCTION(E4_ADSLDIRECTIVE, E4_MODEMREADY, 1)) { wake_up_cmv_ack(sc); - uea_leaves(INS_TO_USBDEV(sc)); return; } =20 @@ -2053,7 +2024,6 @@ static void uea_dispatch_cmv_e4(struct uea_softc *sc,= struct intr_pkt *intr) sc->data =3D be32_to_cpu(cmv->dwData[0]); sc->data1 =3D be32_to_cpu(cmv->dwData[1]); wake_up_cmv_ack(sc); - uea_leaves(INS_TO_USBDEV(sc)); return; =20 bad2: @@ -2061,7 +2031,6 @@ static void uea_dispatch_cmv_e4(struct uea_softc *sc,= struct intr_pkt *intr) "Function : %d, Subfunction : %d\n", E4_FUNCTION_TYPE(cmv->wFunction), E4_FUNCTION_SUBTYPE(cmv->wFunction)); - uea_leaves(INS_TO_USBDEV(sc)); return; } =20 @@ -2089,8 +2058,6 @@ static void uea_intr(struct urb *urb) struct intr_pkt *intr =3D urb->transfer_buffer; int status =3D urb->status; =20 - uea_enters(INS_TO_USBDEV(sc)); - if (unlikely(status < 0)) { uea_err(INS_TO_USBDEV(sc), "uea_intr() failed with %d\n", status); @@ -2130,8 +2097,6 @@ static int uea_boot(struct uea_softc *sc, struct usb_= interface *intf) int ret =3D -ENOMEM; int size; =20 - uea_enters(INS_TO_USBDEV(sc)); - if (UEA_CHIP_VERSION(sc) =3D=3D EAGLE_IV) { size =3D E4_INTR_PKT_SIZE; sc->dispatch_cmv =3D uea_dispatch_cmv_e4; @@ -2188,7 +2153,6 @@ static int uea_boot(struct uea_softc *sc, struct usb_= interface *intf) goto err2; } =20 - uea_leaves(INS_TO_USBDEV(sc)); return 0; =20 err2: @@ -2198,7 +2162,6 @@ static int uea_boot(struct uea_softc *sc, struct usb_= interface *intf) sc->urb_int =3D NULL; kfree(intr); err0: - uea_leaves(INS_TO_USBDEV(sc)); return ret; } =20 @@ -2208,7 +2171,7 @@ static int uea_boot(struct uea_softc *sc, struct usb_= interface *intf) static void uea_stop(struct uea_softc *sc) { int ret; - uea_enters(INS_TO_USBDEV(sc)); + ret =3D kthread_stop(sc->kthread); uea_dbg(INS_TO_USBDEV(sc), "kthread finish with status %d\n", ret); =20 @@ -2222,7 +2185,6 @@ static void uea_stop(struct uea_softc *sc) flush_work(&sc->task); =20 release_firmware(sc->dsp_firm); - uea_leaves(INS_TO_USBDEV(sc)); } =20 /* syfs interface */ @@ -2495,8 +2457,6 @@ static int uea_bind(struct usbatm_data *usbatm, struc= t usb_interface *intf, int ret, ifnum =3D intf->altsetting->desc.bInterfaceNumber; unsigned int alt; =20 - uea_enters(usb); - /* interface 0 is for firmware/monitoring */ if (ifnum !=3D UEA_INTR_IFACE_NO) return -ENODEV; @@ -2589,7 +2549,6 @@ static int uea_probe(struct usb_interface *intf, cons= t struct usb_device_id *id) struct usb_device *usb =3D interface_to_usbdev(intf); int ret; =20 - uea_enters(usb); uea_dbg(usb, "ADSL device found with vid (%#X) pid (%#X) Rev (%#X): %s\n", le16_to_cpu(usb->descriptor.idVendor), le16_to_cpu(usb->descriptor.idProduct), @@ -2620,7 +2579,6 @@ static void uea_disconnect(struct usb_interface *intf) { struct usb_device *usb =3D interface_to_usbdev(intf); int ifnum =3D intf->altsetting->desc.bInterfaceNumber; - uea_enters(usb); =20 /* ADI930 has 2 interfaces and eagle 3 interfaces. * Pre-firmware device has one interface @@ -2631,8 +2589,6 @@ static void uea_disconnect(struct usb_interface *intf) mutex_unlock(&uea_mutex); uea_info(usb, "ADSL device removed\n"); } - - uea_leaves(usb); } =20 /* --=20 2.51.0