From nobody Mon May 25 00:10:14 2026 Received: from mail-ej1-f74.google.com (mail-ej1-f74.google.com [209.85.218.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A100234B183 for ; Wed, 20 May 2026 09:40:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779270051; cv=none; b=S0KlBirYgj7njZEbD66e2WRPJX2jlnsQVzqL+b8fHWYe4BQ6E8bLZoeqc8A5iN6u2DaWuAlw3rgdeDQL0DLJfqVGzWz62io8ejjLjVpryxMYsKNQ/EqVNj3/4fwGJidIXu78TSm12dxSDEXerFR2VcLJobgcmfz5SAYP2BKgfoA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779270051; c=relaxed/simple; bh=lKom9UTw1WehL2PBXSRisw+Lkyc8BEm/Zjtk+6IGJrU=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=m0vjN5Tw2svxUKqc8AOCp+VOmGUfVWi7CPoz6yhaL9u8AiBs0JhRfHbYyWSismCjmJ0L737DHUIGuqavfhrFwp3+Hwj+ONNujl+RW+q8AV5GuW2xLUlIDz3dhNOn9fKKox6Kb2K02YPyvWqqdFH5tmIM8DNEVEaQJPksHjbaCvQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--sidnayyar.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OvDrpbCO; arc=none smtp.client-ip=209.85.218.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--sidnayyar.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OvDrpbCO" Received: by mail-ej1-f74.google.com with SMTP id a640c23a62f3a-bd31fa4b1b8so440656366b.2 for ; Wed, 20 May 2026 02:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779270046; x=1779874846; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=9g8XT+Bh4N5cFmthEloiR2bFLHwmyEYitwYQWyR1h7U=; b=OvDrpbCOdDR/nIGLrVPasb05k6bTOggrPn+q8oxqKk41etMZQTsCqHyHNLYLnjvLLq btI3U79TJY1RFM0hbGRowa4frdEvwrHOcn2EY+3y39eA7dKGx4nzeywuTHR1m1aqrlRd vMtmVnCPdfFLv0I1t/nSbsonSk5cCnQcCif4kFQspsAY2SZ5vRgtK3h91KkLo2EC0Y9Q VJPKFiAdV55KxYDmjP98r3uW/oUwL+o047zhSPLB9re+pVO4y8mnWjDHWfgh3mG7FGHC ztDyyoh//JrTgi9/Cw7wBHz5tOAED1GwVJKD+FNeGzGAa6nmWndWqt7bivFPn3kv1ONM nOCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779270046; x=1779874846; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9g8XT+Bh4N5cFmthEloiR2bFLHwmyEYitwYQWyR1h7U=; b=km6bNUw6x4Sqf1gkj9R+ynVCT1BrO4qKJDIbxl9k5MWE/e1HmHUirTI9mZ2DdKq6nl hAAvKhlz4GTBXZ8jS6JIo/2tRwle+lUxYngwDeM5y6l7hls7y6XP0UdHCYgNdZGH2KbM +/nM7oap0T4+9zuoDBaHo7ENSE6Zs5GXRF0WpUj3wazFfYxESExciVqGAuyzwcnYImTl C5bgdrfOncrTUEATTEGGNIEFDBiOCAXEiy3XsSNl7OLpcojBEN1VR4j1WfTn7KwcNlME ReCrOL9NZyTVfcT07ja8RYXGtR/BjdsnTjw715+10UmOtW0Xx9E/yTxDk0+LrqzmBebe DZNg== X-Forwarded-Encrypted: i=1; AFNElJ9vAGCG30/sflk1akpZmyrwzEv570A2f1xEN3Gk+jPNan6Q5gYWWEXu1CMykG3FXgn8X/0jmW9afcktr90=@vger.kernel.org X-Gm-Message-State: AOJu0Yyjh0+BwOudLWj+CA6UvdkjAhWJdKbTdvPjXr0aThq2RhXv4GgB YGPhxlxKq0xuiceL/GLdvJLemmS8lcdbVP9Ln/M0WJQl4lncKhf6cX09Q3xbnhR8cuHQlwNTFn9 jzreSfDg1f07NqI6plA== X-Received: from ejcdt4.prod.google.com ([2002:a17:907:7284:b0:bcb:43e0:b835]) (user=sidnayyar job=prod-delivery.src-stubby-dispatcher) by 2002:a17:907:a807:b0:bd4:f854:27b5 with SMTP id a640c23a62f3a-bd5177da46bmr1444350366b.9.1779270045541; Wed, 20 May 2026 02:40:45 -0700 (PDT) Date: Wed, 20 May 2026 09:40:44 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAJuBDWoC/x2MWwqAIBAArxL7ndDLXleJkLCt9kfFtSikuyd9z sBMBEZPyDBmETxexGRNgjLPQB+L2VHQmhiqomoLWQ6Cgz91UNax2tGo8DirNrqFHFZZd02vUSO k2nlM+j9P8/t+boSY4mkAAAA= X-Change-Id: 20260519-struct_ops_gen_typo_fix-59d53748cece X-Mailer: b4 0.14.3 Message-ID: <20260520-struct_ops_gen_typo_fix-v1-1-4dee3771da46@google.com> Subject: [PATCH] bpftool: fix typo in struct_ops map FD generation for light skeleton From: Siddharth Nayyar To: Quentin Monnet , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa , Mykyta Yatsenko Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, gprocida@google.com, maennich@google.com, Siddharth Nayyar Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable When generating light skeletons for BPF programs containing struct_ops maps, bpftool incorrectly outputs a stray literal 't' instead of a tab character for the map file descriptor member in the links structure. This causes a compilation error when the generated light skeleton is used. Correct the format string by replacing 't' with '\t'. Fixes: 08ac454e258e ("libbpf: Auto-attach struct_ops BPF maps in BPF skelet= on") Signed-off-by: Siddharth Nayyar Acked-by: Quentin Monnet --- tools/bpf/bpftool/gen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/bpf/bpftool/gen.c b/tools/bpf/bpftool/gen.c index 2f9e10752e28..d6040b52d4e1 100644 --- a/tools/bpf/bpftool/gen.c +++ b/tools/bpf/bpftool/gen.c @@ -1399,7 +1399,7 @@ static int do_skeleton(int argc, char **argv) continue; =20 if (use_loader) - printf("t\tint %s_fd;\n", ident); + printf("\t\tint %s_fd;\n", ident); else printf("\t\tstruct bpf_link *%s;\n", ident); } --- base-commit: c6e99c10fd9855082568cbd71bb2cc5dc90eda53 change-id: 20260519-struct_ops_gen_typo_fix-59d53748cece Best regards, --=20 Siddharth Nayyar