From nobody Mon May 25 00:55:39 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F8983AFCEA; Wed, 20 May 2026 08:19:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779265160; cv=none; b=I1oSk146ZiQn+DAt537e84HO8f41OBem9lo2jI2ishaHqBOkFkPQzQ55RYtJLGMI7ZEw957dgkeelViHh3ygRdaQzl2AeqbCYBL1y2a4cRgjUeM7yt03KrygMBa3p01T7JWr6HwsuCECvHCrNy7KHiXUQRSXXyf5d2xEBU7ja8Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779265160; c=relaxed/simple; bh=egsexhbhZMn6N2VNXPeFT9FZiiU9sNsftvujWkJEIxM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mPj2tGoNFeM6xI3t5/q81a9yWIs+rXSU9M7gOwjbt34zFcdrLDNJQLfd1+FR0KJOTK/ilL2FG+dKd/SHHf7X91r5hSpEiPA2sPrmtZ+0B4qy2i3fj9iBRcwVB2MNa6zN3zJ8lo0oU8DENpe22mzJdmOjHam70ii9lCUAQQpivIA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QGRWwolu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QGRWwolu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A23C1F00893; Wed, 20 May 2026 08:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779265158; bh=GVDlYomtipo4qtAHTcknpPeYaQN/qiVuV/EAqg0FNOE=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=QGRWwoluHB1wxqmq1NnHTwUGrOw0HmNcITLn8Pe3aTepQ46r2jdkcAYNLOmQLC6Ws fAO7nMcK4IAkEmw7q1Rz88yVzOt27cWANLTYW1boJbIknXERD1KFDTQKy4tYZOuC8K Xa83/+bLmy01KovNY7i3HHz3XSz0Y55T2cD1454db7Enrehvtwru2MztE1Skbw8C6K TzwzSQ9MpvS02tzUSDzYmwgI436vCppFZB1Rztx7znFzz5ZPc7GKf2Bv7bJ/FVIRKG DWbYxGBPnHJkKZKcVSZ0d3B7MBNCEqN4D1I+B9cReO5mepsJHAHs9ie8fqs14ga6GT +nHHtsTbiaf7Q== From: "Mike Rapoport (Microsoft)" Date: Wed, 20 May 2026 11:18:55 +0300 Subject: [PATCH 1/3] selinux: use k[mz]alloc() to allocate temporary buffers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260520-security-v1-1-831bd8e21dd0@kernel.org> References: <20260520-security-v1-0-831bd8e21dd0@kernel.org> In-Reply-To: <20260520-security-v1-0-831bd8e21dd0@kernel.org> To: James Morris , John Johansen , Ondrej Mosnacek , Paul Moore , "Serge E. Hallyn" , Stephen Smalley Cc: Mike Rapoport , apparmor@lists.ubuntu.com, selinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2557; i=rppt@kernel.org; h=from:subject:message-id; bh=egsexhbhZMn6N2VNXPeFT9FZiiU9sNsftvujWkJEIxM=; b=owEBbQGS/pANAwAKATkDhibLDv2RAcsmYgBqDW51z/2b9a1wBbACD7Lqy3AESWFSJG96Ft/Fc u9GHWORn7qJATMEAAEKAB0WIQR45VhVpZkvn3TRr+k5A4Ymyw79kQUCag1udQAKCRA5A4Ymyw79 kesfB/95neKLPMgBSsir1CVvO5hzi/mjOmpGVmukHgd+jj7BYpflrDOxXDEgBs6XHWLBXr6p9JI xvWliqXNwwYOaRYZrG10Gbl4vCSoFGOQPMOCctQQm9FEIATJM8lY9frjkw41Nd9vpyDWOUNoaB2 3KByTXQIPueuUKZKZxZf990V0FXHun2IroxnjikC7dbpoD+Ok7KlOfCucRjXTKN283DLquejXI/ MXWd19xgl5hyQaJR8l/0oPy+zZfbJBFZRt//57o+nv0whqgh4IDwfpdTwytJ50DBSSXdYZ7OH1j GtKAKh+ZMI9rY83yzUXjIC1ZjMGgzVRheIfJSJrbV+SP0mx7 X-Developer-Key: i=rppt@kernel.org; a=openpgp; fpr=B8E96E880C4A40C3C1255AA8C532392DE6DA7CE9 Several functions in selinuxfs.c allocate temporary buffers using __get_free_page() or get_zeroed_page(). These buffers are used either to store a string generated by snprintf() (in sel_make_bools()) or to copy data from user (sel_read_avc_hash_stats() and sel_read_sidtab_hash_stats()). Such usage does not require struct page access and it is better to allocate these buffers with kzalloc()/kmalloc() that provide better scalability and more debugging possibilities. Replace use of get_zeroed_page() with kzalloc() and usage of __get_free_page() with kmalloc(). Link: https://lore.kernel.org/all/635405e4-9423-4a25-a6e7-e03c8ea0bcbe@redh= at.com Signed-off-by: Mike Rapoport (Microsoft) --- security/selinux/selinuxfs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c index 25ca7d714014..e7b884eedf80 100644 --- a/security/selinux/selinuxfs.c +++ b/security/selinux/selinuxfs.c @@ -1244,7 +1244,7 @@ static int sel_make_bools(struct selinux_policy *newp= olicy, struct dentry *bool_ char **names, *page; u32 i, num; =20 - page =3D (char *)get_zeroed_page(GFP_KERNEL); + page =3D kzalloc(PAGE_SIZE, GFP_KERNEL); if (!page) return -ENOMEM; =20 @@ -1290,7 +1290,7 @@ static int sel_make_bools(struct selinux_policy *newp= olicy, struct dentry *bool_ ret =3D sel_attach_file(bool_dir, names[i], inode); } out: - free_page((unsigned long)page); + kfree(page); return ret; } =20 @@ -1349,14 +1349,14 @@ static ssize_t sel_read_avc_hash_stats(struct file = *filp, char __user *buf, char *page; ssize_t length; =20 - page =3D (char *)__get_free_page(GFP_KERNEL); + page =3D kmalloc(PAGE_SIZE, GFP_KERNEL); if (!page) return -ENOMEM; =20 length =3D avc_get_hash_stats(page); if (length >=3D 0) length =3D simple_read_from_buffer(buf, count, ppos, page, length); - free_page((unsigned long)page); + kfree(page); =20 return length; } @@ -1367,7 +1367,7 @@ static ssize_t sel_read_sidtab_hash_stats(struct file= *filp, char __user *buf, char *page; ssize_t length; =20 - page =3D (char *)__get_free_page(GFP_KERNEL); + page =3D kmalloc(PAGE_SIZE, GFP_KERNEL); if (!page) return -ENOMEM; =20 @@ -1375,7 +1375,7 @@ static ssize_t sel_read_sidtab_hash_stats(struct file= *filp, char __user *buf, if (length >=3D 0) length =3D simple_read_from_buffer(buf, count, ppos, page, length); - free_page((unsigned long)page); + kfree(page); =20 return length; } --=20 2.53.0 From nobody Mon May 25 00:55:39 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11FE43AE184; Wed, 20 May 2026 08:19:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779265164; cv=none; b=Hr3IIU3u7UG9Oref/KQfis0tgHNwL+21SuQPPIxc13ZObeAmtRWYBDrIoBM/lpJxTQEoB/aWLa3h+zSCAhH9rsTBikh4OeIpw7zqKR+TLobaEIkdZ4K8F6TltIeJQ3+qQD+dB5wTybJeMSTPTkwYXJr5pbSFoJMr7jv2CZJDYaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779265164; c=relaxed/simple; bh=F5N75Y8mUQYU1TgbgAwnzxz6xj0Y0zUFBQbr3qsftFc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MkT3lhNz1Pqm2tnjDRqDGao1JPumYMTGLZWLw5vjH5tFChB7YU4mOxKEu9HeYWnuc2hQRokGsBQbUdqPeo9sBF7w9z8poc2uYcRLssSvQmfaD9UvYZj889HtKJGejaP0jz9aYmIfQzrs1S01I44HZsrlBoLdBi3lw++/bj4lbe8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Fcgnwf+N; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Fcgnwf+N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BBAD1F000E9; Wed, 20 May 2026 08:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779265161; bh=zQRjpjIyAer953PPORKHqLJlFZ+L04n/ATscYla4KeM=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=Fcgnwf+NkTvhc7Mit+rAGitTzJZDlSEN/uHXD+gkXTB4npyMOpLlukZugq5ohxYtX lp6Azi92eVPhKV2Of6k/TAuTwG5evXZE5iWXANKE368n2gb20O7Yk1D8poK4bptGLN gKe8i674mGmddBOIeCjCdBQZB++cVpQ3pABKGDDtYv1sDVGuBJybOROagMRccDcSYN IOJ+03oCmUzYmIeuCTV917LSALVXG/MOjKC37dj+ruYComBK3Zm/MddcvAxEHycf0d 5NeR4M53U0lDs0Dt7niUyxN8BHwvrWRr2eCyzFovqPzYoGX+jRtPZSSK5eflbyRre6 JMGR0/leTjL/g== From: "Mike Rapoport (Microsoft)" Date: Wed, 20 May 2026 11:18:56 +0300 Subject: [PATCH 2/3] selinux: hooks: use __getname() to allocate path buffer Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260520-security-v1-2-831bd8e21dd0@kernel.org> References: <20260520-security-v1-0-831bd8e21dd0@kernel.org> In-Reply-To: <20260520-security-v1-0-831bd8e21dd0@kernel.org> To: James Morris , John Johansen , Ondrej Mosnacek , Paul Moore , "Serge E. Hallyn" , Stephen Smalley Cc: Mike Rapoport , apparmor@lists.ubuntu.com, selinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1022; i=rppt@kernel.org; h=from:subject:message-id; bh=F5N75Y8mUQYU1TgbgAwnzxz6xj0Y0zUFBQbr3qsftFc=; b=owEBbQGS/pANAwAKATkDhibLDv2RAcsmYgBqDW55/xeAuypW72Duwu823AN1y512GZtlik/jj f9D/szH8CKJATMEAAEKAB0WIQR45VhVpZkvn3TRr+k5A4Ymyw79kQUCag1ueQAKCRA5A4Ymyw79 kZuWB/43kQ89qeDN/5ULkrNOC7BisGyehYajp/+I5dGOiekEQFVDn0eaXHd2QTlf2f+hnv9BbpS fupeiqIj/Ou0trjtruRc0roPfmTRWNl9OxfhUuaSxc9GbFpfOSSmDFlvcmAvuVfqHGwLIFMFssG 8mm454MTwB23N3EFSGJSY2MNo4gGywEW6qmCrvBydmM27UydkD17stPOyxleOIbhjcFw9EU+Tbb +ElbtkFJ9OCCiKpoaEQ2mt0A6m1jr7ibLlu4TaUUYxaBcV2k/0oDtw0F6cQCRfH5oKGirJnU7/p mu1k/3MeSbO7pTCcTcyGil3l1Jnug1PwZNhjPyZbODCzEwv3 X-Developer-Key: i=rppt@kernel.org; a=openpgp; fpr=B8E96E880C4A40C3C1255AA8C532392DE6DA7CE9 selinux_genfs_get_sid() allocates memory for a path with __get_free_page() although there is a dedicated helper for allocation of file paths: __getname(). Replace __get_free_page() for allocation of a path buffer with __getname(). Signed-off-by: Mike Rapoport (Microsoft) --- security/selinux/hooks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 0f704380a8c8..05b84b3781e0 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -1336,7 +1336,7 @@ static int selinux_genfs_get_sid(struct dentry *dentr= y, struct super_block *sb =3D dentry->d_sb; char *buffer, *path; =20 - buffer =3D (char *)__get_free_page(GFP_KERNEL); + buffer =3D __getname(); if (!buffer) return -ENOMEM; =20 @@ -1361,7 +1361,7 @@ static int selinux_genfs_get_sid(struct dentry *dentr= y, rc =3D 0; } } - free_page((unsigned long)buffer); + __putname(buffer); return rc; } =20 --=20 2.53.0 From nobody Mon May 25 00:55:39 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0198A3B4EA5; Wed, 20 May 2026 08:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779265167; cv=none; b=rjVcbPXAHKV2CZULk9yjpwm+A2tRF5F4/osbjJWqpoyWcCpQy+/GM6pQ3f/uBoLJj4Mkg+n91ddipZNCzQdLMmBm4fTcgQr8JGXdlKdCkhZss8VxuhgVignowIFZPhcxnaXAinPtcnD/GL8b+t5zqt5la0jBgil9nqSIHpd8tQ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779265167; c=relaxed/simple; bh=+ey+joQwrn1qEqiykmTx8dcM/5TMNFhXgYB3MVPrqgk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EqO36U48QLRZ/TE80EIabhU7HwjvmImGRRPlPHA5wX8tvmLsF7PPIk1S2SyORrjHw1WyIQRnGvz35N0n8rEfJbqrRrw+Rrn4IcGM9hF0jX9j9ejKkgBLixO1oxtq+7Q2AKuM2kljK/ASJCV66G6fYonJoSEDLLeA+ynwxWYObXk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dhrtBEWS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dhrtBEWS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D39A1F00893; Wed, 20 May 2026 08:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779265164; bh=z/4rfPWQ5HkZJZbwpLmw5R+Mmu26rwOzXYpZdnVV9Dk=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=dhrtBEWShLy1GXu88WxKJts8sqyBs3VBaS/0WLRV9zaUqdWgXLHfayljVW97Fzzt4 7RtyF7wImuoFzhQU2h1L/9hdvim4iIBcz+tYzmJARLjMnGtyMGEVbK6TanLVgv5ezd pl2W90AdTAhfQYtdHrNc/ZaD6QYOJsb+tmCa4s+FcbkkL1YVX+LulzmbDC0pnq4PMo DOm/1SfLkw4tBV6zjcUB1mSnHQb6DFgEY8+1JAf3u3TUVlgsOTyhBBEs84dzpl+0hv Io6iD2BfJBbqMYv94X1UXa0e+rWghxaGSLk/NiWOlAMkORwV4u37I9g6gA5eJAi3h2 jYSNBO2FU/hAg== From: "Mike Rapoport (Microsoft)" Date: Wed, 20 May 2026 11:18:57 +0300 Subject: [PATCH 3/3] apparmor: replace get_zeroed_page() with kzalloc() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260520-security-v1-3-831bd8e21dd0@kernel.org> References: <20260520-security-v1-0-831bd8e21dd0@kernel.org> In-Reply-To: <20260520-security-v1-0-831bd8e21dd0@kernel.org> To: James Morris , John Johansen , Ondrej Mosnacek , Paul Moore , "Serge E. Hallyn" , Stephen Smalley Cc: Mike Rapoport , apparmor@lists.ubuntu.com, selinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1580; i=rppt@kernel.org; h=from:subject:message-id; bh=+ey+joQwrn1qEqiykmTx8dcM/5TMNFhXgYB3MVPrqgk=; b=owEBbQGS/pANAwAKATkDhibLDv2RAcsmYgBqDW58nz384TTzPZOUrhMG7PeyvhDRvKQD8RIHd PLEfs78XJeJATMEAAEKAB0WIQR45VhVpZkvn3TRr+k5A4Ymyw79kQUCag1ufAAKCRA5A4Ymyw79 kTbyCACtJ9ZYDN3YybRMNR2UBnLXfQyIAs1SRXhO192EBvmpN0Vt1m1sNk+uZlH2OVV5dTRBzer ZUVu6/sROZL71OF1VFySzWa2xD3gLaKVlDyPHe7gMBIdFhQXjQSEkzNGbSjvJOMChXiBsUYfHoP 8/amlGCtmTomdv0rSvCj0jqMgMKqzQRqkZNjEH90UwnQthW1EMjaZxKlluFPBguq2912ZX3N37M 39ADj+W0iqAhCINM5YCk/d6G5x1kKmOGD0cVEdms7dn/8CLb7b/5BGRj4tIG1uoK+Yn+hh31hYu 1+YvsR3KShRortBO77alQvQ9eR/1ZUROdSNcuV07i91Ita/k X-Developer-Key: i=rppt@kernel.org; a=openpgp; fpr=B8E96E880C4A40C3C1255AA8C532392DE6DA7CE9 multi_transaction_new() allocates memory with get_zeroed_page() and uses it as struct multi_transaction. The usage of that structure does not require struct page access and it is better to allocate multi_transaction objects with kzalloc() that provides better scalability and more debugging possibilities. Replace use of get_zeroed_page() with kzalloc(). Link: https://lore.kernel.org/all/635405e4-9423-4a25-a6e7-e03c8ea0bcbe@redh= at.com Signed-off-by: Mike Rapoport (Microsoft) --- security/apparmor/apparmorfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c index ededaf46f3ca..e5c99c71e7ca 100644 --- a/security/apparmor/apparmorfs.c +++ b/security/apparmor/apparmorfs.c @@ -9,6 +9,7 @@ */ =20 #include +#include #include #include #include @@ -904,7 +905,7 @@ static void multi_transaction_kref(struct kref *kref) struct multi_transaction *t; =20 t =3D container_of(kref, struct multi_transaction, count); - free_page((unsigned long) t); + kfree(t); } =20 static struct multi_transaction * @@ -947,7 +948,7 @@ static struct multi_transaction *multi_transaction_new(= struct file *file, if (size > MULTI_TRANSACTION_LIMIT - 1) return ERR_PTR(-EFBIG); =20 - t =3D (struct multi_transaction *)get_zeroed_page(GFP_KERNEL); + t =3D kzalloc(PAGE_SIZE, GFP_KERNEL); if (!t) return ERR_PTR(-ENOMEM); kref_init(&t->count); --=20 2.53.0