From nobody Sun May 24 23:30:57 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5C512D3EC1 for ; Wed, 20 May 2026 13:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284185; cv=pass; b=W4T/px/xUYZEjs+CCl0oAy411Gb70QxnGsr4qr1sc3QnpScEGvA/mud9zI+OZPXNXu1/5h/7kW0gZwmYolmiUjIbVp4n5UGfb6ieDu0dlESJoSSTD0asPi6PAgYTTutS6koB7vTPjrihw64bU6RcF8Ybe417ZY6EK2Kt3Xr56jM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284185; c=relaxed/simple; bh=OEINEnz0oIEeN8AGE7WELgO/x6vFeg1ru5MOk4XXuLY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rLzXck9gqzY/KQyoZKpmryHv67iHtB25qqtcZCz1tshYbmbvFnjIXOeXWFTYKsLIP5g47GdSNraNNeLZ1ZL+LHFYuBig8+6Y3dd5FSUVysg2XBLPXTcOls49cXw1AF+n/TcMS3ezflGhacGO38sq6+T4Q3+o4RCHJssBwGAHpbc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=c1Ydt3Kr; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="c1Ydt3Kr" ARC-Seal: i=1; a=rsa-sha256; t=1779284140; cv=none; d=zohomail.com; s=zohoarc; b=hTE+Anh1Nu4iUQhm884VSoeT27Hw7dSBvGLCdmHpVCSNAjVkYsLSs9eElrXgc3BdDMaEcpsPzIS6FZZ3tv7otrfbiHHIYSNpgs4f0ydX0HSxQEfWkmSnh0pIPhUTjvgpuMNWERPt3XbPJ+HVMiEJkgy1lB00LqsZFtsFbb+V7so= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779284140; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=3jjnduw6kYgb6GJQpcvuvNDBFXd2EsVZ8wd/7sE0lnA=; b=A2rDnOCHpQS5SfbcGVztB1KTSeZMDaYfKcf9ph6zqRdwnDOEYy8LXt8ak0OKrmRRGfkP6hm2JFdu3ruQFZwVxFgIQT4AiShUqxYw2wT9uq1+PJOkz61QoWVZ2e6xPO53jGi09c/+LVRl8IYJ2ieV7WedR7O1nQy+iRsF+BHqXsQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779284140; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=3jjnduw6kYgb6GJQpcvuvNDBFXd2EsVZ8wd/7sE0lnA=; b=c1Ydt3Krg+KhtfnSlGh+OJIH+SPudvH/bX/svbMgC2qNA8O06LAV2XL0BrJnFnPV a/neTUwYPRdA046d4Rvvmh2lYxJVmOtPiW7clOBWor5kIk3ripoyWMf8Y0wUncOKOwp ZlAVlU0I3uxz3eGa72z7RKre2EfajLrKe6EcZNk8= Received: by mx.zohomail.com with SMTPS id 1779284137490261.2177283866233; Wed, 20 May 2026 06:35:37 -0700 (PDT) From: Nicolas Frattaroli Date: Wed, 20 May 2026 15:35:14 +0200 Subject: [PATCH v2 1/3] drm/scdc-helper: Add scdc_status debugfs entry Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260520-scdc-link-health-v2-1-511af18cd64b@collabora.com> References: <20260520-scdc-link-health-v2-0-511af18cd64b@collabora.com> In-Reply-To: <20260520-scdc-link-health-v2-0-511af18cd64b@collabora.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Daniel Stone Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Nicolas Frattaroli X-Mailer: b4 0.15.2 SCDC provides status information on the current display link. At the very least, it may be useful to expose this info through debugfs. Add a debugfs entry for it under the connector, which displays a few more details parsed out of the SCDC registers. A new drm_scdc_debugfs_init function can be called by the connector implementation to initialise the debugfs file. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/display/drm_scdc_helper.c | 229 ++++++++++++++++++++++++++= ++++ include/drm/display/drm_scdc_helper.h | 56 ++++++++ 2 files changed, 285 insertions(+) diff --git a/drivers/gpu/drm/display/drm_scdc_helper.c b/drivers/gpu/drm/di= splay/drm_scdc_helper.c index df878aad4a36..d582ba38a610 100644 --- a/drivers/gpu/drm/display/drm_scdc_helper.c +++ b/drivers/gpu/drm/display/drm_scdc_helper.c @@ -24,11 +24,14 @@ #include #include #include +#include #include +#include =20 #include #include #include +#include #include =20 /** @@ -55,6 +58,11 @@ =20 #define SCDC_I2C_SLAVE_ADDRESS 0x54 =20 +struct scdc_debugfs_priv { + struct drm_connector *connector; + struct drm_scdc_state state; +}; + /** * drm_scdc_read - read a block of data from SCDC * @adapter: I2C controller @@ -276,3 +284,224 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct drm_co= nnector *connector, return true; } EXPORT_SYMBOL(drm_scdc_set_high_tmds_clock_ratio); + +/** + * drm_scdc_read_status0_flags - Read SCDC "Status Flags" Register + * @connector: pointer to &struct drm_connector to issue the scdc request = on + * @flags: pointer to the caller's &struct drm_scdc_status_flags to output= to + * + * Reads the SCDC Status Flags 0 register, and outputs its contents to the + * destination @flags. Contents of @flags.status0 is only valid if function + * returns 0. + * + * Returns: %0 on success, negative errno on error. + */ +int drm_scdc_read_status0_flags(struct drm_connector *connector, + struct drm_scdc_status_flags *flags) +{ + int ret; + + ret =3D drm_scdc_writeb(connector->ddc, SCDC_UPDATE_0, SCDC_STATUS_UPDATE= ); + if (ret) + return ret; + + return drm_scdc_readb(connector->ddc, SCDC_STATUS_FLAGS_0, &flags->status= 0.data); +} +EXPORT_SYMBOL(drm_scdc_read_status0_flags); + +/** + * drm_scdc_read_error_counters - Read and clear SCDC error counters + * @connector: pointer to &struct drm_connector to issue the scdc request = on + * @counter: Caller's u16 array with 3 elements to write the counter value= s into + * + * Read the SCDC channel error counters. If the count of channel *n* is va= lid, + * write it into counter[n]. Otherwise, set counter[n] to 0. Reads all cou= nters + * in one read chunk, then clears every counter, as is mandated. + * + * Returns: %0 on success, negative errno on error. + */ +int drm_scdc_read_error_counters(struct drm_connector *connector, u16 coun= ter[3]) +{ + u8 buf[7] =3D { 0 }; + ssize_t ret; + u8 sum =3D 0; + int i; + + ret =3D drm_scdc_writeb(connector->ddc, SCDC_UPDATE_0, SCDC_CED_UPDATE); + if (ret) + return ret; + + /* why in the fucking fuck does this return a ssize_t */ + ret =3D drm_scdc_read(connector->ddc, SCDC_ERR_DET_0_L, buf, ARRAY_SIZE(b= uf)); + if (ret) + return ret; + + /* + * Verify the "checksum", i.e. sum up everything including the checksum + * register as a wrapping unsigned 8-bit addition and verify it's 0. + */ + for (i =3D 0; i < ARRAY_SIZE(buf); i++) + sum =3D wrapping_add(u8, sum, buf[i]); + + if (sum) + return -EPROTO; + + for (i =3D 0; i < ARRAY_SIZE(buf) - 1; i +=3D 2) { + if (buf[i + 1] & SCDC_CHANNEL_VALID) + counter[i / 2] =3D buf[i] | (buf[i + 1] & ~SCDC_CHANNEL_VALID) << 8; + else + counter[i / 2] =3D 0; + + buf[i] =3D 0; + buf[i + 1] =3D 0; + } + buf[ARRAY_SIZE(buf) - 1] =3D 0; + + return drm_scdc_write(connector->ddc, SCDC_ERR_DET_0_L, buf, ARRAY_SIZE(b= uf)); +} +EXPORT_SYMBOL(drm_scdc_read_error_counters); + +/** + * drm_scdc_read_state - Update state from SCDC + * @connector: pointer to a &struct drm_connector on which to operate on + * @state: pointer to a &struct drm_scdc_state to fill + * + * Reads update flags from SCDC, and updates the parts of @state that SCDC + * claims have changed, as well as populating those where such a distincti= on + * can't be made. + * + * Returns: %0 on success, negative errno on failure. + */ +int drm_scdc_read_state(struct drm_connector *connector, struct drm_scdc_s= tate *state) +{ + u8 upd_flags[2] =3D { 0 }; + struct i2c_adapter *ddc; + struct drm_scdc *scdc; + int ret; + u8 val; + + if (!state || !connector) + return -ENODEV; + + scdc =3D &connector->display_info.hdmi.scdc; + ddc =3D connector->ddc; + + if (!scdc->supported) + return -EOPNOTSUPP; + + ret =3D drm_scdc_readb(ddc, SCDC_TMDS_CONFIG, &val); + if (ret) + return ret; + + state->scrambling_enabled =3D !!(val & SCDC_SCRAMBLING_ENABLE); + state->tmds_bclk_x40 =3D !!(val & SCDC_TMDS_BIT_CLOCK_RATIO_BY_40); + + state->scrambling_detected =3D drm_scdc_get_scrambling_status(connector); + + ret =3D drm_scdc_read(ddc, SCDC_UPDATE_0, &upd_flags, sizeof(upd_flags)); + if (ret) + return ret; + + if (upd_flags[0] & SCDC_STATUS_UPDATE) { + ret =3D drm_scdc_read_status0_flags(connector, &state->stf); + if (ret) + return ret; + } + + if (upd_flags[0] & SCDC_CED_UPDATE) { + ret =3D drm_scdc_read_error_counters(connector, state->error_count); + if (ret) + return ret; + } + + return 0; +} +EXPORT_SYMBOL(drm_scdc_read_state); + +#define scdc_print_str(_f, key, s) \ + (seq_printf((_f), "%-30s: %s\n", (key), (s))) +#define scdc_print_flag(_f, key, val) \ + (scdc_print_str((_f), (key), str_yes_no((val)))) +#define scdc_print_dec(_f, key, val) \ + (seq_printf((_f), "%-30s: %d\n", (key), (val))) + +static int scdc_status_show(struct seq_file *m, void *data) +{ + struct scdc_debugfs_priv *priv =3D m->private; + struct drm_scdc_state *st =3D &priv->state; + struct drm_connector *connector =3D priv->connector; + struct drm_scdc *scdc =3D &connector->display_info.hdmi.scdc; + int ret; + + drm_connector_get(connector); + + if (connector->status !=3D connector_status_connected) { + ret =3D -ENODEV; + goto err_conn_put; + } + + scdc_print_flag(m, "SCDC Supported", scdc->supported); + if (!scdc->supported) { + ret =3D 0; + goto err_conn_put; + } + + scdc_print_flag(m, "Sink Read Request Capable", scdc->read_request); + scdc_print_flag(m, "Scrambling Supported", scdc->scrambling.supported); + scdc_print_flag(m, "Low Rate Scrambling Supported", scdc->scrambling.low_= rates); + + ret =3D drm_scdc_read_state(connector, st); + drm_connector_put(connector); + if (ret) + return ret; + + scdc_print_flag(m, "Scrambling Enabled", st->scrambling_enabled); + scdc_print_flag(m, "Scrambling Detected", st->scrambling_detected); + + if (st->tmds_bclk_x40) + scdc_print_str(m, "TMDS Bit Clock Ratio", "1/40"); + else + scdc_print_str(m, "TMDS Bit Clock Ratio", "1/10"); + + scdc_print_flag(m, "Clock Detected", st->stf.status0.flags.clock_detected= ); + scdc_print_flag(m, "Channel 0 Locked", st->stf.status0.flags.ch0_locked); + scdc_print_flag(m, "Channel 1 Locked", st->stf.status0.flags.ch1_locked); + scdc_print_flag(m, "Channel 2 Locked", st->stf.status0.flags.ch2_locked); + + scdc_print_dec(m, "Channel 0 Errors", st->error_count[0]); + scdc_print_dec(m, "Channel 1 Errors", st->error_count[1]); + scdc_print_dec(m, "Channel 2 Errors", st->error_count[2]); + + return 0; + +err_conn_put: + drm_connector_put(connector); + + return ret; +} +DEFINE_SHOW_ATTRIBUTE(scdc_status); + +/** + * drm_scdc_debugfs_init - Initialize scdc files in connector debugfs + * @connector: pointer to &struct drm_connector to operate on + * @root: debugfs &struct dentry for the debugfs root of @connector + * + * Creates SCDC-related debugfs files for @connector. Must be called after + * @root is already created. + */ +void drm_scdc_debugfs_init(struct drm_connector *connector, struct dentry = *root) +{ + struct scdc_debugfs_priv *priv; + + if (!root || !connector) + return; + + priv =3D drmm_kzalloc(connector->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return; + + priv->connector =3D connector; + + debugfs_create_file("scdc_status", 0444, root, priv, &scdc_status_fops); +} +EXPORT_SYMBOL(drm_scdc_debugfs_init); diff --git a/include/drm/display/drm_scdc_helper.h b/include/drm/display/dr= m_scdc_helper.h index 34600476a1b9..b597e24a2976 100644 --- a/include/drm/display/drm_scdc_helper.h +++ b/include/drm/display/drm_scdc_helper.h @@ -30,6 +30,55 @@ =20 struct drm_connector; struct i2c_adapter; +struct dentry; + +struct drm_scdc_status_flags { + /* Status Register 0 */ + union { + struct { + bool clock_detected : 1; + bool ch0_locked : 1; + bool ch1_locked : 1; + bool ch2_locked : 1; + bool rsvd_4 : 1; + bool rsvd_5 : 1; + bool rsvd_6 : 1; + bool rsvd_7 : 1; + } flags __packed; + u8 data; + } status0; + + /* Status Register 1 */ + union { + struct { + bool rsvd_0 : 1; + bool rsvd_1 : 1; + bool rsvd_2 : 1; + bool rsvd_3 : 1; + bool rsvd_4 : 1; + bool rsvd_5 : 1; + bool rsvd_6 : 1; + bool rsvd_7 : 1; + } flags __packed; + u8 data; + } status1; +}; + +struct drm_scdc_state { + /** @stf: contents of the status flag registers */ + struct drm_scdc_status_flags stf; + /** @scramling_enabled: true if TMDS scrambling is on */ + bool scrambling_enabled; + /** @scrambling_detected: true if the sink actually detected scrambling */ + bool scrambling_detected; + /** + * @tmds_bclk_x40: true if TMDS bit period is 1/40th of the TMDS + * clock period, false if it's 1/10th of the clock period. + */ + bool tmds_bclk_x40; + /** @error_count: character error counts for each channel */ + u16 error_count[3]; +}; =20 ssize_t drm_scdc_read(struct i2c_adapter *adapter, u8 offset, void *buffer, size_t size); @@ -77,4 +126,11 @@ bool drm_scdc_get_scrambling_status(struct drm_connecto= r *connector); bool drm_scdc_set_scrambling(struct drm_connector *connector, bool enable); bool drm_scdc_set_high_tmds_clock_ratio(struct drm_connector *connector, b= ool set); =20 +int drm_scdc_read_status0_flags(struct drm_connector *connector, + struct drm_scdc_status_flags *flags); +int drm_scdc_read_state(struct drm_connector *connector, + struct drm_scdc_state *state); +int drm_scdc_read_error_counters(struct drm_connector *connector, u16 coun= ter[3]); +void drm_scdc_debugfs_init(struct drm_connector *connector, struct dentry = *root); + #endif --=20 2.54.0 From nobody Sun May 24 23:30:57 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67CFF2C15A9 for ; Wed, 20 May 2026 13:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284187; cv=pass; b=ibLyHnK2238sqzCh/HRiQRCLH3xRyO9f08Jv+endgBqzRrAG0IWMRenArQK/m27E3/tkkq0R2BWSmpYLigxoMqRNl6NIChHqi04m+biZzU0IKm6ur1ZUPU+t8ZfxMiYY3nGz9vbMetW1YiBNUM8b5J1kK/5Uijr/R7WkUIicJLQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284187; c=relaxed/simple; bh=A/5l2oXewFD/gL+tkV0dIynqFmCTuIqOyqU+3TcN8cw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=s9a4TC7VYtMYw47z3F2KZ6Naiqpn4TepdU4pEcNGnk4x2OLv0YmS2+BZsvzcDu6cmW7cgsVKR03XvMoLj+QNH0be01F9BpgzP2Jml4OOp7VDyvWxHuPbHCqCO3Vr7Au+qizRXUBrvbJsUysxDmK1MDLm1bFkUO2JLVonGrlToOs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=g+GXuS6+; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="g+GXuS6+" ARC-Seal: i=1; a=rsa-sha256; t=1779284144; cv=none; d=zohomail.com; s=zohoarc; b=mjKRpx7MDQTmWeemjxalGsVQTQo5hYR/SfF0tKWxg7FoEIvQURsjziGSStSPtm0SGSMQlocOziVGEPeLFtMUxNU+BWD49DDUIEUau5rw4Rrut6va6wW5F8wyYvNOtoMjGw8+j4soaaW8Ltcsk9jI2hUOpcYqa/ZxQrUqFJM/Yrs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779284144; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=5WJqoKD0/rlbWLk1M3RnI2w0Q4nYAEZ0gDBgKgmKzK0=; b=WR/HrRWVIlIP8PRiD6xBZMgmRPEBdpihjGHZT4+l+0wSER+LaIkCOCRr3Oes2g4qmkR3dhwQ5BAtQEJAXvxSKtdh/XbfADz/HOk4yCGlffOOi0dMfwLFRtDNj+pnHc1EBMXo/0vSkVdeYYUgMt8qdUND/c5aRovG5U88v7Khro8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779284144; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=5WJqoKD0/rlbWLk1M3RnI2w0Q4nYAEZ0gDBgKgmKzK0=; b=g+GXuS6+/UUuof9YqgYR14RvQznSvbF05/PvANOvp5t9cuy0lXVo+0kCTrBjzI0M t4yqwV85SxxizRktKjdHuSR6FTo6vPIrCj/KyaH3Yaq+cDO1DKXSsNZJ3sdlGPfZB1Z x8HoXW/UNgGMMUWIARsIEjoBO9furHOFcQZ4gFwg= Received: by mx.zohomail.com with SMTPS id 1779284141955445.44461628665726; Wed, 20 May 2026 06:35:41 -0700 (PDT) From: Nicolas Frattaroli Date: Wed, 20 May 2026 15:35:15 +0200 Subject: [PATCH v2 2/3] drm/display: bridge_connector: init scdc debugfs for HDMI Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260520-scdc-link-health-v2-2-511af18cd64b@collabora.com> References: <20260520-scdc-link-health-v2-0-511af18cd64b@collabora.com> In-Reply-To: <20260520-scdc-link-health-v2-0-511af18cd64b@collabora.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Daniel Stone Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Nicolas Frattaroli X-Mailer: b4 0.15.2 On drm_bridge_connectors that contain an HDMI bridge, initialise the SCDC debugfs entry under the connector's debugfs root. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/display/drm_bridge_connector.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c b/drivers/gpu/d= rm/display/drm_bridge_connector.c index 649969fca141..8c2c890bd95d 100644 --- a/drivers/gpu/drm/display/drm_bridge_connector.c +++ b/drivers/gpu/drm/display/drm_bridge_connector.c @@ -25,6 +25,7 @@ #include #include #include +#include =20 /** * DOC: overview @@ -263,6 +264,9 @@ static void drm_bridge_connector_debugfs_init(struct dr= m_connector *connector, if (bridge->funcs->debugfs_init) bridge->funcs->debugfs_init(bridge, root); } + + if (bridge_connector->bridge_hdmi) + drm_scdc_debugfs_init(connector, root); } =20 static void drm_bridge_connector_reset(struct drm_connector *connector) --=20 2.54.0 From nobody Sun May 24 23:30:57 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C62539B94C for ; Wed, 20 May 2026 13:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284188; cv=pass; b=qs8PsTkOzncsz5OO1nAdwXgseumnVtW2n1NmmhMQ+Y8mJ5teBSmSIOKEDgxZXxnAlNvp6T6Z1DFTlbjJT4Mw86deY+kPJ75wnhju4Q9Tx/Qi50YYxlxdUUE6THEiP4VOBPdnc9qF1M3UgYl35ENev5uQsUAj+FmrrO17A5gWbb8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284188; c=relaxed/simple; bh=gx8GWWhVZ747ezioWbDmuSJFF4eCIvHbvS0PR820h38=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CSbwoBsiSvQFU2g2hKoXzsdnWJ3nryf/GmYgSb0r8r9jO+ZM28YtBXWmXd0EKWsWROfsGSYvUP8O4w/zr6d8NUc/A9RGSkM2LGHgRZmgGxvZPhBVKVVGrCWVaF68FpNiJ0MOgG9eJ57Vlz1N4dOa0OH0OV5+rNQNQuEg5QWT0ss= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=EaOFruzn; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="EaOFruzn" ARC-Seal: i=1; a=rsa-sha256; t=1779284150; cv=none; d=zohomail.com; s=zohoarc; b=Jj78TwIL/nnO+MZbLaakGl/J/oV3TGCTui4vaUfqYsyxZp2YqDehdjTKkqijDfEi6Cs1yY5b+9miWjkzW9NTGQa5IWGVgmz+UCeggWXK0xGiQlheLSuuxwGqU73mhtZooNosC+fK1bZzQLRCNy3N9Wger0bzJgKVmvZ2W/x1VJg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779284150; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ke5hx67m62CM40Whc9CMxbRnFQn6KjsrZ7sJRAjlIZA=; b=Z/7pDNpVx1unKTNZ34wu9kHwfqCLb2njT2xYS1NfykNNaR4Q4XJxOZEdobFlWi22jr2m4KMZuM3wy7dpBmqFX5yctoh1fVJRG7iZXAVtlwnQXp92KHgubwcsnMYWCdAHCbCdHoplKAh8P/UT0wW7ujPKGw+rqyo4ReWpYwvRXUw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779284150; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=Ke5hx67m62CM40Whc9CMxbRnFQn6KjsrZ7sJRAjlIZA=; b=EaOFruznTHtAQMVqroZgWCzciEuskm1YmbaRTRtdGTAlZaNAwVy56w1xUEz+Vl8U 7JxRC1sCsnBvIKL79DpMiIibx/wScqUUY3Kebx3iggZ368rtszy96mxQlrESMSB/slu 3g/ZuIC6CKP4sQG+dHil3klbICheodNF8T13XdeM= Received: by mx.zohomail.com with SMTPS id 1779284146269789.372916806077; Wed, 20 May 2026 06:35:46 -0700 (PDT) From: Nicolas Frattaroli Date: Wed, 20 May 2026 15:35:16 +0200 Subject: [PATCH v2 3/3] drm/scdc-helper: Implement parsing and printing HDMI 2.1 fields Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260520-scdc-link-health-v2-3-511af18cd64b@collabora.com> References: <20260520-scdc-link-health-v2-0-511af18cd64b@collabora.com> In-Reply-To: <20260520-scdc-link-health-v2-0-511af18cd64b@collabora.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Daniel Stone Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Nicolas Frattaroli X-Mailer: b4 0.15.2 HDMI 2.1 redefines previously reserved fields in SCDC for various new uses. No version check needs to be performed, as an HDMI 2.0 sink's reserved SCDC fields are well-defined to be 0, and any zero-ness of these fields for an HDMI 2.0 sink is not a surprise for SCDC parsers for HDMI 2.1. Implement reading and outputting these fields over debugfs. Signed-off-by: Nicolas Frattaroli Reviewed-by: Daniel Stone --- drivers/gpu/drm/display/drm_scdc_helper.c | 130 ++++++++++++++++++++++++++= +--- include/drm/display/drm_scdc.h | 9 +++ include/drm/display/drm_scdc_helper.h | 85 +++++++++++++++---- 3 files changed, 201 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/display/drm_scdc_helper.c b/drivers/gpu/drm/di= splay/drm_scdc_helper.c index d582ba38a610..e9e59c7553a4 100644 --- a/drivers/gpu/drm/display/drm_scdc_helper.c +++ b/drivers/gpu/drm/display/drm_scdc_helper.c @@ -21,6 +21,7 @@ * DEALINGS IN THE SOFTWARE. */ =20 +#include #include #include #include @@ -63,6 +64,38 @@ struct scdc_debugfs_priv { struct drm_scdc_state state; }; =20 +static __pure const char *drm_scdc_frl_rate_str(enum drm_scdc_frl_rate rat= e) +{ + switch (rate) { + case SCDC_FRL_RATE_OFF: + return "Off"; + case SCDC_FRL_RATE_3X3: + return "3 Gbit/s x 3 lanes"; + case SCDC_FRL_RATE_6X3: + return "6 Gbit/s x 3 lanes"; + case SCDC_FRL_RATE_6X4: + return "6 Gbit/s x 4 lanes"; + case SCDC_FRL_RATE_8X4: + return "8 Gbit/s x 4 lanes"; + case SCDC_FRL_RATE_10X4: + return "10 Gbit/s x 4 lanes"; + case SCDC_FRL_RATE_12X4: + return "12 Gbit/s x 4 lanes"; + case SCDC_FRL_RATE_RESV_7: + case SCDC_FRL_RATE_RESV_8: + case SCDC_FRL_RATE_RESV_9: + case SCDC_FRL_RATE_RESV_10: + case SCDC_FRL_RATE_RESV_11: + case SCDC_FRL_RATE_RESV_12: + case SCDC_FRL_RATE_RESV_13: + case SCDC_FRL_RATE_RESV_14: + case SCDC_FRL_RATE_RESV_15: + return "(Reserved)"; + default: + return NULL; + } +} + /** * drm_scdc_read - read a block of data from SCDC * @adapter: I2C controller @@ -309,10 +342,41 @@ int drm_scdc_read_status0_flags(struct drm_connector = *connector, } EXPORT_SYMBOL(drm_scdc_read_status0_flags); =20 +/** + * drm_scdc_read_status1_2_flags - Read SCDC "Status Flags" 1 and 2 Regist= ers + * @connector: pointer to &struct drm_connector to issue the scdc request = on + * @flags: pointer to the caller's &struct drm_scdc_status_flags to output= to + * + * Reads the SCDC Status Flags 1 and 2 registers, and outputs their conten= ts to + * the destination @flags. Contents of @flags.status1 and @flags.status2 a= re + * only valid if function returns 0. + * + * Returns 0 on success, negative errno on error. + */ +int drm_scdc_read_status1_2_flags(struct drm_connector *connector, + struct drm_scdc_status_flags *flags) +{ + int ret; + + ret =3D drm_scdc_writeb(connector->ddc, SCDC_UPDATE_0, SCDC_FLT_UPDATE); + if (ret) + return ret; + + ret =3D drm_scdc_readb(connector->ddc, SCDC_STATUS_FLAGS_1, &flags->statu= s1.data); + if (ret) + return ret; + + return drm_scdc_readb(connector->ddc, SCDC_STATUS_FLAGS_2, &flags->status= 2.data); +} +EXPORT_SYMBOL(drm_scdc_read_status1_2_flags); + +#define ERR_DET_OFF(x) ((x) - SCDC_ERR_DET_0_L) + /** * drm_scdc_read_error_counters - Read and clear SCDC error counters * @connector: pointer to &struct drm_connector to issue the scdc request = on - * @counter: Caller's u16 array with 3 elements to write the counter value= s into + * @counter: Caller's u16 array with 4 elements to write the counter value= s into + * @num_lanes: number of active lanes, either 3 or 4 * * Read the SCDC channel error counters. If the count of channel *n* is va= lid, * write it into counter[n]. Otherwise, set counter[n] to 0. Reads all cou= nters @@ -320,19 +384,33 @@ EXPORT_SYMBOL(drm_scdc_read_status0_flags); * * Returns: %0 on success, negative errno on error. */ -int drm_scdc_read_error_counters(struct drm_connector *connector, u16 coun= ter[3]) +int drm_scdc_read_error_counters(struct drm_connector *connector, u16 coun= ter[4], + unsigned int num_lanes) { - u8 buf[7] =3D { 0 }; + unsigned int buf_sz; + u8 buf[9] =3D { 0 }; ssize_t ret; u8 sum =3D 0; int i; =20 + switch (num_lanes) { + case 0: + case 3: + buf_sz =3D 7; + break; + case 4: + buf_sz =3D 9; + break; + default: + return -EINVAL; + } + ret =3D drm_scdc_writeb(connector->ddc, SCDC_UPDATE_0, SCDC_CED_UPDATE); if (ret) return ret; =20 /* why in the fucking fuck does this return a ssize_t */ - ret =3D drm_scdc_read(connector->ddc, SCDC_ERR_DET_0_L, buf, ARRAY_SIZE(b= uf)); + ret =3D drm_scdc_read(connector->ddc, SCDC_ERR_DET_0_L, buf, buf_sz); if (ret) return ret; =20 @@ -340,13 +418,13 @@ int drm_scdc_read_error_counters(struct drm_connector= *connector, u16 counter[3] * Verify the "checksum", i.e. sum up everything including the checksum * register as a wrapping unsigned 8-bit addition and verify it's 0. */ - for (i =3D 0; i < ARRAY_SIZE(buf); i++) + for (i =3D 0; i < buf_sz; i++) sum =3D wrapping_add(u8, sum, buf[i]); =20 if (sum) return -EPROTO; =20 - for (i =3D 0; i < ARRAY_SIZE(buf) - 1; i +=3D 2) { + for (i =3D 0; i <=3D ERR_DET_OFF(SCDC_ERR_DET_2_H); i +=3D 2) { if (buf[i + 1] & SCDC_CHANNEL_VALID) counter[i / 2] =3D buf[i] | (buf[i + 1] & ~SCDC_CHANNEL_VALID) << 8; else @@ -355,9 +433,15 @@ int drm_scdc_read_error_counters(struct drm_connector = *connector, u16 counter[3] buf[i] =3D 0; buf[i + 1] =3D 0; } - buf[ARRAY_SIZE(buf) - 1] =3D 0; + buf[ERR_DET_OFF(SCDC_ERR_DET_CHECKSUM)] =3D 0; + + if (num_lanes =3D=3D 4) + counter[3] =3D buf[ERR_DET_OFF(SCDC_ERR_DET_3_L)] | + (buf[ERR_DET_OFF(SCDC_ERR_DET_3_H)] & ~SCDC_CHANNEL_VALID) << 8; + else + counter[3] =3D 0; =20 - return drm_scdc_write(connector->ddc, SCDC_ERR_DET_0_L, buf, ARRAY_SIZE(b= uf)); + return drm_scdc_write(connector->ddc, SCDC_ERR_DET_0_L, buf, buf_sz); } EXPORT_SYMBOL(drm_scdc_read_error_counters); =20 @@ -377,6 +461,7 @@ int drm_scdc_read_state(struct drm_connector *connector= , struct drm_scdc_state * u8 upd_flags[2] =3D { 0 }; struct i2c_adapter *ddc; struct drm_scdc *scdc; + int num_lanes; int ret; u8 val; =20 @@ -398,6 +483,17 @@ int drm_scdc_read_state(struct drm_connector *connecto= r, struct drm_scdc_state * =20 state->scrambling_detected =3D drm_scdc_get_scrambling_status(connector); =20 + ret =3D drm_scdc_readb(ddc, SCDC_CONFIG_1, &val); + if (ret) + return ret; + + state->rate =3D FIELD_GET(SCDC_FRL_RATE, val); + num_lanes =3D drm_scdc_num_frl_lanes(state->rate); + if (num_lanes < 0) + return num_lanes; + + state->ffe_levels =3D FIELD_GET(SCDC_FFE_LEVELS, val); + ret =3D drm_scdc_read(ddc, SCDC_UPDATE_0, &upd_flags, sizeof(upd_flags)); if (ret) return ret; @@ -408,8 +504,15 @@ int drm_scdc_read_state(struct drm_connector *connecto= r, struct drm_scdc_state * return ret; } =20 + if (upd_flags[0] & SCDC_FLT_UPDATE) { + ret =3D drm_scdc_read_status1_2_flags(connector, &state->stf); + if (ret) + return ret; + } + if (upd_flags[0] & SCDC_CED_UPDATE) { - ret =3D drm_scdc_read_error_counters(connector, state->error_count); + ret =3D drm_scdc_read_error_counters(connector, state->error_count, + num_lanes); if (ret) return ret; } @@ -457,6 +560,8 @@ static int scdc_status_show(struct seq_file *m, void *d= ata) =20 scdc_print_flag(m, "Scrambling Enabled", st->scrambling_enabled); scdc_print_flag(m, "Scrambling Detected", st->scrambling_detected); + scdc_print_str(m, "FRL Rate", drm_scdc_frl_rate_str(st->rate)); + scdc_print_dec(m, "FFE Levels", st->ffe_levels); =20 if (st->tmds_bclk_x40) scdc_print_str(m, "TMDS Bit Clock Ratio", "1/40"); @@ -467,10 +572,17 @@ static int scdc_status_show(struct seq_file *m, void = *data) scdc_print_flag(m, "Channel 0 Locked", st->stf.status0.flags.ch0_locked); scdc_print_flag(m, "Channel 1 Locked", st->stf.status0.flags.ch1_locked); scdc_print_flag(m, "Channel 2 Locked", st->stf.status0.flags.ch2_locked); + if (drm_scdc_num_frl_lanes(st->rate) =3D=3D 4) + scdc_print_flag(m, "Lane 3 Locked", st->stf.status0.flags.ln3_locked); + + scdc_print_flag(m, "Sink Ready For Link Training", st->stf.status0.flags.= flt_ready); + scdc_print_flag(m, "Sink Failed To Decode DSC", st->stf.status0.flags.dsc= _fail); =20 scdc_print_dec(m, "Channel 0 Errors", st->error_count[0]); scdc_print_dec(m, "Channel 1 Errors", st->error_count[1]); scdc_print_dec(m, "Channel 2 Errors", st->error_count[2]); + if (drm_scdc_num_frl_lanes(st->rate) =3D=3D 4) + scdc_print_dec(m, "Lane 3 Errors", st->error_count[3]); =20 return 0; =20 diff --git a/include/drm/display/drm_scdc.h b/include/drm/display/drm_scdc.h index 3d58f37e8ed8..56cd909edac9 100644 --- a/include/drm/display/drm_scdc.h +++ b/include/drm/display/drm_scdc.h @@ -29,6 +29,7 @@ #define SCDC_SOURCE_VERSION 0x02 =20 #define SCDC_UPDATE_0 0x10 +#define SCDC_FLT_UPDATE (1 << 5) #define SCDC_READ_REQUEST_TEST (1 << 2) #define SCDC_CED_UPDATE (1 << 1) #define SCDC_STATUS_UPDATE (1 << 0) @@ -46,6 +47,10 @@ #define SCDC_CONFIG_0 0x30 #define SCDC_READ_REQUEST_ENABLE (1 << 0) =20 +#define SCDC_CONFIG_1 0x31 +#define SCDC_FRL_RATE 0x0f +#define SCDC_FFE_LEVELS 0xf0 + #define SCDC_STATUS_FLAGS_0 0x40 #define SCDC_CH2_LOCK (1 << 3) #define SCDC_CH1_LOCK (1 << 2) @@ -54,6 +59,7 @@ #define SCDC_CLOCK_DETECT (1 << 0) =20 #define SCDC_STATUS_FLAGS_1 0x41 +#define SCDC_STATUS_FLAGS_2 0x42 =20 #define SCDC_ERR_DET_0_L 0x50 #define SCDC_ERR_DET_0_H 0x51 @@ -65,6 +71,9 @@ =20 #define SCDC_ERR_DET_CHECKSUM 0x56 =20 +#define SCDC_ERR_DET_3_L 0x57 +#define SCDC_ERR_DET_3_H 0x58 + #define SCDC_TEST_CONFIG_0 0xc0 #define SCDC_TEST_READ_REQUEST (1 << 7) #define SCDC_TEST_READ_REQUEST_DELAY(x) ((x) & 0x7f) diff --git a/include/drm/display/drm_scdc_helper.h b/include/drm/display/dr= m_scdc_helper.h index b597e24a2976..1a95da3da5fe 100644 --- a/include/drm/display/drm_scdc_helper.h +++ b/include/drm/display/drm_scdc_helper.h @@ -24,6 +24,7 @@ #ifndef DRM_SCDC_HELPER_H #define DRM_SCDC_HELPER_H =20 +#include #include =20 #include @@ -40,10 +41,10 @@ struct drm_scdc_status_flags { bool ch0_locked : 1; bool ch1_locked : 1; bool ch2_locked : 1; - bool rsvd_4 : 1; + bool ln3_locked : 1; bool rsvd_5 : 1; - bool rsvd_6 : 1; - bool rsvd_7 : 1; + bool flt_ready : 1; + bool dsc_fail : 1; } flags __packed; u8 data; } status0; @@ -51,19 +52,68 @@ struct drm_scdc_status_flags { /* Status Register 1 */ union { struct { - bool rsvd_0 : 1; - bool rsvd_1 : 1; - bool rsvd_2 : 1; - bool rsvd_3 : 1; - bool rsvd_4 : 1; - bool rsvd_5 : 1; - bool rsvd_6 : 1; - bool rsvd_7 : 1; + u8 ln0_training_pattern : 4; + u8 ln1_training_pattern : 4; } flags __packed; u8 data; } status1; + + /* Status Register 2 */ + union { + struct { + u8 ln2_training_pattern : 4; + u8 ln3_training_pattern : 4; + } flags __packed; + u8 data; + } status2; +}; + +enum drm_scdc_frl_rate { + SCDC_FRL_RATE_OFF =3D 0, + SCDC_FRL_RATE_3X3 =3D 1, + SCDC_FRL_RATE_6X3 =3D 2, + SCDC_FRL_RATE_6X4 =3D 3, + SCDC_FRL_RATE_8X4 =3D 4, + SCDC_FRL_RATE_10X4 =3D 5, + SCDC_FRL_RATE_12X4 =3D 6, + SCDC_FRL_RATE_RESV_7 =3D 7, + SCDC_FRL_RATE_RESV_8 =3D 8, + SCDC_FRL_RATE_RESV_9 =3D 9, + SCDC_FRL_RATE_RESV_10 =3D 10, + SCDC_FRL_RATE_RESV_11 =3D 11, + SCDC_FRL_RATE_RESV_12 =3D 12, + SCDC_FRL_RATE_RESV_13 =3D 13, + SCDC_FRL_RATE_RESV_14 =3D 14, + SCDC_FRL_RATE_RESV_15 =3D 15 }; =20 +/** + * drm_scdc_num_frl_lanes - get number of lanes for a given FRL rate + * @rate: one of &enum drm_scdc_frl_rate + * + * For a given @rate, return the number of lanes it uses. + * + * Returns: %-EINVAL if @rate is not a valid FRL rate, or the number of la= nes + * for a given &enum drm_scdc_frl_rate on success (including %0 for "off") + */ +static inline __pure int drm_scdc_num_frl_lanes(enum drm_scdc_frl_rate rat= e) +{ + switch (rate) { + case SCDC_FRL_RATE_OFF: + return 0; + case SCDC_FRL_RATE_3X3: + case SCDC_FRL_RATE_6X3: + return 3; + case SCDC_FRL_RATE_6X4: + case SCDC_FRL_RATE_8X4: + case SCDC_FRL_RATE_10X4: + case SCDC_FRL_RATE_12X4: + return 4; + default: + return -EINVAL; + } +} + struct drm_scdc_state { /** @stf: contents of the status flag registers */ struct drm_scdc_status_flags stf; @@ -76,8 +126,12 @@ struct drm_scdc_state { * clock period, false if it's 1/10th of the clock period. */ bool tmds_bclk_x40; - /** @error_count: character error counts for each channel */ - u16 error_count[3]; + /** @rate: FRL rate set by the source */ + enum drm_scdc_frl_rate rate : 4; + /** @ffe_levels: The FFE levels for @rate set by the source */ + u8 ffe_levels : 4; + /** @error_count: character error counts for each channel/link */ + u16 error_count[4]; }; =20 ssize_t drm_scdc_read(struct i2c_adapter *adapter, u8 offset, void *buffer, @@ -128,9 +182,12 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct drm_con= nector *connector, bool se =20 int drm_scdc_read_status0_flags(struct drm_connector *connector, struct drm_scdc_status_flags *flags); +int drm_scdc_read_status1_2_flags(struct drm_connector *connector, + struct drm_scdc_status_flags *flags); int drm_scdc_read_state(struct drm_connector *connector, struct drm_scdc_state *state); -int drm_scdc_read_error_counters(struct drm_connector *connector, u16 coun= ter[3]); +int drm_scdc_read_error_counters(struct drm_connector *connector, u16 coun= ter[4], + unsigned int num_lanes); void drm_scdc_debugfs_init(struct drm_connector *connector, struct dentry = *root); =20 #endif --=20 2.54.0