From nobody Mon May 25 00:08:04 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3944633A032 for ; Wed, 20 May 2026 07:42:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779262941; cv=none; b=ROgOev4AUiZ1YN0VBL2WbdqLT0o8U/BkLi5GOJT+i5SpbSRJpS3DJZHCrULn+Nvf1cCCytJIp7zj8PaIn76/6lHEoQ4C9xS9e7uRGKQdJxpUVzIhKkvOsDmy/805Ma+OJ02vY2Lxs20l2p9CzXZeh9nMVLdqnTe5oSGaf4FPu2I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779262941; c=relaxed/simple; bh=XFzN6vM/Oj3ZhWKDE0Pqw3nGv4lwE+G7MDQ+R+DGRWc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=mjz2Aqr7Ls+yylUR5UngfXRZj/bPgnmTnAjyvpH3LgiYdvax5P2Ju0kCa1B/kPBRfAW7oREve8XIRxhTz1PVHwlSaI9tVggFdH3f9tU/gK9iBL1ifPHdkyvdGcTCCLSkGxI/L6Yvfx3p0lFHsXnBsnXHoibWqsa6tjuqOmVk75I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ogGZwT02; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RoseE7/R; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ogGZwT02"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RoseE7/R" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64K7IGl9341703 for ; Wed, 20 May 2026 07:42:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=IXEJOp3nNbLPWB6txTpAU9 4P/zOlvq5ax+yaAGGQzjI=; b=ogGZwT02csbcbo2AdKo94WcLKaqX8lEIKOPxmR yhUy+/fbHmyVc5r1V/bvWuynwJlvHfPJ/pUlRwBBaGOM5fbkTRJlym8eshzHBXfs DPRe9t3wjI5XQ0hM3dtucnc/PzlEDhJX0bvha5UsrQBIJuX5qXUtPqdOkXFeOSPL onNmUycUHfVsAIpF/G0M1tX3mHdp+7cHPU+mLnYASE+115cpPq9ROXo4BHD7hqKy oS0BOX2rVwCfpiJ1vl6LRU6SiWa8WGE47lr71hbVzUTK1OPTLOeaT8l4U6ztE4Xx W+HYug4RLgOCXI8I5axuwoa9phVK4PbPO4l9iRV++Zob5HqA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8t3vbjjk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 07:42:19 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50d812c898cso128881281cf.1 for ; Wed, 20 May 2026 00:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779262938; x=1779867738; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=IXEJOp3nNbLPWB6txTpAU94P/zOlvq5ax+yaAGGQzjI=; b=RoseE7/RcqVCW98U9SMe810gR4fW1Vi4PefJE8c8Ebw03/O5znk786IJcv47ITpKVy QIVQ/OjsQ+3GCuefCJbcwupTOQqnJKALzs+Px/Q2wHJfi1yhiOaAYjGeDM4l+HHYYXnf +1EzHGdPgVFBQ31tBACxG9ZuFQibsU6Qj2VlBRT3xaAsNnx0cSb5LaRBs8YLgbNEXICQ 9ZkIXh+uKqE8dPQdm3CBFfy9m315LJd13/rX7/i/K6Oa3HKyaB1FKpolIoHhQPJnc2ql b+euLUNwDNgfk3I7qUCQg82Bqj59DNvsUXTZU3l/qAkd0vdmb4jmwUExLIiWJViJeQf1 Mepg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779262938; x=1779867738; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IXEJOp3nNbLPWB6txTpAU94P/zOlvq5ax+yaAGGQzjI=; b=Jj/XLuPtFMayv05r6lwcHTq4bpBa4k5XSgZoHpjM5vxrcvqCtaWuBf9GZe2LFCG0sY VtFK0+pX7jHq4DYDVjXfTPfhFkPM6YKkG7uvezhysTCKGDnbj/CPvcfKl9e5ETjt86Wy kgZk81oQVslqL09WwBg2aYesDY1a+/mocgvxD2tUt820p1uX2p/hoBjbDzll3h297M5a QcYj8JjTXrUog3suSz/xkd9uouYEXi/AO85OahkR7Ta3WUtAsieWBdMVaxbg25aef2Vj P5yCTWFpYeDsfmCWetaOPJHeHRDgp/sjVIMDLtcJKRRDZDuQSu1paFTbG4IY+Zhzh1QZ ctSg== X-Forwarded-Encrypted: i=1; AFNElJ/16une0+07m9MLuQ8GAWE4ZbywPuMWgqq2q1TFJcc9uyrIsgmtooar2a5ISEka+HKze+RU6T9LRktExjc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywq4ArdkzDRwG8TClalpl6OzpKYnkGe4yWUCEgjohfl5Yqttzst Ga1unqYro/fjHczbVJKarXwW7po8oQAUNyZzI1ytKsnqUETr/k2xwSR+m513VpyMu86ueSZisKA pZW2P0LKcnwYQnrLaJtOZu+oicoPBgs4pLjbZlXR1ZQJdyROffU2qRRMMjeIkwTtvA79tC4RycM w= X-Gm-Gg: Acq92OFTuBQv4V4BiWw/vrK4sCYLcuxwVUhiKtp3Gx+vVkp8Q1T+G9bOHz/HK9Y2REY UBC/VFf/l7HgNPh0N0KYCezbSc0pLoArlc0zekYIc6kQ+E0XuQ6AV0Lc2zNj10S36Vb3vtnaySp VAyva3T9Na6kFgep+JJAc9VSAJ5EQdaNONoT3PyOoJ8z3szp0IHQawAbXVi9ElNk0UzH7iOUQKX PjyaUzEEKMALkkEdNDHPdGE0nHWxjbxVWh+286PsA5BXdKVwLrWUE4qqaF/4RqmAHN2oVuFmtuQ IJM7DL0xmoY8YbyQC0E08+o5ZrTa1CUTTcQtJV7fKq3z5a255axt2Ra9uZz6x8ULWIJHYrALgSO ha19/obPpTi+/60aC/L9Ks6akbCGJb9CQSduV6PD7eH14HpKG35U= X-Received: by 2002:a05:622a:608e:b0:50f:bc35:aae with SMTP id d75a77b69052e-5165a25e9bdmr296796201cf.52.1779262938472; Wed, 20 May 2026 00:42:18 -0700 (PDT) X-Received: by 2002:a05:622a:608e:b0:50f:bc35:aae with SMTP id d75a77b69052e-5165a25e9bdmr296796021cf.52.1779262938070; Wed, 20 May 2026 00:42:18 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:9ec3:885a:6d78:48d0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48febe585absm127410435e9.19.2026.05.20.00.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 00:42:17 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 20 May 2026 09:42:10 +0200 Subject: [PATCH v2] gpio: cdev: check if uAPI v2 config attributes are correctly zeroed Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260520-gpio-cdev-attr-padding-check-v2-1-0010daf8059f@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIANFlDWoC/42NTQ6CMBBGr0K6dgit8ufKexgWYzvARGmxxUZDu LuVE7j5kvct3ltFIM8UxDlbhafIgZ1NoA6Z0CPagYBNYqEKVRWlbGGY2YE2FAGXxcOMxrAdQI+ k71BTqXTb4NFQLZJi9tTze9dfu8Qjh8X5z16L8vf+KY4SJGChK3PCqm1u/cWFkD9f+NBumvI0o tu27QvGzRPHzwAAAA== X-Change-ID: 20260519-gpio-cdev-attr-padding-check-7e52c98a3de7 To: Bartosz Golaszewski , Kent Gibson , Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1729; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=XFzN6vM/Oj3ZhWKDE0Pqw3nGv4lwE+G7MDQ+R+DGRWc=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqDWXUT58hRt1wSZv4rc0Butcw50EiGObucPa9l ZRBtaXxwNWJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCag1l1AAKCRAFnS7L/zaE wwPIEACjNXkJGdl3Xd2/mIfW0GGbUtFj31JqxgprrFWXf89VLrmfaiflmtOd4Pozh9bGHWcGnKk wwGmxefTSxJriojkyKzYnyD7vysOE+OxEgEKG9FBSYHhjMS4VxumTvxPVDBvFdL2bs0BI2DKlOx 8IK+zztXHuhtA9mlH5H9Y1pEb5ZxzqK2WhaeWGNUo7GEDcmN6qu++tCXLyx1VJ8qLqirs6WvUCe FlhC0RqqEPp+NPTJbB6HMxj7Vh84vA6UfLeek7BYnUmjqkpwRSCRS2PQ8YIeeoiMS0PJss1Fa6N pkPeNpBb2lYUcqEnm+lA1/2/uf0V/uXVM2nBTeKvQ4xCimQDveIBTMLV4oMwIF9dteVLItl/uul yh93Q1riI1VunLcR8T0Jlh2c7/m6Qxroi35jTHkmZTd1BwoZo+4ypKqXUkFJGVKpil50L9J+Q9h eAMcXEKdSUvTTDyYFhPz9fGeFcyq0MGp0ntnKo7YvWuDT89v+QQFo56DJ+meKJnbZA0OxmNTLT3 UuUi/npmS5SsAtQUdSrrdiUOQWN38X4ib70IWGrVpERDyZvL9rDOrGP+61xy5P8ypShLGPd3I+N wixyiGFNWgquJ0G1rzQqXbiRK954h+13S7FjFViWzyHh8n3wMVp/M+Aj3lFpnZvBos/DkRGIZQx CncabsTEvLtgTMw== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-GUID: iWkAyj-CG2oA-piktMvpvF4vNHS5RJCW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDA3MyBTYWx0ZWRfX7QaVbA90JNIF 7sTbKUvPhWEcTTvo75jRm7l/GK9k8+LRTqQbgGNx0xPqdSRTxU53wHITzV9NfnfkXbxS2YSqm9V is0zc+Hy2Q01mHhGiWi5iwapSZa/S7MC2HDUXMipB+jOEXBxWkriW1CSMnHXCo84F2mkJ9QVZbR ygAuRRsA7BNr+x7TPea484JlUlw7rovG4LkKJY0RAMKi0laZLnf2t9Y7VDKqhVqnuv03d/ssyUT Vq8NTc9E44z4Q1i2z/NBgwkbSwrSUaF8ySX5QgsbsNkVOmfvztwIz4cM57pRbzX9JhWcwSsLpXa jXRtN/giQxonaZpKAiorFdq6+nh8vpxNA7K7VDV0XFVQfAcV9kEvvtFVDlnbptt/V9Hd5ylnyWV kVxYYFFlR6Jpn5cutZlpfw7lJLvJRvUCbCKIQfVsOlEH43iIYg/muH7naM7nPxKsecL6RGwXa8f TV1CswHymBBqfAeZggA== X-Authority-Analysis: v=2.4 cv=JuPBas4C c=1 sm=1 tr=0 ts=6a0d65db cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=BL_IfG5vSrN7on1ht2cA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-ORIG-GUID: iWkAyj-CG2oA-piktMvpvF4vNHS5RJCW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200073 We check the padding of other uAPI v2 structures but not that of line config attributes. For used attributes: check if their padding is zeroed, for unused: check if the entire structure is zeroed. Fixes: 3c0d9c635ae2 ("gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPI= O_V2_LINE_GET_VALUES_IOCTL") Signed-off-by: Bartosz Golaszewski --- Changes in v2: - Make checking even stricter: check if padding is zeroed for used attributes, for unused ones: check if the entire struct is zeroed - Link to v1: https://patch.msgid.link/20260519-gpio-cdev-attr-padding-chec= k-v1-1-a0c6d4a698bf@oss.qualcomm.com --- drivers/gpio/gpiolib-cdev.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c index f36b7c06996d70b2286edbd181899e4c572b9086..edbcc86e4b26f88036ed12c1305= 5bb2c371fb6a3 100644 --- a/drivers/gpio/gpiolib-cdev.c +++ b/drivers/gpio/gpiolib-cdev.c @@ -1194,6 +1194,15 @@ static int gpio_v2_line_config_validate(struct gpio_= v2_line_config *lc, if (!mem_is_zero(lc->padding, sizeof(lc->padding))) return -EINVAL; =20 + for (i =3D 0; i < lc->num_attrs; i++) { + if (lc->attrs[i].attr.padding !=3D 0) + return -EINVAL; + } + + if (!mem_is_zero(&lc->attrs[i], + (GPIO_V2_LINE_NUM_ATTRS_MAX - lc->num_attrs) * sizeof(*lc->attrs))) + return -EINVAL; + for (i =3D 0; i < num_lines; i++) { flags =3D gpio_v2_line_config_flags(lc, i); ret =3D gpio_v2_line_flags_validate(flags); --- base-commit: 6a50ba100ace43f43c87384367eb2d2605fcc16c change-id: 20260519-gpio-cdev-attr-padding-check-7e52c98a3de7 Best regards, --=20 Bartosz Golaszewski