[v2] ALSA: hda: cs35l56: fix system name leaks

[PATCH v2 0/2] ALSA: hda: cs35l56: fix system name leaks

Cássio Gabriel posted 2 patches 4 days, 7 hours ago

Diff against v1
Download series mbox

sound/hda/codecs/side-codecs/cs35l56_hda.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)

Expand all Fold all

[PATCH v2 0/2] ALSA: hda: cs35l56: fix system name leaks

Posted by Cássio Gabriel 4 days, 7 hours ago

cs35l56_hda_read_acpi() reads an allocated ACPI _SUB string to build
the firmware system name. Current error paths can return after _SUB has
been allocated, or after it has been transferred to cs35l56->system_name,
without releasing that memory.

Fix the local read_acpi() unwind paths first, then release the stored
system name from the common probe error path.

Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
---
Changes in v2:
- Use __free(kfree) for the temporary ACPI _SUB string.
- Keep the derived system name local until read_acpi() succeeds.
- Transfer ownership with no_free_ptr() only on successful paths.
- Link to v1: https://patch.msgid.link/20260520-alsa-cs35l56-system-name-leak-v1-0-d13b54423198@gmail.com

---
Cássio Gabriel (2):
      ALSA: hda: cs35l56: Free ACPI _SUB string on errors
      ALSA: hda: cs35l56: Free system name on probe errors

 sound/hda/codecs/side-codecs/cs35l56_hda.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)
---
base-commit: 38c607c673155d6335591cdbd9c785fb2b7550e5
change-id: 20260501-alsa-cs35l56-system-name-leak-7fd779eac391

Best regards,
--  
Cássio Gabriel <cassiogabrielcontato@gmail.com>