From nobody Mon May 25 01:15:57 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1011434A794 for ; Tue, 19 May 2026 19:18:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779218327; cv=none; b=UdflOutZ+KCbqrnYoY+qqv6merGnQDdvwLeOp5Cz1eq50MAd/5wuDzDNSotGWYYXQeY/PZFp/qa4P/Q/XdjwPq0/SVFvEz6wXc1eAiFOB/S2CX5kzd4JIUa62JXgEkpuor5QuWiIeTn//eizn3u6FKlwJR5Oeg8SM7cd1JKNwI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779218327; c=relaxed/simple; bh=11ZzDVR/rAYwtCJFjE2rpGZRM0S99r8yiZLpiE1WFtI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N3lxmGr0cKGjyINz0G+uHItKBkmSqc6sfd57MfGvvYj64o1zk7V0h3m0lYmXmEGuAbxiz1jYXza+qm3AoTZEMXAzjoGaeNyS0lstHXl8rmzQWCj/Zz5dXSujnl70+jqzA9hc8eDiBto7V07qxfsOc93JFHMNviaMWju6LF8H6U0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TlI84h8L; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TlI84h8L" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779218325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=FbrMGqqeY5Jd/S5PIg+1PZmYt+RwLc6Pzk5VD4FqcFs=; b=TlI84h8LgiFx1BVnJfzKCztEHFRnwsymnz6gYMQQBCVcwhbjtsQK7618ZXuNjVMVrJa1QE 8W7rEcNEvJ7Jx+qZsJQ0tWV2JRZTll5K+yXMFmRC2QSkp7Fx0wDxaFy1LKONsNXBMJEJsk BKUCMm0Wws1odbaR9da3qWhqiKT5jzE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-arIxYbxmOKarj2MM35m-FA-1; Tue, 19 May 2026 15:18:42 -0400 X-MC-Unique: arIxYbxmOKarj2MM35m-FA-1 X-Mimecast-MFC-AGG-ID: arIxYbxmOKarj2MM35m-FA_1779218322 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D65341956050; Tue, 19 May 2026 19:18:41 +0000 (UTC) Received: from emilne-na.ibmlowe.csb (unknown [10.17.17.93]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5AB0E19560A3; Tue, 19 May 2026 19:18:41 +0000 (UTC) From: "Ewan D. Milne" To: linux-kernel@vger.kernel.org Cc: sarah.catania@broadcom.com Subject: [PATCH] drivers: base: Remove statistics group if encryption group not created Date: Tue, 19 May 2026 15:18:40 -0400 Message-ID: <20260519191840.1030912-1-emilne@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Content-Type: text/plain; charset="utf-8" If transport_add_class_device() gets an error from sysfs_create_group() when creating the encryption group, it does not remove the statistics group in the error path. Adjust the error path to do this properly. Fixes: bd2bc528691e ("scsi: scsi_transport_fc: Introduce encryption group") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-6 Signed-off-by: Ewan D. Milne --- drivers/base/transport_class.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/base/transport_class.c b/drivers/base/transport_class.c index 416e9f819df5..2787967e1063 100644 --- a/drivers/base/transport_class.c +++ b/drivers/base/transport_class.c @@ -168,11 +168,13 @@ static int transport_add_class_device(struct attribut= e_container *cont, if (tcont->encryption) { error =3D sysfs_create_group(&classdev->kobj, tcont->encryption); if (error) - goto err_del; + goto err_del_statistics; } =20 return 0; =20 +err_del_statistics: + sysfs_remove_group(&classdev->kobj, tcont->statistics); err_del: attribute_container_class_device_del(classdev); err_remove: --=20 2.52.0