From nobody Mon May 25 02:53:59 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43A763FC5C0 for ; Tue, 19 May 2026 17:15:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779210938; cv=none; b=u1V5w3vcRU43ZymXNiYiUdg0q3DlGPTnxho3o/9KJUrXF8r7Q7NYMN8VmHXc0GWFVQ5vaS+iiG5UyU5udV029Mk8UaKE9WfBSEomkpYLty5qHMhkJvKMyfudE/goSRnoFSa8a4ri3iv5eaLWua3sNNnRKDQBWHxp4Q6Cx5rW24c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779210938; c=relaxed/simple; bh=Q8wHeL91TSb3urvpRCuxQfEFd1CujUhU0rk1XYHwsiQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SXyRTOqEEPnG20ZUQtMWc+GBQpH5pTzFddRtI7mjCbyT9mP46/OxMmvRAm8iBkGMGELzQ8rRgqKSs3dnOd3AjxtNow+Cy3tbYDWAFUBVfuxl5BqSaSZWTKq9nxCy7PE/HETDD9gKuPdAol1Y1WLSUBtXF8j8czcvUsLfxAkP2DQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dR+zsZAI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LYvdO943; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dR+zsZAI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LYvdO943" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64JExPdw1963823 for ; Tue, 19 May 2026 17:15:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=tOITleWCuvp i0+dYRoQBpEMVHrSEpgzzTWuCd/gwHCw=; b=dR+zsZAIJF3UFECu5KsfUSmTEZS JzIMwkClVRN6LtkUA2JYnGSR6Qd1a/b1rtXlu/RcREa3+Df1hN4fxYhDY5HmXfhS qhQCPCjr1RB0yk65qBUiKzEQKziMwgzRarx8oVOKvC+sZ+YcaFkBSl7h+yB+/AvW n6gbKLIOx6l3MGI3CS7VfLdmPiUs5wLecXyl1WfIeep55wNhs+cAVFuTFrp7tmNs E7vIzY+G7cC3R0suVoGAG6NlYvHNc6tvKoDlKxdbWrpsD2afxdomVd4g7jFNdDCP TaZKc/MszB4voeIf2Wl40LVkDS89dWAeOQUicoSPqINO+5n3eFByNM+CETw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8t3t0mvv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 19 May 2026 17:15:36 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-837c4eb3bdfso2513747b3a.2 for ; Tue, 19 May 2026 10:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779210935; x=1779815735; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tOITleWCuvpi0+dYRoQBpEMVHrSEpgzzTWuCd/gwHCw=; b=LYvdO943H4zRUYBvtu17kIYpE2BSWCWwesHJjAUhNibnq8mpoB7RZSSLlYfRPG7dnP Dxy9xy10g65Z2jiz2/2tOTHtXKvP+fjggiwMTEzSjwYaq8kM2ZuWXntc2Ou0BNKhidPl /upYtCJGMneI8GDQieEUcy0t2/UVSBWM9buExP24XcyTMxO2OQcrik2Da/zz4Ee/PHCu mH+sl4gPxj8VN7gr1+djpRRr665WsMxsznIH8vbPXcY+kUUtYZgqUzSQIRlpV8qmh6iE 1pwb3YCI+1f/KB7OAkkJpCAsCcGj0cslatbq13jvOJV/WCuouJTk4X6hauNiBcnUz8X+ fbGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779210935; x=1779815735; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tOITleWCuvpi0+dYRoQBpEMVHrSEpgzzTWuCd/gwHCw=; b=Kk3NcN2o7OONxTHnsSd6JvXXy5E/PwtgiGBgmWhm9GjFlG0iZy1cEpXqZBxrmLWLJE EthL8kVJpN9yqLM25n2CG8kK9AXmP7F3i7/6/EA23xoIJcKhgHFYNNoGXSdHrZIzDLqX PjtcTLZO6s2sjp2P1FQ3I5zAqRSQDjMjQEAZ/rkuDKYFDYmMtFX0CYpw5UkpYCDkWySP 1njW/p9wxfvFSQqFSFFMdFyG3T6C8u4fRs9VLCpxsQBs6NywmLe0XqsMf8DkBc2YN9CT mIM1knZkDzPEhymkVVYMlAPKwy2efpjmpC6H5V1rfEl3Z+1bDjBRFO5jEohNmRkyC2cA aehA== X-Forwarded-Encrypted: i=1; AFNElJ+bEyCXe5thC/GXKg2YXR3wJklppYWQcsIoIec2X5giyU1P05iB/sSj/IifyWOBZrgeRBE2Ok0pu5KhetU=@vger.kernel.org X-Gm-Message-State: AOJu0YyrvTzJJ/WICFtrYI46oWtr0XKJ5GQKLWrHpH3j+FSAHuuVw/Dn ECLONSTQQXejpZFhYFtrL8UkUDhpG0h4N5L0VvKnbv26wdweLJpwI35+cT1P7ovvbosBd1whGEA +91Gm9+O3zlSZADLWAwV6nFabIRL5ln0oYaeZkkkIfsHv6I+fetl6R5BZbYoCM2Phy9A= X-Gm-Gg: Acq92OHu2u4aUCxTqsExPmTiVkOTJvGeUe+VL+xMCX4YYZMimpaijusVwOkUVFrA/aX F5HZOw0ZitoRkV+C5piAtZCKu8lLQQ9od07LbmLhVYQlUCFRvNzHpBtwgG2aXJ3zTt4/AsJwX5y wk+SIoWv9RFd3BUUpQxArVVZh8Gd4JcZIul3PEzM/GsJOYKixNJVfsKW1dQOq7Bg4j8lVWmz94U heIY+tMC4D7iQIHS9AgMTAe/KYGp4FcD4RKrZCa/e6QR3MnfLF48ePci8RQ1/7TmtFpQpR2oR/y eDkgQuH8SiM0rJZxOceBepem5y6bknBUZhyGbjUWR48GaMXMmWXInR9fvAPdX+m+vkdA8yV5dvC wfjgtLzhL56/j27t5qso2ts4oxsnT44lZDf92GAe6ig9kNGsq X-Received: by 2002:a05:6a00:6c9d:b0:82f:3828:a01d with SMTP id d2e1a72fcca58-83f33cf0bd2mr20263871b3a.29.1779210935038; Tue, 19 May 2026 10:15:35 -0700 (PDT) X-Received: by 2002:a05:6a00:6c9d:b0:82f:3828:a01d with SMTP id d2e1a72fcca58-83f33cf0bd2mr20263832b3a.29.1779210934470; Tue, 19 May 2026 10:15:34 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19c77822sm18634720b3a.41.2026.05.19.10.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 10:15:33 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Marko , Guru Das Srinagesh Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha Subject: [PATCH v2 1/4] dt-bindings: firmware: qcom,scm: Add minidump SRAM property Date: Tue, 19 May 2026 22:44:39 +0530 Message-ID: <20260519171442.1582987-2-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260519171442.1582987-1-mukesh.ojha@oss.qualcomm.com> References: <20260519171442.1582987-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: -6Aww05PJlL6Axoudby24o3GjjEAdatl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE5MDE3MiBTYWx0ZWRfX2TAR34wgbife e9K5gAJaOeL41rUzVC4D5yLIjI/TdboGxe3A1huCz3AiFba9Q3A5u7N877x8n7B2LwcwM6mxiwI crXdLjAbBWD9MlulRUevHtWL9gTS1anEsS91gUN4mW5iV/uqca7ZD0RG6ylU93mcHrWj1sUvE0d sEK/r34hwmVqPxehjx74VW8Sc2trBuU7mks6ywnWpCe9VheuHyitx8TTQoM2nDei5AZBlS12m6X ouGUZDYp4YN98TAOWjAFUHA27isaY8EL7juE9zF51yGlI9wgCoIiBoQPS05p9hMn9xcjrySmXdc i6rD/KRMx/VKWQeVMCnJfAsTe41l5UANEWAQfqkYr8sTvj1wQcmYUWEXZMguWD1geMmnaXtDh7a yUFenH5Ak/9RN57KQYkwjzWMoR8KTompHv5QguItQgKWljazmkbmfe1QOeVWcf1kLdDnRg6CZnd Jk18Nxvv8Z3xPR8qMjQ== X-Authority-Analysis: v=2.4 cv=Y/bIdBeN c=1 sm=1 tr=0 ts=6a0c9ab8 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=Uf9RHLb8GrDHKnSoJrcA:9 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-GUID: -6Aww05PJlL6Axoudby24o3GjjEAdatl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-19_04,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 phishscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605190172 Content-Type: text/plain; charset="utf-8" On most Qualcomm SoCs where minidump is supported, a word in always-on SRAM is shared between the kernel and boot firmware. Before DDR is initialised on the warm reset following a crash, firmware reads this word to decide if minidump is enabled and collect a minidump and where to deliver it (USB upload to a host, or save to local storage). Add a 'sram' property to the SCM binding to describe a region in always-on SRAM where the minidump download destination value could be written. Boot firmware reads it before DDR is initialised on a warm reset to decide where to store the minidump either to host PC or to on device storage. Signed-off-by: Mukesh Ojha --- .../devicetree/bindings/firmware/qcom,scm.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Doc= umentation/devicetree/bindings/firmware/qcom,scm.yaml index 25f62bacbc91..27422d00b8fc 100644 --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml @@ -129,6 +129,13 @@ properties: - description: offset of the download mode control register description: TCSR hardware block =20 + sram: + description: + Phandle to a region in always-on SRAM used to store the download + mode value for boot firmware to read before DDR is initialised on + the next warm reset. + maxItems: 1 + allOf: # Clocks - if: @@ -250,3 +257,12 @@ examples: clock-names =3D "core", "bus", "iface"; }; }; + + - | + firmware { + scm { + compatible =3D "qcom,scm-kaanapali", "qcom,scm"; + sram =3D <&minidump_config>; + #reset-cells =3D <1>; + }; + }; --=20 2.53.0 From nobody Mon May 25 02:53:59 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A59E48AE2B for ; Tue, 19 May 2026 17:15:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779210948; cv=none; b=Yx8I127oziMIgmfd1RWtRZ71Si3i6mnTbvJChi2LmSu861M2z7kTIuoicvnZ6TsOtYTforx36IqzATlYiPxu9ruXMHtB3SNbKn2KzVQ5HcCMQLgR2i1WC6ieH1Uf6fS4neozCXIbrMa+wC91DsCwy7v0j12MMYJ+vaJyPgecLyM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779210948; c=relaxed/simple; bh=MCragVeqWGfwwLMtO1vbVTdRFf4q/FyUz9Na6DMFRdE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RzmiarubGGJ7Ju7wyuXVxwGgQtichm06ZWX21BJTh6lytBEGK+EdMUPKKEuord2SO3KKdDgU01uELzvRxu1CB7KkqMkQi/IXHxtDoz4BXnLADFuhM9GvExBU0ZVktdyVsQlKX4tnYDBi2kBIjcKMRECQh+i9FvaI7ebjTr0IQhY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Xma0Spst; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RyGFwMjC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Xma0Spst"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RyGFwMjC" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64JEwlfG1636897 for ; Tue, 19 May 2026 17:15:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=+J0UtrHxFLw 6ZMOq5E+Alm1lz0ZEDn8wjg09ZAPN87Y=; b=Xma0SpstGs2h892VEZcl0EsuuZV /OqYjyqFPk5EsN1tTEe6H0kakTj+jmQgO3lCYMNONmC8kYpzM5xMuEN0u7EShU83 CI6qMr0xJcgadLKeTWFv3PWGy7qsl9PfA/ruVMmpUysdFwpYASBvyDi6Reo74v5J 7+wqZxXLgcZD1q0RdaY+fbsOckGdCj1WZ2GS3j/sUIYtL1OYoSd9lNE/tXS9fIiU fh2bzC0rSXnEnUkujFhzdi0oz2FguzqOK58lSDndmvaFmCWCPMc3UCs8/jXnUCv1 i7MOFHb7hPwq/Y2uzz1Zbj4rMQQxPSesZWuYhgTxjOyuD1zA0zCwaBksExQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8t3s8nt1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 19 May 2026 17:15:43 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-835423c69ffso2047185b3a.1 for ; Tue, 19 May 2026 10:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779210942; x=1779815742; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+J0UtrHxFLw6ZMOq5E+Alm1lz0ZEDn8wjg09ZAPN87Y=; b=RyGFwMjCBbbDC5otKsyyGV7qvNxY1YK81VUEoJKdfVeIBmxdAPTEP9eTJO/yPcB5IN jnMg6Vxnb397197Qt04RcPvlCfRhgeBtbDMhdSWuZ/ZoB3/XGzloE41/zxcq35Uqlt6g as/9Jjyo6hJ/syBTNHTUXiDpZgZ1GriFSCZk1w52kH9zSPA1OomP0UDf26b1XvLNNjWU Q/WToghERbwyfVZZ17OgUPHS9LJnkrZLql2fOgR6aR2KHcp2RpeQ2ntNbNtooGa24b00 SCph2zZJTRyzq5VYkOt6oQc1ImwldoJg4Zf6Xl0bG5ezvvSiNwq9jaIb9wbGnYoLxBQ8 j1UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779210942; x=1779815742; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+J0UtrHxFLw6ZMOq5E+Alm1lz0ZEDn8wjg09ZAPN87Y=; b=IbHY+ymJLQr5QfP4qETLEegryyDJ6FqHfZKQeHsVVzqZ68sF0161Yn6bZq5Uw6JfC8 eurHDhl3uJKSWwXDu9b5bv6SEGsxpZ0Jo8SL5mcXUbyw1lPqURlY2p0G8oT5zU8ZcgLr p/SUX+sJUY1PElwKl8DuzO+cJvai5v/qS/SfpLtMv6fHtexRkLP32HanWDudeze1eqxg bj4X2S6bcQ61teRLel+/T7lkf/xpmc8JjIuH5cRtxkrOzvuPPp1vWPDwl8ZPX3645MLC Ab04Bmlc7vOKe+Vx6R6Dhg1iAfjNWzFhJHHM6n1zxY6+Z9ayydrJTlYrAKjTV7Au7Wok 0uAA== X-Forwarded-Encrypted: i=1; AFNElJ/iw07s7bZQfjwCJAU/7j5/LQtRTnMT2yrkV5zxS3JblaxfV2RoItSIHov7Z29JUq9lfu73QLhX0YAiZAU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzpeza28Y2vn7YOrZxWQyc/x+gUzO+daSiJYRtuE66gz9VQeaJ9 PNJezJCT1J3bu9ie6ECQkQesivczmJpy92skWcOx3S7IfTK1w+BdDI8DCRn1PmtfZyev8F7fJRb 6NxQrDQI63fbKGLl7G2nPkRjFZPyiuPVdlHT3YqXjIkeeJDADyG3Qc5hHGn0sZjhuivc= X-Gm-Gg: Acq92OEcR0gD3mz8IRinVYKl3MNgItOQyHmMiAr4wHY8tF5kBzHrNyEMQGQZN8Kvlai PEus6F38tfzz3C1fIlO0lbszXtes3SVmwXLRtzO+aratB9/xFP0TmsEP3jum0FwYCEvvYXM8Rtj W4SBWQiaL9FnowrmUKnmZSUY/nYVUiUVEbiJMKUfExRaj8L2d/I2cTNwYwMJQLnDeD6toF/139i ReXqZtJ2Qo6iYSDfd5F4w+eGP34rtwQ3IVh4pfC3jtWM6pSAYOpWoudp9tQD+b6x6OjO+lFug8b J7+woPwe7AmYR2glOZity5W37Cq41P2lu3YSFSbhbtDZ9aVc7qhWKcRrsEqEAYI05+bQsg9iktd iUZPscr59e8iPtYPNHNBeRUsBWk/9GcNzBJExlu1ITa/hiNMC X-Received: by 2002:a05:6a00:130f:b0:82f:abc8:ae0 with SMTP id d2e1a72fcca58-83f33b3385bmr20139496b3a.17.1779210942038; Tue, 19 May 2026 10:15:42 -0700 (PDT) X-Received: by 2002:a05:6a00:130f:b0:82f:abc8:ae0 with SMTP id d2e1a72fcca58-83f33b3385bmr20139371b3a.17.1779210940413; Tue, 19 May 2026 10:15:40 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19c77822sm18634720b3a.41.2026.05.19.10.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 10:15:40 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Marko , Guru Das Srinagesh Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha , Konrad Dybcio , Dmitry Baryshkov Subject: [PATCH v2 2/4] firmware: qcom: scm: use dev_err_probe() for dload address failure Date: Tue, 19 May 2026 22:44:40 +0530 Message-ID: <20260519171442.1582987-3-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260519171442.1582987-1-mukesh.ojha@oss.qualcomm.com> References: <20260519171442.1582987-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE5MDE3MiBTYWx0ZWRfX6r1IH+OB71Ge uQooO+HkBHjm/RjCyaArT+wVSW/0oSo8ywdQ25j442J2ST+ghKo3xStikTTgtBNCXE0Lg8B/Vh/ +MO6eqBYP1EnxhtxMrm13GICmgWn8Shhgx1QUxzJ9SpRfVWkQMC10xW0ZoJlY6sSzrzfqAB26jX z+is4I5vOlkRoNaIL7UZlEL9wWuQ2y7ZzM1jIz3hhXTWf9qGp3n9oh904o43JlXFu0hHWOBFwR1 n0KyjReTC8feId4lNT7iB4ZlTw8Sy44gc68LNRDvl2ZCaIIqFPbkBH068a7hLOqWHKSX4hNvfhP EGE8rOp3T7QbZdB8SzXwhLoly7RDF+2AdlS84yTcSbx57TAIFqeByzSPR2jdvqbTHhhlrpjuu/q X/r+B2wH+GwIs24Q1SurDVxlukJ6BJ5WfguON1pYxaMlEyhjr5vyb4U5R4Vza8m7HI1gxbKNb8m x/2lc4KKW9d+9DraRig== X-Authority-Analysis: v=2.4 cv=Oc6oyBTY c=1 sm=1 tr=0 ts=6a0c9abf cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=GEQWD5Nhug1BhVu3dP8A:9 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: cU029KtUb7GXJMyANoMkbRR93pz8TVSr X-Proofpoint-ORIG-GUID: cU029KtUb7GXJMyANoMkbRR93pz8TVSr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-19_04,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 clxscore=1015 bulkscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605190172 Content-Type: text/plain; charset="utf-8" Replace the bare `return ret` after qcom_scm_find_dload_address() with dev_err_probe() to produce a consistent, deferred-probe-aware error message when the download-mode address cannot be resolved. Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom/qcom_scm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_= scm.c index 9b06a69d3a6d..52432469badc 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -2747,7 +2747,8 @@ static int qcom_scm_probe(struct platform_device *pde= v) scm->dev =3D &pdev->dev; ret =3D qcom_scm_find_dload_address(&pdev->dev, &scm->dload_mode_addr); if (ret < 0) - return ret; + return dev_err_probe(&pdev->dev, ret, + "Failed to get download mode address\n"); =20 mutex_init(&scm->scm_bw_lock); =20 --=20 2.53.0 From nobody Mon May 25 02:53:59 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9887B3FC5C0 for ; Tue, 19 May 2026 17:15:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779210952; cv=none; b=W54/0y49OP6PNjP5Wu1buptMy3EkC+57CjUJhoqqX3DYxSy9DKqY9TWmvnF1IaHfTtl+uehj5nTgM1odLcKr2RY7gYMpBbRNlTlHRkcS8+xPDo2anFfi0VsPGdbA6rs/ZHwQt/SRUnsNRDp2K3YBVa3u/AUkFeuTCUzqmXydILw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779210952; c=relaxed/simple; bh=k7XS6g+yACWsz+lIJOxbyvEHuQON0JBUh1Zalmxh+qU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mBtAArK21vK0UQfL3AvQorh7rhm2k6I2boytm0bn+lQNQrrfJ2tGPcTEWNA9fAUBF2UEprIZzjR4/gDU94c11Tq+O4daMNCtohH/7JnNUZi39bujsEgsUY68Sd4kD/tKMagj7/QnPiSFr+fHdVstqqw3HfUc9kOuj8tlPb3g1CY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YCbvO47G; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jK60jVPj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YCbvO47G"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jK60jVPj" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64JExNaR2065195 for ; Tue, 19 May 2026 17:15:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=b0ycF5Fq5Oe oqByK3KqvktQxaoXUN5vjDwDOf+0yGu8=; b=YCbvO47GgEpfdToboN6JOusS/3V qNWgbNwVzdUHvhdsYvUqYqTAHrxQaIxblwUkm4wfkhI1BIabsMS5sc74/4SpRU/2 fM1DdRsc7mcrLjtTT4ERqi9EfE4wvNAqpCeApnJ5IY5dxBqOUcC2V08IGQeGtj9k kbgwFqMSmmw9pZC9LJdCo0oa0jhNLx84wNdEasiMdWRBA7yJhuDGEF5AgBhEPns4 OFUZ7DG0356f4pzw4S6Sb2For79r1VEB2ODeGRoWKrnfK04gpXBy5iBbrtWQaTuT 0mKEPdYQKXUlBOj96IeYFUVp4num/dsHhoM5qvGqbneoOA5gYz2/Rzl5/Jw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8t3t0pfr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 19 May 2026 17:15:46 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c82c84be9c3so1735070a12.0 for ; Tue, 19 May 2026 10:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779210946; x=1779815746; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b0ycF5Fq5OeoqByK3KqvktQxaoXUN5vjDwDOf+0yGu8=; b=jK60jVPjBLLSrXfzRp3sWEMPeq8SNcMVnXskL7Y8OdwLoCIxYjQG25bYBGDWfZ7Lvz tcN5IJ7obBaW290qWaFIaeD2RvCES2gm/9BDagidPSr2I/0BGKt6YzVXzWNXJ/O1em/y EOS6yeX7VZBbpHi5VDDXugjgVAa6ybDi9HjPkng+bW0Kob9pG7jh49MjEYNcXEL9/+BI wirNTtoo0GC7qlA9JHwSo/YU23h2QSGSiSUTGpGqrFTT1FbRr3LVsctxrNIrRrVw1yb1 ibj9Xnt+5m3VIKdHooKB/T7VRhqQFShe20dm7bCD9nUMuH3jhNikRE+vKfq5XvcB96d8 0Pnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779210946; x=1779815746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=b0ycF5Fq5OeoqByK3KqvktQxaoXUN5vjDwDOf+0yGu8=; b=gccyEdQ1QB+EbOt1r1QsFVgOur50uUBuVS8cfhRnGcb86pgsnZ8gptVjhTuFsAxxjA BlbDZd3lOLVx9Ec6NjvRnkmyxhLe+50Rne0o4nIUCLnpg7rsy+2WD0BIrQS1EGWJI2jt gzqc0caa+mo4PorT/A/4FWbhk6u/d5waBS1RNQ0/TfiK8ruu34mgWdKBTvtWjyHZvwRX WChnvt1D3uLRcepYZfyw+2EBLU/0R9T/heZIO2qHOcABPTCBFMTlYeuDPIMgTEM44cd9 e0WLCN9l1OkNNBeyLeHVBZa192e/uYyNWM8SE/wVsFe0hyWuiH1hhQ+utbgAYP5Uc0EA rQXQ== X-Forwarded-Encrypted: i=1; AFNElJ+LgGGdR5pGvzjx47eYiOM836f4miYIQ3C8DF9np0PT9o1mT/yj3x2piaErMiWoKIZSmAmjHVVwPJD0KNA=@vger.kernel.org X-Gm-Message-State: AOJu0YyvcvalMibc09MxHN9T8O8wua44KMXZkrwUS/FQ5rzg4pLdw7fj IQhUET0/GtkCuBP1KZrXmJZHCo2v9/WJ0VTaf7df+oSNm4E6mOHWE3nZLCbw3P0udlMYUyVEbim A8dpPcx+ZgKf0Gy3pnAhHHU0sv0J4zV/iiWC6gTyJJkmm7B+MqEpgG3B1E/sleFJ30qY= X-Gm-Gg: Acq92OEZ8eb8JI5xwB0zdzpxTDMJCJIqN+Mg76/+83C193Hk26WS/gj/0FJ2epS5jEM jCIXaf84VTdP50hw15zwuOIpP1rhDL57sqvEAIus8GL9nJMxujOEIL1wU0vUl9eX+SxKlfO/CzV GRFlkJYX6Ec+jYVSzRvu587hGshmKml++OGyUM+ZSyebpBOJFvkItNodGoNreJPSu8bN5MW+8pm po2nEDlhyyTQHJ8aIUKFDbTu5k/aSL6xnb8N5EJDBoLvOI9k6+Q9cl59GznmWG7N6tYdB/mGnA8 UIFSQOMy6cqrlfBO416gbrebg2bhjwSvxiDVRRWF7witnTdTVNARWeRWR9aRuB1AS5E2sllKPg7 OFJYowIOMV3jkcmTItSkeT0n+kaTBA3Nrrihf/dnxNmo6var9 X-Received: by 2002:a05:6a00:a203:b0:837:7e7d:3d9 with SMTP id d2e1a72fcca58-83f33dc529amr21144317b3a.44.1779210945384; Tue, 19 May 2026 10:15:45 -0700 (PDT) X-Received: by 2002:a05:6a00:a203:b0:837:7e7d:3d9 with SMTP id d2e1a72fcca58-83f33dc529amr21144248b3a.44.1779210944514; Tue, 19 May 2026 10:15:44 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19c77822sm18634720b3a.41.2026.05.19.10.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 10:15:44 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Marko , Guru Das Srinagesh Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha Subject: [PATCH v2 3/4] firmware: qcom: scm: Add minidump SRAM support Date: Tue, 19 May 2026 22:44:41 +0530 Message-ID: <20260519171442.1582987-4-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260519171442.1582987-1-mukesh.ojha@oss.qualcomm.com> References: <20260519171442.1582987-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: ouI3DfZEWmxzZYHbF7_GW_Qgd2jUO2nV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE5MDE3MiBTYWx0ZWRfXzjnZYJd4DE1v OAXx3iWDvVWdEmGVPUkmyP7YPnpwMg3l5k1sqq0ZR0T5q23XU6+GglgpRkYsY9g55lKOl3Ak74d fHdF+HIq2rk/pbX5HVESz2k1XKX8K+Gyr3Fjem1HrxUmA4ZWnaTFtTUMMrTOqVqc4pFGvnK3Ll+ q0HAQN3cu2Q87Y/cVxITceT0q4Xbr92kSX3bOlYorzjVYsR1Q9lMIwPeleyFxPCdE2gePEButJa ApmTf9CCK/HZtNwgzSdTSC2NgeXxJjqh2LC2XRn2xkT+GXPzW7p3B4AvnbWydd0lFLELDzBbKaE 05aVEFDds2jLJ8vwh4xfngl3HUp2l1fgvkc3PIvLAtCA8TBzaNtYbXPz00+sEljek0v7a6EhO15 /WzmtbwrA8+xH+1o8/clhJfRXtF43e1NHresMwuciD6BCHx0Ph9HLbG9sFUi3xtgdkSoVWS7XFZ ZmZpXaMIZGOTAm8i9LA== X-Proofpoint-ORIG-GUID: ouI3DfZEWmxzZYHbF7_GW_Qgd2jUO2nV X-Authority-Analysis: v=2.4 cv=C4LZDwP+ c=1 sm=1 tr=0 ts=6a0c9ac2 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=rvpxAYJ4qTt-cjm6DxwA:9 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-19_04,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 adultscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605190172 Content-Type: text/plain; charset="utf-8" On most Qualcomm SoCs where minidump is supported, a word in always-on SRAM is shared between the kernel and boot firmware. Before DDR is initialised on the warm reset following a crash, firmware reads this word to decide if minidump is enabled and collect a minidump and where to deliver it (USB upload to a host, or save to local storage). The SRAM region is described by a 'sram' phandle on the SCM DT node. If the property is absent the feature is silently disabled, keeping existing SoCs unaffected. Expose a 'minidump_dest' module parameter (default: usb) so the user can select the destination. Only the string names "usb" or "storage" are accepted; an invalid value is rejected with -EINVAL. Changing the destination while minidump mode is already active updates SRAM immediately. Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom/qcom_scm.c | 91 ++++++++++++++++++++++++++++++++ 1 file changed, 91 insertions(+) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_= scm.c index 52432469badc..e3d5973bf567 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -57,6 +57,7 @@ struct qcom_scm { int scm_vote_count; =20 u64 dload_mode_addr; + void __iomem *minidump_sram; =20 struct qcom_tzmem_pool *mempool; unsigned int wq_cnt; @@ -141,6 +142,18 @@ static const u8 qcom_scm_cpu_warm_bits[QCOM_SCM_BOOT_M= AX_CPUS] =3D { #define QCOM_DLOAD_MINIDUMP 2 #define QCOM_DLOAD_BOTHDUMP 3 =20 +/* Minidump destination values written to always-on SRAM for boot firmware= */ +#define QCOM_MINIDUMP_DEST_USB 0x0 +#define QCOM_MINIDUMP_DEST_STORAGE 0x2 + +static u32 minidump_dest =3D QCOM_MINIDUMP_DEST_USB; + +static const char * const minidump_dest_name[] =3D { "usb", "storage" }; +static const u32 minidump_dest_val[] =3D { + QCOM_MINIDUMP_DEST_USB, + QCOM_MINIDUMP_DEST_STORAGE, +}; + #define QCOM_SCM_DEFAULT_WAITQ_COUNT 1 =20 static const char * const qcom_scm_convention_names[] =3D { @@ -568,6 +581,14 @@ static void qcom_scm_set_download_mode(u32 dload_mode) =20 if (ret) dev_err(__scm->dev, "failed to set download mode: %d\n", ret); + + /* + * Write the destination into the always-on SRAM so boot firmware + * can read it before DDR is initialised on the next warm reset. + * Only written when minidump is active; + */ + if (__scm->minidump_sram && (dload_mode & QCOM_DLOAD_MINIDUMP)) + writel_relaxed(minidump_dest, __scm->minidump_sram); } =20 /** @@ -2040,6 +2061,37 @@ int qcom_scm_gpu_init_regs(u32 gpu_req) } EXPORT_SYMBOL_GPL(qcom_scm_gpu_init_regs); =20 +static int qcom_scm_map_minidump_sram(struct device *dev, void __iomem **o= ut) +{ + struct device_node *np =3D dev->of_node; + struct device_node *sram_np; + struct resource res; + int ret; + + if (!of_property_present(np, "sram")) + return 0; + + sram_np =3D of_parse_phandle(np, "sram", 0); + if (!sram_np) + return -EINVAL; + + ret =3D of_address_to_resource(sram_np, 0, &res); + of_node_put(sram_np); + if (ret) + return ret; + + if (resource_size(&res) < sizeof(u32)) { + dev_err(dev, "minidump SRAM region too small\n"); + return -EINVAL; + } + + *out =3D devm_ioremap(dev, res.start, resource_size(&res)); + if (!*out) + return -ENOMEM; + + return 0; +} + static int qcom_scm_find_dload_address(struct device *dev, u64 *addr) { struct device_node *tcsr; @@ -2733,6 +2785,40 @@ static const struct kernel_param_ops download_mode_p= aram_ops =3D { module_param_cb(download_mode, &download_mode_param_ops, NULL, 0644); MODULE_PARM_DESC(download_mode, "download mode: off/0/N for no dump mode, = full/on/1/Y for full dump mode, mini for minidump mode and full,mini for bo= th full and minidump mode together are acceptable values"); =20 +static int get_minidump_dest(char *buffer, const struct kernel_param *kp) +{ + int i; + + for (i =3D 0; i < ARRAY_SIZE(minidump_dest_val); i++) + if (minidump_dest =3D=3D minidump_dest_val[i]) + return sysfs_emit(buffer, "%s\n", minidump_dest_name[i]); + + return sysfs_emit(buffer, "unknown\n"); +} + +static int set_minidump_dest(const char *val, const struct kernel_param *k= p) +{ + int i; + + i =3D sysfs_match_string(minidump_dest_name, val); + if (i < 0) + return -EINVAL; + + minidump_dest =3D minidump_dest_val[i]; + if (__scm && __scm->minidump_sram && (download_mode & QCOM_DLOAD_MINIDUMP= )) + writel_relaxed(minidump_dest, __scm->minidump_sram); + + return 0; +} + +static const struct kernel_param_ops minidump_dest_param_ops =3D { + .get =3D get_minidump_dest, + .set =3D set_minidump_dest, +}; + +module_param_cb(minidump_dest, &minidump_dest_param_ops, NULL, 0644); +MODULE_PARM_DESC(minidump_dest, "Minidump SRAM destination: usb (default) = or storage"); + static int qcom_scm_probe(struct platform_device *pdev) { struct qcom_tzmem_pool_config pool_config; @@ -2750,6 +2836,11 @@ static int qcom_scm_probe(struct platform_device *pd= ev) return dev_err_probe(&pdev->dev, ret, "Failed to get download mode address\n"); =20 + ret =3D qcom_scm_map_minidump_sram(&pdev->dev, &scm->minidump_sram); + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "Failed to map minidump SRAM\n"); + mutex_init(&scm->scm_bw_lock); =20 scm->path =3D devm_of_icc_get(&pdev->dev, NULL); --=20 2.53.0 From nobody Mon May 25 02:53:59 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8666A3ACA57 for ; Tue, 19 May 2026 17:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779210954; cv=none; b=DmYbeW01A9TtKnEjEmST3oIZBhWg6SMNlJSfO97WQEoXtp8o8pRjHodp0aD0qFHpxb02aRZGnkQcbP65rv1ep/gUqE3k4oug6pKisDQz/lYrrj6dPIq6V+kmiFjkvvfJNbtBdjuuP7HOyzl6HLeTmzv+JS3eyIGbOgbg7xHGfpE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779210954; c=relaxed/simple; bh=KI+58/ONAYxQ6op8vnR01ldyxV8090Z36iFsslPUisM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ks9sh/Ah4GIbKqxCnzBLYo+SrE4aTGkmU4h5TYyy6E6/7yc2OtnbM5lJKN2vNtrt81k9D1ONlqEY+MsfL8f78L+/bXHxkPMpflySiZZlLvzg2XyYmi872tYnqX0CdkSTEiMJhtqw0mR0ZUO8QQFfYQ+hfUMqfj/zsRAgufhRw00= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Yg9oOiyi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kSjcuV93; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Yg9oOiyi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kSjcuV93" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64JEwdFC1739333 for ; Tue, 19 May 2026 17:15:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=lfKVHCmUtRu 10BDgmOnebTByINr9r0sGsNkJtT8G/r4=; b=Yg9oOiyi+y5eLhnGUIJI5a4hY7T c4+gZWxznsB8Vf74Pyr0+59E922Ee4i+f7zqu3HiYK56EXU3DRVpTueDlRs/8tim c8pnDDshlnTfPis/zXQlyYMZ42R9r4rua1v1g1ljX3h8UzN2BknabuQkWdg5ZReC 97FDoxX0UcEK4zQCG80pfs5vyGKpmHVbrKV/L6+laccCExqPkCe2K4ltiz+1JPsf f+K1eBSq9D/aJDmhBrLWzv+i68pxHmwee3l1idTou4NWzcAF3sZ2DmNlM+CmVe+W xiJxVKJ04lMN/Zd+Qtj6MnmeUzWRIaIVlzGlBgV7MB7rBR5J+jxiUeypYtw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8t3q8nc2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 19 May 2026 17:15:50 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c8024fc7032so2189146a12.1 for ; Tue, 19 May 2026 10:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779210949; x=1779815749; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lfKVHCmUtRu10BDgmOnebTByINr9r0sGsNkJtT8G/r4=; b=kSjcuV93WQqxfDLWCQsMaJVcTjM35jocDwqRHeEnnCRgB0PMCj24GbQX2dEvFFraKj 4XxBiBgBiJj2FInZ4pu0vnacMIMKevGNcDxz5vGs7UETQNcFnFc1xANPPleSWfJVgEdX ZB/YkxlKBaLZfU1hDhiFkKhu+A+DeYK+0nomgghLz2DV9N/pTvNSrZ4cG0CdObj0dDQa HgHNDc7WJh1kXzWK+oYjndPjkHHVzzNgD8XKFgCLenDq9brspYAvYtlIO6yNfr2LBjiH CehRqHypJf8G44UfbycsFGQc4YsKXLIXxI++V8+rZH7w8hrF+M2nfDvatkQrPNvfWqE+ AfSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779210949; x=1779815749; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lfKVHCmUtRu10BDgmOnebTByINr9r0sGsNkJtT8G/r4=; b=JfcRUgWYnXNp8pAAKM9MOGanIluvfttS+eVHXAgr8Ymr1c5tLVdsWPSQk0nYzn747S egOAhUkaJ5Ipfe01Mo2daiOC94I3eYtZ/aZCD6pik81BbXbLvKXwiB9EQaVax49d6l5j qFq/qrRXdJPrBl+K+zJbpwV4+lsqGRMzyq552sYxicELopnlK7wuudgI5PZ+Dpr4fgJ3 dKovbX1Xq2XljbRyVZZ3TDjCGgCDCOMH2RNpaw7XacezJ7BCcVDHz7gpVagc1t/3D4LN BvQK2WsfbOrh0EY85hABmNyYCcP6qJpLeCknSNrMVURS9ZDmdJLoWTH980CjzAfD7r/5 zMNA== X-Forwarded-Encrypted: i=1; AFNElJ+O/jkr3iTqDAUViMUApwB3AOGmHkXnKpDt0UJSjFZIkQlZlzqobEXZ29M0/fpXRi+GApnixTbGLouNPKU=@vger.kernel.org X-Gm-Message-State: AOJu0YwuWWzs05nJBa2KvjaUX13ZhbKXlVw14R75VNMonlC0jefRQtJk CbYLaPu45on+iE4GQPQpGTHm8xIpAVcKhSBoHK32qpjeLIqlChjf43s+tgVFioq5fPR94FZwMeT 4qZg8681bH2Y3yhTfEKAkWvrehgVgf9hcgh/j9IxgdJK9YN9zzj+vMbWhKtlw+Wuy820= X-Gm-Gg: Acq92OEU6YFCUfAAlqJKZxQrjIdEV0C1i2WYkPHEW0qhxhV/UjZrm5xq78J9yhCKBuP SEBKyrQbgyr2h0LTZoDe96eW/IgmPuN2W51/3CTh5rEN5OB/x18HFTVeMZg02nQiL/dAET6eEkY CGawQenJe//6MvUw8C61y1jCmR1J5yyRec3TLivLRLGtcyKuAkhWG6VxDMkqSlrSEoA/+5MYgCD WWzUOheoAl/tHX7zEc2ieZ6650yab4VTz1IHqaHhxMzKAo2gw+Z4EAQTUk86wwWMIeS9oON/uuM nyaO+Qzt8zCbYiaUMfdZtfUiFdk5mrq0+XTL6pMlRl+AEdie/sFVHwPifgRxzeH1zG7HoFMU/+o lnJp017+CZffynaY0O0PgMsbE5wJaRa4kBoqzb1gSeCs4FEpp X-Received: by 2002:a05:6a00:4397:b0:837:8ae9:6c30 with SMTP id d2e1a72fcca58-83f33d8c21cmr20246549b3a.29.1779210949136; Tue, 19 May 2026 10:15:49 -0700 (PDT) X-Received: by 2002:a05:6a00:4397:b0:837:8ae9:6c30 with SMTP id d2e1a72fcca58-83f33d8c21cmr20246501b3a.29.1779210948532; Tue, 19 May 2026 10:15:48 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19c77822sm18634720b3a.41.2026.05.19.10.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 10:15:48 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Marko , Guru Das Srinagesh Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha Subject: [PATCH v2 4/4] arm64: dts: qcom: kaanapali: Add minidump SRAM config to SCM node Date: Tue, 19 May 2026 22:44:42 +0530 Message-ID: <20260519171442.1582987-5-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260519171442.1582987-1-mukesh.ojha@oss.qualcomm.com> References: <20260519171442.1582987-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: WYvN1IE_rHvsYN8iGcW_7gTX2vEN8F4u X-Authority-Analysis: v=2.4 cv=LcMMLDfi c=1 sm=1 tr=0 ts=6a0c9ac6 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=ZJQsJAtiAu0WCEyc7p8A:9 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-ORIG-GUID: WYvN1IE_rHvsYN8iGcW_7gTX2vEN8F4u X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE5MDE3MiBTYWx0ZWRfX6Reu3+rwWPwM 32JmPbzeo5V/k6Y64iMaQZFXYG4mhGhlaqTUsiF/1AEnVY0Y66W82ux9hPQyxiTTJRBGy7xsu5S qEebYrrnwrt6rRF66FY26X63CquQ+zDgprycXhjoN0c33Q2/yUJTBmcqjBkOrMvvLuUvpCxGc7q GB9jraZmM3UkA80DARwl3MQNL+HxChdlpWljg1ptrj0EtpBnWwnTe8qIGSfhtiomQskvxutC/fc hJcqgWL90R7uDJP4Dog203MFefU8GRp6UWB16k8QT+IlsD92e49GOmhtB1ZoCASU5fZX/pLMTaL Vlc/HiY0WdmLLMEhhjXA/Od5q7lX4X865nkxivgpQL4PJ51+tMPk4qfpI4L3l/58y1t9iaHDTq0 7ekRfOAdSmsvhBcSc2Bp1pEAQgG9mjCsBFMLzxaOWwobzTCr3VrGg9pXtzlWHHp3vYVGjraZxWu nfZEkvTFjNrAZFsvxRQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-19_04,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 spamscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605190172 Content-Type: text/plain; charset="utf-8" Point the SCM node at the minidump config slot in the always-on SRAM. Boot firmware reads this word before DDR is initialised on a warm reset to decide where to deliver the minidump. Signed-off-by: Mukesh Ojha Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/kaanapali.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/= qcom/kaanapali.dtsi index bcd1cee31356..425b532c53be 100644 --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi @@ -224,6 +224,7 @@ scm: scm { qcom,dload-mode =3D <&tcsr 0x19000>; interconnects =3D <&aggre_noc MASTER_CRYPTO QCOM_ICC_TAG_ALWAYS &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; + sram =3D <&minidump_config>; }; =20 scmi: scmi { @@ -5448,6 +5449,10 @@ sram@14680000 { #address-cells =3D <1>; #size-cells =3D <1>; =20 + minidump_config: minidump-sram@1c { + reg =3D <0x1c 0x4>; + }; + pil-sram@94c { compatible =3D "qcom,pil-reloc-info"; reg =3D <0x94c 0xc8>; --=20 2.53.0