From nobody Mon May 25 02:56:45 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B45903AFD10 for ; Tue, 19 May 2026 15:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779203311; cv=none; b=Sn2jGny3/Z0+vbo2u0EVxNkTigjQ6LxxeVw7myOlRfIGwz+F9KiWa5OmVisJKCAKuCz9DzL+YcihLrjVUakZAU+dq9NL/A76mWjNfycW/BCG836Aa8q/U8lHyLFTzt1mn6q14f7WyqU6kgZN9HYED7gCdcR4lKKeSwK5gCTkOnM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779203311; c=relaxed/simple; bh=gIyTbMVZo8oTivU+L+iUC7MZ0p4vQZ+dB80RhLLIzW0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=gSg3K9a/ycXVkPSDpwzoT4VAkdxkf0a3flMyffMko1sK1rN2fwDlpXXOAuO8yBOVkGuVt2foCUywNGAgn9dtljBKjuNbfh0L8sPc/pCLsiP8vZmSZnTQsuwMl1fItznrJjm35fWuD4G9DlruWjJmzldAJ0ZfWPxxDGxv35kAUNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Lwk12n9D; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Lwk12n9D" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48e6db3ff7eso18954295e9.0 for ; Tue, 19 May 2026 08:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779203307; x=1779808107; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZafhjMvS5iVLV8z8KBAbQMcJgUXaOxdh1lGuv0i+yeI=; b=Lwk12n9D+D/8y7AP2B780qu5UdKz8gDAIZ7771Od6t2Amw8ScG2DsY4k5DmFYBWcjk p2Ny0Bh2RZ5dtL5YjR5cnMcQ7saxORptK6pG8d8uzj5F+c7sAmyx8fGVNC3YVhW0/17f +r3oQ0FbEWkdNveSVG0dKO8gFT2dGM/4w21dBSJLh4DJM4/IWJ7WOpEOfC9UVB7y9gim hSxKS3jNSUkoIJHOL+pSDxQ4i+DvmRldJTWeZmM/tMDZErt1Kv5LTVJdzRhJAoggiiEz wLHH8kUtleP1dwYpd8N+3lkzpWDBU5ZqC4zLkxXZobfLBND7QTNXeue8gUaKV547M01N I6ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779203307; x=1779808107; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZafhjMvS5iVLV8z8KBAbQMcJgUXaOxdh1lGuv0i+yeI=; b=buEvaUV9anY0fI+85enctNR33xOCbmPy8qWMoH0Q7V444/zl7FMfihji0xzC8vF3ot 6+Hrx646ylfhP/CobwEjstFth9q1bGFK/JLrOMiNcorS4RE+gKH/9wqncjd6ZC78ur4f Lgd2P9YSz1FHDLMVXVzIpFptnV255bJ/eeAX9sjEulP0JzDFR18XZTcH3YJOLTX5Cx/A lUKPWV4ghyZsNGCyRXHYruAESt3HEAcq7ywGbKz8tSXX9Yy+nuTjiby4INr1qkN6cgvD 7spffY46Pco6HUdskt4+8RWD2Ahu5XmVheuTEqB6ns2B6yrYEFQk/5lG4z1QcC4lT6Vg 4PJA== X-Forwarded-Encrypted: i=1; AFNElJ9Gzz/SDnRCDi0uLmyzRm97E4ZADm0vtZBqo3OBv5+EhNsgRQFdFCGsAkPVVlz8aYb8l2ubsscU4dAyWOM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywf3QSak6jI3I/vg1u9CIxQ8cRvn1ukk5oyMbQRihOApMwZ3r6I +y9d0B/lVPbEvCND0NUVVOxRrUugijp1OUbONY+5VM+IJl3/dIurN8A3qEebYAtVO7s= X-Gm-Gg: Acq92OG9RsTteA4pMrKevM0+gbsz2BswK0d1jDhiK1Rkj5gvj9exbVsPQByiAZx6dQt Zqg+ruCX89iVHwKcdx/bQ7btXYXwtmSYYtZZp10LS65XYnzTSp3qYauCruYAjAXtF0JJIugVCfk 2RWtEzOk86NClN4YaxdE9RzTF2aUbKD+s6PRauRfN6nOHIXeKjIcjdWshEX+XYMMaD9+OokHXtm hupZdCc/NGjS+VWeqtju2rS/xo+Xd5IQ29NcF7KfiTEXE3xfUYeIEtKgxGjOtY4YNOgHIkcyf7G SyMdmu6IeQXklhl1tTc0ObmHOkSESjfjMZvqqcNsSETUxZOO6XnuWEQUKepsV+AYCB/NDIq4ul3 6b9Lbor5K9K6rixjoNBDPpfX0On156xogThX9r1HR7zPYLia/qZNXi4MQgyEFN8Gc9aJxuWJ5gE UTdJzSWQ1/kgAw0R+6EL20jmK/tyfkt6QKI/lyod3RXc5IyKXBSnnxE1vklN3c+CYgIbSutO6Bh BOykxTPkhQV470= X-Received: by 2002:a05:600c:4e47:b0:48e:8345:6f8f with SMTP id 5b1f17b1804b1-48fe632361fmr322914425e9.18.1779203307084; Tue, 19 May 2026 08:08:27 -0700 (PDT) Received: from localhost (p200300f65f47db048a8dfcf61053817f.dip0.t-ipconnect.de. [2003:f6:5f47:db04:8a8d:fcf6:1053:817f]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-45d9e768bcesm48390695f8f.4.2026.05.19.08.08.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 08:08:25 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Benson Leung , Tzung-Bi Shih Cc: Guenter Roeck , Dan Callaghan , =?utf-8?b?U2FtaSBLecO2c3RpbMOk?= , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v1] platform/chrome: Use named initializers for struct i2c_device_id Date: Tue, 19 May 2026 17:08:18 +0200 Message-ID: <20260519150819.1591409-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2187; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=gIyTbMVZo8oTivU+L+iUC7MZ0p4vQZ+dB80RhLLIzW0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqDHzjzqz1XSHwHEQwVCZaixXB3ZcRSzu0cnWVd aOtmI6gNzWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCagx84wAKCRCPgPtYfRL+ TqWYB/92+bp9+2WuMbMgWbwkMC4YblBdayAHB8zJZuOT0IOt/9GcrbNM92w0uJfEojGGGmGQqDX ZEAJtLGZ6em3rMlAXbWFdmt3T+Eau+0S9B7EPqu3HAPWKDOo5YNVyi7Ku3GnLlpOEgkZQSSI2KC IIzBZgGmuR94aS41sWyCCzaAO6FQ9p9O3sreVkzcPoqGLcrLWQpJFi/pfDoljS1fWKwx2o2LiGH J00xVKpH+/ZAM4fHakAmElYgvl2ZP9r/NVoR89GC4JvCNh1VZKqQfwNqmWs/Yggr5kWE91QulBW PbJ1/6A37/jwA7EaLm1CqWSVq9qxZc2LsHR3pDd3+lg7dQOu X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable While being less compact, using named initializers allows to more easily see which members of the structs are assigned which value without having to lookup the declaration of the struct. And it's also more robust against changes to the struct definition. This patch doesn't modify the compiled arrays, only their representation in source form benefits. The former was confirmed with x86 and arm64 builds. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- Hello, this patch is part of a bigger quest to use named initializers for mainly struct i2c_device_id::driver_data to be able to modify i2c_device_id. See e.g. https://lore.kernel.org/all/20260518111203.639603-2-u.kleine-koenig@baylibr= e.com/ for the details. This patch here isn't critical for this quest, as no driver makes use of .driver_data, so apart from the better readability this is only about consistency with other subsystems. Best regards Uwe drivers/platform/chrome/cros_ec_i2c.c | 2 +- drivers/platform/chrome/cros_hps_i2c.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_i2c.c b/drivers/platform/chrom= e/cros_ec_i2c.c index def1144a077e..2f46be4a2756 100644 --- a/drivers/platform/chrome/cros_ec_i2c.c +++ b/drivers/platform/chrome/cros_ec_i2c.c @@ -348,7 +348,7 @@ MODULE_DEVICE_TABLE(of, cros_ec_i2c_of_match); #endif =20 static const struct i2c_device_id cros_ec_i2c_id[] =3D { - { "cros-ec-i2c" }, + { .name =3D "cros-ec-i2c" }, { } }; MODULE_DEVICE_TABLE(i2c, cros_ec_i2c_id); diff --git a/drivers/platform/chrome/cros_hps_i2c.c b/drivers/platform/chro= me/cros_hps_i2c.c index ac6498c593e3..3b9485627831 100644 --- a/drivers/platform/chrome/cros_hps_i2c.c +++ b/drivers/platform/chrome/cros_hps_i2c.c @@ -131,7 +131,7 @@ static int hps_resume(struct device *dev) static DEFINE_RUNTIME_DEV_PM_OPS(hps_pm_ops, hps_suspend, hps_resume, NULL= ); =20 static const struct i2c_device_id hps_i2c_id[] =3D { - { "cros-hps" }, + { .name =3D "cros-hps" }, { } }; MODULE_DEVICE_TABLE(i2c, hps_i2c_id); base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 --=20 2.47.3