From nobody Mon May 25 02:56:45 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A518D3AFCF5 for ; Tue, 19 May 2026 15:02:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202926; cv=none; b=PydM+ZDfQjgLF+3CKjI+WTKwYuXxdkQ6hyNCHVo6cI5ZtgR2sf8TKbd4VRBUa9tOwZ/3/x08Xh2y0K27IaI+TEpb8x3rCdGAmbwOUVDnA4qvQcWMgvGv6P+OsDDQWff+oO0VBqumHLXgwZfvquhCpTIA49wS1QQLAhqIWec3r04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202926; c=relaxed/simple; bh=cmpjBF/YYXkke9emOrt0Uyvq9m4XkcGd10/Ml1tUeLY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=oCqRzbnIds8VCjSlAqq7EJIHtWOX75vaixsotkfS3cFz4ASpd9fN2SgbpqaBaPf1Ajh/gcNFM9cNFseo8fehLgb9N4qzyF6S+16WXHJtCKy6jdpksa3OxUiP+cp7H2P24vdpGnfOh3p6V46UTSJj+1hxOZPsainKPa8LklSfIhg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=dWSYFh3c; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="dWSYFh3c" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so40893535e9.0 for ; Tue, 19 May 2026 08:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779202923; x=1779807723; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GgT161B6wKarrjgD+/dVj/0hn/MrD5kPqO21KOBfXOE=; b=dWSYFh3cPHu00ItwUHF0JqfGvwsxzBcxIjl2mbAyI0ms4+liqhhWFNaOwlMv7WaV/p qNIaUBe88iyr1lcw9NebTJpQgQ78nCszJTn+6h2NkLKJsLoVc2IOZs5+ok8jGRPFehJC CIHt079JqRjfUmpdxu0xVe186hm5ufa0tkSZXEl6Oo7Mulmm9nzQBOEEcbfwQvltGujw dXqKgbkrTXkwIOvhb3lpYeLirjCPJYF5MV30ZL26OZ5CbKYqVp4+YDzXiIuFMLKXZnYV 5O/vYvGC7ayhBoPeofDwbcCUlXwYT6ADSoZtR0j1A6mY38auUFmBxlM+JyieR4LRHkZS CSTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202923; x=1779807723; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GgT161B6wKarrjgD+/dVj/0hn/MrD5kPqO21KOBfXOE=; b=S9iy3nJG6uEGVkueFScZj94BCHbpWn2CHYbs4iWGSyAz5/EUGXldhSs7A/jTdBAwa7 +WPp4DHWV+5IDHMjjUYYHyVgPfQbpH7lgTE2cmwOH4dS888Kh+eK2TXrpMOn2t+W9KqF Edb19CiIaj6UuuzGT65v9nQ2H8/0TL4dHAhmMmlhw62R6wFcojrYoKsZCzbvruB1tRcp yitsHzW7ZXY8TWBwIjyyDQEhn3kkXw+pc/XC2ugPf5EbW/sUaOpb7d5PQWjeBwcqKHS0 AIpeMWZe8iVVFJV55oByv9xSr7iksJhLVJwBxzUJBKj0TFiqSJM+/T3udPCPvjX0GqaT ZjUQ== X-Forwarded-Encrypted: i=1; AFNElJ//ssl+SWkDvAxm+qtVqZRJKgBsGvj531IwUuI26lMtW3W9LTRDVz5BviK1SKt1ZW1bnLZnxk9tMXQ9dlM=@vger.kernel.org X-Gm-Message-State: AOJu0YyUIKXS7TFjbMAjNLJ0yuJvxxKep9Zu/9SbEdZ9uDAlpBOeSL3H oMbIjyRWnp9P9V2t4uvXS119AjCKGHmRnZTnttebdb7A2O3P+AdXqItJZ+WU/ETUhgY= X-Gm-Gg: Acq92OF3m6LebJ51GIrvkbTh43JvvFQquE/GNW8wSo3wWWQxk5uBzec2KD4bgZYJ2pi sQaG7tfQHRNFNGjlFSXvRolMVgJ4Zy/j7dBYRnLhcoaoTS59G6aMXqfLnRDuy+GRym0MlNLbzXh 7BJgG9MGZ0ASESjxpQ7jnKvQm/I7e0h4xp3eD8E3gWkreP1zlh2vXuR0dh0sHyXeTRwqEfyeiOh gb9ZQK4QARDHPyiYgS1gD81lge59HJwAm8di6MOTgHjb3881YTWkGicNK3MSrWqHL7M1lyIkFtw 1bJAejnNpsi1I77hJBx9PTSXJKS6NRv78e0lsyFR/X6spXc0J0icWQxJw7VpW1Ztj9IkJS6UIcc UYqiL2J35yUfT1pA0K/Ol2e/uH2FKS0PKI2qx+tXGowobpYVEWc+uyrlkXwojJEiuZyqc2LR+RP /IGH9TX7a7lhPS4EILs1A+6tq9Vxnc9H9gUxT+LSB1OejqA5XGAC5jEFQVP1xVM2UGzR6kBT7aS Hpqz6iEBb2HGaM= X-Received: by 2002:a05:600c:3493:b0:48f:d2fc:d042 with SMTP id 5b1f17b1804b1-48fe61f1a27mr329748165e9.13.1779202922780; Tue, 19 May 2026 08:02:02 -0700 (PDT) Received: from localhost (p200300f65f47db048a8dfcf61053817f.dip0.t-ipconnect.de. [2003:f6:5f47:db04:8a8d:fcf6:1053:817f]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48feb029180sm164155535e9.4.2026.05.19.08.02.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 08:02:02 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Corey Minyard Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH v1] ipmi: Use named initializers for struct i2c_device_id Date: Tue, 19 May 2026 17:01:56 +0200 Message-ID: <20260519150156.1590826-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=3118; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=cmpjBF/YYXkke9emOrt0Uyvq9m4XkcGd10/Ml1tUeLY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqDHtkmryaSHRv72LrgZ+n0oWtKE+IvPD7pfvd8 m+QF+FciZSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCagx7ZAAKCRCPgPtYfRL+ Tn+3B/4nwwfMzq0rv+fXWGjskBTWNgCVP3LlrFgev3K6JdMiosGStdzWBUnB4/m8V0dmx0LPB2H xEd4dcnk7Z931Jc9n0HJrt4+VsEtdAizZ1cx7zIEHRD4N4L8zT+Ocqet0tZdc4pfr1o7uwQJvaK n4QyXuqCQki5Zn++3Wf2wQzxHSkoMNrcT1BOFswM/yg3LcxxfZwKAVRDTHIUU7voXqSXv+wn2Cw H3thLxXquupfy1tzJf3iP775wd6/duqV6tKOLitx9BKj7XUdBpNlybc1Pe+W30il1nOoNXTWmSq ZI9QoHP/4QFZ4T/5hBZW3RROuY+YQbLA1+k8zURM/5aEC7vQ X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable While being less compact, using named initializers allows to more easily see which members of the structs are assigned which value without having to lookup the declaration of the struct. And it's also more robust against changes to the struct definition. This patch doesn't modify the compiled arrays, only their representation in source form benefits. The former was confirmed with x86 and arm64 builds. While touching these arrays, unify usage of whitespace in the list terminator. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- Hello, this patch is part of a bigger quest to use named initializers for mainly struct i2c_device_id::driver_data to be able to modify i2c_device_id. See e.g. https://lore.kernel.org/all/20260518111203.639603-2-u.kleine-koenig@baylibr= e.com/ for the details. This patch here isn't critical for this quest, as no driver makes use of .driver_data, so apart from the better readability this is only about consistency with other subsystems. Best regards Uwe drivers/char/ipmi/ipmb_dev_int.c | 4 ++-- drivers/char/ipmi/ipmi_ipmb.c | 4 ++-- drivers/char/ipmi/ipmi_ssif.c | 2 +- drivers/char/ipmi/ssif_bmc.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_= int.c index 2fe1d205ce4e..680ff15c30ab 100644 --- a/drivers/char/ipmi/ipmb_dev_int.c +++ b/drivers/char/ipmi/ipmb_dev_int.c @@ -353,8 +353,8 @@ static void ipmb_remove(struct i2c_client *client) } =20 static const struct i2c_device_id ipmb_id[] =3D { - { "ipmb-dev" }, - {} + { .name =3D "ipmb-dev" }, + { } }; MODULE_DEVICE_TABLE(i2c, ipmb_id); =20 diff --git a/drivers/char/ipmi/ipmi_ipmb.c b/drivers/char/ipmi/ipmi_ipmb.c index 28818952a7a4..1f1e5718f082 100644 --- a/drivers/char/ipmi/ipmi_ipmb.c +++ b/drivers/char/ipmi/ipmi_ipmb.c @@ -566,8 +566,8 @@ MODULE_DEVICE_TABLE(of, of_ipmi_ipmb_match); #endif =20 static const struct i2c_device_id ipmi_ipmb_id[] =3D { - { DEVICE_NAME }, - {} + { .name =3D DEVICE_NAME }, + { } }; MODULE_DEVICE_TABLE(i2c, ipmi_ipmb_id); =20 diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c index b49500a1bd36..32460c3858f4 100644 --- a/drivers/char/ipmi/ipmi_ssif.c +++ b/drivers/char/ipmi/ipmi_ssif.c @@ -2074,7 +2074,7 @@ static int dmi_ipmi_probe(struct platform_device *pde= v) #endif =20 static const struct i2c_device_id ssif_id[] =3D { - { DEVICE_NAME }, + { .name =3D DEVICE_NAME }, { } }; MODULE_DEVICE_TABLE(i2c, ssif_id); diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c index 1df0e9284ad9..6036897725f3 100644 --- a/drivers/char/ipmi/ssif_bmc.c +++ b/drivers/char/ipmi/ssif_bmc.c @@ -874,7 +874,7 @@ static const struct of_device_id ssif_bmc_match[] =3D { MODULE_DEVICE_TABLE(of, ssif_bmc_match); =20 static const struct i2c_device_id ssif_bmc_id[] =3D { - { DEVICE_NAME }, + { .name =3D DEVICE_NAME }, { } }; MODULE_DEVICE_TABLE(i2c, ssif_bmc_id); base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 --=20 2.47.3