From nobody Mon May 25 01:58:04 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 751AE2F8EA5 for ; Tue, 19 May 2026 14:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202053; cv=none; b=YhItn15aHOfPN/StpwFFFikE4T0aSEkcLt9Vqrl2BySaqPtK0CPd+S86dsc6On8JGHoiK5ls3OFkW3NMETO42PdRo2M6Wpj2/+Z34dj9JE375HMXnyLfBKpHa8YrrPP7Ehb8b+i68lcJS1uwCHUyZlxkM1i2gDnnemDX8nbvChw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202053; c=relaxed/simple; bh=FExfXeTtX13Ua6YaVKVNwPlQCE/bpxMzecVw3ov+tIA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CBssHuD2xkn6sLVty1MEkcFsCXJwDSK0LbTXRSCTXRoZNT6amcjRvF3fJUGde3hLaeE+7PzaezTAc5t6lodRy360OXs/diNtcfSKw/3ltz5XomhHO9hBiQ/9RNvVitiqj4k77r9TK76b0aiNfGJXC4AGSaKvM/zRWxCdtQGeXt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NaWTgcGB; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=L7MhtoyH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NaWTgcGB"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="L7MhtoyH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779202049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=giYYHrHxYHTkG5VVTzSY8R7Lmh6VjOaCPuVGGkOK6iA=; b=NaWTgcGBqnUJQN//slNDaVa2xlW8OqN2OsmLBCLY4baLMA3BtqaoqSFEa0KnjwclXXUjhQ Kx87QHxG2WOXbmKyI0QAt2fN1NYNEekMKKgiFEsJRfvx78BSnm7rLFBd4Jr0RXt4sMgzUU cQlD1kv6OnXtv0jn3CgEwG8504AM6Mk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-399-ENEc-_VcNTCvLpItvN6KVQ-1; Tue, 19 May 2026 10:47:27 -0400 X-MC-Unique: ENEc-_VcNTCvLpItvN6KVQ-1 X-Mimecast-MFC-AGG-ID: ENEc-_VcNTCvLpItvN6KVQ_1779202046 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4497a0e3acaso3752423f8f.0 for ; Tue, 19 May 2026 07:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779202046; x=1779806846; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=giYYHrHxYHTkG5VVTzSY8R7Lmh6VjOaCPuVGGkOK6iA=; b=L7MhtoyHglMafFeisejWsxHvFcZizp5FkWa1cIEDcCKhzP1Xmftve0hJZC+w/kr7Qd nyeLjSFHZ/HkMfL/MRtVPfrNCufAPbNP9nsUms/BAfgAw9X2mnXabpwWPVu3ytdQ32nO v7Sy2K3fVIL0uQ7vJ5kgMujuOjQExswLs2Nvg3PKe3zh0jxy5BkbBeNMe4/qLJM5Udcf 3d9Ur9XDQpVyC4ebbt1MVl/WIJxpYruh1pNX8fVJl0bHUAKzg3RlXLelX8FwHuSiWJeF 5tWX5id9D3XBe96pyqPDV+Es3jmUElP6cEeE4Px2Ji425hrjWgbgaVLV7FeCVZvS4Amc d8tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202046; x=1779806846; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=giYYHrHxYHTkG5VVTzSY8R7Lmh6VjOaCPuVGGkOK6iA=; b=Bv0Vy26veZPHGQYssUYwyBYpHMUWrTGCGj6Ssna73qf0haFAOoYVxw6vbw6h/NuO+E AhPmXwCSMb0dGHiyvQVJ0mT8LNSASh10AnA40c9W1BKrjP8/JDOH9uFeHKF6TWgt2VMT ZEtlL85Z8bANyCzhgXJGZ9fMCnUAAj7zepnklnAsCajAvTXT3opdyU/7dJpfI2Mnj/M8 icno0EHpqjz562TfaHD608u8cpQvOc2AIJwS5S/9PvKYdtPe/yeWSFw5wXq7W+dDVmAj eWkjTWuTMUoz5Ahoc96DYaIlP7XhlIKk7Jb8mxZ0PSlPCtqSrfcLujc6aXbBUFOAXee4 g52g== X-Gm-Message-State: AOJu0YwPF59zecuxXUle9ciEoExGaHRSOBlqg1QSLHT5v5TwKPx9tiZ5 nCGGy14YhgcYNRChbhTNaAQfh/p+3rBFoZi6OHK3jV6pAq+dw4BQLyWtD7hbJVADZODnrcY/0X1 fumesRm+EyLdarlcXs3q5V9eOrSWh7Bkr6SKnvKWjgF13rnhHXYOkz77MXSwPRONGoXUpT+eft9 duiIhm7nSzpWZycAif8KPo0mn3c2Q/JSVXjx5sZWxODSR7Z2xt X-Gm-Gg: Acq92OGSuEZu+kLUn8gHJSVVkztu3eSXloO8ziQDI6rWLoZ9o+M+UB7ZpgWRH/w2B3e 6Jv9R4iNUbKvZ8l4Pm4rFuDDjfHWSRwm12ekVRbb53oFaqINcH9ZgE483y4ltVEyyJInfoeVhz/ yCCMrfqzIdVXohEuTUK2KQ1XiLV82AIV5nBjIdGcNN8HO54Box8RhtFfVjVKIjBRzE7Cs18WQ7L kMvSvwj+QPlyGqEOMsuVrKcnxOzJQyfTYSM9pBRmPNm6/p4OxFcSrcyCqFw872jn/77nMJbbMyP kJSUlsgucYMcDb+kmmaqq7n5VXTGcVY3dRBwNsHpKPTgjTQ7rc2NI+A3ubkyiao6DoK1dkut4Of Swl+C2EiRPmqCK2NXWIjUw/J19CbBmsp50GCdOGyhOiOG6Oo= X-Received: by 2002:a05:6000:1ace:b0:43b:3b80:6776 with SMTP id ffacd0b85a97d-45e5c594c2cmr30926062f8f.30.1779202045590; Tue, 19 May 2026 07:47:25 -0700 (PDT) X-Received: by 2002:a05:6000:1ace:b0:43b:3b80:6776 with SMTP id ffacd0b85a97d-45e5c594c2cmr30925971f8f.30.1779202044996; Tue, 19 May 2026 07:47:24 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm45731796f8f.36.2026.05.19.07.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:47:24 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , David Airlie , Dmitry Baryshkov , Jani Nikula , Nicolas Frattaroli , Simona Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 1/8] drm/display: hdmi: Add common TMDS character rate constants Date: Tue, 19 May 2026 16:46:57 +0200 Message-ID: <20260519144712.1418302-2-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260519144712.1418302-1-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Several DRM drivers already define their own constants for minimum and maximum TMDS character rates. By defining common rate constants in a shared header, drivers can just use them instead of having driver local define macros or use magic numbers. The values defined in the header correspond to maximum TMDS character rates defined by each HDMI specification version: - DRM_HDMI_TMDS_CHAR_RATE_MIN: 25 MHz (minimum for all versions) - DRM_HDMI_TMDS_CHAR_RATE_MAX_1_0: 165 MHz (HDMI 1.0 maximum) - DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3: 340 MHz (HDMI 1.3 maximum) - DRM_HDMI_TMDS_CHAR_RATE_MAX_2_0: 600 MHz (HDMI 2.0 maximum) Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Heiko Stuebner --- include/drm/display/drm_hdmi_helper.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/drm/display/drm_hdmi_helper.h b/include/drm/display/dr= m_hdmi_helper.h index 9c31ed90516b..0ee246ff82e0 100644 --- a/include/drm/display/drm_hdmi_helper.h +++ b/include/drm/display/drm_hdmi_helper.h @@ -5,6 +5,12 @@ =20 #include =20 +/* HDMI spec TMDS character rate limits (in Hz) */ +#define DRM_HDMI_TMDS_CHAR_RATE_MIN 25000000 +#define DRM_HDMI_TMDS_CHAR_RATE_MAX_1_0 165000000 +#define DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3 340000000 +#define DRM_HDMI_TMDS_CHAR_RATE_MAX_2_0 600000000 + struct drm_connector; struct drm_connector_state; struct drm_display_mode; --=20 2.54.0 From nobody Mon May 25 01:58:04 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A69A13769E0 for ; Tue, 19 May 2026 14:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202054; cv=none; b=Ip4b4HTQuxBxQjwmKlQhnTDu6ttcWCQ1ezq4InYt/OwrJXT2bWX0fWUSL0J3z4pniWtbDI/WkeJD6FyW4VfvpG1lC0rmbbeEoiShFPIccZVsK+FuKphKT6s+usRZff76q8VdH4SwagHJ+d8Kxfn5g/ljVmpSBInyijRjRUSjc1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202054; c=relaxed/simple; bh=yP560d1t52HZeKj2l1zFFVEa59NMCb7eLPRgS8DMLcQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nc+wXjz7qvIMPfYjVajEsOCEJoR7ljpircdyhDvtJi4JUFWv3HN1awXctnPFVt54JHlmrMiNTTuYmmYMGaMJf0u6aAmC7xAh/AQIkwnJB2aGNHayDHar5PHDWHMFcCV7t1BbLYo9YhoXKi8cS2a3o/RB+JpPIFGl26aHzMG2sf4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OHKQNgoo; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=NPtAZC6B; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OHKQNgoo"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="NPtAZC6B" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779202051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wmO8Wr7tsXS06zFtg7IPRTUeza9gF/FNLRuBRJpr0Ck=; b=OHKQNgooah5hXEtqAaN78j2rvgLSo6fdTLQi53ICr+6jZKD8wPWAQVe4P7xttWzn0W08Cf MsX0WQA8Fzi9y/zrUv5lmqQ5ANbgvXDqoFLjqs57kYkw9BJnWUZHPmL4AeLSftTc2A7tI7 HzezQl7DlGIzWOK7B2nwjDCbO406KGU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-7hYHjrlwMjG4Kg-EWBFzDw-1; Tue, 19 May 2026 10:47:29 -0400 X-MC-Unique: 7hYHjrlwMjG4Kg-EWBFzDw-1 X-Mimecast-MFC-AGG-ID: 7hYHjrlwMjG4Kg-EWBFzDw_1779202049 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-45e7c7289c3so2137331f8f.1 for ; Tue, 19 May 2026 07:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779202048; x=1779806848; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wmO8Wr7tsXS06zFtg7IPRTUeza9gF/FNLRuBRJpr0Ck=; b=NPtAZC6Bc1a2bZa9QKuKljIi6jZQdHfC47KpWZ0sumcWDKN90K7Tkhrylv72hMgjZi FtRM0NcNuVapqhU56FaqglWum/L/ScNLn3hPbzlO2v80SbcEGNNV2EdEoKcfrAJ1nWXd G7bceEdyP1kOFspfoycmvLaI3evUxuAXC8kyU4ucMIA1x4a0Em/LtWxEfWEtDODt3Mzv 8q0SI37+mc5Jk1Rso3GSDcwwwu1FjR9IGzfrRP7CZmuAbojThNP8D5ProcC/oR7rYc6U yj4oXHD62+7fDIuN1SMVoI0T3d45rb6l1s+ptWeOq49Hsc6zW3KELDwbOF/UXLpffb7o 32yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202048; x=1779806848; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wmO8Wr7tsXS06zFtg7IPRTUeza9gF/FNLRuBRJpr0Ck=; b=jISQgNh5Z6xgyp2sZDRyXhrnfrYXNXVVAmo8w4pd3c7h+AT+IYNG0UtcHjjC4NJ5V+ 27q6hNW0WP6ZVnPdAyGPHNzEfo7fC4TgS68LohTTpTEsSIPK1MuFKQqRI6wE6IDOH2+r nRGS0258tqx/qmgauzYBujQbsmITHOrQoz0eu1GEskuZoZATvEz5ADyZK51BV6TA3nXc EUv6IoiUJBwWnl11aT2aM0fNffw4BXHMmKqO1d1wHTP6CnpPCX38p5Pp9i0BYKI5Xvyg aS2sZjZLGPxBEStTIdVJ3qyhwI3dcK8t7rcFikcT4/8xBZig4Ks8tcBPWrp5QZiR1nt3 qCIQ== X-Gm-Message-State: AOJu0Ywomkan59tdC57Kyziwf9B7vhIcb6PUndbzZ7rw568jiuzxkgmj F0QlJz4xQnPjUWKiB2yjKte/dAFdHxdP9t4Vz1YZfC5PSLRDSeQXpaNKtD86/THgIkwLvEGxOhv LlKv3N3dyzyxU9w3qjFr5SjBGtFwC9ZGkCiuDC/LgvmyRt+ZANNHSSZBBjLZhYH1TyVW8g4fRFu KDVr94pSnqUCZQAu+nL6Y5A44dFnPUcK+Jotvc4uyPHOnrdcWG X-Gm-Gg: Acq92OH0D2UqHs2VU2yuH1YiPcHkap2UfPwElzF8zAgy1/IvKOfdafoYvq8bEBa2ofP hiieINcr1N17+AJqOX/vaYvLMDABjZG1I+m+vZVhJiQBvoTqyf5PIXjF7kLfM8TJnvr59x03K9t YocTSbBwMM16nQ4HXGqSjIdttDGXZgvc6fLeoOFp6bcrJPZNS98swc9Y94SsUKHtYTtfoz0ZKqK QEAoJRoN653gCx9xj5nM+mdiRbsQ8ivJF6bMY8802pGOj8v3b3KFaOtsXdG6BTYdIyqQx1PITSZ CSUl+PtTCKYRhmmI7aDXM1KBXXbWALxx4XFOVbr5xD5E7oiwMAKRH8cICHvEj4/QRo8KwiuPiOi AvtprY0PWkHDUmT7GslMTchpnZvMJfzVh4PZc+HHN3RyS1+9YM3N+53hQ+w== X-Received: by 2002:a05:6000:40cf:b0:441:29cd:a18e with SMTP id ffacd0b85a97d-45d941b19admr38673202f8f.23.1779202047981; Tue, 19 May 2026 07:47:27 -0700 (PDT) X-Received: by 2002:a05:6000:40cf:b0:441:29cd:a18e with SMTP id ffacd0b85a97d-45d941b19admr38673113f8f.23.1779202047191; Tue, 19 May 2026 07:47:27 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9e768acesm49336351f8f.7.2026.05.19.07.47.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:47:26 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Andrzej Hajda , Andy Yan , David Airlie , Dmitry Baryshkov , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Liu Ying , Luca Ceresoli , Maarten Lankhorst , Neil Armstrong , Robert Foss , Shengjiu Wang , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH 2/8] drm/bridge: dw-hdmi: Use the common TMDS char rate constant Date: Tue, 19 May 2026 16:46:58 +0200 Message-ID: <20260519144712.1418302-3-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260519144712.1418302-1-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the driver local HDMI14_MAX_TMDSCLK define with the shared constant defined in the header. The local define incorrectly referenced HDMI 1.4, but the 340 MHz maximum TMDS character rate was actually introduced in HDMI 1.3. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Heiko Stuebner Reviewed-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/br= idge/synopsys/dw-hdmi.c index 41b3a9cfa2f5..d7c0a599aa42 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -51,8 +51,6 @@ /* DW-HDMI Controller >=3D 0x200a are at least compliant with SCDC version= 1 */ #define SCDC_MIN_SOURCE_VERSION 0x1 =20 -#define HDMI14_MAX_TMDSCLK 340000000 - static const u16 csc_coeff_default[3][4] =3D { { 0x2000, 0x0000, 0x0000, 0x0000 }, { 0x0000, 0x2000, 0x0000, 0x0000 }, @@ -1426,7 +1424,7 @@ void dw_hdmi_set_high_tmds_clock_ratio(struct dw_hdmi= *hdmi, =20 /* Control for TMDS Bit Period/TMDS Clock-Period Ratio */ if (dw_hdmi_support_scdc(hdmi, display)) { - if (mtmdsclock > HDMI14_MAX_TMDSCLK) + if (mtmdsclock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3) drm_scdc_set_high_tmds_clock_ratio(hdmi->curr_conn, 1); else drm_scdc_set_high_tmds_clock_ratio(hdmi->curr_conn, 0); @@ -1671,7 +1669,7 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi, } =20 /* Wait for resuming transmission of TMDS clock and data */ - if (mtmdsclock > HDMI14_MAX_TMDSCLK) + if (mtmdsclock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3) msleep(100); =20 return dw_hdmi_phy_power_on(hdmi); @@ -2032,7 +2030,7 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi, /* Set up HDMI_FC_INVIDCONF */ inv_val =3D (hdmi->hdmi_data.hdcp_enable || (dw_hdmi_support_scdc(hdmi, display) && - (vmode->mtmdsclock > HDMI14_MAX_TMDSCLK || + (vmode->mtmdsclock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3 || hdmi_info->scdc.scrambling.low_rates)) ? HDMI_FC_INVIDCONF_HDCP_KEEPOUT_ACTIVE : HDMI_FC_INVIDCONF_HDCP_KEEPOUT_INACTIVE); @@ -2100,7 +2098,7 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi, =20 /* Scrambling Control */ if (dw_hdmi_support_scdc(hdmi, display)) { - if (vmode->mtmdsclock > HDMI14_MAX_TMDSCLK || + if (vmode->mtmdsclock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3 || hdmi_info->scdc.scrambling.low_rates) { /* * HDMI2.0 Specifies the following procedure: --=20 2.54.0 From nobody Mon May 25 01:58:04 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5541831F991 for ; Tue, 19 May 2026 14:47:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202056; cv=none; b=ihtIb9ud3j1vfy1th5U+ngrg2mBsNaa002mX1rYjmtVgAjCvu15kItslJDcMYKqdk3D3XPiU781MQVaDQsxhDLEBkHBtdXVLsKNYCsUWZwWe2WObmRFuXSCaQA8yv7EloSI3UCJlZj4Ke6AYEBg55Sj4GgeWdcHQJJCEhe4O4AM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202056; c=relaxed/simple; bh=vL1GTbSKQ5S+0iYmLgnrX0ISDLezNcz2LNIEztFx1f0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PT5Hn7TbFrzWOtVZrxURyaC1cpnQmVqkAq++CRbWiKpkdCOggc00eYLCmD3q3QxgUGDJAWCM1YBIqCIQifET7fYcC+H4w4vko+NLSr9QBQYReMNELmzTzzyhJFS44szjM3xPWl63sdkACBdCG9WPvADy5iam5gsv7zPSE0zPx5M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AZ6QnR9v; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=iMAq6k5K; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AZ6QnR9v"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="iMAq6k5K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779202054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6xsSoTwiRNz90vOYxeUhQK/ys9WcE9kZjrgtjE9tN3g=; b=AZ6QnR9vJCSGgE6+X8sGPTG4v0tY5MiVck8jzkIO/KCtucnArmqUiryyooUT89M2qlNRP5 J9MB9fvUyM5HGzVkxBnW/M/y6PjlDXxcJxV1fn76YWAu5mqjdq9HFQn86CbMw7U7ZOVinN heBgwzBLNNdDzvV2AQIaQ0pppoROEdA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-yd6hnuR0P1eWZzbsrPE5SA-1; Tue, 19 May 2026 10:47:33 -0400 X-MC-Unique: yd6hnuR0P1eWZzbsrPE5SA-1 X-Mimecast-MFC-AGG-ID: yd6hnuR0P1eWZzbsrPE5SA_1779202051 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-45e7c7289c3so2137473f8f.1 for ; Tue, 19 May 2026 07:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779202050; x=1779806850; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6xsSoTwiRNz90vOYxeUhQK/ys9WcE9kZjrgtjE9tN3g=; b=iMAq6k5K3U5gKmz5CEbJ8zoCGd4+02UPygSFDoqgke1KXZkUK9+m9/0kj6coFU1rzA FSExmFubb/7cCvIHpSjoqqX7PPu/wc/mMvI6H+Tc+Re+D+ov/+9nsbe7i/McDYKWC8xb 7FhxFl3oy1yPIPehJ8Dlfjc0pwxX2cNmQZ+cWxhLf5lKl05jpf9JGHnZz6FCF3HMyDAq 6AvVVzxCAZ0EJUxBDHr4ntzS28JbQThKdf8DbFfJ41VN32VWa/5z8TgYgRuujJZ9lteW 3zqHaH2jDXZjb6nKnC5MAafHERFpnEG0Omu9havekNxjPuHLQC/V25dDrj1rRXY+KVeu fRyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202050; x=1779806850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6xsSoTwiRNz90vOYxeUhQK/ys9WcE9kZjrgtjE9tN3g=; b=iOL3d3PpyPPGrTHHk0LJRtKWhmtNKOUaImgyyUxMH2mDVXQP2PoRA2vE/shU8SdD7Y oVDfnysZNzovE//jH1eB5k977Er3AfEXt+SBM7+bsk5nULNYH18eFN775lRjaCnJk8JD lvJ0Vl6QiYA948JjcedCunZOS8l9b1pa0pNG1oBYMqaDU47EQygyVE5oVWw69UHlAinj TtXnQHBj75QENqDWTbjM4Uq98VGJkja3WkfAjtg29c1nj5fllA2sediQDlmlk13C1YKu p7RIWNE3v/ddac64vQiD2EQYCzXL0KwgxT9qOnVH5OiAwgVkA8dxaHPe5xdruGZ8nFmH jPQQ== X-Gm-Message-State: AOJu0YxxxKqFoKORDE1Guvxcgqdz9Ytfx29yfMIddSzY8vonbiFUyN6C s57xF1D9Ob3UvisiGNn3b+AYg5wDyivYCpxn3k3pGw8WzkdsBZTpVRDaorctzKea+1cXQuC1wE5 EKDfTIKOvyvlD65E6lsz2vDtt+ULzi40uIWzfGKIio40OG/IaH6Z65Qu+CKVPB+Nweg7XlDGhFL 96wbrW/Bx6MJRL2cyykYAE6bMoZNT7RwqksQQTBZLSD1v14hw0 X-Gm-Gg: Acq92OEmmmAwLt/fToGGFqprq1acAoaa8s/9vVZzSBkoj+rWY+C+t2VGfZkjOEQkIxN T+ulOAB2BTkjfWevr9sLgH0V8M3VqRW6oIrjbUmXkwfSu2IIxmk+7BVvXZUNQfc5bF9PCHierdS dM7jJmWqBCPxqCyEREdPpox4jcNYsXfIgnx+7ItfE2+HUmC8j2DKaBqTtQ4nwW9/AZYHyrk6tla 6XTJaiOpxRKThb/7yh3pBqNGxZI0BzNQKZOXU9g9ktBd3zE692rahQEgowrsCaBsuWz7H8GhY6A zBr66KV8rhsR8znzg4zAI7MUutUmBgu+0P1O6DAnBrAFlhT7OhtM+bR1cYPUBGPmBErIzRLGZct DWHBVifab/mpeKMOMClrOdrZUYcb8bQVDf0f/sMfm1rqO5e4= X-Received: by 2002:a05:6000:160f:b0:45e:8a9c:608c with SMTP id ffacd0b85a97d-45e8a9c6144mr3198450f8f.2.1779202050188; Tue, 19 May 2026 07:47:30 -0700 (PDT) X-Received: by 2002:a05:6000:160f:b0:45e:8a9c:608c with SMTP id ffacd0b85a97d-45e8a9c6144mr3198381f8f.2.1779202049410; Tue, 19 May 2026 07:47:29 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9e768c4fsm46647759f8f.8.2026.05.19.07.47.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:47:28 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Andrzej Hajda , Andy Yan , Chris Morgan , Cristian Ciocaltea , Daniel Stone , David Airlie , Dmitry Baryshkov , Heiko Stuebner , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Neil Armstrong , Robert Foss , Sebastian Reichel , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH 3/8] drm/bridge: dw-hdmi-qp: Use the common TMDS char rate constant Date: Tue, 19 May 2026 16:46:59 +0200 Message-ID: <20260519144712.1418302-4-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260519144712.1418302-1-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the driver local HDMI14_MAX_TMDSCLK define with the shared constant defined in the header. The local define incorrectly referenced HDMI 1.4, but the 340 MHz maximum TMDS character rate was actually introduced in HDMI 1.3. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm= /bridge/synopsys/dw-hdmi-qp.c index 0dbb12743609..37d8292b6f7f 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -38,8 +38,6 @@ #define DDC_CI_ADDR 0x37 #define DDC_SEGMENT_ADDR 0x30 =20 -#define HDMI14_MAX_TMDSCLK 340000000 - #define SCRAMB_POLL_DELAY_MS 3000 =20 /* @@ -835,9 +833,9 @@ dw_hdmi_qp_bridge_tmds_char_rate_valid(const struct drm= _bridge *bridge, /* * TODO: when hdmi->no_hpd is 1 we must not support modes that * require scrambling, including every mode with a clock above - * HDMI14_MAX_TMDSCLK. + * DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3. */ - if (rate > HDMI14_MAX_TMDSCLK) { + if (rate > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3) { dev_dbg(hdmi->dev, "Unsupported TMDS char rate: %lld\n", rate); return MODE_CLOCK_HIGH; } --=20 2.54.0 From nobody Mon May 25 01:58:04 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 781E83769E8 for ; Tue, 19 May 2026 14:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202057; cv=none; b=ja7uaGpCiWO4FayNnr0ZyUUWZkPljvd+mL04J7x+uGlDXwUSJRSDaAUI+HaxkWxX68syXY00BMl7z/b0qjSDGr9L2kVY94xiotpP/YTH0Q+0xzEIv5xaP537xKy30AeOUVl/O+XGEvQLZ6R/ghgP2tQfl+I7Whvb1ohPDahCfEM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202057; c=relaxed/simple; bh=V6eP9lXIdf31FmOPO0Y92jRXcpgiVkDeCBnSDlZgBb0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mtvj/bICeV73qph9dceNNI8GTLCJ3vTjEV1p16L2Nyzd8zktk9ZlTrU4mjIAxjBNgZd674CW6KALmLrS7Z6dXdCLj/GeWqAANWbelyoFDqaynNz2u14783jvxyi91bzNFQ7shF3lap7ekzErxBgoJnTHhP08vb5mQuPRDJJvrGk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=G3HS4/J5; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ir8UYXJX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G3HS4/J5"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ir8UYXJX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779202055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tFMw+n7BkLAZhcZJbxdTqPXw7UJEF/lNM6lp+q3G+24=; b=G3HS4/J5z6xqj6dVArJ4bxihOST/4YqgTHt8uCy9kA9SWqZQ0Hx93/poihK59kn7vaf4uP AZh1/X1L4ZMbPIS5hZK8lWxHGh49cIIOphkVSzdv8DFhocjLhx3wBp+VGz5vAI/kLbPZAz Q0/1ASfH3gd70YszmUdgenMLxLEvbI4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-W7UqiNpcPA2BXX4oVat15A-1; Tue, 19 May 2026 10:47:34 -0400 X-MC-Unique: W7UqiNpcPA2BXX4oVat15A-1 X-Mimecast-MFC-AGG-ID: W7UqiNpcPA2BXX4oVat15A_1779202053 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48fd33b4921so26255635e9.2 for ; Tue, 19 May 2026 07:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779202053; x=1779806853; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tFMw+n7BkLAZhcZJbxdTqPXw7UJEF/lNM6lp+q3G+24=; b=Ir8UYXJXKtfYrHosnbIh+kxjCgc/HfPRsTxAY460Pv5/UBHyNCgsreFPSoQIZvbldw qr+aUixIeAhfQJyKEU3l4C/MmsZoJhBkomBUBqAkLtA31ni3bQ8J+0T+0wwXDXpQaIbb eigqImsi+e9YJSZeD71wkuHgJP1tv56O1GmkcXMA2TtJcUaPMdyYzldmIFF0PBrPfYQy l43RZofh4UbReWah4bHcLHQvJeqvWIK9Y0EMLGCWwE3HSxOzUgOvfDkbWeYsHFKEZ54k TydbXm0YmEGa34GXNsPtMubjokTozyYXjhBk9LsCnKzgazNe3t4lcZPPzIYvG/VOqknA MMpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202053; x=1779806853; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tFMw+n7BkLAZhcZJbxdTqPXw7UJEF/lNM6lp+q3G+24=; b=V69aRb5tsjQ+eF02vm8R8kCldyBz0ycZzar4SAAoLgyjfLnZZ54GXruQunYC7487d/ 85MJaZMEV0Zhdu0LePYutFiOGg762H/JSwsdnVK98YJ8ji4lAJpt7s9SiPIrGIvD5F5t OatKpQcuQof4X7vPL+pZsYUuZ66ughYGbZjpS8aojNyjv+Bs1uvIMPngGtYxytCJrgkn UgMtpNNK5xQrt3mSQRl+9lm4ikfB1o5QVqpVv7IxrixmZpTPB5QVnTmEEu9qZ/PqkVCT efUf24DYyG6qtqFsoGqS57iSMnghxKbm3Uwj5EOhrlrbKnjWP+gBVzcSvkc3/6z+yp3H nOfg== X-Gm-Message-State: AOJu0Yy+gI6oMCYMJaEhWRwOE0GxwFM9BdPmo4VjAmMpW6gySfQ/Gy8e gpZB6wRbLISEmFZckx3qKYYQaaQGSVOuncNV3FdWOm3K1CJMcTK7SJl+WMm7yLs29KSJedJ90dO EIhiGpaZrOLfCYuYrpYhPufQwG2Xlr0m9v9Yy93pfZdvDImhTXdS5vJ+G7DISDkjYzcd7RRDRJX /jDlNNp2iPo75/j6OraCQYhxMtVFxFOHd6VBGPkeyhBEqqAfVw X-Gm-Gg: Acq92OGmL6UNbp6VcCuyankeU20eXqIjSELhB0/QIiBxQSXRmA2z825lgorVDNiUjKl RfKN2Bv3tncj33AMEqK1dBjYeRgRuCJtDE3oHQAMfKP7lt+kWXk6/b8/Y/lrI2vixHi+EqA3kPO rcAPbXxKiGmnQ7Cx1d/6RUvtrSz47yoWs528oEJJGgwna5gxrrpMibVcazDc9Ktr39LKfQTlrPz ABt1iNs0+dB4gVqyeeWvLAq0XBNRc5KeGEZVyPuA5rFDJvPMvGLIAaj/QwBmBI8VvDruucwvCux lovZksQiCZd5T53n3lFkkpTx2fx0CBPI+GlnfAHJBH6QoDGlQlJ/cfFXJnqk1iHZwad528+b85K XBkuCrlvJBC+BD7LzodmqMef9JGbuBUAJDZQE2v/tvinSdjI= X-Received: by 2002:a05:600c:3f0f:b0:48f:99a9:bbcc with SMTP id 5b1f17b1804b1-48fe60ecb9cmr289838105e9.10.1779202052911; Tue, 19 May 2026 07:47:32 -0700 (PDT) X-Received: by 2002:a05:600c:3f0f:b0:48f:99a9:bbcc with SMTP id 5b1f17b1804b1-48fe60ecb9cmr289836755e9.10.1779202051577; Tue, 19 May 2026 07:47:31 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48ff2cb4ae0sm157990615e9.0.2026.05.19.07.47.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:47:30 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Andrzej Hajda , Andy Yan , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Neil Armstrong , Robert Foss , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH 4/8] drm/bridge: inno-hdmi: Use the common TMDS char rate constant Date: Tue, 19 May 2026 16:47:00 +0200 Message-ID: <20260519144712.1418302-5-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260519144712.1418302-1-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the driver local INNO_HDMI_MIN_TMDS_CLOCK define with the shared constant defined in the header. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Heiko Stuebner --- drivers/gpu/drm/bridge/inno-hdmi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/inno-hdmi.c b/drivers/gpu/drm/bridge/in= no-hdmi.c index 1091af29ad8f..4387493c13a1 100644 --- a/drivers/gpu/drm/bridge/inno-hdmi.c +++ b/drivers/gpu/drm/bridge/inno-hdmi.c @@ -31,8 +31,6 @@ #include #include =20 -#define INNO_HDMI_MIN_TMDS_CLOCK 25000000U - #define DDC_SEGMENT_ADDR 0x30 =20 #define HDMI_SCL_RATE (100 * 1000) @@ -820,7 +818,7 @@ static enum drm_mode_status inno_hdmi_bridge_mode_valid= (struct drm_bridge *bridg =20 mpixelclk =3D mode->clock * 1000; =20 - if (mpixelclk < INNO_HDMI_MIN_TMDS_CLOCK) + if (mpixelclk < DRM_HDMI_TMDS_CHAR_RATE_MIN) return MODE_CLOCK_LOW; =20 if (inno_hdmi_find_phy_config(hdmi, mpixelclk) < 0) --=20 2.54.0 From nobody Mon May 25 01:58:04 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F061409608 for ; Tue, 19 May 2026 14:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202066; cv=none; b=hwh6vuka9Jo0UWqhSPBPz59qPa3MpTSgDEopLDjuSx67zMkgdcP+5WbfkdxBYoGfo6e4fz3zBcCOBq+gfOBfagpwcCeP1IAmZoIc7KdkSrXNyA2mUwo5LqaOUlwYVPkytPgb9C6oGQJmacvcQTGS/s5Lk8qpGuZQsyeskEO1xN8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202066; c=relaxed/simple; bh=Zx2pQ/iF45ZSuo8/R4kpLZOJ9t4SmC/C+PyvOGFsAu4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hrHn71Mb5mDtGZRDkEmP7Cu0PGEtRP6K1TtN16AVTYHPWcj7JpEJ+sl3/U2hNy6l61feyg1InnSA1KONGPD1Vxycre6SX3tqpK4xl9TNILJWkqWa7BaacQ+gd3NNuCQKYXKccORlUZysdhfT6xYuC/H/Kg0O810Sj02ZxXQmUW8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b5U41oAB; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jg/1dFmG; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b5U41oAB"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jg/1dFmG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779202060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xGU7tCe8cxmqo3dopXR3nMSFVicCg4pj3EDoOkKJvvo=; b=b5U41oABvKEXDnhphgZ8Ia6yNZn8xymKodWLid1TGugZ2RPI6MEdIKGd2vSbdxvWGOrTqX ykLSnp9h5u5sqhXCS0rn+8rJX0lb7UnCcfiVsrG44BDIfhfz1YbqhCm/xvgftglFFIRK/X BtkWQnmWt6Csct3CSa07IsskFwL8+DE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-aaj3UMLXOy6Q8GXoNjBsvg-1; Tue, 19 May 2026 10:47:37 -0400 X-MC-Unique: aaj3UMLXOy6Q8GXoNjBsvg-1 X-Mimecast-MFC-AGG-ID: aaj3UMLXOy6Q8GXoNjBsvg_1779202054 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43d789cebcfso3137534f8f.1 for ; Tue, 19 May 2026 07:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779202054; x=1779806854; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xGU7tCe8cxmqo3dopXR3nMSFVicCg4pj3EDoOkKJvvo=; b=jg/1dFmGBkXI8jsfrAWGGXG/CuVcHXkWAjfYfoq/82VACOSMeXlLiKYDssugd3zViG uVTqa9mfZZ2ReZ41X8IULZQv89IdGFre2rKkPqJJQWGq3XKtDdZdlg1O65QcXlZIR9cy bxj5UewITCaIXl78vd/Z68iQP31NENf8SwI0LxLfwxF1hDkl5ASIxFqHw2f/U747KJjY gjfZlxvlkxhr1lLNMTCyDI6pJlExr0caHeXNEk5MFa06RmN40UWSwnhGHRMM3m8jQNHs +NflwxgU/uGWYNaVNTyVi5Fr1iOoDAY1fer4AShuKofwIIe8mh+fxAr6y5M2FDbnnqmT yrcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202054; x=1779806854; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xGU7tCe8cxmqo3dopXR3nMSFVicCg4pj3EDoOkKJvvo=; b=O0EYV4Gz0hocHTd5iW9mKEpKxUzABwzFXRZG776n7n92D9Z1g6PV3mm8JFhKfjYjtU 7SqcqXmVytwr6mCdhbD/1tOH+QT2uaSW1bmml34ixK4WuUk3NbUqAgNPoDTr2sbJgWts QFnhTRwxHZGgcupkbFvbYNUsDZVbLvrDHucNIfJ9o2zKMhHlfbbv0lJnLUS2GpWA7r6W rH1aEh/U6THti6ciu/AXMG8w/nqOecoRWcv4uAeLuge5xC4XGrZXxs1+4YAka4vSLo0p /emwAh2LSp4LAuxhLtDT2xMSWzPUnBqNdkejfq33P0kEuu6mSom9GNMGXgxvsj2HZmfo szQQ== X-Gm-Message-State: AOJu0Yyr6x/CGgYJhsQ/jmNAZGVknvlKuS5LstukiMjtHuOBj5VrkujO rZ1gwtH4xI9oZvt+rR2hsk5bCGEM3H0JlDwHU95VZG79xWaJJiHJ/o3VALnCn/9XhkDM9Fr031o 2FCWflQtrmaOHXTrZ8TixC7zwDrAZPYZo8uB6NRrrQvP/f3Yv3iRDGUQp7UsD4BCVJLFC/tkYb3 LxJWoTQs3wQWXnHQnFAS/HJ4oX6hRboTNC+Hkd0iXcRF/DdQol X-Gm-Gg: Acq92OFIKoep3SiaoY2gep9XlCPRpzVYM18hG/xK8hJ2ByF0XVjsdVGBymPFrEaJGhA jlLnoWi0txFV+dE6oXXs8W8nH7Nc1pE9FA63NiAf23WFLEibv+VRNnuyUNDS/3zmGGks2jsCGOU anta3rPWgXCZcM83UyUwfAhcMzFI1uptCfhobH43yTD5RjX62U3PkwGK38RCrbnecH/kP53Yp1r NsWDGaf/705QlfyJjZYuIVxlgdF11r1z6sHKZ9YFCWI5XzaAYm6ar/mWignvmJDV75nJlGCy5wF yO1JGDXM6DfKYP506dmq4t/yWwI+0ZeeXLtqMb9chmRG6wXJJzEnZLkHf8CGGC+gibVGNo3iqkw LCFZhtue4Jp4PSYkh2i9Gyr9Xekn9wKszJU+LIkBUh2kGp00= X-Received: by 2002:a05:600c:4851:b0:48a:79d8:a8d6 with SMTP id 5b1f17b1804b1-48feea99dc7mr161602735e9.7.1779202053778; Tue, 19 May 2026 07:47:33 -0700 (PDT) X-Received: by 2002:a05:600c:4851:b0:48a:79d8:a8d6 with SMTP id 5b1f17b1804b1-48feea99dc7mr161602515e9.7.1779202053300; Tue, 19 May 2026 07:47:33 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fffb9aac4sm399895345e9.9.2026.05.19.07.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:47:32 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Alain Volmat , David Airlie , Maarten Lankhorst , Raphael Gallais-Pou , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH 5/8] drm/sti: hdmi: Use the common TMDS char rate constants Date: Tue, 19 May 2026 16:47:01 +0200 Message-ID: <20260519144712.1418302-6-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260519144712.1418302-1-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the 340000000 and 165000000 magic numbers with the shared constants defined in the header. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c b/drivers/gpu/drm/s= ti/sti_hdmi_tx3g4c28phy.c index d25ecd4f4b67..1c5a54cb999a 100644 --- a/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c +++ b/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c @@ -4,6 +4,7 @@ * Author: Vincent Abriou for STMicroelectronics. */ =20 +#include #include =20 #include "sti_hdmi_tx3g4c28phy.h" @@ -102,7 +103,7 @@ static bool sti_hdmi_tx3g4c28phy_start(struct sti_hdmi = *hdmi) tmdsck =3D ckpxpll; pllctrl |=3D 40 << PLL_CFG_NDIV_SHIFT; =20 - if (tmdsck > 340000000) { + if (tmdsck > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3) { DRM_ERROR("output TMDS clock (%d) out of range\n", tmdsck); goto err; } @@ -135,7 +136,7 @@ static bool sti_hdmi_tx3g4c28phy_start(struct sti_hdmi = *hdmi) HDMI_SRZ_CFG_EN_BIASRES_DETECTION | HDMI_SRZ_CFG_EN_SINK_TERM_DETECTION); =20 - if (tmdsck > 165000000) + if (tmdsck > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_0) val |=3D HDMI_SRZ_CFG_EN_SRC_TERMINATION; =20 /* --=20 2.54.0 From nobody Mon May 25 01:58:04 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 307F0348C5C for ; Tue, 19 May 2026 14:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202062; cv=none; b=oGet8Ddj7G8LBSVcv4sM/Lh9CbcoxFeCrIwgLwZuCG7XZ8mJJg9U2CByM5kTwmxCT3nCBEmSplcZg4UgM49P2vcZ0msf6xChDhe/TiUBTydErrfjcnVFNMs7bgOViaOANknoU2U0Q6lPVYhw5LpHaUPSu3bTxPlzuMA7CVBt754= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202062; c=relaxed/simple; bh=tYLDZyLDMsiJnrQuLxzYP38x7kZlanYxzwgaiO61vVw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OAeRuZl0qhO3NVFoZPWnOgJUpkXX2fSnvcpXr/a7WIdFrqxT/xV7GSp6xScLz437VtXQZnRn6XZRFxDdwP1XW/7SOYldD1WP/WOBRFD7fW2l1ouPloNi0xhpfgfJ6iblgWQE0CRu8lWUk/W/PifXU1g5qckmCPaehhRUwa7i2XA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=I9wivgt1; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=sj2hoRGI; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I9wivgt1"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="sj2hoRGI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779202060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZLSJynfj/SfMKra6MuoVzzg6ibW6tvdwMbY0XP2994w=; b=I9wivgt1zOT1erOrdUkCjet6AyESx+XKm9UZJfU1RLDGITf8IpKa+MJChwiUTsaY3rHUsW S6VcqQtIhSpWGIGWq7Z1gXR228pK2L6G+XZhV3zROK3i0IbsC4SXF7eFeW0ywSdXCgs9l/ IyJnO9hmMXqehogwJp7aXYja5D/aQL8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-198-NCsLrnVDPPWw1FPLdV-o1g-1; Tue, 19 May 2026 10:47:38 -0400 X-MC-Unique: NCsLrnVDPPWw1FPLdV-o1g-1 X-Mimecast-MFC-AGG-ID: NCsLrnVDPPWw1FPLdV-o1g_1779202057 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-44d83e45febso3231583f8f.0 for ; Tue, 19 May 2026 07:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779202056; x=1779806856; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZLSJynfj/SfMKra6MuoVzzg6ibW6tvdwMbY0XP2994w=; b=sj2hoRGIaWm9vIk0xtNMlDfIp6gyJjFcLFUQkQA5e/UNtB+YCU9qa//ix7wTwUcg3K S9m5kjT9q8VhahC8jE3qcyauqpRj1s+vW3TxXIGzsema0Stv8YQjnxpgKln7rTTHQ8Fv bzkPal3uEu6JvbeF11Q445LlbU0oeb78ynO9kIsjhBIyulEbwqW4Yhoh/7LKQdtoagFm /QDicNTwQQR5VLgY+nbAH/i5KOzJiwhc6ZHeGfI7NHAZh4OpL1cZdq3nCrCO4oKkXZAK pqgW7UghR9SVOm6Mj+ppzJvYX24okYmmRjJmVb7a2v3URPeqFgXp+cBtgf2ai7laG2iE oPgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202056; x=1779806856; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZLSJynfj/SfMKra6MuoVzzg6ibW6tvdwMbY0XP2994w=; b=amlID+D0NF2iktlSc9ekH+z8h58X2t4w9PWmHZHjl+cutB+CSzE7QV1lZSFSfWS++h 0KVYOpaZqExbXMYkAAwP8lH+ZD0Z6ZvpgMG2h2b6HavNZmjIOOtLrLuEBlb7YpSgsOCR 0NlAU4iQr6N5SPsKh/uTO+dWhYo+AV6b+aBhQDISAMdDEHHTO5r/TO5JG9e+rdwDrRjW uJtO5QmvdEKPBGdKzBjmz864ZZYd75kA9npJJ8aU9aTlwYZ5+eFVbPCYWZRo7oa3Yg65 2KmL9xk6FWyPnrMYKKvi+zguJHvKjLPUg6id0W3oWUBEMvTfIJH9FOqd3E7ePOH7lpyS tc6g== X-Gm-Message-State: AOJu0YyD8AtoD9qiVWCZli1W7mw10dke9t6/ZIwQ1kdrXD4l5R3Ei3V0 x6n2ZgOB0WYJOEDzWuL7E8F0CIYAlCc1jnUZkaWxghGpfO8iLsiEfJ0y1xWuIV0N82YzySWIqc4 lx/nlt2zu7hm2YGJUksHYnWcxhKHSTmmtxb7r1grxt1YLrB4TK/odqCgInGc6zzCrK5y+j9txEn 6cyx7daHSNpj+GrhxFryEsoRqcomE+0uv1B7HzMAGC+PKrpm7x X-Gm-Gg: Acq92OFV6uVcFyhcV/Ykm2sU0xSd+80uYVsiW1nXyGBDPKX0IrAEjPe8ixUtQ6QeA3D uv6eOFSxguFHNo0z9Mr2PxLRe6MoSIe24GSHNukeTa5ltbJdVIdK+ykHJ65so1B72Fo3jPZFi0v 1E919NZsgWT0etTWG0foSwbpEsEH2HtiRxzHO37lcTjYGHtBImvhp3H+50W21OM0F/e2LhCY9QS d2FXsq+yarLNP7u2ZaMRpDMivumpeW3SzDuXMk6KzjnWLpcqOYCKel+I5zlG6m9fSCURkHjuGxP bplafsCafp/x0rTSJ93cPPSsXAhpDliR9nyW3yA7grTtVdR4/1WnO0ELI/pRCwx0VvxkN11q8mI 1u5lTjsLjS09fVCyhhJuCmS2b95eJzDKvaou6GcAHGlvrPSQ= X-Received: by 2002:a5d:64c6:0:b0:446:708e:1e8d with SMTP id ffacd0b85a97d-45d955021f5mr37986718f8f.30.1779202056338; Tue, 19 May 2026 07:47:36 -0700 (PDT) X-Received: by 2002:a5d:64c6:0:b0:446:708e:1e8d with SMTP id ffacd0b85a97d-45d955021f5mr37986653f8f.30.1779202055797; Tue, 19 May 2026 07:47:35 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ed2f738sm45113118f8f.16.2026.05.19.07.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:47:34 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Chen-Yu Tsai , David Airlie , Jernej Skrabec , Maarten Lankhorst , Samuel Holland , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH 6/8] drm/sun4i: hdmi: Use the common TMDS char rate constant Date: Tue, 19 May 2026 16:47:02 +0200 Message-ID: <20260519144712.1418302-7-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260519144712.1418302-1-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the 165000000 magic number with the shared constant defined in the header. The old comment referenced "HDMI <=3D 1.2" but 165 MHz is actually the maximum TMDS character rate defined by the HDMI 1.0 spec. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Chen-Yu Tsai --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i= /sun4i_hdmi_enc.c index 07e2afcb4f95..723a6a11c94e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c @@ -189,8 +189,8 @@ sun4i_hdmi_connector_clock_valid(const struct drm_conne= ctor *connector, if (mode->flags & DRM_MODE_FLAG_DBLCLK) return MODE_BAD; =20 - /* 165 MHz is the typical max pixelclock frequency for HDMI <=3D 1.2 */ - if (clock > 165000000) + /* HDMI 1.0 max TMDS character rate */ + if (clock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_0) return MODE_CLOCK_HIGH; =20 rounded_rate =3D clk_round_rate(hdmi->tmds_clk, clock); --=20 2.54.0 From nobody Mon May 25 01:58:04 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1177E3546F7 for ; Tue, 19 May 2026 14:47:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202064; cv=none; b=j/aKu/QYQRVXShirIpVsO9X89SlnEEo/uKBkjolzdV6lfNEl6yNR6juYpcdc5qVWbCvjamXiHnZym36QuXucIX6B7ZPS7CN5lrVE3gEZoDRaKRK6w2vQ2L9tAvfeqEVpxMBNf95FBKzs7WX4PlYTFUNXT9eJ9m8Ffd9USToCCg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202064; c=relaxed/simple; bh=njSaqEb/RrHFAOptgN0I9HenaXw24PAsx9xYCcorRn0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ti/XnVzU5CFObaqoxcu45N6GKmDiFLsFi3QNPIuLLJepHej0vWxAtSXZ4dGszsjRlWgE4kh63g7IsSeY8hCHnDvjZwsYYoc81SFJy9IAxdSzQqH8KZaZzdzsGa17Jkl/FFgojSVEOswnaPcqXf+4E85lbd+gghwGonxx9YWlG9A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ECc1r+zB; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=CWwRF55o; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ECc1r+zB"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="CWwRF55o" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779202062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ePBiuXBOAJ8Za5EC9PfbU980/aL/8IJLEdhXnj55n9g=; b=ECc1r+zBUP2g3tM4Vf/6U8O5kpc1zKKCH5QVfZP1Vtb+KVb8HjsLSYXl/x9MqiJmKr7M7p m6vLezNtYCKLJtzM82dVbCnQ6MBGpQhmeLY8iNipXbdJsvHc5mTqhdr6fjff7qpFeCXxUN VwrE8y9b1GchyPtWybw1G/EVRZYuQIM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-BFyNYkfeNJ6RipvwWZCeRA-1; Tue, 19 May 2026 10:47:40 -0400 X-MC-Unique: BFyNYkfeNJ6RipvwWZCeRA-1 X-Mimecast-MFC-AGG-ID: BFyNYkfeNJ6RipvwWZCeRA_1779202060 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48fd233d1e2so38702425e9.1 for ; Tue, 19 May 2026 07:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779202059; x=1779806859; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ePBiuXBOAJ8Za5EC9PfbU980/aL/8IJLEdhXnj55n9g=; b=CWwRF55ouBUDlmJupNTIMqKPLjfv3xb/XFveywHnxrP4aa2VpBIGIusah87JsrUbhN k5Jj1IwxEXu9VS6AwYlb9bZK3Efnj8IOU3uhSer6l9kDSxSF+Bm/hRRQX/OS7q+DNhhe dg62X2L+F+1carMWmexsVwQmsmesdlFlbtetOrEh/M6AufqU9ml3T/dUZbNsDKkd2hG8 GjdZxwXpIAaD9k8T12LgigzBQcQmru76xGQcaxC3ng8SN0RL4huPXoiLsO4MxLhMCwh8 AFGZhg0uNenQgnmtUYrlObM8MQRDxonSEq8XL68OlCxCZMrHZz86zWyqG6/sUmIPlNCW EgNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202059; x=1779806859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ePBiuXBOAJ8Za5EC9PfbU980/aL/8IJLEdhXnj55n9g=; b=RkJM52gfJHfBU9v/edRKHMAdyDmfoYjtHJP8HULfgtCmsy32KwN/AVM6p4onKcxAGO kLbQ8d6rcFcYIgtcwxnqCA02JX752byRVQCtrMCgt+SdoQX9XkyEReaX60kqG+1IdyS8 sJRLMfaiCqP+jan7bvjGinmUUyL5jrzubgYfFJbUafp1y5pE57O4Nd6cVAUUX/4LwvuG E8nJrxnv3+WDW0JiyDDsmIg38UqsiOO0Ja7voA03HicM7jT5HHJmhGuKTDiU9nw7pdal LokN3Cg/yOzQi2qbYP5g22YP9D73+ikwZTgFpZUMamOIvkpZCZn+AC+pmlFham4/Me8R XHIA== X-Gm-Message-State: AOJu0YwEAVBy30B4Kt072W39T3vUMee4Fjc5u3dE8T3lq9NvLW9JlQ1o RPpPHwgJSzZf/WDdCsy+AuMW5SxkeCogoilrR0ZrXjTvmhxpwv43rCBxx7sFWm2o6UXLNUMNMYQ UF/DWnf5+Zd1L1YHmRyq1Ram+AQDBXqibLxI8Da5q0AEcOkWo36SXqhYi5FreuCNtTZLeAo1fHB 5iaGh3CCWWnApIo/XnMm5WXXEmqWxqxwEAbwsnhBjMh59BOuvK X-Gm-Gg: Acq92OFOssCSyMK3lUIuumEBj8VfaOzTWED/DUDAwwfV5mC1Wt4xqYmlAw/RdulSMJg iG+MCjeOD+RxArkXM2nztVueeoR29pQarkKvFNVvp0YY+qHEnKuajLqwsqTvwXoEdxfbcXV0wRa av8ClJUU4sROnhhKPnl9In0F2PpgDLak7I0V4J3UsED8R7tF5IwzxTQRj5MDG/ZYs9nAXhYY7WP cLvsnTLpUe1UDbiPJjTYgt0DbJ35Azq1iTGO5E3mn18IkBuuv0DTYJI4SJ78+uOBBuh1Cjrnkla N7X0vcus3JYXchSZ66/SI7Aub1dt4+VCBlD5ClKvyat2/onX3KNFzM/0tsQb2RFdMXO0CnZK5k9 oeoUONLEpkNpRU5PKWjFM0y4S5xn8oGviJiWxUaW6c/6S2lE= X-Received: by 2002:a05:600c:c087:b0:485:3cf3:1010 with SMTP id 5b1f17b1804b1-48fe60e1444mr223519815e9.2.1779202058918; Tue, 19 May 2026 07:47:38 -0700 (PDT) X-Received: by 2002:a05:600c:c087:b0:485:3cf3:1010 with SMTP id 5b1f17b1804b1-48fe60e1444mr223519425e9.2.1779202058487; Tue, 19 May 2026 07:47:38 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48ffed68baesm99701235e9.0.2026.05.19.07.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:47:37 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Abhinav Kumar , Brian Masney , David Airlie , Dmitry Baryshkov , Jessica Zhang , Konrad Dybcio , Marijn Suijten , Rob Clark , Sean Paul , Simona Vetter , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 7/8] drm/msm/hdmi: Use the common TMDS char rate constants in 8996 PHY Date: Tue, 19 May 2026 16:47:03 +0200 Message-ID: <20260519144712.1418302-8-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260519144712.1418302-1-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the driver local defines, for the minimum and maximum TMDS char rates, with shared constants defined in . Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c b/drivers/gpu/drm/msm= /hdmi/hdmi_phy_8996.c index 36e928b0fd5a..a2eb84358b01 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c @@ -6,14 +6,13 @@ #include #include =20 +#include + #include "hdmi.h" =20 #define HDMI_VCO_MAX_FREQ 12000000000UL #define HDMI_VCO_MIN_FREQ 8000000000UL =20 -#define HDMI_PCLK_MAX_FREQ 600000000 -#define HDMI_PCLK_MIN_FREQ 25000000 - #define HDMI_HIGH_FREQ_BIT_CLK_THRESHOLD 3400000000UL #define HDMI_DIG_FREQ_BIT_CLK_THRESHOLD 1500000000UL #define HDMI_MID_FREQ_BIT_CLK_THRESHOLD 750000000UL @@ -632,7 +631,9 @@ static int hdmi_8996_pll_prepare(struct clk_hw *hw) static int hdmi_8996_pll_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { - req->rate =3D clamp_t(unsigned long, req->rate, HDMI_PCLK_MIN_FREQ, HDMI_= PCLK_MAX_FREQ); + req->rate =3D clamp_t(unsigned long, req->rate, + DRM_HDMI_TMDS_CHAR_RATE_MIN, + DRM_HDMI_TMDS_CHAR_RATE_MAX_2_0); =20 return 0; } --=20 2.54.0 From nobody Mon May 25 01:58:04 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F41A3BCD14 for ; Tue, 19 May 2026 14:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202065; cv=none; b=dow95MAqMWtZsntNhqboymbpNJIl5AZyvjDMDwsRVbtxXopcrOcwcG/oLLGlUVkJjQzRJFTUn3dxhi+T5iS8lEeC2OBExCDfMjH17qp2tJ5MiPrlHtjqkq4AO02zECG4BfzaFcs92WnpoAlcz4bDrWPnnhUzYJl1GhLt6J9K2XQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202065; c=relaxed/simple; bh=MqTKnSCziFxZ+NsgKUBcw9ux+x44pK74BKLiQYyRDHg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M2kargbgau21LTmYNaXQGtDqPdzrwKbdLIwPYfrc0jRdiKbmkR47CEmZsUb1G/BPNRCvXY5jvwWtt4/2oG9h1v6F8iOgFFpQwO+1FRiJNTxFoRhybz5n+7Th8xg+Ywe7n5WXWEbjRp7FEvcWXAjCQVxuiNxBER2GRMcDUzO86BA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XW9L6ape; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=bcBMUY+5; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XW9L6ape"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="bcBMUY+5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779202063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6r8iDBFlPBC89fVvBoaRrCLk0Thq/XCfLs2Px8PTdkk=; b=XW9L6apeE3FQfa3xtWOGP6WCUtnEpDa0ODDxAVyWj1lSuT0IKFkKVOaU5gdM30WPmyK0fv +XoyjeYKPZmXN5khdJvvNaKF5e83ORD2CSePUoGIk2Xl3a5hZrhpMSYoeiHCZLMT0eu0B/ vAGx0N1mJOOUSN7HDTbJhfPdpbmsHqY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-256-SPwQho5qNDGnHe4Zb5Y_aw-1; Tue, 19 May 2026 10:47:42 -0400 X-MC-Unique: SPwQho5qNDGnHe4Zb5Y_aw-1 X-Mimecast-MFC-AGG-ID: SPwQho5qNDGnHe4Zb5Y_aw_1779202061 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48fdacff6d2so28782825e9.2 for ; Tue, 19 May 2026 07:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779202061; x=1779806861; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6r8iDBFlPBC89fVvBoaRrCLk0Thq/XCfLs2Px8PTdkk=; b=bcBMUY+5/vFHrig+JgIigd4XfB7XZ9jC4EXwKrs2z7dRQ2dNdgccYNK3pUuiyN8htA 0sNCr5E2kxXcwyvAoe1cPbfseuijJrmegnDXLXk5dv/0v6ILl2dNbsS5WHylX9pKwcKZ Ez2ZA9wpw6tmdQW21K3REz8CdGGe+u0Ve6CDc/gtZe5D7tNXwMG6iX3hNMkwm2+3Nral klTV29D/jUUYG0vxWeEzolM1bLEEl4a3QhsSOfzurA9YAG7kJ3xt8kViSAvGMoJJ5vN2 zFnv1LFbDg9vQOKRo0Xonmoks+AzRm8OQTFzJlp+6FuYgrwav9FvfF4dQqxEP4eie5MU QMYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202061; x=1779806861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6r8iDBFlPBC89fVvBoaRrCLk0Thq/XCfLs2Px8PTdkk=; b=dGQesab/fcq3RDBF45Un3P5VbwAC6Pd3K6ACP4SjhfpJLbzUT20rzVlLUp0mLrdDHb NlSLQ2aA+/AxBjuN2sf72TKz7V+soG0Is3MOUkhGFrLvkHesUBidmw9Q88l+A5uVRY/+ Gf6Q24N0UjiSbMgX1nUOiYPR/9Fli2A84x6lqjeEnHIgsBXmWPIsOHmZ7VLMP+IGSkvO TTm96gOVvadP6rkMZIgaIK/jDLryO1mqjCwWB/BYl6qYNlM7cqygesHm8I4Jjom1k2ew D3Xobc1s/Q0NaeGK+/C12IxybqHO++Kl/Sv1oMZB8oD0pFGtoi3Kg6R1vgIFYuNVfyGd puog== X-Gm-Message-State: AOJu0YxiX4INQV2E8aqv9F574c4sfJhY01o7r8o8uabiWFmm01yDfbHc L2F/YwTmTPscLmmgsm2yJNUO8e3LD+AbZb6EeLO6RFZJyze1DBkVUv/WE+jGfMtTSicdk7donGF /hTjV/E4CFPuE5/cYSlBOS/gbpWl8k2LvLFrI/v+f+If6LNOvFBpHFSY+uNAQyEvTBK0e9gXqyp 1pm5lqnr/+0+e4WOxsYvNe5X3MQcvNmfdpX5Z+DcsZhRdWEO2C X-Gm-Gg: Acq92OHex+OplRD+Y+Jnf5UMWma4n4Pk6qr95w31+O6TOcjpndF85/kKgTdtl4bhqti dymFuJQ8AyQp3PUcziNIiRap81ZA0npCMnQ2oLbFa3ie6fNL7B2Y3UpoLIBy7qHnPvoNNhgMBVd 1daAkjlFsBRaOcOPb290CpXBEzpYMbr84e057flFk4AjlXisJ/Q40VUKrD0WV/0nKVPhbD6kX7x gQ/DSBbzPInTPSd6MSguh4Qy3CnIUm7p72gt0Gy7tyk15760DJ4vb5u5zhDCQMZxNl3r5kudcyE Gko5BJk2tEYRwHc2CDIKlEoBxKXZb/2D5pgJzAa5ejckDKv4b+qDLmOTpuW8b4gY405dpCMJrI6 ZgOpXH26mnUUDhzMlaXJTZEt2xlsHSq6yB6E0eUE9uLC+yp4= X-Received: by 2002:a05:600c:858c:b0:48a:563c:c8e2 with SMTP id 5b1f17b1804b1-48fe60e54d6mr245200845e9.3.1779202060841; Tue, 19 May 2026 07:47:40 -0700 (PDT) X-Received: by 2002:a05:600c:858c:b0:48a:563c:c8e2 with SMTP id 5b1f17b1804b1-48fe60e54d6mr245200135e9.3.1779202060303; Tue, 19 May 2026 07:47:40 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49008c047absm67922045e9.0.2026.05.19.07.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:47:39 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Abhinav Kumar , Brian Masney , David Airlie , Dmitry Baryshkov , Jessica Zhang , Konrad Dybcio , Marijn Suijten , Rob Clark , Sean Paul , Simona Vetter , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 8/8] drm/msm/hdmi: Use the common TMDS char rate constants in 8998 PHY Date: Tue, 19 May 2026 16:47:04 +0200 Message-ID: <20260519144712.1418302-9-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260519144712.1418302-1-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the driver local defines, for the minimum and maximum TMDS char rates, with shared constants defined in . Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm= /hdmi/hdmi_phy_8998.c index a86ff3706369..3d2c1de975da 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c @@ -7,14 +7,13 @@ #include #include =20 +#include + #include "hdmi.h" =20 #define HDMI_VCO_MAX_FREQ 12000000000UL #define HDMI_VCO_MIN_FREQ 8000000000UL =20 -#define HDMI_PCLK_MAX_FREQ 600000000 -#define HDMI_PCLK_MIN_FREQ 25000000 - #define HDMI_HIGH_FREQ_BIT_CLK_THRESHOLD 3400000000UL #define HDMI_DIG_FREQ_BIT_CLK_THRESHOLD 1500000000UL #define HDMI_MID_FREQ_BIT_CLK_THRESHOLD 750000000UL @@ -649,7 +648,9 @@ static int hdmi_8998_pll_prepare(struct clk_hw *hw) static int hdmi_8998_pll_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { - req->rate =3D clamp_t(unsigned long, req->rate, HDMI_PCLK_MIN_FREQ, HDMI_= PCLK_MAX_FREQ); + req->rate =3D clamp_t(unsigned long, req->rate, + DRM_HDMI_TMDS_CHAR_RATE_MIN, + DRM_HDMI_TMDS_CHAR_RATE_MAX_2_0); =20 return 0; } --=20 2.54.0