From nobody Mon May 25 01:58:16 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A600434041A for ; Tue, 19 May 2026 13:12:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779196371; cv=none; b=d73vE0KJv9ogcMD29J3ffnRH+L0vhS9JiaTGzqN1zvNsCIoLBGdKgmwOFGR4Mti36NWWZ77vp/SmvKwR2OFhwCOkTEFA/hJJEY6M+IDpJcp+CmKLJoohJjU+3M093HeoY7qdDhpwf3t53g3R866l2HHt2tLyaAMyuwd4I0ik9oM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779196371; c=relaxed/simple; bh=lImeEsAHqUGq9zR78xP8XHL9dVlEe1rkWqdWMLkWziA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Whh6kivCxwC6iwnjfk63ss3tVLcKHY66YQPQrXMP19hCbe8ooFgABnSxEkmhi/5/uQHGfVuf+CvB+p6WgBG53vNQNbavutnv4nQp7PZoWyyuOl78NOlWHW0pMqsq03/bS6r9XLV8WNmTUgdTRDeT7J6BDP9K7H9rzDte+jNbde0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=P0VQHWox; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=JZvJX8jL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P0VQHWox"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="JZvJX8jL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779196368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AG4FqkfMx5fUyMM7BkxHeJoowUaeWn4Zw1beeRp993Q=; b=P0VQHWoxWb3gvWMMCy/oCUo2PSd9ff6sl+UaM1+LC+Lq1GGG8WMyWzXjqOqzfBqqyT6dkG bvZ1h8TI9eRKdm2BjUAj/bUR5a5hxoC1DydUyyM7S1V/5w8KFzgAFTsCxViD9RqWjUOuNU f3w9hqwiSetvrW8H8pDzX2nfDjYoKII= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-5kexIwR4NCqbBjN2W9IBsw-1; Tue, 19 May 2026 09:12:47 -0400 X-MC-Unique: 5kexIwR4NCqbBjN2W9IBsw-1 X-Mimecast-MFC-AGG-ID: 5kexIwR4NCqbBjN2W9IBsw_1779196366 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-45e2f74da10so4067914f8f.2 for ; Tue, 19 May 2026 06:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779196366; x=1779801166; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AG4FqkfMx5fUyMM7BkxHeJoowUaeWn4Zw1beeRp993Q=; b=JZvJX8jLNUcux1FDhGguvXgUlcVfM/i2QNLIJ/QWqi+bbqf/haNhXyTgS1vvc5g/Go RVdeQD2uoiRZhUULyKur/MEzzML0toZHFbomRYgUurzD7Lbq/TwKRxpuQU9P/oANeF4N RUF6Hs/R4wzMf+Cscp/3KfaaGgR6pTAkYKVt6ZKR3XlOE8WfZSzz90puf3JgXiP+inxk miSTWrKh3y88j5p72Jy8EoPwCAqGPZTmm9urUgTORYkt4VfeoF3p82TtJjYPUB83i2AN RwkjeM9TySRwakxRTCQhIeY4W1WBgDuK2NSvNIzfQKnf/cO5qYB7To1AWC9F5Pj9aIl9 DAHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779196366; x=1779801166; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AG4FqkfMx5fUyMM7BkxHeJoowUaeWn4Zw1beeRp993Q=; b=kS5kH8tdI/HEaKk4uJizxvugkzJgH7vVjn6ggcFe6k2GXv8bBV6Oq6kyy/gSOj5t97 isW9ClOPJvO2+No1sbD/a8cIx8hJSu4U9Ak1rEZMI78rpyjWjb/6ZISRVwT9Dpetw/0E pApl9bINNsVqsTF47V0ZVHZZjWzzSkELUW+UMg6FWGeIpJqBJpkVUAVLUwHPOqfut8w8 vaWQAskgZsM6M4GxvOL4bEcXKyQ5QYZ8GDSu9HJ86U5b4awS3fXNVWDNATRNizRl2szW k3QGzTiyg3/zy7cP9qFktKq053GwxdEwCLdqMEGXf1fFQmV1HCWB3c/OuLsqG2Us5WJT 1LTw== X-Gm-Message-State: AOJu0YwQeUupqxnaFY2Jfiz7OWBIntElOpZKtTGkoSCqOZ/Y2cePQxHI 7qONZA0ydIoTxW99ZRwziX8zO4hITTPeHRRRXoAs1jDDL59OqgKDisRmgMkt2YtfgcLIDuJPnmq BeBFjuqR4gcIK3/gjscSsS97dZx5j31eRYONp8xUB8eoGnwaM7tLXrKTSSlFFn08lDC6egdTUF+ PuEVLNjOtMOwjVPPbHuWZDFc7FGnllPGf8/PGsNmxnPjQ1NzPn X-Gm-Gg: Acq92OFSnf/pcyY6bm6cDRdB79K9HtCtuftrUL2eD9WSyqVKTNib+g+9ekLpyqVqwxN kUNolnwrPGTPsn9Q+jlgiJJU46J+bF2C6cAXY7LscKA9yIEGppuZKgmfC6Xh2mEC/7vzATRm1L4 tmMjvtVS6eGvxRRxVHb9kxVXYk0q02cPbdDve7300XJnb+fn52BJ8TVpPceI/HWuQnN9Gnyfrxj 5OVJklci/QwDPIP3f/CuAvI3lDvJcdMO+au+l8IiNcYbe7TicmzW57AStFWUUsLSziIRiqEh+RZ J/eKaScQ9w1p5nZHMuIWqA5xE3rxxmaSVUkTma3YOcOsQLpXptLU01H2oXr/hucmzCadPmVYZsh iGgmK+TsqiMI/WQshwoQJNgpThiEguRBn0ZETGU2e8JIrW70hN4LdXUtJzQ== X-Received: by 2002:a5d:5d86:0:b0:45e:8547:f217 with SMTP id ffacd0b85a97d-45e8547f327mr9475850f8f.37.1779196365615; Tue, 19 May 2026 06:12:45 -0700 (PDT) X-Received: by 2002:a5d:5d86:0:b0:45e:8547:f217 with SMTP id ffacd0b85a97d-45e8547f327mr9475591f8f.37.1779196363474; Tue, 19 May 2026 06:12:43 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a19c2dsm46669982f8f.21.2026.05.19.06.12.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 06:12:42 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Brajesh Gupta , David Airlie , Frank Binns , Maarten Lankhorst , Matt Coster , Maxime Ripard , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH] drm/imagination: Fix missing pvr_power_fw_{en,dis}able() argument Date: Tue, 19 May 2026 15:12:05 +0200 Message-ID: <20260519131239.1291732-1-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Commit 42577ba79fbf ("drm/imagination: Rename FW booted to FW initialised") dropped by mistake the last argument of the functions pvr_power_fw_enable() and pvr_power_fw_disable(), leading to the following compile error: CC [M] drivers/gpu/drm/imagination/pvr_power.o drivers/gpu/drm/imagination/pvr_power.c: In function =E2=80=98pvr_power_dev= ice_suspend=E2=80=99: drivers/gpu/drm/imagination/pvr_power.c:382:23: error: too few arguments to= function =E2=80=98pvr_power_fw_disable=E2=80=99; expected 3, have 2 382 | err =3D pvr_power_fw_disable(pvr_dev, false); | ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/imagination/pvr_power.c:93:1: note: declared here 93 | pvr_power_fw_disable(struct pvr_device *pvr_dev, bool hard_reset, b= ool rpm_suspend) | ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/imagination/pvr_power.c: In function =E2=80=98pvr_power_dev= ice_resume=E2=80=99: drivers/gpu/drm/imagination/pvr_power.c:412:23: error: too few arguments to= function =E2=80=98pvr_power_fw_enable=E2=80=99; expected 2, have 1 412 | err =3D pvr_power_fw_enable(pvr_dev); | ^~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/imagination/pvr_power.c:122:1: note: declared here 122 | pvr_power_fw_enable(struct pvr_device *pvr_dev, bool rpm_resume) | ^~~~~~~~~~~~~~~~~~~ make[6]: *** [scripts/Makefile.build:289: drivers/gpu/drm/imagination/pvr_p= ower.o] Error 1 make[5]: *** [scripts/Makefile.build:548: drivers/gpu/drm/imagination] Erro= r 2 make[4]: *** [scripts/Makefile.build:548: drivers/gpu/drm] Error 2 make[3]: *** [scripts/Makefile.build:548: drivers/gpu] Error 2 make[2]: *** [scripts/Makefile.build:548: drivers] Error 2 make[1]: *** [/home/javier/devel/linux/Makefile:2141: .] Error 2 make: *** [Makefile:248: __sub-make] Error 2 Fixes: 42577ba79fbf ("drm/imagination: Rename FW booted to FW initialised") Signed-off-by: Javier Martinez Canillas Reviewed-by: Brajesh Gupta --- drivers/gpu/drm/imagination/pvr_power.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imagination/pvr_power.c b/drivers/gpu/drm/imag= ination/pvr_power.c index 0ed9e7be604b..a71d5b35601e 100644 --- a/drivers/gpu/drm/imagination/pvr_power.c +++ b/drivers/gpu/drm/imagination/pvr_power.c @@ -379,7 +379,7 @@ pvr_power_device_suspend(struct device *dev) return -EIO; =20 if (READ_ONCE(pvr_dev->fw_dev.initialised)) { - err =3D pvr_power_fw_disable(pvr_dev, false); + err =3D pvr_power_fw_disable(pvr_dev, false, true); if (err) goto err_drm_dev_exit; } @@ -409,7 +409,7 @@ pvr_power_device_resume(struct device *dev) goto err_drm_dev_exit; =20 if (READ_ONCE(pvr_dev->fw_dev.initialised)) { - err =3D pvr_power_fw_enable(pvr_dev); + err =3D pvr_power_fw_enable(pvr_dev, true); if (err) goto err_power_off; } --=20 2.54.0 base-commit: c1079aebb4de218caa86c44f9a53700d1a582683 branch: drm-misc-next