From nobody Mon May 25 01:58:13 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0B4134041F for ; Tue, 19 May 2026 13:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779196319; cv=none; b=RTpdyaHMyBVx9T3IY+FvV72bQjJ4b8VkAy2wayTt3d/iOhD7E6M6P34arZB2VByYqogE+iIAyHcInvLLuJL1oW9Iiar0uWyHgO9lRbJXgxL6Q0tSo04DcxJzqwYxToG5Cs+1lc2Tdgyl9zHgLNYgOmsQ7IBKVrKrDP0UVQqjh04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779196319; c=relaxed/simple; bh=NGAoKSZsSI6yS68/Cka/Ug/C4BfsSVSyxcCxJsa4/kk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=hIWxWR9SsU+VlVsPfcRG0OUxKDIVGCAPZ3sJqwiGXKUPZWuvz5iU2tBcQ5ZPMvmhC4/xr47gTKKzpSZpBPfKs2PN/cMTOEAIHg2+4ZacO6KuNoxcqvX4N/obrp3j/TdUePL4jbwEg54kgXnro/zxFshhfW0SSJzfVKOaW/k3xZ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aGMEc19X; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=J2d6SFfK; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aGMEc19X"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="J2d6SFfK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779196316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lmE8m1KTGvjbfJBeKvFdnsCGJAOM6YzAXXd3ty/sM/w=; b=aGMEc19XGeE1wmr0HXOsE+k6q6lPg3WSkDUPYKbzcj1td+Be3IcXkzIRc66lZDkdi/bOd8 fSfevTGkBxz9SN2psMF83L8rRyhL51Q/7CFgzk51Wyyrpb/gF1aBHzn2qB/sxDQYWCs6P2 dauC5XxQEBcH6xh8WKmL21QaNjOK3gk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-mwtk1GhEMAi7FxKpUY-99g-1; Tue, 19 May 2026 09:11:54 -0400 X-MC-Unique: mwtk1GhEMAi7FxKpUY-99g-1 X-Mimecast-MFC-AGG-ID: mwtk1GhEMAi7FxKpUY-99g_1779196313 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48fd8162ed7so27708525e9.2 for ; Tue, 19 May 2026 06:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779196313; x=1779801113; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lmE8m1KTGvjbfJBeKvFdnsCGJAOM6YzAXXd3ty/sM/w=; b=J2d6SFfKKMxapL8ggcJutERgyzIOQvz6N+cgnnHUGN/Hpbb5aVRi44N7re8wLo7fed SUpbT8/9QtQOZAj+BbzH0klg49EgiBTq5SwooqCibT4YqlZQNQXFoHzbHaseUpLvA/0X /pWcN2zczYBB7VywR1t9syHPC5LA1fuvdCSpzHWUBOR0raO+SlWTsevcoqTvfMyXjIjY ZJLLovHBsB5L1H7wbulOf8ofn4IuxRxFqnV8NKuTL4aagdZvu3oLH/6vrSiA/ol2oK5v w9p5MTjELeNEtzptmVuLV15iY3vKn3RlJOwNzF9cA1P7CsH5+DxuQDJb8zxZmBHriHuG hqSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779196313; x=1779801113; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lmE8m1KTGvjbfJBeKvFdnsCGJAOM6YzAXXd3ty/sM/w=; b=CVLhBoxgDe7TwIe2xSHU+Ew6nXt2fCCXTnkCrojhodSgrw+usU31a2mtPw1j5icTx3 IkEb2sfUTNsXLKj2D2tLx300X8ZUDi+JcqJLFsusbrctZh/0QCQbm9JLxYiNhu1/gFQv xqDxfWAqP2LXxyMuE2N7Y13RyhG1+zC0EZkvrmcrUKQcwVRF0vInJmO0xSq6lyXhMWcH S6t+qoILWRC2yz+827WuCZGzeIbWIICrM2yz53cJz7XLvNPnDB/zUnyK9IURiI65CVu9 tFjE7sjxZZoO+Q7sEaz7PkpG6r8fzlrYkT1r/KuwgktLMAoj9LxxU6aoxAiC0oK5+M0Q ggZA== X-Gm-Message-State: AOJu0Yzpyn3GjAbcYN6Fnkx5Mkkn0pWCLbCU6Ld9AJf2vxhJBm9wYKxo rlod3e0o2jmkXGekSCijEcPSaGotkOSh+BaKMsqfnds6TCnEqceF/BqYN6VjnpJ1BT1BgzJPHv0 lvjHBxZUn5SUGUI2FMv6/TZiZOl3S3ihQni8C/kKhJNsEwHjcTGAThWr+S/bQgOGnL0cY97qsOC hRfLulMYFZnn+iumd4Te7E3mxmtH2enwFLwataXFZXbWm+ZB5p X-Gm-Gg: Acq92OEsSvzLbfyHpb/yB5su5Kcddl0wfNp/Num09usD1qNqmJ+XgYsaBGfww7I8Yjb 6jH/zyfkuNa+uQ4eZe8F/UdcamIu4GCFGO1pQ+2UHwENASZ4dARC6Xeg3ra2oYIlH3Ifc54qxWy VCtudg6hfhPelMjsfuqz1s9e59kjk93EtF7uyhjPRLoQKIrAvpWtek6QjQNJU0G8N6vJ0Q6jneo fy5uB8Z7TGX1jxvYQrAWA39qomeJB79aqPEgaAmsEbdVqL7wWLrxnMG4hYKt5srlkKlwwtDRlaD B9WTBBDoQivT4fj2RWLKqiPRP6VV37TRUHeUWRYN3vViHTLavRr/3+QsILtbZblx+rsk+FhOr94 Elt9HdHI1geKSJYSacv7bhbgqd5BPHURYnPOyjeDzokwH4xY= X-Received: by 2002:a05:600c:3b12:b0:488:b14f:b8ed with SMTP id 5b1f17b1804b1-48fe59ab80emr299210055e9.0.1779196312720; Tue, 19 May 2026 06:11:52 -0700 (PDT) X-Received: by 2002:a05:600c:3b12:b0:488:b14f:b8ed with SMTP id 5b1f17b1804b1-48fe59ab80emr299209445e9.0.1779196312141; Tue, 19 May 2026 06:11:52 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe57943b2sm334627745e9.8.2026.05.19.06.11.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 06:11:51 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Brajesh Gupta , David Airlie , Frank Binns , Maarten Lankhorst , Matt Coster , Maxime Ripard , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH] drm/imagination: Fix missing pvr_power_fw_{en,dis}able() argument Date: Tue, 19 May 2026 15:11:30 +0200 Message-ID: <20260519131150.1290393-1-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Commit 42577ba79fbf ("drm/imagination: Rename FW booted to FW initialised") dropped by mistake the last argument of the functions pvr_power_fw_enable() and pvr_power_fw_disable(), leading to the following build error: CC [M] drivers/gpu/drm/imagination/pvr_power.o drivers/gpu/drm/imagination/pvr_power.c: In function =E2=80=98pvr_power_dev= ice_suspend=E2=80=99: drivers/gpu/drm/imagination/pvr_power.c:382:23: error: too few arguments to= function =E2=80=98pvr_power_fw_disable=E2=80=99; expected 3, have 2 382 | err =3D pvr_power_fw_disable(pvr_dev, false); | ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/imagination/pvr_power.c:93:1: note: declared here 93 | pvr_power_fw_disable(struct pvr_device *pvr_dev, bool hard_reset, b= ool rpm_suspend) | ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/imagination/pvr_power.c: In function =E2=80=98pvr_power_dev= ice_resume=E2=80=99: drivers/gpu/drm/imagination/pvr_power.c:412:23: error: too few arguments to= function =E2=80=98pvr_power_fw_enable=E2=80=99; expected 2, have 1 412 | err =3D pvr_power_fw_enable(pvr_dev); | ^~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/imagination/pvr_power.c:122:1: note: declared here 122 | pvr_power_fw_enable(struct pvr_device *pvr_dev, bool rpm_resume) | ^~~~~~~~~~~~~~~~~~~ make[6]: *** [scripts/Makefile.build:289: drivers/gpu/drm/imagination/pvr_p= ower.o] Error 1 make[5]: *** [scripts/Makefile.build:548: drivers/gpu/drm/imagination] Erro= r 2 make[4]: *** [scripts/Makefile.build:548: drivers/gpu/drm] Error 2 make[3]: *** [scripts/Makefile.build:548: drivers/gpu] Error 2 make[2]: *** [scripts/Makefile.build:548: drivers] Error 2 make[1]: *** [/home/javier/devel/linux/Makefile:2141: .] Error 2 make: *** [Makefile:248: __sub-make] Error 2 Fixes: 42577ba79fbf ("drm/imagination: Rename FW booted to FW initialised") Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/imagination/pvr_power.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imagination/pvr_power.c b/drivers/gpu/drm/imag= ination/pvr_power.c index 0ed9e7be604b..a71d5b35601e 100644 --- a/drivers/gpu/drm/imagination/pvr_power.c +++ b/drivers/gpu/drm/imagination/pvr_power.c @@ -379,7 +379,7 @@ pvr_power_device_suspend(struct device *dev) return -EIO; =20 if (READ_ONCE(pvr_dev->fw_dev.initialised)) { - err =3D pvr_power_fw_disable(pvr_dev, false); + err =3D pvr_power_fw_disable(pvr_dev, false, true); if (err) goto err_drm_dev_exit; } @@ -409,7 +409,7 @@ pvr_power_device_resume(struct device *dev) goto err_drm_dev_exit; =20 if (READ_ONCE(pvr_dev->fw_dev.initialised)) { - err =3D pvr_power_fw_enable(pvr_dev); + err =3D pvr_power_fw_enable(pvr_dev, true); if (err) goto err_power_off; } --=20 2.54.0 base-commit: c1079aebb4de218caa86c44f9a53700d1a582683 branch: drm-misc-next