From nobody Mon May 25 01:58:47 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 909223328FD for ; Tue, 19 May 2026 11:46:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779191190; cv=none; b=o0U4Z/342gWAuU+2ZrYvMD/6cTN9M2fRtQAxaWZAPG1XHiqKOpVy5fRTFUcJpVjTwnO7pJxMlFvVD+QLy/psL0tJz0uugN07Z/4IrubyBwehMeKENP7SWt/J0ws+knpajoRivboPgawFtHcqsi4GwniBrl53s2lRH1HSHzgT+iE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779191190; c=relaxed/simple; bh=N7hZu7+aCRedqgt69jIx8GEcM20nGTuyb3uXDewztTE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Saj6tW41jlivVl+hZ+IS0w4ep7GNfCiP1IXROFL1NzJ3wPha4d6vlAVWw4DXvXN9h+9y16Z5Q0FOALaJSJ5AxqHuDctWYGPr3m0Zz7RkmGifjwgFkwjNQpbwRKBf/Y5WjHXIoKxIkDo1VX5HscQu96ifX8hvMeYaJDJuR6H4XjY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aXBIQIVJ; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aXBIQIVJ" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2bc7b311e77so13919255ad.0 for ; Tue, 19 May 2026 04:46:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779191188; x=1779795988; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ta61K0Pmld/CsWKgzlq6xjmWULCR3bAZMfwfucx3DEM=; b=aXBIQIVJ+L/MiHV66x9yRdUGYJRBESgFBzJYXuzXXNG/V/MfNJRjGQgyfoeJohjtHA zsfEBeeny9vmsOuqNLat/3TckJ9c8TpSzm6H0rCFC8kYt7m76Ff8yKCOBE5A+i30ryUI bpCtERLVW5PVkv+zJJ8/q3BshcjxFA5B8m+YBSU70Bp+B14OwJDGsE3roQnuS2yJk5xC TvPZYmCPc+JR063KQVCVpUZff0PVhMLpbfSCUDEu6aHYo6GVM7uuuPTNV9sANHJHu4n2 kxCJHSXvAXNPPC/ZstY7ynB2ODLXyItR5KmUyA4Vg+M3f7UclRuxqkjYgR0DgUS6oYz4 tvqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779191188; x=1779795988; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ta61K0Pmld/CsWKgzlq6xjmWULCR3bAZMfwfucx3DEM=; b=FZrGGctiCh/6gXOmjavYIP/ySyPyc0WXso0H6+ZaygnbwaeGVVNs4gPwKbleSW5wIA 50s1R7PeVPARHZY0PoQP74ZHSrN3mPhyLKXqtFIqVaROgDC/ydwwSr5LgVZILoHyO7Dz v42khCZiaEMQExeTsTb9WmM72eaZRBUVgmhdgesxSEcppZS7L9LZV3Dm6d0XQu5Q/qzU gHS5S6eAo+66AMU5RWFpR3v/nELLyw/j+jabiv7vo/ZIYJcuGuMQAodmUkSMQDk3HlQR mjO0f7/3ndKsI14sb4cXWdObT4GGqQO7SzjQESVRc34Hehax8ixn83YKrRJTLPL6m1CY NXeA== X-Forwarded-Encrypted: i=1; AFNElJ9uz07UbHRnB8wiDQwAULtoLxH0vnlRB2iXRsi+TJwdik/sfe2wN+n3Q7tRlSFUvTXdjpA3uVV5l8b3cUo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy07FRCgYcc7FoxDOQjBGO0aRSzac+pH6Ty3/7oHiksJVnrtSAO 5MGIq5aajo2ykC/N8Qlx1SuEY5nNNhprm35cyXJ4APbG8Uba4OjHTIGa X-Gm-Gg: Acq92OEyR74Ye2uywtqu3Zb3ha6dTWiQ2ttVo7/qtrWJzjT9hf9MwyWNDIC9Io9tmvG /eU09vrJMYnyFvZWo7nzSxrJoEKo0JKPNtLR9fLvDnQdfrmJERpdTt33FgF/gCsT+J9Z4iXZX1G rYDU/Emor92PIY4y6Bguj1BYq0jBoXal0Sv9mdm5h7EUoEbUHAl9X2N4JhbB+LBKuCYEXKxLnvK aHl2GuT7KDIyRmZGVpl2JZ/XxwlvBvLgwotrkAUKhVlku2sUDrRThmkHtYO0C0cCRHuR9Jtw58w kRgw4dIHUZx36LGd2BdS3Z+32DAU5M4UfnF3eDQlwjLAtRoP1HdrjG6A9IR4x+SRoes0jGDjQOg Z7Hk7+y2r6mh4mKhj5chpXT4f2skWq7dDlrjxh3Qs/1yl+T6Qd7YO5WXHB9j57Y0/Zn1suFioLC or9kr00/2AYoiSMx+cncmNjn3UOecvLksx6ptm1xTDYBECLys+Nw7QwQ== X-Received: by 2002:a17:903:1cc:b0:2bd:2c3a:2a36 with SMTP id d9443c01a7336-2bd523168b6mr203103925ad.0.1779191187600; Tue, 19 May 2026 04:46:27 -0700 (PDT) Received: from souradipto-das-Latitude-3460.. ([2405:201:8011:1c:c7a5:efe1:9ef6:7b2e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5cfe4935sm193368545ad.42.2026.05.19.04.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 04:46:26 -0700 (PDT) From: Souradipto Das To: Stefan Agner , Alison Wang Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Souradipto Das Subject: [PATCH] drm/fsl-dcu: Remove redundant connector registration Date: Tue, 19 May 2026 17:16:11 +0530 Message-ID: <20260519114611.11388-1-souradiptodas6@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the explicit calls to drm_connector_register() and drm_connector_unregister() from the parallel RGB setup track. For standard drivers, these operations are redundant as they are already handled automatically under the hood by drm_dev_register() and drm_dev_unregister() during the master device probe lifecycle. Collapsing these calls simplifies the error unwinding path down to a single internal memory cleanup step, as stated on the gpu todo list. Signed-off-by: Souradipto Das --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c b/drivers/gpu/drm/fs= l-dcu/fsl_dcu_drm_rgb.c index 84eff7519e32..5b457c16966a 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c @@ -92,18 +92,12 @@ static int fsl_dcu_attach_panel(struct fsl_dcu_drm_devi= ce *fsl_dev, return ret; =20 drm_connector_helper_add(connector, &connector_helper_funcs); - ret =3D drm_connector_register(connector); - if (ret < 0) - goto err_cleanup; - ret =3D drm_connector_attach_encoder(connector, encoder); if (ret < 0) - goto err_sysfs; + goto err_cleanup; =20 return 0; =20 -err_sysfs: - drm_connector_unregister(connector); err_cleanup: drm_connector_cleanup(connector); return ret; --=20 2.43.0