From nobody Mon May 25 03:33:06 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74BA637E308 for ; Tue, 19 May 2026 09:56:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779184571; cv=none; b=KWjO1tJX0mzjLOe86iSBffzUTRHSyimiMAsx2OU2lh9jo5nPucBlJZRvdBd2e5lcxWd5zxREHIFFk+btWVdqfLGlSZ+aNc5MRVbdKKpkodxjNq+scc/8BTjDBYxAVYeaSjAGLewx7STSc3FZvv+Et0fgDz9pb29FdpPnG318Wsw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779184571; c=relaxed/simple; bh=/LQEHTIq6LTFMijbqMPUVwmgIpviSok94r1c4CxGapE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Gjqc0XSICFiGSgaqjp1zryUg78fmoPr0cguvGGFMyRLma+s8Z3oDB6rW+eP3zIYbl73BOv6UjKVZQ75Q4CDmMIrDC2Mei3QAlXpW44W2gUKOQlYlEl9zdMctuXVY4DYez0E66wbSWK2L8NaGo/vyqht983ima+hG/DQrfUZnXv4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QTV8G513; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QTV8G513" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-48d10c981e4so4694475e9.0 for ; Tue, 19 May 2026 02:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779184568; x=1779789368; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wUceqssW4JcolAy41kY7p6kxMzL22y72v8TwMZQc6vc=; b=QTV8G513eBS5UV6HXAA4TQW6YDi7DzjGSL1XRsxyVx60B3mofpt8Cr2z5GaSObA9Sj fYllfbvWBA7rxa0KFqS1NEHxxBvmA26kOJhHIpxLSSV36Foim+ki0H6fP1KKDGpTd1UU n3y+kPo1pMNb7Z/MlL3fBcxmg0/k/w6mn2kp0t6m22ivTd7p0vFMLw2Bd6z80n7kreVm 4HaJRMG0lobXehSdc6g0d2598bcHlaMdyjj48OnQMnKW4OFe0TB+E7LL6+zNECfUkxIV 0ugVbZhFYV5KsrkQe+AOQVuLmOK+QG+PtjAmhjym/j5S4U3ZyvcRB1TJuEQKZwwYTkx4 r0FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779184568; x=1779789368; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wUceqssW4JcolAy41kY7p6kxMzL22y72v8TwMZQc6vc=; b=r6SumRRYHMTY6p1KPqZrgA970PiBYw+zCXUPkGHTfcxd8k7+XGekCsMAYzS5Dpz92v QJkIkWvi9VPbs+AiEdvztubDZlnjt5G/j+CL8eV2RuTFDs+mt7QKC3K4XoboaKHMhAX3 v6lBNhMJaLVrBNIDfev0lSxiuDXi0kgevFgLNUpdjbCSKTXBQBfcBLqNWmOqbFoF+xky d09Dc//2zld3y9Ric+wZWaPaQdPCIQFfKtZp1f1VZ/q2kvn95DgTzrImXE1bRidA9sMw BwFdK7+GUNP03VhiXQA4KBGATckjwyGKqswTF6PqNWrsPO9ZZFSATOWYWvsyVI6ZAaL0 L63Q== X-Forwarded-Encrypted: i=1; AFNElJ+uMQhI5+X2nOYaoycIkgTw9iGH9L73ddFV1+LTiy7HAUXLu/q9Bolyx0r7fIpO23TorGx5sxCZfx7QU4M=@vger.kernel.org X-Gm-Message-State: AOJu0YyQXzwLU09VasHlw3qeuzfof+g7PsHIk6EYOsXyhxCUbG/OPi/f iQUmmI+ftWmv44MrRedwLu5RFmZzjxKlbHzPRKCwNKHl/Iyqbh0BWwym X-Gm-Gg: Acq92OGHB0r9bnNPkCMCOE/G0CnILp2QRebpmKIopvxdQj3Z8DRgRUpwt8COiqEKg2u CRctMypcAlBAvN7jXjb05GbCAztGIlyXkfOhzC/yK5T5PNc6qgONPMIVpcAOMtj0Rot0Dd8+RHm YLDtWr486E4OH4E6SqW1qDiMe8wePAoKh/lqjDnWNgZecxea6HmsUZTQ0plRUk/s8boOaliOL2M 6xwNOn2Iwn6CKS9yIFglaoNOesKqjZIqz9IZPctF2xAu83otPLxY63wv3dUbkVgtl2jnq6zHNhJ 45yiCnka6AMnbnt4MIeJaL2B+Hjvg/ewXHLa4TqmcAvloagfi+jFnM/6uqHwSKRdB2u+DTOitA0 Sp4efH2PwJIA6vvpSGi/j4tsHQtdpxCWH7xsOln7QBHdvzd3IjTntrzBspBaNlJI3NPD7MsZFe6 nPMRWAcZhITlIsZ/vfzy0JEgl2252WazvFZ4Jm/NdaDZ/tHPivK6iO+1vcYmhbMHR3fW5Dmffeu Z1/SX8= X-Received: by 2002:a05:600c:1d02:b0:48a:5302:8ed9 with SMTP id 5b1f17b1804b1-48fe5ea0842mr170501005e9.0.1779184567548; Tue, 19 May 2026 02:56:07 -0700 (PDT) Received: from ast-epyc5.inf.ethz.ch (ast-epyc4.inf.ethz.ch. [129.132.161.179]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48ff43f213esm142960545e9.1.2026.05.19.02.56.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 02:56:07 -0700 (PDT) From: Zijing Yin To: Stanislav Fomichev Cc: Zijing Yin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Qingfang Deng , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next] net: dev_addr_lists: don't WARN on GFP_ATOMIC kmalloc failure in netif_rx_mode_run Date: Tue, 19 May 2026 02:55:55 -0700 Message-ID: <20260519095557.3749407-1-yzjaurora@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" netif_rx_mode_run() fires netdev_WARN() when netif_addr_lists_snapshot() returns non-zero. The only path to a non-zero return is -ENOMEM from __hw_addr_create() failing its kmalloc(GFP_ATOMIC) -- syzkaller hits it via failslab, and it can also be reached under real memory pressure. This is the only allocator-failure site in this file that WARNs. __hw_addr_create() itself, and every other caller of it in this file (__hw_addr_add_ex(), dev_uc_add_excl(), dev_uc_add(), dev_mc_add(), ...) just propagate the -ENOMEM silently. GFP_ATOMIC is a may-fail allocator; callers are required to handle NULL, so a returned -ENOMEM here is an expected runtime condition, not an invariant violation. The miss is self-healing: any subsequent change to dev->uc / dev->mc (every dev_{uc,mc}_{add,del}, IFF_PROMISC flip, etc.) calls __dev_set_rx_mode() -> netif_rx_mode_queue(), which re-queues the device and retries the sync. The only cost of a failed attempt is one stale rx-mode window until the next update; nothing in the kernel relies on this attempt succeeding. Demote to net_err_ratelimited() so the condition stays observable in dmesg without tripping panic_on_warn. Reproducer (syzkaller .prog format with setup notes):=20 https://pastebin.com/t7AQKx9v Fixes: 3554b4345d85 ("net: introduce ndo_set_rx_mode_async and netdev_rx_mo= de_work") Signed-off-by: Zijing Yin --- net/core/dev_addr_lists.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c index d73fcb0c6..c6fdcac74 100644 --- a/net/core/dev_addr_lists.c +++ b/net/core/dev_addr_lists.c @@ -1275,7 +1275,8 @@ static void netif_rx_mode_run(struct net_device *dev) err =3D netif_addr_lists_snapshot(dev, &uc_snap, &mc_snap, &uc_ref, &mc_ref); if (err) { - netdev_WARN(dev, "failed to sync uc/mc addresses\n"); + net_err_ratelimited("%s: failed to sync uc/mc addresses\n", + netdev_name(dev)); netif_addr_unlock_bh(dev); return; } --=20 2.43.0