From nobody Mon May 25 03:55:48 2026 Received: from m16.mail.126.com (m16.mail.126.com [117.135.210.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 708433D47DD for ; Tue, 19 May 2026 09:46:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779184014; cv=none; b=KqTck00glA9+r0D7ZHh0U+HXTecrf3Akb5VCgNqM9tIqUEdI7a9Qb9M74lfkbBnov3w7eDqEMuxNsnYypFS63DewDQu0RV1iuoXPHS12MhqQLaDevXtgIybOTHbv+pSXW49/sMHCMneesaofxMn6BeiIX+QM6obgwRDmzvynbHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779184014; c=relaxed/simple; bh=CSICgJrYHPQMJ8YAC/O27aOVVi9IAJPafcgoMZNM/bs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CSG35LXYx0WlsLZLorJJG/gXQIBx4JrmHDfWx8aCWBfJeUHRc/La2y5bfQBHjW2pzveXUve9ZPq+nElvTofk/6WRtdu4F89SxMthTIFwbNgDegMbN0mwdlslqeInbZbi0aiVzuJW1s7J1ptiDBXvuyshXtyXanSIJl9ySIbPxSs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com; spf=pass smtp.mailfrom=126.com; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b=OS+CwQPq; arc=none smtp.client-ip=117.135.210.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=126.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b="OS+CwQPq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=Oc MMjMJFRoHZSSWwbns9LSAwRbAkAZjbhxx++vgKVRU=; b=OS+CwQPq8hUJ5nhXBX Y0ssaYhbkSywyfnhBhmHy4rT1akrEa1+I2GHKzK51DyIIdzk7SJWrB49n51mBy/T wNxTJaflC5yrj3q6o6ga08TL7nrT9fu82YbSzGZzIRAxPyvA0dSI+CUh5Ecxo7bF YqdsERh0dVyqu4K4yiO4yh3Ys= Received: from DESKTOP-EQVOVNC.localdomain (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wDnryN6MQxqbACWBw--.65405S3; Tue, 19 May 2026 17:46:34 +0800 (CST) From: lixinyu To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] staging: rtl8723bs: replace C++ style comments with kernel style Date: Tue, 19 May 2026 17:46:32 +0800 Message-Id: <20260519094633.869233-2-xinyuili@126.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260519094633.869233-1-xinyuili@126.com> References: <20260519090114.828918-1-xinyuili@126.com> <20260519094633.869233-1-xinyuili@126.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDnryN6MQxqbACWBw--.65405S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7CrWDuw45Ar43WrW8WFW8Crg_yoW8Jw4Dpr Z7Z343Kr4Yqw1q9r4DJrn7ZF1fuan7WasrKayIvanYqFy7u347Xr98Kr10kr45urW7G3WY qrn5Xw1UW3ZxKr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jlxRhUUUUU= X-CM-SenderInfo: 50lq53xlolqiyswou0bp/xtbBrxsIUGoMMXt7vwAA3E Content-Type: text/plain; charset="utf-8" Replace C++ style comments (//) with kernel style comments (/* */) in rtl8723b_hal_init.c. Assisted-by: Claude:claude-4-opus --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 2a748367fbba..2c98ecc98ce5 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -2877,15 +2877,15 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum= hal_def_variable variable, v =20 rtw_write32(padapter, REG_HMEBOX_DBG_2_8723B, cmd); msleep(10); - rtw_read32(padapter, 0x2F0); // info 1 + rtw_read32(padapter, 0x2F0); /* info 1 */ =20 cmd =3D 0x40000400 | mac_id; rtw_write32(padapter, REG_HMEBOX_DBG_2_8723B, cmd); msleep(10); - rtw_read32(padapter, 0x2F0); // info 1 - rtw_read32(padapter, 0x2F4); // info 2 - rtw_read32(padapter, 0x2F8); // rate mask 1 - rtw_read32(padapter, 0x2FC); // rate mask 2 + rtw_read32(padapter, 0x2F0); /* info 1 */ + rtw_read32(padapter, 0x2F4); /* info 2 */ + rtw_read32(padapter, 0x2F8); /* rate mask 1 */ + rtw_read32(padapter, 0x2FC); /* rate mask 2 */ } break; =20 --=20 2.34.1 From nobody Mon May 25 03:55:48 2026 Received: from m16.mail.126.com (m16.mail.126.com [117.135.210.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 996CC477E53 for ; Tue, 19 May 2026 09:46:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779184022; cv=none; b=qrDk2qgH+qnK9MXhkw/ejYa5+i3XUAWjzN7wbZKQWAQ3rBZjOgdn5w6+tjG3hzr9ISBGQvEhKvWt3JdnmPPT2gFYEumSko4nen7D3UY/3g/1GL7qwKC5ksqUlGqhAiKA0BmobOUqvHPQLIlao6+35TCm8/FiyXoGtuAWE3Lntfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779184022; c=relaxed/simple; bh=CkvoSoRRHnLrQy4O4YluE0eyHQdgC8xZJ7RJxCHMfsc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pEP7gb/HDYRhgb6aqO0Hqj/yNnZSby5z1I7SLJ5JG59Z+zzOKgXK+X2A7i7Z0cQ9Ef88BBXgLFyZYTHv2rhWMdZ33gHZCj3POQ1r1u6TFR9cXrrU6M3gkWKVZc6lAiQS9YOApKBe8SNdF4SibdFwE50wgCGYzydWtyI6eQBzEKM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com; spf=pass smtp.mailfrom=126.com; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b=V94T/a66; arc=none smtp.client-ip=117.135.210.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=126.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b="V94T/a66" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=YK ziTSGVrIrdxsDTgoz2V2jaOYnrks7EABI7uVXM37g=; b=V94T/a66oLaK+LtuXJ yQcMVHtKKVN2BSdqgzssamef4ZHVpJR4Op1/wyIgts5BEoqa/6J/7I1SI7jfz1ne KKYXwJjKi9ug0LC0rDd7B3U1eujhkIc0STimhy4GmOMax4TG9s5Rhk+r6DEbCF48 Zr6auN7HRfi5MgAoyeiGJIDcg= Received: from DESKTOP-EQVOVNC.localdomain (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wDnryN6MQxqbACWBw--.65405S4; Tue, 19 May 2026 17:46:35 +0800 (CST) From: lixinyu To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] staging: rtl8723bs: add missing spaces around operators in rtl8723b_hal_init.c Date: Tue, 19 May 2026 17:46:33 +0800 Message-Id: <20260519094633.869233-3-xinyuili@126.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260519094633.869233-1-xinyuili@126.com> References: <20260519090114.828918-1-xinyuili@126.com> <20260519094633.869233-1-xinyuili@126.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDnryN6MQxqbACWBw--.65405S4 X-Coremail-Antispam: 1Uf129KBjvAXoW3CFW7tF4DJFWkCryrXF13Jwb_yoW8Gw4DZo WSyFWjvr1fKas7ta18tr17XF15Zw4xu343Aa17XaykW3y3JF4UZrZaq34UAw4UXr95t3yv yFW0qasIvwnayr4Dn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7v73VFW2AGmfu7bjvjm3 AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUSfHUDUUUU X-CM-SenderInfo: 50lq53xlolqiyswou0bp/xtbBrhsIUGoMMXt5JAAA3c Content-Type: text/plain; charset="utf-8" Add missing spaces around binary operators (|, &, +, >>) to comply with kernel coding style. This includes spacing fixes for register offset patterns, bitwise operations on function arguments, array index arithmetic, and bit shift operations. Assisted-by: Claude:claude-4-opus --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 96 +++++++++---------- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 2c98ecc98ce5..bcea4ab18540 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -21,23 +21,23 @@ static void _FWDownloadEnable(struct adapter *padapter,= bool enable) rtw_write8(padapter, REG_SYS_FUNC_EN + 1, tmp | 0x04); =20 tmp =3D rtw_read8(padapter, REG_MCUFWDL); - rtw_write8(padapter, REG_MCUFWDL, tmp|0x01); + rtw_write8(padapter, REG_MCUFWDL, tmp | 0x01); =20 do { tmp =3D rtw_read8(padapter, REG_MCUFWDL); if (tmp & 0x01) break; - rtw_write8(padapter, REG_MCUFWDL, tmp|0x01); + rtw_write8(padapter, REG_MCUFWDL, tmp | 0x01); msleep(1); } while (count++ < 100); =20 /* 8051 reset */ - tmp =3D rtw_read8(padapter, REG_MCUFWDL+2); - rtw_write8(padapter, REG_MCUFWDL+2, tmp&0xf7); + tmp =3D rtw_read8(padapter, REG_MCUFWDL + 2); + rtw_write8(padapter, REG_MCUFWDL + 2, tmp & 0xf7); } else { /* MCU firmware download disable. */ tmp =3D rtw_read8(padapter, REG_MCUFWDL); - rtw_write8(padapter, REG_MCUFWDL, tmp&0xfe); + rtw_write8(padapter, REG_MCUFWDL, tmp & 0xfe); } } =20 @@ -102,8 +102,8 @@ static int _PageWrite( u8 value8; u8 u8Page =3D (u8) (page & 0x07); =20 - value8 =3D (rtw_read8(padapter, REG_MCUFWDL+2) & 0xF8) | u8Page; - rtw_write8(padapter, REG_MCUFWDL+2, value8); + value8 =3D (rtw_read8(padapter, REG_MCUFWDL + 2) & 0xF8) | u8Page; + rtw_write8(padapter, REG_MCUFWDL + 2, value8); =20 return _BlockWrite(padapter, buffer, size); } @@ -264,7 +264,7 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padapte= r) !(IS_FW_81xxC(padapter) && ((pHalData->FirmwareVersion < 0x21) || (pHalD= ata->FirmwareVersion =3D=3D 0x21 && pHalData->FirmwareSubVersion < 0x01))) ) { /* after 88C Fw v33.1 */ /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ - rtw_write8(padapter, REG_HMETFR+3, 0x20); + rtw_write8(padapter, REG_HMETFR + 3, 0x20); =20 val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); while (val & BIT(2)) { @@ -682,7 +682,7 @@ static void hal_ReadEFuse_WiFi( =20 rtw_efuse_one_byte_read(padapter, eFuse_Addr++, &efuseData); - efuseTbl[addr+1] =3D efuseData; + efuseTbl[addr + 1] =3D efuseData; } addr +=3D 2; } @@ -776,7 +776,7 @@ static void hal_ReadEFuse_BT( =20 rtw_efuse_one_byte_read(padapter, eFuse_Addr++, &efuseData); - efuseTbl[addr+1] =3D efuseData; + efuseTbl[addr + 1] =3D efuseData; } addr +=3D 2; } @@ -881,20 +881,20 @@ void rtl8723b_InitBeaconParameters(struct adapter *pa= dapter) =20 pHalData->RegBcnCtrlVal =3D rtw_read8(padapter, REG_BCN_CTRL); pHalData->RegTxPause =3D rtw_read8(padapter, REG_TXPAUSE); - pHalData->RegFwHwTxQCtrl =3D rtw_read8(padapter, REG_FWHW_TXQ_CTRL+2); - pHalData->RegReg542 =3D rtw_read8(padapter, REG_TBTT_PROHIBIT+2); - pHalData->RegCR_1 =3D rtw_read8(padapter, REG_CR+1); + pHalData->RegFwHwTxQCtrl =3D rtw_read8(padapter, REG_FWHW_TXQ_CTRL + 2); + pHalData->RegReg542 =3D rtw_read8(padapter, REG_TBTT_PROHIBIT + 2); + pHalData->RegCR_1 =3D rtw_read8(padapter, REG_CR + 1); } =20 void _InitBurstPktLen_8723BS(struct adapter *Adapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); =20 - rtw_write8(Adapter, 0x4c7, rtw_read8(Adapter, 0x4c7)|BIT(7)); /* enable s= ingle pkt ampdu */ + rtw_write8(Adapter, 0x4c7, rtw_read8(Adapter, 0x4c7) | BIT(7)); /* enable= single pkt ampdu */ rtw_write8(Adapter, REG_RX_PKT_LIMIT_8723B, 0x18); /* for VHT packet len= gth 11K */ rtw_write8(Adapter, REG_MAX_AGGR_NUM_8723B, 0x1F); rtw_write8(Adapter, REG_PIFS_8723B, 0x00); - rtw_write8(Adapter, REG_FWHW_TXQ_CTRL_8723B, rtw_read8(Adapter, REG_FWHW_= TXQ_CTRL)&(~BIT(7))); + rtw_write8(Adapter, REG_FWHW_TXQ_CTRL_8723B, rtw_read8(Adapter, REG_FWHW_= TXQ_CTRL) & (~BIT(7))); if (pHalData->AMPDUBurstMode) rtw_write8(Adapter, REG_AMPDU_BURST_MODE_8723B, 0x5F); rtw_write8(Adapter, REG_AMPDU_MAX_TIME_8723B, 0x70); @@ -902,13 +902,13 @@ void _InitBurstPktLen_8723BS(struct adapter *Adapter) /* ARFB table 9 for 11ac 5G 2SS */ rtw_write32(Adapter, REG_ARFR0_8723B, 0x00000010); if (pHalData->chip_normal) - rtw_write32(Adapter, REG_ARFR0_8723B+4, 0xfffff000); + rtw_write32(Adapter, REG_ARFR0_8723B + 4, 0xfffff000); else - rtw_write32(Adapter, REG_ARFR0_8723B+4, 0x3e0ff000); + rtw_write32(Adapter, REG_ARFR0_8723B + 4, 0x3e0ff000); =20 /* ARFB table 10 for 11ac 5G 1SS */ rtw_write32(Adapter, REG_ARFR1_8723B, 0x00000010); - rtw_write32(Adapter, REG_ARFR1_8723B+4, 0x003ff000); + rtw_write32(Adapter, REG_ARFR1_8723B + 4, 0x003ff000); } =20 static void ResumeTxBeacon(struct adapter *padapter) @@ -916,10 +916,10 @@ static void ResumeTxBeacon(struct adapter *padapter) struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); =20 pHalData->RegFwHwTxQCtrl |=3D BIT(6); - rtw_write8(padapter, REG_FWHW_TXQ_CTRL+2, pHalData->RegFwHwTxQCtrl); - rtw_write8(padapter, REG_TBTT_PROHIBIT+1, 0xff); + rtw_write8(padapter, REG_FWHW_TXQ_CTRL + 2, pHalData->RegFwHwTxQCtrl); + rtw_write8(padapter, REG_TBTT_PROHIBIT + 1, 0xff); pHalData->RegReg542 |=3D BIT(0); - rtw_write8(padapter, REG_TBTT_PROHIBIT+2, pHalData->RegReg542); + rtw_write8(padapter, REG_TBTT_PROHIBIT + 2, pHalData->RegReg542); } =20 static void StopTxBeacon(struct adapter *padapter) @@ -927,16 +927,16 @@ static void StopTxBeacon(struct adapter *padapter) struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); =20 pHalData->RegFwHwTxQCtrl &=3D ~BIT(6); - rtw_write8(padapter, REG_FWHW_TXQ_CTRL+2, pHalData->RegFwHwTxQCtrl); - rtw_write8(padapter, REG_TBTT_PROHIBIT+1, 0x64); + rtw_write8(padapter, REG_FWHW_TXQ_CTRL + 2, pHalData->RegFwHwTxQCtrl); + rtw_write8(padapter, REG_TBTT_PROHIBIT + 1, 0x64); pHalData->RegReg542 &=3D ~BIT(0); - rtw_write8(padapter, REG_TBTT_PROHIBIT+2, pHalData->RegReg542); + rtw_write8(padapter, REG_TBTT_PROHIBIT + 2, pHalData->RegReg542); } =20 static void _BeaconFunctionEnable(struct adapter *padapter, u8 Enable, u8 = Linked) { rtw_write8(padapter, REG_BCN_CTRL, DIS_TSF_UDT | EN_BCN_FUNCTION | DIS_BC= NQ_SUB); - rtw_write8(padapter, REG_RD_CTRL+1, 0x6F); + rtw_write8(padapter, REG_RD_CTRL + 1, 0x6F); } =20 void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter) @@ -1004,9 +1004,9 @@ void rtl8723b_SetBeaconRelatedRegisters(struct adapte= r *padapter) void hal_notch_filter_8723b(struct adapter *adapter, bool enable) { if (enable) - rtw_write8(adapter, rOFDM0_RxDSP+1, rtw_read8(adapter, rOFDM0_RxDSP+1) |= BIT(1)); + rtw_write8(adapter, rOFDM0_RxDSP + 1, rtw_read8(adapter, rOFDM0_RxDSP + = 1) | BIT(1)); else - rtw_write8(adapter, rOFDM0_RxDSP+1, rtw_read8(adapter, rOFDM0_RxDSP+1) &= ~BIT(1)); + rtw_write8(adapter, rOFDM0_RxDSP + 1, rtw_read8(adapter, rOFDM0_RxDSP + = 1) & ~BIT(1)); } =20 void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_le= vel) @@ -1211,7 +1211,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( =20 memset(pwrInfo24G, 0, sizeof(struct TxPowerInfo24G)); =20 - if (PROMContent[eeAddr+1] =3D=3D 0xFF) + if (PROMContent[eeAddr + 1] =3D=3D 0xFF) AutoLoadFail =3D true; =20 if (AutoLoadFail) { @@ -1260,7 +1260,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( if (PROMContent[eeAddr] =3D=3D 0xFF) pwrInfo24G->BW20_Diff[rfPath][TxCount] =3D EEPROM_DEFAULT_24G_HT20_DI= FF; else { - pwrInfo24G->BW20_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr]&0xf0)= >>4; + pwrInfo24G->BW20_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr] & 0xf= 0) >> 4; if (pwrInfo24G->BW20_Diff[rfPath][TxCount] & BIT(3)) /* 4bit sign nu= mber to 8 bit sign number */ pwrInfo24G->BW20_Diff[rfPath][TxCount] |=3D 0xF0; } @@ -1268,7 +1268,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( if (PROMContent[eeAddr] =3D=3D 0xFF) pwrInfo24G->OFDM_Diff[rfPath][TxCount] =3D EEPROM_DEFAULT_24G_OFDM_DI= FF; else { - pwrInfo24G->OFDM_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr]&0x0f); + pwrInfo24G->OFDM_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr] & 0x0= f); if (pwrInfo24G->OFDM_Diff[rfPath][TxCount] & BIT(3)) /* 4bit sign nu= mber to 8 bit sign number */ pwrInfo24G->OFDM_Diff[rfPath][TxCount] |=3D 0xF0; } @@ -1278,7 +1278,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( if (PROMContent[eeAddr] =3D=3D 0xFF) pwrInfo24G->BW40_Diff[rfPath][TxCount] =3D EEPROM_DEFAULT_DIFF; else { - pwrInfo24G->BW40_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr]&0xf0)= >>4; + pwrInfo24G->BW40_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr] & 0xf= 0) >> 4; if (pwrInfo24G->BW40_Diff[rfPath][TxCount] & BIT(3)) /* 4bit sign nu= mber to 8 bit sign number */ pwrInfo24G->BW40_Diff[rfPath][TxCount] |=3D 0xF0; } @@ -1286,7 +1286,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( if (PROMContent[eeAddr] =3D=3D 0xFF) pwrInfo24G->BW20_Diff[rfPath][TxCount] =3D EEPROM_DEFAULT_DIFF; else { - pwrInfo24G->BW20_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr]&0x0f); + pwrInfo24G->BW20_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr] & 0x0= f); if (pwrInfo24G->BW20_Diff[rfPath][TxCount] & BIT(3)) /* 4bit sign nu= mber to 8 bit sign number */ pwrInfo24G->BW20_Diff[rfPath][TxCount] |=3D 0xF0; } @@ -1295,7 +1295,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( if (PROMContent[eeAddr] =3D=3D 0xFF) pwrInfo24G->OFDM_Diff[rfPath][TxCount] =3D EEPROM_DEFAULT_DIFF; else { - pwrInfo24G->OFDM_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr]&0xf0)= >>4; + pwrInfo24G->OFDM_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr] & 0xf= 0) >> 4; if (pwrInfo24G->OFDM_Diff[rfPath][TxCount] & BIT(3)) /* 4bit sign nu= mber to 8 bit sign number */ pwrInfo24G->OFDM_Diff[rfPath][TxCount] |=3D 0xF0; } @@ -1303,7 +1303,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( if (PROMContent[eeAddr] =3D=3D 0xFF) pwrInfo24G->CCK_Diff[rfPath][TxCount] =3D EEPROM_DEFAULT_DIFF; else { - pwrInfo24G->CCK_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr]&0x0f); + pwrInfo24G->CCK_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr] & 0x0f= ); if (pwrInfo24G->CCK_Diff[rfPath][TxCount] & BIT(3)) /* 4bit sign num= ber to 8 bit sign number */ pwrInfo24G->CCK_Diff[rfPath][TxCount] |=3D 0xF0; } @@ -1348,9 +1348,9 @@ void Hal_EfuseParseTxPowerInfo_8723B( =20 /* 2010/10/19 MH Add Regulator recognize for CU. */ if (!AutoLoadFail) { - pHalData->EEPROMRegulatory =3D (PROMContent[EEPROM_RF_BOARD_OPTION_8723B= ]&0x7); /* bit0~2 */ + pHalData->EEPROMRegulatory =3D (PROMContent[EEPROM_RF_BOARD_OPTION_8723B= ] & 0x7); /* bit0~2 */ if (PROMContent[EEPROM_RF_BOARD_OPTION_8723B] =3D=3D 0xFF) - pHalData->EEPROMRegulatory =3D (EEPROM_DEFAULT_BOARD_OPTION&0x7); /* bi= t0~2 */ + pHalData->EEPROMRegulatory =3D (EEPROM_DEFAULT_BOARD_OPTION & 0x7); /* = bit0~2 */ } else pHalData->EEPROMRegulatory =3D 0; } @@ -2057,7 +2057,7 @@ static void hw_var_set_correct_tsf(struct adapter *pa= dapter, u8 variable, u8 *va rtw_write8(padapter, REG_BCN_CTRL, val8); =20 rtw_write32(padapter, REG_TSFTR, tsf); - rtw_write32(padapter, REG_TSFTR+4, tsf>>32); + rtw_write32(padapter, REG_TSFTR + 4, tsf >> 32); =20 /* enable related TSF function */ val8 =3D rtw_read8(padapter, REG_BCN_CTRL); @@ -2373,7 +2373,7 @@ void SetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) =20 /* Set RRSR rate table. */ rtw_write16(padapter, REG_RRSR, BrateCfg); - rtw_write8(padapter, REG_RRSR+2, rtw_read8(padapter, REG_RRSR+2)&0xf0); + rtw_write8(padapter, REG_RRSR + 2, rtw_read8(padapter, REG_RRSR + 2) & 0= xf0); } break; =20 @@ -2455,10 +2455,10 @@ void SetHwReg8723B(struct adapter *padapter, u8 var= iable, u8 *val) /* SIFS_Timer =3D 0x0a0a0808; */ /* RESP_SIFS for CCK */ rtw_write8(padapter, REG_RESP_SIFS_CCK, val[0]); /* SIFS_T2T_CCK (0x08)= */ - rtw_write8(padapter, REG_RESP_SIFS_CCK+1, val[1]); /* SIFS_R2T_CCK(0x08)= */ + rtw_write8(padapter, REG_RESP_SIFS_CCK + 1, val[1]); /* SIFS_R2T_CCK(0x0= 8) */ /* RESP_SIFS for OFDM */ rtw_write8(padapter, REG_RESP_SIFS_OFDM, val[2]); /* SIFS_T2T_OFDM (0x0a= ) */ - rtw_write8(padapter, REG_RESP_SIFS_OFDM+1, val[3]); /* SIFS_R2T_OFDM(0x0= a) */ + rtw_write8(padapter, REG_RESP_SIFS_OFDM + 1, val[3]); /* SIFS_R2T_OFDM(0= x0a) */ break; =20 case HW_VAR_ACK_PREAMBLE: @@ -2470,7 +2470,7 @@ void SetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) /* regTmp =3D (pHalData->nCur40MhzPrimeSC)<<5; */ if (bShortPreamble) regTmp |=3D 0x80; - rtw_write8(padapter, REG_RRSR+2, regTmp); + rtw_write8(padapter, REG_RRSR + 2, regTmp); } break; =20 @@ -2693,19 +2693,19 @@ void SetHwReg8723B(struct adapter *padapter, u8 var= iable, u8 *val) break; case HW_VAR_BCN_VALID: { - /* BCN_VALID, BIT16 of REG_TDECTRL =3D BIT0 of REG_TDECTRL+2, write 1 = to clear, Clear by sw */ - val8 =3D rtw_read8(padapter, REG_TDECTRL+2); + /* BCN_VALID, BIT16 of REG_TDECTRL =3D BIT0 of REG_TDECTRL + 2, write = 1 to clear, Clear by sw */ + val8 =3D rtw_read8(padapter, REG_TDECTRL + 2); val8 |=3D BIT(0); - rtw_write8(padapter, REG_TDECTRL+2, val8); + rtw_write8(padapter, REG_TDECTRL + 2, val8); } break; =20 case HW_VAR_DL_BCN_SEL: { /* SW_BCN_SEL - Port0 */ - val8 =3D rtw_read8(padapter, REG_DWBCN1_CTRL_8723B+2); + val8 =3D rtw_read8(padapter, REG_DWBCN1_CTRL_8723B + 2); val8 &=3D ~BIT(4); - rtw_write8(padapter, REG_DWBCN1_CTRL_8723B+2, val8); + rtw_write8(padapter, REG_DWBCN1_CTRL_8723B + 2, val8); } break; =20 @@ -2769,8 +2769,8 @@ void GetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) =20 case HW_VAR_BCN_VALID: { - /* BCN_VALID, BIT16 of REG_TDECTRL =3D BIT0 of REG_TDECTRL+2 */ - val8 =3D rtw_read8(padapter, REG_TDECTRL+2); + /* BCN_VALID, BIT16 of REG_TDECTRL =3D BIT0 of REG_TDECTRL + 2 */ + val8 =3D rtw_read8(padapter, REG_TDECTRL + 2); *val =3D (BIT(0) & val8) ? true : false; } break; --=20 2.34.1