From nobody Mon May 25 03:46:53 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 986C23FDBFC for ; Tue, 19 May 2026 09:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779183497; cv=none; b=QqIIam795cV59JOQhdxyd0jDkwymXuGECzpUQ7hTpPo74XkchGhlv3ZcFMQ1Zp4ZCnfDs+gfVZfeQ6WvHAjeHuwulYJqi2rlkFLFwnMZSzdCCdF5/EvdsIWDOpNT3nn+e2qcds+Hq72z/YoeM2jc3pGoFddsvw1RReQLw2SV/5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779183497; c=relaxed/simple; bh=qRRQXp0U6iWJ6fRxiYMVSIZ4g1MrQM/QNV99ICd0FUA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=q1ulKg2LkjjJ0u9gY8tzWHUyZdkyemCiNlVzAUdjr81W29yaaot3eiTFyiSR7ZVq5sZmBT9tb5/ofwsovkuYGoh61egIu5h6978KIY813TiXMtv0UmPEMsdzJe4oyU0+8mklMg2Cx89NpqKylym8EUlZSoGif/zHaIbaWpW48LY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=D4r0zBgM; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="D4r0zBgM" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488a9033b2cso26543185e9.2 for ; Tue, 19 May 2026 02:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779183494; x=1779788294; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5w9ev5uT8jYgS/YrJtWGQ7Pmlpe8iBTub42CMDhT6CY=; b=D4r0zBgMuLFKXy8Mu/Es4evv9VmvRmI0E9QESf/O82D5zu2pRmI0biElkBM/Ovp3Nw jcWB3igfB21YVOVz3+AdNSEURF51NomMc09m+BRFYk7f3Wpq7WPGB4bqg0K4OYBJMTHK 8K+GWEgE1FQb+N42z+Dpwn39aXSi0ot7SvkQ4lrxe5IalCPtswwbSEprF7t92GLNpS40 OOlCZMJ8rijpl2FkoglA+DbXUpHpLPmff6D0CYCyoTGOU8M83OL+l8vOAGISdMb06pmI 7jvtGTJZBKhwR+iiSxRXOZSM3F1pzIlzFVs70nPd4ikGIVKdvwZGY1qJIB8NFqxEAJAY sVMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779183494; x=1779788294; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5w9ev5uT8jYgS/YrJtWGQ7Pmlpe8iBTub42CMDhT6CY=; b=WmDbusZ7ODqHHgLsdUoxJW9OG3Vh8rPLcjZOO+asKlo9XPT3xB5IOyyCOHSTyLpALC 5AkiJVB2rbeyDvXF3zTqxFlaq4OREZMgmE2FI8uFbaUQBbXjZScaFXm08euX8SKVBBi3 eaVI3OCjWLS3IpGPaWoSwvtcUr1zHneeYtRe8XshDOUJwJilPYPuOvzwWEK9i6la7bnQ /Y53z80gKJjzuNmfwe5WyPXTjf9bJSR/AJJkiH6q5uyEmVso9oVC2sGFZqVeRtWItW9F xPz9tQ34j0Wx/3bEdsSAyNTW/PzkAgN8/PGGoB/8LbD+U1Cf78kLQEU6ZGmZyOW6dEeT 69Xg== X-Forwarded-Encrypted: i=1; AFNElJ/DTmzbT6JuEFE97u59OcN9XYvryiWoRrcsY4WExn5MVrK5eAXPSBRbJNB/abpnX7G6s8hVmTEMql56FH4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyaxw2IDB0WxG4SA1jLuJec+o39TYMS00IOqVoLCK6A+WbN8Q0k vDVwt7i4p2B/yKwA1NeV0jGm/jOKOPwSGT164xZG8DsdCiAgP8J5GI6bdxWlWCNISbY= X-Gm-Gg: Acq92OE3sZdLYI3SbQxM4EV6pdt7zqTdYqsY9Tu+6vVU9ucLdOESOi1GfoHghMJu8k/ n+pthzgzuQl9AiEdX9C24vTkLNFF+bz7w1A3rP23eXUsVj2qOODxfHAKN0dhyfAhnP+R33nnRGP BFNV9yBbYk8yamysuNmRIOETRQVnf+UVT8MakdazfUQZ4V0gX7QfaYATQa0ah06HvHxfGZ/2ITd vGczNbFGnCYpX0pDibAML2hgOBgq8xeXuYQbX1KQpSRwyE7Qd9uv6tF/htEj2uSicEgMRdEbrOK +NO4bbQO297JcXo+oe9vAEmFX+WXQocHLzNngVY7P5k8Hg+HHFwDzolpbqKG9lxV/WXKQVy5uBf c9yWHxhtIBFiXLuEeqEv8i1AgNULhSQ8Gfxm/0ZEVo3vp8tPmjF/DrPuqmqFqeZmMcsTDwskM+O oAMgi5o0vEJDPYoKQFapQFsH6lJZCHaDsAQnOqc72+aKFpkV5pWL8V3vx5g1A44zijwqX8v4aYq Qsz08WLz8hu6SExm3Q1kTHhLQ== X-Received: by 2002:a05:600c:34d4:b0:48f:e245:394e with SMTP id 5b1f17b1804b1-48fe631f631mr304965415e9.27.1779183493958; Tue, 19 May 2026 02:38:13 -0700 (PDT) Received: from localhost (p200300f65f47db0428dec7b135f55767.dip0.t-ipconnect.de. [2003:f6:5f47:db04:28de:c7b1:35f5:5767]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48febe794e7sm101611265e9.30.2026.05.19.02.38.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 02:38:13 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Bartosz Golaszewski Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] eeprom: at24: Use named initializers for arrays of i2c_device_data Date: Tue, 19 May 2026 11:38:05 +0200 Message-ID: <20260519093806.1567914-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=5487; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=qRRQXp0U6iWJ6fRxiYMVSIZ4g1MrQM/QNV99ICd0FUA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqDC9+ilqg6HFqf2Af1WyMWKAaYdX5nvQmuxdEY hqtqK4lU9qJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCagwvfgAKCRCPgPtYfRL+ TrMOB/0e8DkeZNN+c3X8MebNVJdfcA0IMlTqGfpzOlY+Pl0HC619Mw4MvSHk3QY7u0Eh1vPlp5x ex3rx0FEqpJXekYbA9HR4Ue/BDCuVr9TQXRYKRbjGD0/VUho8P4qDLXDXj6BbqdFlB1fb/eZu7b kmZHo5VbR6HWU7758dxM2iGEzl/bZvyAnqe7kyENvuUgwJvmktA7nOU7MtmGWmT579ApMAuLy97 FZEMa8yJWSMogz0ADXUNhk4GWOnN8WMn3rFn9sf6w501Zb9SVfMhVRTBtRWkVKUHyS7gxgjnqGR D5X4WWQouEH/ai1wD5B3h1quiHak3WEHrC4sPt6GIfk74JZ3 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable While being less compact, using named initializers allows to more easily see which members of the structs are assigned which value without having to lookup the declaration of the struct. And it's also more robust against changes to the struct definition. The mentioned robustness is relevant for a planned change to struct i2c_device_id that replaces .driver_data by an anonymous union. This patch doesn't modify the compiled array, only its representation in source form benefits. The former was confirmed with x86 and arm64 builds. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- Hello, this patch was split from https://lore.kernel.org/linux-kernel/20260515162734.469327-2-u.kleine-koeni= g@baylibre.com on Bartosz's request. I'm not sure if still more should be split out, so I'm not resending the remaining patch yet. Best regards Uwe drivers/misc/eeprom/at24.c | 62 +++++++++++++++++++------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 0200288d3a7a..5d5f357a1996 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -215,37 +215,37 @@ AT24_CHIP_DATA(at24_data_24c2048, 2097152 / 8, AT24_F= LAG_ADDR16); AT24_CHIP_DATA(at24_data_INT3499, 8192 / 8, 0); =20 static const struct i2c_device_id at24_ids[] =3D { - { "24c00", (kernel_ulong_t)&at24_data_24c00 }, - { "24c01", (kernel_ulong_t)&at24_data_24c01 }, - { "24cs01", (kernel_ulong_t)&at24_data_24cs01 }, - { "24c02", (kernel_ulong_t)&at24_data_24c02 }, - { "24cs02", (kernel_ulong_t)&at24_data_24cs02 }, - { "24mac402", (kernel_ulong_t)&at24_data_24mac402 }, - { "24mac602", (kernel_ulong_t)&at24_data_24mac602 }, - { "24aa025e48", (kernel_ulong_t)&at24_data_24aa025e48 }, - { "24aa025e64", (kernel_ulong_t)&at24_data_24aa025e64 }, - { "spd", (kernel_ulong_t)&at24_data_spd }, - { "24c02-vaio", (kernel_ulong_t)&at24_data_24c02_vaio }, - { "24c04", (kernel_ulong_t)&at24_data_24c04 }, - { "24cs04", (kernel_ulong_t)&at24_data_24cs04 }, - { "24c08", (kernel_ulong_t)&at24_data_24c08 }, - { "24cs08", (kernel_ulong_t)&at24_data_24cs08 }, - { "24c16", (kernel_ulong_t)&at24_data_24c16 }, - { "24cs16", (kernel_ulong_t)&at24_data_24cs16 }, - { "24c32", (kernel_ulong_t)&at24_data_24c32 }, - { "24c32d-wl", (kernel_ulong_t)&at24_data_24c32d_wlp }, - { "24cs32", (kernel_ulong_t)&at24_data_24cs32 }, - { "24c64", (kernel_ulong_t)&at24_data_24c64 }, - { "24c64-wl", (kernel_ulong_t)&at24_data_24c64d_wlp }, - { "24cs64", (kernel_ulong_t)&at24_data_24cs64 }, - { "24c128", (kernel_ulong_t)&at24_data_24c128 }, - { "24c256", (kernel_ulong_t)&at24_data_24c256 }, - { "24256e-wl", (kernel_ulong_t)&at24_data_24256e_wlp }, - { "24c512", (kernel_ulong_t)&at24_data_24c512 }, - { "24c1024", (kernel_ulong_t)&at24_data_24c1024 }, - { "24c1025", (kernel_ulong_t)&at24_data_24c1025 }, - { "24c2048", (kernel_ulong_t)&at24_data_24c2048 }, - { "at24", 0 }, + { .name =3D "24c00", .driver_data =3D (kernel_ulong_t)&at24_data_24c00 }, + { .name =3D "24c01", .driver_data =3D (kernel_ulong_t)&at24_data_24c01 }, + { .name =3D "24cs01", .driver_data =3D (kernel_ulong_t)&at24_data_24cs01 = }, + { .name =3D "24c02", .driver_data =3D (kernel_ulong_t)&at24_data_24c02 }, + { .name =3D "24cs02", .driver_data =3D (kernel_ulong_t)&at24_data_24cs02 = }, + { .name =3D "24mac402", .driver_data =3D (kernel_ulong_t)&at24_data_24mac= 402 }, + { .name =3D "24mac602", .driver_data =3D (kernel_ulong_t)&at24_data_24mac= 602 }, + { .name =3D "24aa025e48", .driver_data =3D (kernel_ulong_t)&at24_data_24a= a025e48 }, + { .name =3D "24aa025e64", .driver_data =3D (kernel_ulong_t)&at24_data_24a= a025e64 }, + { .name =3D "spd", .driver_data =3D (kernel_ulong_t)&at24_data_spd }, + { .name =3D "24c02-vaio", .driver_data =3D (kernel_ulong_t)&at24_data_24c= 02_vaio }, + { .name =3D "24c04", .driver_data =3D (kernel_ulong_t)&at24_data_24c04 }, + { .name =3D "24cs04", .driver_data =3D (kernel_ulong_t)&at24_data_24cs04 = }, + { .name =3D "24c08", .driver_data =3D (kernel_ulong_t)&at24_data_24c08 }, + { .name =3D "24cs08", .driver_data =3D (kernel_ulong_t)&at24_data_24cs08 = }, + { .name =3D "24c16", .driver_data =3D (kernel_ulong_t)&at24_data_24c16 }, + { .name =3D "24cs16", .driver_data =3D (kernel_ulong_t)&at24_data_24cs16 = }, + { .name =3D "24c32", .driver_data =3D (kernel_ulong_t)&at24_data_24c32 }, + { .name =3D "24c32d-wl", .driver_data =3D (kernel_ulong_t)&at24_data_24c3= 2d_wlp }, + { .name =3D "24cs32", .driver_data =3D (kernel_ulong_t)&at24_data_24cs32 = }, + { .name =3D "24c64", .driver_data =3D (kernel_ulong_t)&at24_data_24c64 }, + { .name =3D "24c64-wl", .driver_data =3D (kernel_ulong_t)&at24_data_24c64= d_wlp }, + { .name =3D "24cs64", .driver_data =3D (kernel_ulong_t)&at24_data_24cs64 = }, + { .name =3D "24c128", .driver_data =3D (kernel_ulong_t)&at24_data_24c128 = }, + { .name =3D "24c256", .driver_data =3D (kernel_ulong_t)&at24_data_24c256 = }, + { .name =3D "24256e-wl", .driver_data =3D (kernel_ulong_t)&at24_data_2425= 6e_wlp }, + { .name =3D "24c512", .driver_data =3D (kernel_ulong_t)&at24_data_24c512 = }, + { .name =3D "24c1024", .driver_data =3D (kernel_ulong_t)&at24_data_24c102= 4 }, + { .name =3D "24c1025", .driver_data =3D (kernel_ulong_t)&at24_data_24c102= 5 }, + { .name =3D "24c2048", .driver_data =3D (kernel_ulong_t)&at24_data_24c204= 8 }, + { .name =3D "at24", .driver_data =3D 0 }, { /* END OF LIST */ } }; MODULE_DEVICE_TABLE(i2c, at24_ids); base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 --=20 2.47.3