From nobody Mon May 25 03:08:52 2026 Received: from cvsmtppost102.wmail.worksmobile.com (cvsmtppost102.wmail.worksmobile.com [125.209.209.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8442B477E32 for ; Tue, 19 May 2026 09:02:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=125.209.209.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779181354; cv=none; b=O5pBEVXU4oFDiVOIXf0JNhrwSFP6gPOAd8jYunY0tXmCuDzs1TxUbT4TlHLeThNVqVIJ0Gj29gOqwYOtXf1i4C5iYtBlk9LGm+dOQPZpgvQUPJ5HKdmp/2WUfw3MelJPvf5MEOFQLwCh43ZEQpQsd7NxXGLHhJq2TgSgR7kdkxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779181354; c=relaxed/simple; bh=3J3/AwLUzcB/WAmYB4Pu04ubxpDRmRuvWzYDYU6hi4w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DA179b+kGvXOcU5GNRJFu7oAaoQy/tumCpT4gJxJcawktPoW96TtcuYJFDdVlRWaLhs7H3FFh7ojVvbIg7Gg1pzy5tvPMXv3XxMlAyTnI8Fa7HzARPvLo0fYE0LpwsdJPPKSnnp/9IgVggLfZjwkolvZlVbbSwpBQpMvY0W7piU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=korea.ac.kr; spf=pass smtp.mailfrom=korea.ac.kr; dkim=pass (2048-bit key) header.d=worksmobile.com header.i=@worksmobile.com header.b=pc8gq95E; dkim=pass (1024-bit key) header.d=korea.ac.kr header.i=@korea.ac.kr header.b=Mz4SsVqe; arc=none smtp.client-ip=125.209.209.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=korea.ac.kr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=korea.ac.kr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=worksmobile.com header.i=@worksmobile.com header.b="pc8gq95E"; dkim=pass (1024-bit key) header.d=korea.ac.kr header.i=@korea.ac.kr header.b="Mz4SsVqe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=worksmobile.com; s=s20171120; t=1779180736; bh=3J3/AwLUzcB/WAmYB4Pu04ubxpDRmRuvWzYDYU6hi4w=; h=From:To:Subject:Date:Message-Id:From:Subject:Feedback-ID: X-Works-Security; b=pc8gq95Ei6M/SfaFHM0c1Sclu2nIjeDVDHTG1k/Y6wCzUnFuieCBn2GaqDMuwtDi9 rIDv6tjD+EM9hrHWEYx5LkkfCint3eZ7JdUnE9T4wHJzbRrL6X63+pwUG7FFuYPG5x OKLpZbxB78aBk2TDrRcCyBgNUz+3Bq9Etuxsp1Ds9GwFhNFwiU//B9gaWuvoE13cHv Fouv5pzgGxI3MGptXKxPKs8mouIDfIFnmCZgNWJG8glIa1jZea27S2NGHSkD3eQIVt 2Mva6yOkDFRzucZFfuUMEl0YlAfQKnm+EkhNpjywo9MFg0sxoF6GIuseYIbIQgP/O4 OQ4cxpz6s7o7w== Received: from cvsendbo001.wmail ([10.113.20.163]) by cvsmtppost102.wmail.worksmobile.com with ESMTP id Cp7yEbYJR8SxJVSMSZI5tg for ; Tue, 19 May 2026 08:52:16 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=korea.ac.kr; s=naverworks; t=1779180736; bh=3J3/AwLUzcB/WAmYB4Pu04ubxpDRmRuvWzYDYU6hi4w=; h=From:To:Subject:Date:Message-Id:From:Subject:Feedback-ID: X-Works-Security; b=Mz4SsVqeAC2FlRYWh8KoKesSAjcMuqNldi9mznSvNtKJH6SI68VHfYJoBNnUv8JdT 85LHNq4EZ1Y1uDeWqo1neSy1rYMlhJNOl0gvJLAETCiQkOcN+XAAC33cEGUOskZ5gk rz90XUGaJws/7qYtS2+9qNdp5Ox6hW3iMI++ilhM= X-Session-ID: B92UEe-9TvuyppjR03krVw X-Works-Send-Opt: 3lYwjAIYjHmXFoEXKBmwaAErKqpYjHmm X-Works-Smtp-Source: edKdKxvXFqJZ+HmrKqK/+6E= Received: from s2lab05.. ([163.152.163.130]) by jvnsmtp403.gwmail.worksmobile.com with ESMTP id B92UEe-9TvuyppjR03krVw for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 19 May 2026 08:52:16 -0000 From: Ingyu Jang To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee Cc: Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-wireless@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] wifi: mt76: Drop unneeded mt76_register_debugfs_fops() return checks Date: Tue, 19 May 2026 17:52:14 +0900 Message-Id: <20260519085214.164846-1-ingyujang25@korea.ac.kr> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514193243.2518979-1-ingyujang25@korea.ac.kr> References: <20260514193243.2518979-1-ingyujang25@korea.ac.kr> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mt76_register_debugfs_fops() returns the dentry from debugfs_create_dir(), which yields an error pointer on failure (notably ERR_PTR(-ENODEV) when CONFIG_DEBUG_FS=3Dn), never NULL. Per commit ff9fb72bc077 ("debugfs: return error values, not NULL"), callers do not need to check the return value. Drop the dead !dir checks in mt7615/mt7915/mt7921/mt7925/mt7996 _init_debugfs(). Converting them to IS_ERR() instead would have exposed a probe abort on CONFIG_DEBUG_FS=3Dn, since each *_init_debugfs() caller propagates the helper's return value. This patch supersedes an earlier proposal that converted the checks to IS_ERR(). Link: https://lore.kernel.org/all/20260514193243.2518979-1-ingyujang25@kore= a.ac.kr Signed-off-by: Ingyu Jang --- drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c | 2 -- drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c | 3 +-- drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c | 2 -- drivers/net/wireless/mediatek/mt76/mt7925/debugfs.c | 2 -- drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c | 2 -- 5 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c b/drivers/= net/wireless/mediatek/mt76/mt7615/debugfs.c index 0f7b20152279c..6a1475e3c8999 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c @@ -550,8 +550,6 @@ int mt7615_init_debugfs(struct mt7615_dev *dev) struct dentry *dir; =20 dir =3D mt76_register_debugfs_fops(&dev->mphy, &fops_regval); - if (!dir) - return -ENOMEM; =20 if (is_mt7615(&dev->mt76)) debugfs_create_devm_seqfile(dev->mt76.dev, "xmit-queues", dir, diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/drivers/= net/wireless/mediatek/mt76/mt7915/debugfs.c index 26ed3745af43e..4d0854fe785bd 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c @@ -1296,8 +1296,7 @@ int mt7915_init_debugfs(struct mt7915_phy *phy) struct dentry *dir; =20 dir =3D mt76_register_debugfs_fops(phy->mt76, NULL); - if (!dir) - return -ENOMEM; + debugfs_create_file("muru_debug", 0600, dir, dev, &fops_muru_debug); debugfs_create_file("muru_stats", 0400, dir, phy, &mt7915_muru_stats_fops); diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c b/drivers/= net/wireless/mediatek/mt76/mt7921/debugfs.c index 4333005b3ad95..a5a70d8e8544a 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c @@ -266,8 +266,6 @@ int mt7921_init_debugfs(struct mt792x_dev *dev) struct dentry *dir; =20 dir =3D mt76_register_debugfs_fops(&dev->mphy, &fops_regval); - if (!dir) - return -ENOMEM; =20 if (mt76_is_mmio(&dev->mt76)) debugfs_create_devm_seqfile(dev->mt76.dev, "xmit-queues", diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/debugfs.c b/drivers/= net/wireless/mediatek/mt76/mt7925/debugfs.c index e2498659c884e..d01ff49de47af 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/debugfs.c @@ -291,8 +291,6 @@ int mt7925_init_debugfs(struct mt792x_dev *dev) struct dentry *dir; =20 dir =3D mt76_register_debugfs_fops(&dev->mphy, &fops_regval); - if (!dir) - return -ENOMEM; =20 if (mt76_is_mmio(&dev->mt76)) debugfs_create_devm_seqfile(dev->mt76.dev, "xmit-queues", diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c b/drivers/= net/wireless/mediatek/mt76/mt7996/debugfs.c index 76d623b2cafb4..327fc2032c8da 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c @@ -856,8 +856,6 @@ int mt7996_init_debugfs(struct mt7996_dev *dev) struct dentry *dir; =20 dir =3D mt76_register_debugfs_fops(&dev->mphy, NULL); - if (!dir) - return -ENOMEM; =20 debugfs_create_file("hw-queues", 0400, dir, dev, &mt7996_hw_queues_fops); --=20 2.34.1