From nobody Mon May 25 03:55:48 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 308323D9025 for ; Tue, 19 May 2026 08:01:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779177684; cv=none; b=i54czmhQTG5/lmggHOwUduqG46xpcahFiS13nR6oVcU94HQlHXnKRvp4sI5ZtEyoMROOkbzzKFNDfbY37PoQ5YH/B7PYxCRpKhG8n+yTIHFPooAkfG5rZXengHEN8fShUKSb8y6tk7dajXzzx1CFnaLpHxoHejL5iyVxQMWss/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779177684; c=relaxed/simple; bh=BxcXCC7+uSkXqvNZeqJG3t0RH5tHwI3otc7K0Xm9Ze0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KrGiSoSjtdMIF7Cmus7PBGnh6E2YW/taS20HtLdr9q8cw3Bu3HJADRP99YjiqymG5AqyAT2m4yA/8Fl/VmOAxatLBEPFsYu8uBk/558KB4Ng/m0NPkW6xjnI/r3B6MFrZXoEs+siDx7lpUYNTBIu3vus3UcTpsysRRxmS9e0dD4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eNZLxR0Z; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eNZLxR0Z" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-367c26471f5so1956542a91.1 for ; Tue, 19 May 2026 01:01:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779177681; x=1779782481; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=07d/k8eN4Hdpw9AEiZl/+4+x3cCvfjw/+oxM3VP8ero=; b=eNZLxR0ZMAOIuPXMRMF2LkyRqD4DiYg7xLtRngvXu14lVSQp/SX+cnGT+O4wi7z1vS /Xd3emE3biCDkuic4Gi7RYfjaJ1lnMHuuAwrnG4cb6YOaeIsR/jVIW8giAdIRFEWjp86 9EYkOXGTRMbwiCmCtpH7NYAyX+DdDV3l4XwGOGhttAUrUV+iCzX5V540YQ2mVzvJ1+yJ 2R0UfQHoVcT0jF7n4nYM/DuJMUB0mshIYG5C8z7MB2uGd9fAriWeT1OWVPTTv5NtzP8A N23V1cdVkw11kXiMoas2B2UO8vscruGc6xcj1Q+cjeDcMlnq559A9ptk1M1TmxD9NeBI D41A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779177681; x=1779782481; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=07d/k8eN4Hdpw9AEiZl/+4+x3cCvfjw/+oxM3VP8ero=; b=Ur0kiqiblW0WYc3Uy1Vm8ayp8GgsBcHzXMFveDfQ9bI340/oeQaVoGO2oCo+pOwIAb CmqWgfPX2iJZpzRK6VS12zj4irNUe9b5xzI+1iyMEvbfXGfgQ2sWNUgy5J9aQIquBYmB zEswNK/HILYVAcID27XEgEt8w+XUBxocHWvq9vp3V4hSYnO/ORLi3PCzo6u/X4Fwor1e orqzyVOPVLCaffYb6RheVLY0TNYiiRBhTjRa91svJaf2HJSdruvGyXg5AnjUq5b7ztmV q1fxW4qvyAtIMNSqCxkChxzgZ/dCy75aRlhsok309p1cUzzwUhNq5JaB2+OmH2ZpokJp /t5A== X-Forwarded-Encrypted: i=1; AFNElJ80vglloCqVR0oj++SN3kNl1E7ufe7o4ERyJ+/7ggjTUS8MabXEGi8igCh2/LFlTu1kbfgb+kWn9V2ZB0E=@vger.kernel.org X-Gm-Message-State: AOJu0YxBKmrNcfMB6fO983dyRG6Kz/jfc68jqfw9DOiX9/3p8RuAmqUO qbUeRU9VD3J4kg1CC7Z6jm3toH+5v1ERmtAiIUZf++YtR3ZObXqF97rz X-Gm-Gg: Acq92OG2OqoxXG8NnJHh9uuJuYxO6F2q6ndu+IpQZYfmXx9tMiKrITNSYX9C/D+iCCt qoSM4yXrFJS4MdW/i9Bk6/jsNvrVSU8WWTDZgFvHAEsaUHC/DHsX4695jXED5eIDYSo794vMnsK 5dfP0qoVnp0raGsUI+fXyuic0UepJLmei/xxTbVLEXPqWC95jRi+gtJwVbN8CWBvT5WExsWTNCg RpdapRMeXvIAXOVMOmg0wNdjkOnU7cML8yNyPDl/pn52Vs06KwR/Y2IMhcj24t4AVKdEnyvOHnF M5ApN/bG83aRmhRDJJTyQtHds8NbFveCPMCkv7wcw3qnjb07OJ0oGiI0UgAORT/ShuuAFsJ+cgd daZ/+S9UnW94/aOqb94MTSwNlmE/44vqzBsP92DUMkyJJFyAKddPMME5+vzHufuXJwFhdMcaX2e hO56qYCw== X-Received: by 2002:a17:90a:2ce6:b0:369:b957:1d8a with SMTP id 98e67ed59e1d1-369b9571fb4mr4786555a91.24.1779177681543; Tue, 19 May 2026 01:01:21 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-369c5f0eb2bsm5612001a91.7.2026.05.19.01.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 01:01:20 -0700 (PDT) From: Guangshuo Li To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kyungmin Park , Andrzej Hajda , Thierry Reding , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] drm/mipi-dsi: Fix reference count leak in mipi_dsi_device_register_full Date: Tue, 19 May 2026 15:59:05 +0800 Message-ID: <20260519075905.1038684-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mipi_dsi_device_alloc() initializes the embedded device. If mipi_dsi_device_add() fails, put_device() should be called to properly drop the device reference and release the memory associated with the object. The current error path directly frees the mipi_dsi_device with kfree(), bypassing the device release callback. This issue was found by a static analysis tool I am developing. Fixes: 068a00233969 ("drm: Add MIPI DSI bus support") Signed-off-by: Guangshuo Li --- drivers/gpu/drm/drm_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index 0390e14d3157..862d56eaf934 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -233,7 +233,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *hos= t, ret =3D mipi_dsi_device_add(dsi); if (ret) { dev_err(host->dev, "failed to add DSI device %d\n", ret); - kfree(dsi); + put_device(&dsi->dev); return ERR_PTR(ret); } =20 --=20 2.43.0