From nobody Mon May 25 03:57:34 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D90323DA7C2 for ; Tue, 19 May 2026 07:43:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779176586; cv=none; b=k6weKLun2vEfT9hmNZWDN1WoBCi556roHWHsHU8mNJrw8uo4FYh4d/Kli1AnQdG9WL9BjdVA2ptE8zEi3KaSu3iBWKRT5GDnrZps6fIwMN2PpfdKVF5rd815sykyF6sAHVI4KdQapxp+AALdnqszyDtnaaQJHpPyIp5DRN8fDrk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779176586; c=relaxed/simple; bh=PqBOXKIcL2LFH254HZC8CVkLl+stNhZQ5ZbAKeES868=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Rm9RRB62k7cm4nVYuRJU51cYFC/UmWyM1Baly7uhyNrse4e/lsCYR04yDEnVYEEjPzpzs0KxftTx1QYV2hUhaNhzHoExM1uuU7SEhOsd8gQ7RqNnGQwJSc/t8zp7fhudwzJpGomQemdBiW5z9Z80ZV1ddicgDWegctkmC+1/1t8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=fcibrqSu; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="fcibrqSu" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-836ebdeb969so1422656b3a.3 for ; Tue, 19 May 2026 00:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1779176582; x=1779781382; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=g/tERIhcgTY407JXDkFbxFgApJOVjg4hy+8W+lvT7Ww=; b=fcibrqSuE6qyEsDuG9FMrvdHztLMUk42O/jagA/vo8hLB09lWyKo6ljvNwpjWK2an9 xKlTUlMlYADUKa6xCE+KFseSaCPvD8pZxO12gPo8lKY9qfKp5/yqdKaVFG2M6LNr+6d4 9KgShMzZy8gcMk/2iDVERHM5MbsYnxnew9wwwt6HqqbSXcKq56ztT3+pjGWUeo1qyfXi RonPNy0l1157I5JgY/5NYAj5v0EjvPHqTwHGgVFNL5zKXU3AxkLzBnweAWgLPaeNCkIR IU1KfRxcHEyU0ZFX8uZauyqxq3OL/NAeHURmmF/aLQAE+ZcW3NBxpsZfJFNhLfUFFyTs Q1Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779176582; x=1779781382; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g/tERIhcgTY407JXDkFbxFgApJOVjg4hy+8W+lvT7Ww=; b=JODsI7cDN/kUGYulsApoqhisB+Ala+ZQ7BZRX8sXQESlhS04WSJSl5QjKRSnnxTMgW HHDa9UlDelKtGi4p2IS1utiOumN2el1dMqWTwnfTwjkFzbTGM/OicQar06tKNme8e+I4 Bv3uV+Dh7/ZDGha3JvZDbhh8w5hgHpfdG4Fi80lwTPoOKmmfvbiXpYtnuF7igvOb0+Jd 7i93FO3BxGF5EJYjlyuKY7w6TXx+dVp/YrvQvIdLFZoCrp/HNlH7GImIyacmtQN+VmTB YvaRRvla8gQvFss1MmtJct27HOBYyyq5fju++OCb/G4vgAuAZGzITN27YF6HCng2YLrO Gf4Q== X-Forwarded-Encrypted: i=1; AFNElJ/2zhmzbymK+VMV5ZoC2oX0ZnwKweKcml11kUtJEnSslMkJC7DiZTdo4bCxWD3i3ZMctOhLEpz1NifCcps=@vger.kernel.org X-Gm-Message-State: AOJu0YwOUG2EGe2hVnc/VC+hfOFMUFyIaFl0heROwLM51OnCLYWXbzD1 HQm45P+VyuIGLWJ4REh6jWbsJAnaUKCQsy8TCwyeJAcrkt+igmD0pfxgktcVS1HdYIs= X-Gm-Gg: Acq92OENL+GOb4qanspdM9D1hWECTVrmL/AdHIVCGeSgIxXdRRVgCG+UwjbUfgRRnqR nUmUHPByO8+XiLo3wOB9Ig1seG6pIonSytfChVrwsjYpOO9tsp0PnMpkDzNfGr9EPwQ9Ps54YlK 33L7tdiSrKrVNaQ44TrFxHvW5X55fnvpFwX4WWun0OA6xDp72pzbvgABb88XyH7GBZ7zixY1iDy 6T0DJ8BXVeNwXl3OnST1TQCiFaF/7TecgMmEXQ7ALFKjxexsv9ILK/qyani2ntWxQa8nZ9bRMv3 eXAikHsc4LihrlDrxYWyydeHeyPyTSXLCFs0ME3mGIjceFRXtCAMLwxknnkXT1G/CcKFtUjs/TL W+qm+iinU/59OerMVSwYNUqLv8GIpijrjHF6i43n6ruZQfUPZwEVsP9tjahhEu0nfCy2XEzBhy1 Jrw6Anq8tn+io8RzOSFogRn85ExXRtyMDYziMzHUeBN8oZgGInACgYQ5pqN5F6QAo2hS4doE0Br VMOPW8tY9gd7ArVeMMQsqX0idv2nnH+ELrrQefUnyWiFldYpAe21tExaw== X-Received: by 2002:a05:6a00:1908:b0:834:df57:9d67 with SMTP id d2e1a72fcca58-83f33cf0bddmr18987872b3a.32.1779176581994; Tue, 19 May 2026 00:43:01 -0700 (PDT) Received: from localhost.localdomain ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-83f19f7cc9asm21029127b3a.53.2026.05.19.00.42.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 00:43:01 -0700 (PDT) From: Abdun Nihaal To: justin.tee@broadcom.com Cc: Abdun Nihaal , paul.ely@broadcom.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jsmart2021@gmail.com, stable@vger.kernel.org Subject: [PATCH] scsi: lpfc: fix potential memory leak in lpfc_read_object() Date: Tue, 19 May 2026 13:12:28 +0530 Message-ID: <20260519074230.110624-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for sge_array inside lpfc_sli4_config() which is attached to mbox, is not freed in one of the error path in lpfc_read_object(). Fix that by calling lpfc_sli4_mbox_cmd_free() instead of directly freeing the mbox. Fixes: 72df8a452883 ("scsi: lpfc: Add support for cm enablement buffer") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/scsi/lpfc/lpfc_sli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index d38fb374b379..fe7d9942ebd2 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -22302,7 +22302,7 @@ lpfc_read_object(struct lpfc_hba *phba, char *rdobj= ect, uint32_t *datap, pcmd->virt =3D lpfc_mbuf_alloc(phba, MEM_PRI, &pcmd->phys); if (!pcmd || !pcmd->virt) { kfree(pcmd); - mempool_free(mbox, phba->mbox_mem_pool); + lpfc_sli4_mbox_cmd_free(phba, mbox); return -ENOMEM; } memset((void *)pcmd->virt, 0, LPFC_BPL_SIZE); --=20 2.43.0