From nobody Mon May 25 03:55:48 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C046352C5B for ; Tue, 19 May 2026 05:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779169660; cv=none; b=bRkr4TOSw3huQkfn7DQNpAjbc/LrAYQBYDV8IQY03eavVZFIVNOC/mkHsi4KzHhtmIBpE4ZWBpfNmrY/kOBnuHWJ3ovysKt+FjUQ/J2h3crudeLJgnGaFzdXzoSnfk700lC0Jd5+i4r0otLO9kP8FDYAvmc12e79i13TMvmdAys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779169660; c=relaxed/simple; bh=MczHRwMv/hLQTMiTEyIurMjTY2+5CIs/9W62uEQNz+o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OneNI40ykmC2wvT+KWUe3YEOeF4VMJT/hr8e1JQKFPmfeeps7YgIye3+Grmb6JDs8Qzn0anUpcyiocc5xp8EwhyT6pH7GMrMUmW93GNClDCw5MwCMoMcsRAsLJct2g7tK7NxsirgN+37oftGpGUSSckDnjR1iDqmXhdu6Ow34Ks= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sndpgUsI; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sndpgUsI" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c8016d642b2so1651261a12.0 for ; Mon, 18 May 2026 22:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779169659; x=1779774459; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=V42qolmFcvj0j5BaiA/mhI5RoSSrJ+Rd9ekJZIwmJwA=; b=sndpgUsImDv5M6SPPGHsHfwX+kNqgTk6sVpVJ33X6/d6SpdyrRIWLNKGSI/XeqjFND 9eCxpmixqVRwA+401O62Vk09nhMusmxFZqk/ZwSYvUjCPESYm7F6TZikU1fzjvcCgXdL rjTU4v2taJmsFZX9I1Z4IdTJiVxPaEa2adfzD2canR62VlhIlsN3qz8go6PnaaeT0ZdL Ps//uUiNKt9GbijTEbe6RtHxryAKCyWNb6br1r8ECIHlwQuSfGDHXQPoJIg3l/QaytMs gtFRceVvHNIzORFbRaK1AqmmnDid8NzJfmHd0NZNQ3LJA6CgrbYJfiscL//TUqxgg5kg Xrqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779169659; x=1779774459; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V42qolmFcvj0j5BaiA/mhI5RoSSrJ+Rd9ekJZIwmJwA=; b=OCCxCjTCTPcV8qPS8CeVunz0MucmjJAMhH9rsYAI+XnxTNKXpJ0faK3HlcCRaRLbWV uysbqFaDGgJ/V0fVYcXSz3f9KBxMiqUtjnO7Zypvxmttan5TzfQdUpo9RnTzEPAID+bN 5rojNVNLrdEqckYUJIlItxp7CqbW3Sta3RkG/WZiG467GrLScsM6Qe6byjkcctmh6tst kIU8n/z6LRBbaLGNqIp8qw+lH2lPMcBOWOxza9+gp6kj9sEOhqbWnNpTlkr/oQjSsxpy PtBh9ArBTqRmvpjrm4M3ZGziFQPc+xIFeE7Fb/eSp1uic+akE2fbWhIp3qUkw+l7V1du 4D4w== X-Forwarded-Encrypted: i=1; AFNElJ9cuWVwKv7houaJ0obPSUgyOC4wCDnP2jq2jg4GQbP5WZwPBQMom0GyGSsN9FA3YG9EKMu+0PQE1rz0bKw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1lr2h339cjUR5o1trjDIhQ8E0eChjlfFzAgysFRmT+TI66wWW 2QhL3WJZaTkE2NGZBHBwoB9Cnm96NPp7YIMrvfg1kMtnCGLsDaVT36hG3vGyDO9oCz0= X-Gm-Gg: Acq92OFX6fAZp0IHZjwFmkIUirpXG2RNy5ddP/qUEdnbZeWLF0WGUDAKLC5Vm9qZ/jg 4sNwOdOAcc+b4AqnqYc7d5o3KmVAGhe2zv9kIe6P+7rd78rJWd0P1DW15/n8poI3wVV9baAmDwo ureWCUvzyKP4Dts9m2WfIMsIr5lBuR8NWt4y9iOAdTcaNzucbqoLNq1oGX7ioz7ev8Ng0p+cLVl 7LNFsAOg7LFrWN5z6PXLaetNmbwd14LOGTFO1YAWC0rnPW5Q3/FccIACnneTlCfnbDbrR30LzS3 vnNPapB7OEOxyEW6Ky047OBPxQrdFuDDji5LEXUPtsR2v1haB0CA3KCSJkHikKShP7P1SdK9xDL 9Jn1muoJhNiHiZ3IogIORkvyjG+dod3ne2ZPxegqN091iWeAS9oRvG9mjbN/F0VIeGvBt2m3wGX 80/On9/Qf+8omD X-Received: by 2002:a17:903:78e:b0:2b0:4f16:22f7 with SMTP id d9443c01a7336-2bd5277b510mr122546635ad.16.1779169658794; Mon, 18 May 2026 22:47:38 -0700 (PDT) Received: from lgs.. ([152.32.188.52]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d23a41fsm170819015ad.83.2026.05.18.22.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 22:47:38 -0700 (PDT) From: Guangshuo Li To: Vlastimil Babka , Harry Yoo , Andrew Morton , Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Pekka Enberg , Tetsuo Handa , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] mm/slub: Fix reference count leak in sysfs_slab_add Date: Tue, 19 May 2026 13:47:20 +0800 Message-ID: <20260519054720.1032616-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" kobject_init_and_add() takes reference even when it fails. If this function returns an error in sysfs_slab_add(), kobject_put() should be called to properly clean up the memory associated with the object. This issue was found by a static analysis tool I am developing. Fixes: 26e4f2057516 ("slub: Fix possible format string bug.") Signed-off-by: Guangshuo Li --- mm/slub.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 2b2d33cc735c..9f0f03460b4d 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -9492,7 +9492,7 @@ static int sysfs_slab_add(struct kmem_cache *s) s->kobj.kset =3D kset; err =3D kobject_init_and_add(&s->kobj, &slab_ktype, NULL, "%s", name); if (err) - goto out; + goto out_put_kobj; =20 err =3D sysfs_create_group(&s->kobj, &slab_attr_group); if (err) @@ -9506,6 +9506,9 @@ static int sysfs_slab_add(struct kmem_cache *s) if (!unmergeable) kfree(name); return err; +out_put_kobj: + kobject_put(&s->kobj); + goto out; out_del_kobj: kobject_del(&s->kobj); goto out; --=20 2.43.0