From nobody Mon May 25 03:32:32 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E97DD33F595 for ; Tue, 19 May 2026 05:40:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779169231; cv=none; b=jtiMPpt3i606V2c0nOLx8GasDBZ9MLhqsFkgKGFApGfhQoTUyT1mabw31jWbthqluz1ZVTDCeKw+2A6riOqFJqz6eXOGjgiZ6jU3ZKBP++pakjx6S2u4PVWTFP5bJCH7pm80qQuPDuHWWhEjxYJFw0ZxZsSwB9olPYcQv09fTrc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779169231; c=relaxed/simple; bh=LGUOcBBjpLtj4Y1JYl5LcWsQBF7rLYN6gfKM8t/7vPs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Hp50dCwoMiOQ5UXfXR+/Q0Bz0D7IrdUTxZzlE6+HmnOABDCRxgRnkyVru1m3hctaWQkpdFFPOPiYGseIMASc7YGUP7SL7zQQ0XiYmkTLhUBeV3qiNm6LCDiGTAE/n4Ot4E0xXzEKiY4pugXwhlmhGZyauNQ491qu7ko1S51pEnE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FGO4BLbt; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FGO4BLbt" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2bdeed4f717so9574015ad.0 for ; Mon, 18 May 2026 22:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779169229; x=1779774029; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kyasRdVNP43J/qdjOUHHjkFB5jEV1GwjVuC9P7OygY4=; b=FGO4BLbtoMoiYMpLi2BosbQe4teyBWmjPLswLe4LXOdS8b1qxfa9Pem5vj8aVH6k4b NpCmuuPstiCfoE1gqiOKKako8rYYozL5UpM7/ZhhlbWaFl+Ae41hNB0lsYZNon7GZRuT K7Uz9+Hee+IxGv20K4trk2Q3djBcl+WjW30ONi8VW/X4ZYCiI7ze0bAI8az1p7L5/cZ1 secmxkZC03ThhzJBHwilZql5G0wfHZPVwcE9tAzpfqhrE0zn+kuBNyOYWqoN/IAUyVb9 xZBxoaYI2kUQO2rYHQ655WanGmuPmMz2wXsdtRPkYiuGbu2yjhDOOMeEUxlyf00ovnoW yY3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779169229; x=1779774029; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kyasRdVNP43J/qdjOUHHjkFB5jEV1GwjVuC9P7OygY4=; b=kjV74hrzP9bXalhzTmL0yTU3bDlJY3XcuNLJm9Lj3OUbKn8ZsbLokyQD6qTSzmcKeR M6BOmcGal6mQhV8TfaX7eRsdmjvyO0FETN3uxVNFi4qLGESj8yFoAfBGf4xO9eCsmUTH PwMfOUmDNV+Etu4gstPv1dAgtEeZAWisfv4yB48tUuxWg/e+7XN+9n5mwLIUf/jr8MIH +/VGyM/o0MpHK79oL1yw4M0i39bdM5Mc7uMngBrUz/tdjlJCupdBs1WVq/XJ46hSUFyt /Vx5WvuNAIaxxrluQv8pudzj6tBy0xxeA+opiFBGg3gXeQm8mE/KCRhiH8zUxmRRsZov /saw== X-Forwarded-Encrypted: i=1; AFNElJ8pf7+uddlc48Xa+C52ot7uSTSa5dlzcD4q6Zu6s0u1wWhlYm20+VxDyxsPUr1CoLxqCTS4enmTou3H80I=@vger.kernel.org X-Gm-Message-State: AOJu0YxF8QVWsylKpBeFLlj59iP6JDXEu0skdoWZdWE66XuxllUHjFlK GAK4ieTH6fXEyToavLVBt2wyrwDJv754Ws/47PWPODtI9Xam5IuFSROxhjri7Q== X-Gm-Gg: Acq92OECXQxNf8sZp6zVUceNDlRDhhP7H+oyruW1abblUkTIcjhUQQlsaesor2YzMoj Ork3yyZptNjQKEmFMLZeipMcJfjC9i+bA2DCiWmZc+UD18etbW3pfztBDDaGA+M7+pc7TPTcmr5 EXAlO3HlBx5tZYEiw4qK82EX0QagfWh72Wi+itydar+dz5SiuV5KS9WlRdQHTCRPmokbWvq3Wpb 2XTJLDZAXcvLAvKEjei9hIjuYpVbXXknMQBzyYakBi0rOHOOTjyU6BJ74kg0GM1COR5YhgoQFgp h25SAlpfyBdmNhwJSmfCcsvvx5kha4rM9xMjWnAHWO7QF0RTL+t6/SNJ7F0osWJKXQsVctOMxQv Bm6Fn+7eab9pR0pXpsVwLh2BeW//fT3ugsiZrhAJpOjWoWyRJe6IC+zf5bfuts1QSKRlArsXu5M qWdY0yvyWq3+QB0+WW0OLzeWimzwVMP4/8BznASQ== X-Received: by 2002:a17:902:f64c:b0:2ba:fed:7891 with SMTP id d9443c01a7336-2bd7e92c24amr206379245ad.30.1779169229167; Mon, 18 May 2026 22:40:29 -0700 (PDT) Received: from soyboi ([2402:8780:1073:dc10:22f6:2ac0:a51b:5d77]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d0fd384sm172858725ad.65.2026.05.18.22.40.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 22:40:28 -0700 (PDT) From: Robertus Diawan Chris To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com Subject: [PATCH] ASoC: soc-utils: Add missing va_end in snd_soc_ret() Date: Tue, 19 May 2026 12:40:24 +0700 Message-ID: <20260519054024.274741-1-robertusdchris@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The default case in snd_soc_ret() use va_start without va_end to cleanup "args" object which can cause undefined behavior. So, add missing va_end to cleanup "args" object. This is reported by Coverity Scan as "Missing varargs init or cleanup". Fixes: 943116ba2a6a ("ASoC: add common snd_soc_ret() and use it") Signed-off-by: Robertus Diawan Chris --- I am still not sure how to test this change. Thank you. sound/soc/soc-utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/soc-utils.c b/sound/soc/soc-utils.c index c8adfff826bd..9cb7567e263e 100644 --- a/sound/soc/soc-utils.c +++ b/sound/soc/soc-utils.c @@ -36,6 +36,7 @@ int snd_soc_ret(const struct device *dev, int ret, const = char *fmt, ...) vaf.va =3D &args; =20 dev_err(dev, "ASoC error (%d): %pV", ret, &vaf); + va_end(args); } =20 return ret; base-commit: 5200f5f493f79f14bbdc349e402a40dfb32f23c8 --=20 2.54.0