From nobody Mon May 25 07:45:46 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CA8E34F479 for ; Tue, 19 May 2026 05:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779169837; cv=none; b=ZQNrQFOCZ2Yf5L4RKT4XQTbZX7BSpuW+xGoB9na1NBSDIp/z4VJkfzfkMchL6AeoY/1eRlx9gLynCRMxCyUkoxg3shXQHJkyAu8zToGWztbNup0Ea3RkDRM7zAGZQH0IaTijeNyLO7UXL9MKQs2t0lez6zg7fZ9RnUkSoBrqgH8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779169837; c=relaxed/simple; bh=fdE73B+2YhgOK4WP6xc0MqGEBiTChQklgG2pvC74mI8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=byzI8xOu3/a4wKSWYM8uTEMB4hmf1MGlKCMk50dTytrXnSfEFNV6P5uPxopTRJnLUIp5yPZZCDcfZnIxE2IqFXDPihl2/1SALw/OfvB+t2IJerta9KiIeAbbbKe+9VyxdMpSdCXHbxSqqqybL5e7VXvsY6LNccPaevWl/KXfUBU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=SFLUP3ym; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="SFLUP3ym" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-834f1075805so2406416b3a.2 for ; Mon, 18 May 2026 22:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1779169834; x=1779774634; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LBYQ1uikIhLCyfxlPUgX6NngwrO0Hp4sxqZIGIzdtpc=; b=SFLUP3ym1FDV/2beeP/zTppJlp7/OFcF4kpjJbG+n9jNi3KbBwhxjTgyD3hUtTEYWv 4zLl+KZoy9pt/lLl2Qlb1qvPWJC6WQw+iQhC0LeDY/XubZWDmMDO2v6WF880qOo8QBlY rfR1KkuCb8ZQVUXW2HZv5B2ENQ/4by4h6bKllr7+OjLWet3N/T6Fj8ZoGaCHq5Ddu294 AqnL0wkjJGWUw6kpIf72NvzmYz1VFDfkRilqx14ruv9zW/py0YQAyY7jZknjJXKtQEpA wTKmY2kB5+7KPtjYLCcVSLdGkeUUxNQ5LLNRAz+bmiYwBWXcW03ithsYuEhJpRgnJSpK ToVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779169834; x=1779774634; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LBYQ1uikIhLCyfxlPUgX6NngwrO0Hp4sxqZIGIzdtpc=; b=oVtgeujeaeUhX2aEgOtMVfhMB0GB4JSUMZPD3zleS3/jifAXVqfnorw0WaInciBcmj 0g3Uc/O1dzz/S51zqyaKq7xXQAzyRjXwGCGEvAWMYS0GJBCyUlD7jS09HJBfyNtWuwvp H2m26agq17aSJNFXW/XjgJEJLxcxZZ1LzUcQXMnfBLSrh/ZIt6m3RPDOD7jqEUlKQw9H NiTGJJ9eD30NlrdyB55OMNEmLFcZqlLuevIPWA49sIJ6Ijp+Q11ujrGLEnhTa+EUh0x/ SKR62cee2eKEJ7Qw275mRwySNJQcc0uSH1lbTLWNnO2LSq6EiDzB9IGHtP4t3ebTdUkg cE3w== X-Forwarded-Encrypted: i=1; AFNElJ8p4QQsU0fXw5NY5IXnkXuHoKGIfmzCJw8TU76VLrQwjkt4iD2mr0roOuRj/AhVtto1tVxA5dFJaEeTatg=@vger.kernel.org X-Gm-Message-State: AOJu0YzwmLAxj0kl+lwUxtq7GhMxKsTZ1Kk/jAvte2cfxDT1/uUTfmAi 0Nj+HuZb4yfpN9f1GkXOORA4B6RboOtJzyM9dOoiFCCbUJSFoZb/krSkayRx+fV1PR0= X-Gm-Gg: Acq92OFx0Ilq7Yln5T0N4pDoBcUkXDNtHwkpgMdQVMdqftwZEOQ2YErPcBQAT13lj8v t8KDrCTbEn9srGU0E/B8UvPQ5EcFwIu1qB59BiTS7Pt7/Vwrw/zv6MFhxX3xWdHIczFLFfjNuXK jQ9C3d1qQ5bPKhXYpoXe6CMyZqYR9m4K6+N096HxY6SYDq4orSLib3pgZakRY6ohLxx0wtNhs7m 9wW1W7mlajahSYuooGVTTsFDFjgh67VFW9dUdD2eJC2bwc8b+M9eQfV78GSl+i6Olf7olZrVHEo MvGQyCKHRsb1UWt84nO+QBPOhL/PpQ8z9ijeF2Fsqvfh/NFKm1s9w8oU4BFlkyL9XuuRoHxejfO NzAG57EHRc7bYJNzSK2OOlqzdbCuvoggNjOHs1XeaD+Cilr1dK3UThy/kVeCnqHBvux1jQj2Q7P JynnuUTN3eFzeK+ilYTxi0aFSYpksU05njyfw3TlksDlxOLecqhRZkp8+kswBQi2GqLVbLQrlyp 8YTxCaeVaJ9SmGOT2gTjZga1oCnOIV+nYb1T88twROypFT59LTDMcQ= X-Received: by 2002:a05:6a00:8088:b0:82f:6858:3f6 with SMTP id d2e1a72fcca58-83f33a2f288mr18205430b3a.0.1779169833930; Mon, 18 May 2026 22:50:33 -0700 (PDT) Received: from [127.0.1.1] ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-83f19664a59sm16818807b3a.1.2026.05.18.22.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 22:50:33 -0700 (PDT) From: Abdun Nihaal Date: Tue, 19 May 2026 11:20:12 +0530 Subject: [PATCH 1/2] nvdimm/btt: fix potential memory leak in discover_arenas() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260519-nvdimmleaks-v1-1-592300fb7a43@cse.iitm.ac.in> References: <20260519-nvdimmleaks-v1-0-592300fb7a43@cse.iitm.ac.in> In-Reply-To: <20260519-nvdimmleaks-v1-0-592300fb7a43@cse.iitm.ac.in> To: Vishal Verma , Dan Williams , Dave Jiang , Ira Weiny Cc: nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abdun Nihaal X-Mailer: b4 0.13.0 Memory allocated in btt_freelist_init(), btt_rtt_init() and btt_maplocks_init() which are called in discover_arenas() is not freed in some error paths. Fix that by adding kfree() calls to error path. Fixes: 5212e11fde4d ("nd_btt: atomic sector updates") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- drivers/nvdimm/btt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c index fdcb080a4314..e0b6a85a8124 100644 --- a/drivers/nvdimm/btt.c +++ b/drivers/nvdimm/btt.c @@ -919,6 +919,9 @@ static int discover_arenas(struct btt *btt) return ret; =20 out: + kfree(arena->freelist); + kfree(arena->rtt); + kfree(arena->map_locks); kfree(arena); free_arenas(btt); return ret; --=20 2.43.0 From nobody Mon May 25 07:45:46 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9275F34DCD6 for ; Tue, 19 May 2026 05:50:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779169839; cv=none; b=ksXfLU0vejvchrsjM24Q2P7MH+QPcihfhSfuWIT/vZ1GlY1QLs1parSawxsRU52bbKP28WOtYMtbE4SHa8vfH8BYq7JdoiUoMX4igq4Iz7k5M7ZqBvL5k8sw6NbzLsmHJw/JHi3qXFK/VEGo4QsjtuA4r4/DfDJRuoEPCw6UZho= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779169839; c=relaxed/simple; bh=XXynUxQ3LuE8fy+pLQmYNaeVurrreAUhZ7Sxgxz5Isc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pjkSMAVu+YSfyBx4JlOQv0tHIrvH89as6hCT/5smQYkra+cgBRjsMZrpJqqQafPhRNY8YpxPUX79GfHZ7qKSHtTIjZvHD0j7Hbmfql3IJvNvrsqIWd302KwOLZ8K0c0bY+syRqCOs8WxYP3TgWlOJFRTrQra3IJdM+0jxhEEajs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=oTsZCmG2; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="oTsZCmG2" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-83ec36a13e9so1354043b3a.0 for ; Mon, 18 May 2026 22:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1779169838; x=1779774638; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ucHECs4zlnHCRoQL7hkpDKkM89fT0NiKrOSG8N2ICv4=; b=oTsZCmG2fnapIvF7tzLJM2hq/Kti0z2SktEe6MYIT4Fa1120tvTOqwG2AFDDfww/+H JIpw/oZC3veHkJXcfTfhSE1+9EawNSxvUna/QBMMMX5b8e1EXqaiwpg5sqK4AboX6ZZF UnUu5yRPn2Wc57QAnvclZj6+HDLFzp5cBGjMVU6NbYwSELnTHSUW3Hu3IinbgvO4CxMA 9DwRroVCsus2rmCdCtnlJb6v+fjlM6G67c3OS4FILa8r+8mcOiGGjWtDiqUZm2wJE6JG oYywmO9oSpGRiVAr8+eC7qyCfYQt50qK35FI9XfyoRS4v9gHRtKHYttPsPS9ERsiZMSC F7iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779169838; x=1779774638; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ucHECs4zlnHCRoQL7hkpDKkM89fT0NiKrOSG8N2ICv4=; b=EOE+dqFe5GK0E0hGENpqFo6bEe3wpTWpWr12920JMtxUppMIqt9BsfVvbZi9ZYZQdZ M0jJpnBVdbmLEzz0cweCpGHDD+6G6Wsvq8SqFPxgx79uLnB8jXLfO9/mJD51C66Wo1Fg aQuFyHT8uzANhvMy5NdfkorhV7OnBXQrKxF0i3UnGix0x9W1Ojl/R9a67/4z+1w8z01x ZeUwWCByCoWPSQEy6Iyk5t/NzwFyng6LxBbL8UNFyEzWrjWFsgB7enYnzoRNWfFZ3gjp CvUZ2Hr4vpOS3l/lBkI4mEn9DoixWRHIiuGiyKrexej44bOqb5WybyDOLeIyCUJ3z44L QTtw== X-Forwarded-Encrypted: i=1; AFNElJ+hig+Bex/TOslPRiTXNuMH/B4oBvpw3CnGv3QvOmcxF7jgSntTvUnI5M2SvwqDK9JshFHePKs/JPZ5hAk=@vger.kernel.org X-Gm-Message-State: AOJu0YxJBcaJs0Gqt7tz2iaAUy85oY2GQqXVaKulQRR3iAK1ka8r501W 3iArz8VcOEz8Ale/D4hWFEQOIeiY9m+9b3ZExjpQ2vbwvr/WQa4t5C74mOTjQv/ZEBw= X-Gm-Gg: Acq92OFAw8dPjmaB3Aw6B47iQ7Xr/enCPUd48J4SeO2lkxw/12h/f+q5Ep5CCqogKJE p22uMEKwepHAq4zryBKCKG/nam+fOPe40R/5BNn9Vz/96/NZS3Mrn2ZVLAhFXW13DpqA7TUkU23 Bl41lOo+HJZaPE1V7jzhjXwJdO6eXPIsR0kEohQ72WfKHoTFFxKQiWdHkSjQLVV2HHFu4wj/B5c fQvoFpfJNwqtoE7UliMgd3LHrQoZUnzeTxIjrIQP72JfhEcET/U409wCImNcfCf8xyL1EQjDdeZ NyCP3pSRNzsvR+XgxsQkOpYW0hieBS8nT4Mh7qZvZkH4ZishNoMIhE6AqlK2hc0KlfJroAtzxrL 757ZmaWTJeNsvX451ncE6X0xseqix1htTOIsa6bZtrtyda0Ix49Kcw70rUVkrcIwUJEbZwM8VXI J2ALGXUbH12Ev0/ZarocaKbxPbdQwxGsiUpGdcY65R9RojnlNmDg0f7eMGwr7pF1R8o/70YTrIl MrJZ2gga06aA34gvM1qcyb+N4mfdDS9sz1YNh+ZWcwB X-Received: by 2002:a05:6a00:429b:b0:82f:d34c:ccc6 with SMTP id d2e1a72fcca58-83f33ab6689mr17997430b3a.10.1779169837802; Mon, 18 May 2026 22:50:37 -0700 (PDT) Received: from [127.0.1.1] ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-83f19664a59sm16818807b3a.1.2026.05.18.22.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 22:50:37 -0700 (PDT) From: Abdun Nihaal Date: Tue, 19 May 2026 11:20:13 +0530 Subject: [PATCH 2/2] nvdimm/btt: fix potential memory leak in btt_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260519-nvdimmleaks-v1-2-592300fb7a43@cse.iitm.ac.in> References: <20260519-nvdimmleaks-v1-0-592300fb7a43@cse.iitm.ac.in> In-Reply-To: <20260519-nvdimmleaks-v1-0-592300fb7a43@cse.iitm.ac.in> To: Vishal Verma , Dan Williams , Dave Jiang , Ira Weiny Cc: nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abdun Nihaal X-Mailer: b4 0.13.0 The memory allocated by discover_arenas() or create_arenas() is not freed in some of the error paths in btt_init(). Fix that by calling free_arenas() on the error paths. Fixes: 5212e11fde4d ("nd_btt: atomic sector updates") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- drivers/nvdimm/btt.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c index e0b6a85a8124..7e1112960d7f 100644 --- a/drivers/nvdimm/btt.c +++ b/drivers/nvdimm/btt.c @@ -1592,7 +1592,7 @@ static struct btt *btt_init(struct nd_btt *nd_btt, un= signed long long rawsize, if (btt->init_state !=3D INIT_READY && nd_region->ro) { dev_warn(dev, "%s is read-only, unable to init btt metadata\n", dev_name(&nd_region->dev)); - return NULL; + goto err; } else if (btt->init_state !=3D INIT_READY) { btt->num_arenas =3D (rawsize / ARENA_MAX_SIZE) + ((rawsize % ARENA_MAX_SIZE) ? 1 : 0); @@ -1602,25 +1602,28 @@ static struct btt *btt_init(struct nd_btt *nd_btt, = unsigned long long rawsize, ret =3D create_arenas(btt); if (ret) { dev_info(dev, "init: create_arenas: %d\n", ret); - return NULL; + goto err; } =20 ret =3D btt_meta_init(btt); if (ret) { dev_err(dev, "init: error in meta_init: %d\n", ret); - return NULL; + goto err; } } =20 ret =3D btt_blk_init(btt); if (ret) { dev_err(dev, "init: error in blk_init: %d\n", ret); - return NULL; + goto err; } =20 btt_debugfs_init(btt); =20 return btt; +err: + free_arenas(btt); + return NULL; } =20 /** --=20 2.43.0