From nobody Mon May 25 04:34:27 2026 Received: from mx4.wp.pl (mx4.wp.pl [212.77.101.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B395739900C for ; Mon, 18 May 2026 21:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.77.101.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779139512; cv=none; b=sgtbbvDy6lydLLaIcgovewvsa5/d1RyFJwhK537j9uXH4dMyI85IcL7wXYTBDq+PSmJyH+5QhmoLrka2aqceSYhGElLEiHWNxvhnpjMDNOk/ZxUBHtY7swerOTLfTxn+MTSySTcJ1u3w0xyHUpBIKN1aRxdCh/wXdo1bHhCEmu0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779139512; c=relaxed/simple; bh=AbvkrBYocTwsgw545YTujBgB19l5nmISKQnQXK9oyIs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KJWLl9iBPPKZt5/FUNsbG1doKjAcq6nIMd/geVphwSToj10fz2TTXSE374lKmRRWvhnT0X0WcdKSAeAXBzNVj6IGFaLsvPrswBsO7iE44ExepTI7Wkeo8A2iFkI3MxKKNKSsFaZ6E6lQHTCRosOyLqdZ2zX+UbM3FSjwLX2cGag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl; spf=pass smtp.mailfrom=wp.pl; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b=FH9Re2T0; arc=none smtp.client-ip=212.77.101.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wp.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b="FH9Re2T0" Received: (wp-smtpd smtp.wp.pl 44396 invoked from network); 18 May 2026 23:25:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=20241105; t=1779139508; bh=qfV6mKkqYHmvXW2NJ0BMnBU3ViOZ1fsAA2f/heqCiZ8=; h=From:To:Cc:Subject; b=FH9Re2T08oyxJgggoCfWUDdPGaG+jmqse11XyXb5hWEKeNSrnHH91hGcb3UWab85C Xr2jP7u+zxwV1q/dEmAgK4zKIfZsh+3N9LwHa2DLOxLca/UxHGHk4+CAGe3sFJHqcL /tyo7Sf7k/VYfzFL3FtRNily7Ndal6cwIQmDlFnWDXX+nJw6GzUoDeoo118NidPKXg WKzhik2/WnzJIa7KSbxH7tymOtAN6gzO69dBuKcQR78x35EQMV0aqDYF1jxm0pYdJs a8sqeqF7pOkdK0rHMXgonwTG1glrRqs/h5bp1MpCd4Ex1pMaui5EUHUF8AW2VGZj17 4XZHy4uR9obZg== Received: from 83.24.127.64.ipv4.supernova.orange.pl (HELO abajkowski.lan) (olek2@wp.pl@[83.24.127.64]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with TLS_AES_256_GCM_SHA384 encrypted SMTP for ; 18 May 2026 23:25:08 +0200 From: Aleksander Jan Bajkowski To: ansuelsmth@gmail.com, atenart@kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Aleksander Jan Bajkowski Subject: [PATCH] crypto: inside-secure/eip93 - Add check for devm_request_threaded_irq Date: Mon, 18 May 2026 23:24:59 +0200 Message-ID: <20260518212506.292170-1-olek2@wp.pl> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-WP-DKIM-Status: good (id: wp.pl) X-WP-MailID: 39f47015a7c0f2b3863711e5b31cc843 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000008 [wfu2] Content-Type: text/plain; charset="utf-8" As the potential failure of the devm_request_threaded_irq(), it should be better to check the return value and return error if fails. Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 cry= pto engine support") Signed-off-by: Aleksander Jan Bajkowski --- drivers/crypto/inside-secure/eip93/eip93-main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/inside-secure/eip93/eip93-main.c b/drivers/cryp= to/inside-secure/eip93/eip93-main.c index 7dccfdeb7b11..276839e1a515 100644 --- a/drivers/crypto/inside-secure/eip93/eip93-main.c +++ b/drivers/crypto/inside-secure/eip93/eip93-main.c @@ -433,6 +433,8 @@ static int eip93_crypto_probe(struct platform_device *p= dev) ret =3D devm_request_threaded_irq(eip93->dev, eip93->irq, eip93_irq_handl= er, NULL, IRQF_ONESHOT, dev_name(eip93->dev), eip93); + if (ret) + return ret; =20 eip93->ring =3D devm_kcalloc(eip93->dev, 1, sizeof(*eip93->ring), GFP_KER= NEL); if (!eip93->ring) --=20 2.53.0