From nobody Mon May 25 04:33:50 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46C0D396D15 for ; Mon, 18 May 2026 21:13:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779138803; cv=none; b=Hbfzf8t5ESB84vwqPAZVO/8kGM3jbl7/UpqEa28YxKqaVnjxBNHg7Wdb7ak+sCXLShNA0a30fuKHJ4r8+F0ZjK5FEE9JO5b3U7YUxidaGVPxId1arIZE8tZPD/iMEGfi1QgV/4D0SjvyBtfY9cFoj2M5Fvv1W0ORIRqvN++Shs4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779138803; c=relaxed/simple; bh=f14EBHDq2i549qJGTfXyZXOwE38/F7SK5VJW+mFje14=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fqEoQrSqoZasLJVix9kizcyUdvSJbfr5wJ5a4B8kaoNEXu6BRCDfBWtRZhO0Kb6YJMHY4OC/0HBR8YbCEo1XusBgVUDB5tYGH0dk8ZWHQ1s+aHEO9WfRb0ukVLdWhX6UAKme8CDOccpc1w3iSpz/WnciIcDsn4xs5LxnAazB+Uk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pHKqMjd5; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pHKqMjd5" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8354461da74so1191580b3a.1 for ; Mon, 18 May 2026 14:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779138802; x=1779743602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5kHLteZtDYYZ0uPDSlKWBJ8+KtD0htFyv3V8YBKOEqE=; b=pHKqMjd5L+gh168dJ6FQpmQL4qGksFKJ3LOSk16jx4l4DZjeWZDviBJA+RGAwU2Mi3 Onn4QtmZo2xeEsk8MQ/6W5nFWfiflmbVqKOPPiPim8F//3aJs/F29fDrcDtpNS0cMTgF 5kNq9miZWcP3J+sUCmgo6KaOArmn2vRlR4x7YobL1rMk4C47yvw3JtIpePN9qhHJfv3z aK8qEjYKIGb6/3uPx7lHxP74WdUqXBB+qy+0pwXmaG6WYB/FrdcnCIL2D4u6NiXL+z4x rkccMJ0uLogWuxrJhs8XDQJ8bsz3ekcSNKEUBtZqsU8t+mnAf2VOkeqGAAKRU43DnhRU FM3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779138802; x=1779743602; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5kHLteZtDYYZ0uPDSlKWBJ8+KtD0htFyv3V8YBKOEqE=; b=Jx37kRbs2Jcoqt3Kq8tVb5j4Gn8qP+Nj6UHZObQ25pgtU/RUJEDtMEWpm7jKyGsTPS DIDuHE5kjy0gIiRWKlI5duOHJKovLpWr/MXTX8isMP+UYEVEkJNzchIkc3YDFsAfRNhr Z9UmFPl2UiZzX/CesW6hgTF8HkZIDN3u/5HgnfSflykM2QVf+VNWsYXjHAy7qllcoG4e qLEdOWmoqzqv6RA2gCM9A11w4TNHTJus1T9WzRdR4WYb8MNk4nfAfmVZBLOZistBDkQS p+QoPSXLcgwyG7vLknlMaqHSAijPpV+5qu06BpJjMqvnZguF51zKRg2LEiInWQXZyiLp Gbbw== X-Forwarded-Encrypted: i=1; AFNElJ/UvzLU8PvAG5mX1IMbpdh8dOZh3Gzdjf2M1yVszFn1d2yq6Z10fdPJcMA6nclkQS/cPhDh/Kv8vM58nTg=@vger.kernel.org X-Gm-Message-State: AOJu0YxHxw8t8Ar6EH4hRUy/WfgRNSnHRQRvni0THDanwk/b7UJEqnCN 1iZr892P41e4fUkIiizk8lNFlifGqEKinS4bcSnW0yJJUM13mcMC3b/O X-Gm-Gg: Acq92OHUhs+fUZnx/HWcpHBUvNw1YHVjJt7deKZOhzOlP+GNhbFqIWhm86a0IE7bSs7 MvkRF85ZLPMHtYxAeGpXtoilXTQLeE+MnZCjn6/SzF8UgzsVv9DDN/Kj9GiJRQOAzmakHhxjXR3 G+1efqUBJ2hjOOI3H2F2EpesPh+uO8bUpPMCfrIM/nJWg9uhxp69sNexbWwbFxpVzNB/uJSt+XO quKzn5repyx6qR/hdSag8i3bUfuKMQyiU5KAdqcicyPGacHHdYMZipdU0/ISL9+lUpE2N1a1Gz3 2Mtsic7ZuYcga1Pc+belBQ635smA8dnqXM/7OwImFePCUeMb/n9Lb6HL2Vy6cmtedz4uJNwpqL7 xvtYYbDlMImPoGGaBOnYK8AH5XD4mEdJn5TJVwDYteKvbwmoMr/NlGUUyax7KZTUUBjk4/MJJk3 Y2DX/TmQMkaNNhVYifXU6xpDGh3dhoHdWN7cj8p3e9ywPSB3ozp19NIZdDUwSzSFo6uyQmv+rx7 e5TMGTEcnVY25Q4LQ5z+7D94NDhP6aZq++AGmSJSqvxSw== X-Received: by 2002:a05:6a00:88e:b0:829:7e6d:cf22 with SMTP id d2e1a72fcca58-83f33dbe4famr15918075b3a.43.1779138801540; Mon, 18 May 2026 14:13:21 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f196638d0sm18775306b3a.7.2026.05.18.14.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 14:13:20 -0700 (PDT) From: Rosen Penev To: linux-fbdev@vger.kernel.org Cc: Sascha Hauer , Pengutronix Kernel Team , Helge Deller , Frank Li , Fabio Estevam , linux-arm-kernel@lists.infradead.org (moderated list:FREESCALE IMX / MXC FRAMEBUFFER DRIVER), dri-devel@lists.freedesktop.org (open list:FRAMEBUFFER LAYER), imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] fbdev: imxfb: Use of_device_get_match_data() Date: Mon, 18 May 2026 14:13:03 -0700 Message-ID: <20260518211303.10777-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use of_device_get_match_data() to fetch the platform ID entry directly instead of open-coding an of_match_device() lookup. No NULL check is needed as every compatible string has a corresponding data section. This also lets the driver drop the of_device.h include. Assisted-by: Codex:GPT-5.5 Signed-off-by: Rosen Penev --- drivers/video/fbdev/imxfb.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index a077bf346bdf..7a021da0a32a 100644 --- a/drivers/video/fbdev/imxfb.c +++ b/drivers/video/fbdev/imxfb.c @@ -30,7 +30,6 @@ #include #include #include -#include #include #include @@ -880,7 +879,6 @@ static int imxfb_probe(struct platform_device *pdev) struct lcd_device *lcd; struct fb_info *info; struct imx_fb_videomode *m; - const struct of_device_id *of_id; struct device_node *display_np; int ret, i; int bytes_per_pixel; @@ -891,9 +889,7 @@ static int imxfb_probe(struct platform_device *pdev) if (ret < 0) return ret; - of_id =3D of_match_device(imxfb_of_dev_id, &pdev->dev); - if (of_id) - pdev->id_entry =3D of_id->data; + pdev->id_entry =3D of_device_get_match_data(&pdev->dev); info =3D framebuffer_alloc(sizeof(struct imxfb_info), &pdev->dev); if (!info) -- 2.54.0