From nobody Mon May 25 04:35:09 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B3039150E for ; Mon, 18 May 2026 20:08:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779134926; cv=none; b=rvH6Q3aByuIH0VssUVINtAVj//icLfHdKZwH0Fqcn4X2t7PkngOl+SkG8+mBGQqWHhpgfx4s7trq52PyYz1ZhzqCc/Fi1CTcpfAW8pgCmjRBwNRYB1LC1oUAP7pAua+w60kvf6BO8M8TOQIgs/chxRs7+upVjkevWcxhWe+8nEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779134926; c=relaxed/simple; bh=FwATgbFAsFr1jepblZdBO9qaPFsv7p+ofKoYrsSikB8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VtgnBdFpgqHbTX1B4eXPQROsuYuP1bvPp5gbapHJ75+2TglmTzaHPoIl+fJZy+lBLiQQc0QwCED/X1e2AqTOlSA/i1iSLx+WBVeoy3Aca4/MknpogASF/CoFoBKhnYePsEscdKVeoyos2JnB5d3mjD3BQifzuJm2+xUhJ2ND9js= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g1HqAsCf; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g1HqAsCf" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-83538fbd0b2so1067496b3a.0 for ; Mon, 18 May 2026 13:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779134925; x=1779739725; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jQ2H6hzbGV+Gx71jCeVXJ0vSIO9SegN96EsFQ4KlCfc=; b=g1HqAsCfJ9g5pudcomVr3T08WS7FqfpiHEOugSRcqOh9Dts0U++2EsCP2j14EAmwEN juYhYm19jwRXHm3GMMs7Cqxe/fPR6T6MKwzYGkBCiybezrfj1UzYN4qczh49cXOB0puw nIE7lS90SonbhDNfB/aTZdXUgIZbEPJFQFzwXwWCQEuIm7Wa1cHDsltOT0eCPcefAnC5 6xTNKdkj1/ReqKI/I5QBsuU6KbRG3Qm74y7s8OPw6mGqdhoN1uIbALZqx2MnNv2aP4w6 82M4IoLl4f4W4XYhBpUZUdXmNGTiOADjP3KJIUAFeiMp05oreihml8jf1IsA8bKM4u6Z xMPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779134925; x=1779739725; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jQ2H6hzbGV+Gx71jCeVXJ0vSIO9SegN96EsFQ4KlCfc=; b=byfmhMi7XzHbzS4bn4kUlkhCD8J58YGU4YeIhqcfPAgJDRqlsJb+cJH4Z5j/vSpFHW hPZyiR0q6+9yAP4Vu4Zz2oug8RsCnR7oWkOHFOwrwpD60dSM5vefFulPWopRor0hPqJ6 hrjQtaBTF2wdEC01IUeW3UpaCmfi26oL6O/CCiMs6I7Q0mU4YJN2TOqlJsM7T9lK6QYS RFehIqZc/piqYBEYFy1stSpDOzpKB0caFwODik4QM9gM+kuCD6X5E6Nq9m17DTURrg9q TkQ8dtbZs390jNQMsK8268j6ptlBRGU8NL3f94bEk6mtP+L0Ue5Dmo2S6b0/4ma52fcs JR8A== X-Forwarded-Encrypted: i=1; AFNElJ88mj0FC+mwPzACmP9ktiVdHGB7Ny+6o6fqEHCU+IDnRpx9vRyYdaQuqGZB49vVrLF2uW0FeEYcngHZli8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5S4zma6F2SZBebhNZGg+ZG4YDfcnJnVEoSf9i90nZvp+23728 Hit1FmqeWXkMNkn96P6jYNqd/1Id5cITekMf2L6DxVbX5P3OM09ojr28 X-Gm-Gg: Acq92OFOSxL4PVc5SJeU0YkGuS49FJprOO0tcRyuJ1Rwo/Vo+jL+7PriJYvKKd5/qBm yRxmD+N/81kGTBcKRjkK/FJy94WXMd25sEn55tLZ0h+z7s85QuewPBPLvouBV90QkAbGrkfIqn7 ZQCElL1vy85e2cyQJuG3zpkE7qn1fjlvdoQwVz57OTxcbLpEgNbTkz07oxbazP1owfANemCpoPM Xnzjqn7n9Mc2rlRpv7fH41mUenS14tqEvUMlmw8MB77ilc3Zta56Qc7FO+ByoAd5Ez0P5vqy3Ib vPCidMkYSmOThr9h21XY8TYmHNPUjaDUeunSmgR+4QMu3s6mjuDLeJtmrahEHpX/vqgR1XFBj54 mKoI7Qtiiu5Rqk/AMuV6mzel3EFAPOfmy1JUxoK0aiPGz7NAAqtXOCDvkCEmRwMC39W+zBwsOt4 1oIeV7zkmKdJvgY93SKfr78PlFv/R7fNmL/mU7WMRX4CbVsWGfELVcpM4AmXOZkg== X-Received: by 2002:a05:6a00:2ea8:b0:83e:e03a:f926 with SMTP id d2e1a72fcca58-83f33bcae20mr16232493b3a.9.1779134924958; Mon, 18 May 2026 13:08:44 -0700 (PDT) Received: from souradipto-das-Latitude-3460.. ([2405:201:8011:1c:1b3:ef9c:231:cc8e]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19661261sm19608369b3a.3.2026.05.18.13.08.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 13:08:44 -0700 (PDT) From: Souradipto Das To: stefan@agner.ch, alison.wang@nxp.com, simona@ffwll.ch Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Souradipto Das Subject: [PATCH] drm/fsl-dcu: Remove redundant unregister call in connector destroy Date: Tue, 19 May 2026 01:37:55 +0530 Message-ID: <20260518200755.5389-1-souradiptodas6@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the explicit call to drm_connector_unregister() inside the fsl_dcu_drm_connector_destroy() callback. During driver unload, the DRM core automatically unregisters all connectors via drm_dev_unregister() -> drm_modeset_unregister_all(). Later, when the connector reference count drops to zero during drm_mode_config_cleanup(), the core calls drm_connector_free(), which invokes the driver's .destroy callback. Calling drm_connector_unregister() inside the destructor is redundant as the userspace sysfs interfaces have already been cleaned up. Signed-off-by: Souradipto Das Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c b/drivers/gpu/drm/fs= l-dcu/fsl_dcu_drm_rgb.c index 84eff7519e32..0d077e507a2d 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c @@ -41,7 +41,6 @@ int fsl_dcu_drm_encoder_create(struct fsl_dcu_drm_device = *fsl_dev, =20 static void fsl_dcu_drm_connector_destroy(struct drm_connector *connector) { - drm_connector_unregister(connector); drm_connector_cleanup(connector); } =20 --=20 2.43.0