From nobody Mon May 25 05:12:56 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A486282F26 for ; Mon, 18 May 2026 14:54:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779116067; cv=none; b=FASQRi7F1VDp40Xy6WWoP/yNtBO2gQXkhldUY9dMW+PKJJqMDtNjc5mDKFkfwFoq4/uc5WvMj339EIlvJWAqbOGZzX0HFSY0aorY0FgaZvcHqdlwmhRODsL0tAKIjscb8wMUvuSWdLAG0etEdFNBsLFXPd1QhSzpUW3nIHXV738= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779116067; c=relaxed/simple; bh=Czv8Tfe2ypNrmX0zrODg0o5K6vEJO7x3cRJLNC1oLno=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rYuPJ35hz1kUuhGNCQejTMOv+owgNADcjXBzrONdydqXO3mUNUWJ1z+/CVkW2yQR5NIHtmtO6mllXYq394JhuDVOIHzQZQ6lGSDUCxGQNVMcs1QIn0kRNQwPY4SpCimAHYsLnpDcj39mYKdrQZr4VTbKSXQHUrum+HdwSQ7AtGc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oH9pdbGd; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oH9pdbGd" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488d2079582so22732365e9.2 for ; Mon, 18 May 2026 07:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779116063; x=1779720863; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pC9TScL6CxIBlhr7Fs+T0Ee2cF3m9ksp0G13aaDD7mA=; b=oH9pdbGdjywz25MCUrFB1Ze7sQc9DtouvLEQdmDEBv8gCpcL1Il53lxU6vRlvZLksv GOmXQz7tMgfQk15rdjyQmgDw3hb4oQPAuY4WXMMqkAKkPLgwuHQG3M9aRZD5m2lpr/Az oO5rAaypIIGFPA+iJ8FFWXCOYkZgj9X8pZNgA9LUQq/fJc5ALEeErb5LB/HVg0FLSurU EPEgj3RFdumsAtMSOGEKG3te2TwhfAJnDTKdD4hSrWls6v/iNpLOgA1BCD2kSCFVdsLr sMAUu1h3k7vsbA67nze95eibcYuNr/pWw9eZ7DZ5ufoBwSb+2bcFzvKWhmhCR6Bf67hN fKpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779116063; x=1779720863; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pC9TScL6CxIBlhr7Fs+T0Ee2cF3m9ksp0G13aaDD7mA=; b=Imhr2IFfapA8yxz3T/zWKUEHz7K6T9hTXPmgO/h1WggHmGig/q2FyRWbTDn1JBdEcq FSRQF2MOiGKndvgzFPgmI/BuGZ69cen5bbFwT5eYgbPYvQTfGRJ0qwsqyneW+xEZk8ei usDbnv3pqR8RlL40+OasdDIG2VVsznCJ0wI7mOBXMabdKqdT8oINCyXZU1YAQqsBEKoI go7hpWpv3jDc3lkCaCsO8BJ9+XdZe2OyFm/vfDsOCkvF88LFmba+a1+cMvFhsdb5OZyg Wmm+oM7kT192FjWLKDHx3MYoPlWFbHEqX/4bbEKMbTdEwRX3Cv0k45qWk3A0Pn4iCR7E 6Ycg== X-Forwarded-Encrypted: i=1; AFNElJ9Si/nd7C4QYLUzKUOgEuMncfPaVT1ltiF8Jm0LWodjF3c/oQQHx2GfqY7zqsqDotHM+3WmGqO7xyTSNzE=@vger.kernel.org X-Gm-Message-State: AOJu0YzHhgCI8G8CsfhARpZzvMJUc4RpBTqSbaxn34iin/LbTxamkxuc MBXzVqVF+ix/sSLGRItr7HzuTXksgUi6TIUNOqXtatV3oxTMJystWwk= X-Gm-Gg: Acq92OHs8oiKH3nL+IKQehTb7j7mOZg28E8Ph32skyO2dIgt6a30WPYKF/UCu/EFaQL TcQUewdExMw4d4xZO6pj1FcWk3T79h1KNbAFfwczmDwiLmVytK6yLDKerI56OVQpxVjwb5c5LVJ 7B66JyZc6aRqh4Bk3rtTpOjTBWL3hiUbyk5Um2Ytq4u2SFTqMPa65VjM4Wo8YGJaMBS3Jt6/ZbZ +8mvHIC+kRwkBZnjQwm7boDvsE+13hxK80UA+ujgeQrLVf4upevwS4kLXeS5mp5lKOzmE3dFm8G HL8fLdbrnDmijnqPJ6xQJOOVNuM16k3qcWSq4FZrs51pU536MC0VbLnBVoCbFFK9+3EoJZTIcPi yaY88NyIf4RqrY8DGXrFCxTvzayxxTTAvdp8ShYQ170kaLW2GfPsZXTTHuycP1aZ575MDgkvl5K k1r7xferiSMou0zQao9XipZtJN94hBMNatIsvDlfWWh3eptx5xzNttbIQ5BFGu2naeBx7BmJ20x ZQSW01mpRM= X-Received: by 2002:a05:600c:821b:b0:488:b811:51c4 with SMTP id 5b1f17b1804b1-48fe6515831mr225383255e9.25.1779116062889; Mon, 18 May 2026 07:54:22 -0700 (PDT) Received: from localhost.localdomain ([151.47.57.9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe53ab671sm261061285e9.1.2026.05.18.07.54.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 18 May 2026 07:54:22 -0700 (PDT) From: Francesco Saverio Pavone To: jonas@kwiboo.se, detlev.casanova@collabora.com, nicolas.dufresne@collabora.com, hverkuil@kernel.org, mchehab@kernel.org Cc: ezequiel@vanguardiasur.com.ar, heiko@sntech.de, stable@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] media: rkvdec: fix PM runtime teardown ordering in remove Date: Mon, 18 May 2026 16:54:14 +0200 Message-ID: <20260518145414.64514-1-pavone.lawyer@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260518105413.42147-1-pavone.lawyer@gmail.com> References: <20260518105413.42147-1-pavone.lawyer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jonas Karlman The current remove() path calls rkvdec_v4l2_cleanup() and pm_runtime_disable() before pm_runtime_dont_use_autosuspend(), and frees the empty IOMMU domain after that. With autosuspend still armed when the domain goes away, the VDPU381 can be left in a dirty state across module reload and suspend/resume cycles. On RK3588 this surfaces as a VP9 inter-prediction bug: from the second ALTREF frame onward, motion blocks decode with U=3DV=3D0 (BT.709 green), while intra and static blocks stay correct. Reordering the teardown to dont_use_autosuspend() -> iommu_domain_free() -> pm_runtime_disable() -> v4l2_cleanup() makes the symptom go away. Tested on a Radxa Rock 5B+ (RK3588, 8 GB LPDDR5) with both the libva-v4l2-request mpv pipeline and Chromium's V4L2 stateless decoder. With the fix, 300 random pixel samples on VP9 Profile 0 clips at 1080p and 1440p match a libvpx software reference exactly (worst delta 0). Without it, the same 1080p sample at frame 4, pixel (960, 270) reads HW=3D(0,112,0) vs SW=3D(204,147,116). HEVC and H.264 stateless decoding via mpv keep running on hardware with no fallback. Fixes: ff8c5622f9f7 ("media: rkvdec: Restore iommu addresses on errors") Cc: Signed-off-by: Jonas Karlman Tested-by: Francesco Saverio Pavone Signed-off-by: Francesco Saverio Pavone Reviewed-by: Nicolas Dufresne Tested-by: Nicolas Dufresne --- Changes in v2: - Add Cc: ; media-CI flagged that the Fixes: target (ff8c5622f9f7) is present in the 6.17, 6.18, 6.19 and 7.0 stable branches, so the fix should reach them too. Link to v1: https://lore.kernel.org/all/20260518105413.42147-1-pavone.la= wyer@gmail.com/ Media-CI report: https://linux-media.pages.freedesktop.org/-/users/patch= work/-/jobs/100124849/artifacts/report.htm drivers/media/platform/rockchip/rkvdec/rkvdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c b/drivers/medi= a/platform/rockchip/rkvdec/rkvdec.c index 6f5f0422d317..bb95b090a25b 100644 --- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c +++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c @@ -2066,12 +2066,13 @@ static void rkvdec_remove(struct platform_device *p= dev) =20 cancel_delayed_work_sync(&rkvdec->watchdog_work); =20 - rkvdec_v4l2_cleanup(rkvdec); - pm_runtime_disable(&pdev->dev); pm_runtime_dont_use_autosuspend(&pdev->dev); =20 if (rkvdec->empty_domain) iommu_domain_free(rkvdec->empty_domain); + + pm_runtime_disable(&pdev->dev); + rkvdec_v4l2_cleanup(rkvdec); } =20 #ifdef CONFIG_PM --=20 2.45.0