From nobody Mon May 25 05:12:11 2026 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B87A481FB7 for ; Mon, 18 May 2026 13:41:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779111695; cv=none; b=J9IYXoeXJj9ZHWwd6BE1nMfh3pOT8bVNOROitfT3rX8gK7QEgSj3mG5D+GpbAGOPHbLHV8WtoJ3+h8QqR4K1rFuUxlf6726/sXhrR0CwzvKmK3bOjKiQ8h+/xy9APD8i/MzzA7KP96liE9x34w9eSAWVAy30lV9T+VlK6G/R7xk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779111695; c=relaxed/simple; bh=0GMy557X2yIPxBvMxVdGjzD8em/l/TBASpj6hxhrv8I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pJL3H4pXZG9dQWNjibiRmbmTC2Tvry5rbEW4g0UT95SH2bvzbYMN4bPcfDDeVDikThTzSsASYyjk6MfmRPTpA4mP0nxRwE5iez/jDnQfd6tD2+fzxxXoosj9i7IY35AQOKMGb9Wnso/1pOzuC6x2269PP4n0agpnuB2cHSeB3gw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OQt8fH/+; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OQt8fH/+" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-3680540a6efso1131596a91.2 for ; Mon, 18 May 2026 06:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779111691; x=1779716491; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wQ1AlD1AM21fm4X96F6F2/fw1jm8rVL0VNrv0bCYenQ=; b=OQt8fH/+sG0QcNDMPZMk0OAxRTbC97PmpYXNaoSCSq3B3RY2PzXPBcuy9AR0WYl4lL Wbf+ta2fK/+BV+Wxgx5fgYFVl6QqzMpBMC6poICpnIKrxRlSoyYh6LZE4Frj2biIFwqJ 2MzN+nlgi7Mtffn3rqZOqDNxtAoCrLX2J4E2g7yogzrgc9H+vNEhMsQAKlxSBGItdel+ eRjcrTqXaFqJASzrc48+1+KZgcA2U1yaQnLVt4XRIPY0Nh4+0gQ9OIHvRr1OYiWaOM1S mWNtxh6mHuPZ0FnfzBN7eZneGGlJKB+mmLZ75VmvuUyKApUaI5F6oTARa6MRHcJXFv1/ 43Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779111691; x=1779716491; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wQ1AlD1AM21fm4X96F6F2/fw1jm8rVL0VNrv0bCYenQ=; b=PYrQa+pTKGaeQFtQGroXvXBaZBAk2dF0wXeK9wgQEf7EaXbW1K7oZ6pihcAScI9bBz IygQiIgr3kAVmTTHRkTEmvzZoD13J8UKqBUgsfPAFkRlKrEzaBx8yBtqs07rCmKNlJcn g/017hTYqqYcQOt+AxbEWtBti6DzjIovVJJpJ5beM7oXLYkhhIanKEOz7mBlsTYVpLlx xyDtx41kDU+cOPdgLneGKlaUGY8LiB2snCBO1uD5QRh25dV8BfJHW/qCMBKt1OSLtB4Y wFsvTMJ5vBxbNwUxqxWpGqOEE0GTIb9YAJA18kNJdO4U+xtgSb/4RFapezEhu5zj+hAB WO0w== X-Gm-Message-State: AOJu0Yw3ZCgiI+2wwPbsd3Yxld1svQUwU+SnQtUxlWWl/RnSn9S/hc/i F5p9QlwrxH42oQGtn567xGYGIQhDDwLn0WDzaxwVSbC9YFRgINFrswt5 X-Gm-Gg: Acq92OHPI1P/LJUFXjxOe8K/8D0HE+2FsOLT9/U6O1oPbvFuShtwL+A5HsMOUdBfsie e6JvFoIGVIhLu10l/x4RhXmcTYxZt9juTmi+w51AJ2/Mu0QrQwdfdxpGxOnE6umM8Zwy5UOsi2b s7tM4w5VDF19XCwF+NcbaVXZpuJUzamQRuh1DvgncOzLFAOWQpgd7s94YgBc6zZsgPx0ntXmZ9S O15Oez8LpljvdOWfn1ymC37pMzRfctaGULnUOFrQyFGfquiALaCVYnzYvYIndwxmuJPeLqiMWSd BboEIdrIY3RJxl6PPU5SRLh+LvbPYePJLQBNzmtNFmPzT5hsIN2EJkdAYx+1xLgoeGuazVP/R+I i8I+rwYw5uMVfwQVYXPb0FJOlfvBodSldRSijYPU4XfbwJ02Mnv573mfD0acBm9RvYVhlJJG4cj yKijfwxZbUpNJ8A1jtLADl6yD/SX6hWvPXH1jAOR/a7ZeCJRLAwA== X-Received: by 2002:a17:90b:38c6:b0:366:2e1f:393 with SMTP id 98e67ed59e1d1-36951b860a0mr15275923a91.21.1779111690695; Mon, 18 May 2026 06:41:30 -0700 (PDT) Received: from localhost.localdomain ([117.30.62.198]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-369512424b2sm10934575a91.3.2026.05.18.06.41.15 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 18 May 2026 06:41:30 -0700 (PDT) From: Xiaobo Liu To: rust-for-linux@vger.kernel.org, linux-modules@vger.kernel.org Cc: linux-kernel@vger.kernel.org, mcgrof@kernel.org, petr.pavlu@suse.com, da.gomez@kernel.org, samitolvanen@google.com, atomlin@atomlin.com, ojeda@kernel.org, boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, Xiaobo Liu Subject: [PATCH] rust: kernel: module_param: replace pr_warn with pr_warn_once Date: Mon, 18 May 2026 21:41:07 +0800 Message-ID: <20260518134107.4114-1-cppcoffee@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace pr_warn!() with pr_warn_once!() in module_param::set_param() to avoid flooding the kernel log when a null pointer is repeatedly passed. The original code had a TODO comment noting that pr_warn_once should be used once available. Since pr_warn_once!() is now available, switch to it and update the comment accordingly. Signed-off-by: Xiaobo Liu --- rust/kernel/module_param.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/kernel/module_param.rs b/rust/kernel/module_param.rs index 6a8a7a875..fedb709fa 100644 --- a/rust/kernel/module_param.rs +++ b/rust/kernel/module_param.rs @@ -62,8 +62,8 @@ pub trait ModuleParam: Sized + Copy { // NOTE: If we start supporting arguments without values, val _is_ all= owed // to be null here. if val.is_null() { - // TODO: Use pr_warn_once available. - crate::pr_warn!("Null pointer passed to `module_param::set_param`"= ); + // `pr_warn_once` is already available, use it. + crate::pr_warn_once!("Null pointer passed to `module_param::set_pa= ram`"); return EINVAL.to_errno(); } =20 --=20 2.34.1