From nobody Mon May 25 05:13:13 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EDCE3EEAED for ; Mon, 18 May 2026 13:31:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779111063; cv=none; b=T/cmYS5HbVBvvJeYercm4P27vJnxo63CeOXajXnE4Ht0hiq6vDhcK0V89jKEQnnotgMe6WJmeEbLdriJt7/TAkIDlge97DqFkoENTT86hkNd3OYyUO4UXdqUjso0g9BZCGRRU4EcrXcr5DeLNgJ58eqoLR5p59AqdmmR7bbo7sQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779111063; c=relaxed/simple; bh=fNDkdg1th08wSvBrCKMPVzuubzHvT54TjiWW/JRQei8=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Cjnwx/7qeBFMi2HzJFz5fHJRQki9nRB4AMQSwqGtnSlXm373S6m0ZMGosgQsgcHPuxPRGiir7LZOHF0azoyBEJkZJpL3VVeEG4NwzoUTuMnaQoLP71h5r9Occ+DsWukFQnA6YB3HIq18RGViGpfD1IiL6gNegMoTjwUU7/9FIA8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jrMJcsS6; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jrMJcsS6" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2b788a98557so13097435ad.2 for ; Mon, 18 May 2026 06:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779111061; x=1779715861; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=1yAI0jmmafbRoW0vPpmk4MEUcDdrrX1KvUtB3nDkkls=; b=jrMJcsS62LSDmwYVeoUxkEFB5q3IZUjvpchNBim5PAxZk1mw19mtjQIskCgqPZwIx8 4qgHNeG/yP6h+gsKMjf94YrTm1JX1ENXdXEsdduLS5QUUWtxHdJUvLxCqAG+i0ypoiYX rc8HUbilZ22EIGfrGdtBWTDepnVnSC4cvwPug/R3t4QZtBW7B7dI4C8gXal3PHh0anao EB0mKn/pOLD1P75gk2ye0+Lw2VbirbDwU2YkcfyBeOJEWFlj8ca6p0Pk3nUg1Q5S36My 5dcDZmG7naFx979Xon5Kjydyrx/hATlPr+W3sfTwdArkAnx7lUZnE1Imn9ahHrmcReF5 7CgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779111061; x=1779715861; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1yAI0jmmafbRoW0vPpmk4MEUcDdrrX1KvUtB3nDkkls=; b=Gh9930FN9gv/hlrHdxz9bzTUdycL2W+v1YObgXa1uTwR8RKf3yYfpT3wvfC/DWdAxr GW3ZLdVf5w2yO8hThQGlQ6lLBIQwCZffA9Z6x65foeCAVxT+Mo0KPCrlrV2LibC8nFMk YPH0eVwBAXUQYFVw2f8r6B+EHK7jH4ssvKrHvV+HUMyMIxrLab7Q9HaYO1PplpFHjIOg Rdvgja3kCeyQs3XsV9/psOvDSkdVg7yyAEnXO59g4zEB8DItn8ijuHoz1fRZ0Zvz2pxn NB1HgK7LXQZ0Bhyg3/rKI0QnAfj0Kdk4nqkbn3sXJNzDcEKX6Sv8GQqfRnCq7KgPMRf1 gtAg== X-Forwarded-Encrypted: i=1; AFNElJ9lhG26tTHB5dZiU79cxWPvN1eJ/6EchhxA7dWCAkNCedDi1KggqMw3j64kCiqzesyTR7YZr/uLc7ZUTM0=@vger.kernel.org X-Gm-Message-State: AOJu0Yya27B7+CqAKktCHpJan/mvP9uso1lw3YqjhxN5rocG4FcJdl6Y eg3IN1ufm3J9bPP6YQvuoSkKHzcJKD7yGlG1y3HvORKA9SC0xqWk/Ph2 X-Gm-Gg: Acq92OGgjNws7slrzWUBMmV+Y9rcWvtk9vDaAveahPAg5MhfcOsZF4pU8K7/Z44qyBe TajpJBAP+AUcG6P9PKjMaE28O8wzc6vWcOUIphFK8OqjoxLVaw/1X2ODYB0E4JoVya/MZ84inwp eojTezDLkf+kfKFiQxNbb6o5j/BiE79ni0bAv1b+ZAdFRXt3iwFWbx+6tHX+SA8TpIEygIwbo7N 2vQrHwGZsJSajzvbtpShpVDAR2PG2RUjuSZsvPuGB2vmT67/FK6sM4NaeQLAFZ2duI2VKJnJ4WT v0B5Fn2YNaeqEZqVTzHQTFyl4CqDLtc+jZ+a8gLM7ba068qEZ/mSzpMjFaMTvUpS/3igKqUsV+Y 3jvjRxgyRWQQpLpGEHRHColFhaps4GU5nxCTMzVfIp7u7bEIwCwHVIHjiHAtTNPGnhyuXH7dQFj TIoxWs5RaWpF63RA== X-Received: by 2002:a17:903:2c04:b0:2b0:c45a:bc2 with SMTP id d9443c01a7336-2bd7e851025mr163691635ad.16.1779111061414; Mon, 18 May 2026 06:31:01 -0700 (PDT) Received: from lgs.. ([101.36.109.218]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bdc58575dfsm66413545ad.20.2026.05.18.06.30.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 06:31:01 -0700 (PDT) From: Guangshuo Li To: Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Guangshuo Li , Kees Cook , Daniel Niv , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: saa7164: avoid double free on video register failure Date: Mon, 18 May 2026 21:30:51 +0800 Message-ID: <20260518133051.1010695-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" saa7164_encoder_register() allocates a video_device and releases it from the fail_reg error path if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) saa7164_encoder_register() -> fail_reg -> video_device_release(port->v4l_device) Use video_device_release_empty() while registering the device so that registration failure paths do not free port->v4l_device through vdev->release(). saa7164_encoder_register() then releases port->v4l_device exactly once from fail_reg. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: c759b2970c56 ("media: media/saa7164: fix saa7164_encoder_register() = memory leak bugs") Signed-off-by: Guangshuo Li --- drivers/media/pci/saa7164/saa7164-encoder.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/pci/saa7164/saa7164-encoder.c b/drivers/media/pc= i/saa7164/saa7164-encoder.c index 64380741b984..e23b44d1fc3b 100644 --- a/drivers/media/pci/saa7164/saa7164-encoder.c +++ b/drivers/media/pci/saa7164/saa7164-encoder.c @@ -1081,6 +1081,7 @@ int saa7164_encoder_register(struct saa7164_port *por= t) } =20 port->v4l_device->ctrl_handler =3D hdl; + port->v4l_device->release =3D video_device_release_empty; v4l2_ctrl_handler_setup(hdl); video_set_drvdata(port->v4l_device, port); result =3D video_register_device(port->v4l_device, @@ -1090,6 +1091,7 @@ int saa7164_encoder_register(struct saa7164_port *por= t) dev->name); goto fail_reg; } + port->v4l_device->release =3D video_device_release; =20 printk(KERN_INFO "%s: registered device video%d [mpeg]\n", dev->name, port->v4l_device->num); --=20 2.43.0