From nobody Mon May 25 05:12:55 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C9173F39DC for ; Mon, 18 May 2026 13:26:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779110766; cv=none; b=WrqeDUuqdH6h7AqMBXIgj8iOrIsa+pZb6RhNU0dk8XVcDolO8XXn5PJ0wG3H+ZQXw0+ZbST/XY9NnSkcRXbOehEjIg0QziML5JrkGjpC8QNt1CEqxqQ5sDr6Si7y9uN+/0NRzjue4BjB7oyO8Z27cYZugkEem9VxiuJvjKaVDzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779110766; c=relaxed/simple; bh=aYYtkakSthLNbLE32vvN8SQxQ+0QZFQ+RUUJhPN+qlQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UOkLj1NuaIhUTqiGq04PlUZ+sU8ii4nnmfkmB0bKWH725t54aLL91GOlY6WbsBygIesDnN7MAxS9BU4RtnQ+ptPcqFTphcu6aCJsVcvMxhl74E4R2JImepu9OqPxTIL4u+7KTZWtvp6PBfGruY21oYmPg+PEO0WwSrZqB8Y3shM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mzshHVzt; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mzshHVzt" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ba17c8cfacso22525425ad.2 for ; Mon, 18 May 2026 06:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779110765; x=1779715565; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OgGqZu/lBvzHJtzf9xCysSkNq9jit1BxS4Kzrlj9Hvc=; b=mzshHVzty1MHn21iZbE9hfeT/Vpjcdv6b1n/hQGUosfQRZdWQqycT1G6rm/HK/OH9x q5Ik5j6fMCziZEOQhlKnsSL2jVeW9uIjGVuST1DxIJZyrd7HTktYKOZ4v8PP9++e6A1C 9PG7lLq7kFhLptmoIUiZlsW9mVU0UWwHHFtcu2YuViKOTdoJWwUfXrvxpqiATEJpbSdL sPcaxYKpZs7/b6Lzp6Au7feh+pX8j5j0jfpCke5c00826csjmGtKQ2cwi044pzviZKJE 6pesmO/piVkBHM2RLCEzfJvY2wOUrRkGAXApFCEFllTU+ykNfT0+Lx232TDZVEVEk2vG wVcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779110765; x=1779715565; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OgGqZu/lBvzHJtzf9xCysSkNq9jit1BxS4Kzrlj9Hvc=; b=mSSySk0ktkj5/17Abn7DMUQ/vW3Cn/EdztbWQUwy630GbbLMO+9D0SYaGY20fRRR0y kc/Cvv78XZ56lpZB77IJ1aHIaFLO0BymPGP46uCoLuSKDBebE1uwPDj/qb5VTdPaHIdC E4lgoBupJ+1eVrrUJTxZEMIazJGjioJPQzwp6qGJ7JNmhJB6/OgbZJCd2jeJiJwdmkF/ YuCYccxde+8TJd4lFz6sTDl2sCvpNU+m2BpkMBT96lfpjiwXcFjIaPkq7lzv7suBJw39 RdOHkTHGl8ft/4ql1MYklug9RwBRVlUjyWecAbxmgDFr9ZaA0mdtMBeeqoGhKePRySWO BRAg== X-Forwarded-Encrypted: i=1; AFNElJ8j9iPRlzhVsidu3ddt1s1eiDWbkPmPqxGGy04AqQcRoGSdCohYbpEwwoUekAXPur7CZBVA03/wIoADml4=@vger.kernel.org X-Gm-Message-State: AOJu0YyjFTrURb5d8RpvTD39oXtMhZBIr441VuqM6EKlkphLfO3sPdVp i3A7DRsc7QSetCf+eOx2aowYIv9UXRvbMGhaOD/JSunei2fpHHYt+XaY X-Gm-Gg: Acq92OGDl3VTLDe5SezXtRO/3ky/BTVA9gy4jD3QAW+z32fiHfsyjzjihIcESZfBaS+ czEQ1akq0wy2TaObNsAoXVQQGa+CwRsZv3EHgYMN2iIih4YRVSTA8xwPP64nNJv8cHPHqSkYfxj 6fUjAHUDpg0JjPhLn0KaQQUJL0IzIpb2q8oVToCAe/ZOGsAMdBBxjfNgIDfvDB5AcXfGUrqzPd6 /UUqUfJuHb7C0X4Q1+ptj/H0FV4NjTaXnqrpdIRYBAlLSN/IeN51zAh2YtJExivyAQh6m4UgleT aSzPUv9s4cW7xBlOKyp+3CtXNi3ct35biUG9PWUL98/Gftom/tHY6zI/kgZrVBTZ3A95I+RpJ2h BLsUVV0eqzMGeJkN1Rk/CujGr+6JNy2ltnNPNZ1YKO5D0u71GJRaAW22AU+ImLclo4Gw5ajaMky nDheuMUQ== X-Received: by 2002:a17:903:3ba4:b0:2b2:4029:d781 with SMTP id d9443c01a7336-2bd7e8c6819mr166862835ad.20.1779110764953; Mon, 18 May 2026 06:26:04 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5f2cesm153402635ad.14.2026.05.18.06.26.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 06:26:04 -0700 (PDT) From: Guangshuo Li To: Hugues Fruchet , Alain Volmat , Mauro Carvalho Chehab , Maxime Coquelin , Alexandre Torgue , Yannick Fertre , Hans Verkuil , linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: stm32: dcmi: avoid double free on video register failure Date: Mon, 18 May 2026 21:23:44 +0800 Message-ID: <20260518132344.1008402-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dcmi_probe() allocates a video_device with video_device_alloc() and releases it from the err_device_release error path if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) dcmi_probe() -> err_device_release -> video_device_release(dcmi->vdev) Use video_device_release_empty() while registering the device so that registration failure paths do not free dcmi->vdev through vdev->release(). dcmi_probe() then releases dcmi->vdev exactly once from err_device_release. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: 37404f91ef8b ("[media] stm32-dcmi: STM32 DCMI camera interface drive= r") Signed-off-by: Guangshuo Li --- drivers/media/platform/st/stm32/stm32-dcmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/p= latform/st/stm32/stm32-dcmi.c index 13762861b769..a6918fc618fb 100644 --- a/drivers/media/platform/st/stm32/stm32-dcmi.c +++ b/drivers/media/platform/st/stm32/stm32-dcmi.c @@ -1990,7 +1990,7 @@ static int dcmi_probe(struct platform_device *pdev) dcmi->vdev->v4l2_dev =3D &dcmi->v4l2_dev; dcmi->vdev->queue =3D &dcmi->queue; strscpy(dcmi->vdev->name, KBUILD_MODNAME, sizeof(dcmi->vdev->name)); - dcmi->vdev->release =3D video_device_release; + dcmi->vdev->release =3D video_device_release_empty; dcmi->vdev->ioctl_ops =3D &dcmi_ioctl_ops; dcmi->vdev->lock =3D &dcmi->lock; dcmi->vdev->device_caps =3D V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING | @@ -2012,6 +2012,7 @@ static int dcmi_probe(struct platform_device *pdev) dev_err(dcmi->dev, "Failed to register video device\n"); goto err_media_entity_cleanup; } + dcmi->vdev->release =3D video_device_release; =20 dev_dbg(dcmi->dev, "Device registered as %s\n", video_device_node_name(dcmi->vdev)); --=20 2.43.0