From nobody Mon May 25 05:12:55 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC1173126DF for ; Mon, 18 May 2026 13:03:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779109396; cv=none; b=u7nJ/KTDS4O5InR1VSr8+wno0nGWUtCgDw6AwHEXw2VnS8D3F9NATnVIBDucag1LV2cUWQHG/rxd9M4zGh/SY1v71eL4CjE2qOxwo/xCIor0x5BGfPgKiDwOkUIdYaty8n5CMF9ZocoVuy53a1rhdyUkJcGZQNv9NJDsMOd1xgE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779109396; c=relaxed/simple; bh=wssxgGrG4IDoGJpbDk8e0YhsxqyFUXYrnmnvjioRl3U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nUZW5lu5/p1Pppc3E+6TMgr7PQjzQ7FABXSu+fCypsVxooIKk9Jgg/Ys+doopPWda+USgwPUgb1NUDQDWTrEML6Ozn2aRrA5DFSAzjVEFKq7MiYU6ROQtWbk6c6tD39lyUoTkMed3wFaL5a1Y2b/8K/owScOmtBTkzGP+EyTBRE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kUWkxgus; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kUWkxgus" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2b788a98557so12809635ad.2 for ; Mon, 18 May 2026 06:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779109394; x=1779714194; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/IrfhLvzq8OFRdclHXEtAh9TYJ/Z5qr3AsT/nk30p7k=; b=kUWkxgus8M7tfQnXCNl4dgbQeXAmoi6TzUR9/RqzdGDJ1ViQUrnkwIXLChEhcJa3Ax oxL6V0QiiibO6tc/DTLQs2iMVndIgJCNKpDFL7yG0/tIIBcDGMDJOw0phBPwuJPNTHD/ WoGRMdOaiMabOY3ZpMukG4L6Aw5kz9nXWmswhZcQJpLVLSClOZfLadJx/A67ZxEfQYd0 BHah9GCrVtMBSC3uhJ1c7pxDDckTmtej7QkrP17YyaQcoj0lpvfudmd6FB/Pwo/Kol9N HezlFV6qiGalfXdmElkYEjrdGvR+M2vrHqJU7mauhwGQwkmj0cN4OUUxd3bzHKvc0Aqz JDeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779109394; x=1779714194; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/IrfhLvzq8OFRdclHXEtAh9TYJ/Z5qr3AsT/nk30p7k=; b=N3jgmCL3OAOiQoZQUTw1wrb8wgZDtUhtPMLw6+xRlIJ7LgFTIo7JgoOmnAOPzroYee sHBm0WUqJHledmITlSrGKPvP4FPumWuGEcg32FjKxzV4NSDQmRR63Y21cM32X1KXHOh5 S0dn0WMLQzOOo+STp9RM4vp4Iuldudu3lKH8uhkmgXLmk9Xvo9I50Ur6oNsuYQxP+DpC 2+4HJCqVPxM0ywhcdQdp52d5HNxbrV+jgSPXfHGIxVLaRfx05jrP3d756tw1ReWz3BeS XlxcCmTTt0ZWEUy5oWBI/TsSVJ129SF117v9UYEoQMOMR7wNXP3oHWpvC3gnxsGRDw5l 9EkA== X-Forwarded-Encrypted: i=1; AFNElJ8Qloleblgl9okti/R4IIUnHrnrC48lnB7FKzpkcnS6KtzRz47FEdfVr5fDecKEC3+o9DuCgLrCbsKaqlk=@vger.kernel.org X-Gm-Message-State: AOJu0YzjfrQ90d5TSz4RRjHiGL47vqzFPtAl3TKns2WYhrThBVZhtB6I oT498weu7bNN+0zOA4PXi8i4qn7vf5pzIgibJlAo0oqXtQTkWkxILAmP X-Gm-Gg: Acq92OE9IxI9u9w47hrKn52qo+Iyx/VOXtKTxacRZNURAcRI69KjLDmshdTE6aCsmkU KqVtZJMc787GCiGWKti0cO5sWJAEceT4KEe4rfTEqf//uGdRdnpN/UbCI8/zhHLthsoSSdh3dix nvxTEb2C9fAVBaN4xfjiUxPY40SiRjAfuB5xhWejZACTLuryOAjo+qP8PCvONGn/Ix9w9Bc7OPg imkPMD1BNmlraD2uIOtWhmsVTDQ8yznumUC/YzGgYyt2f/3BhLI2TyLxOfbwByuCp8YTdL8CKi8 q7xywIlhu87cV1+xHWNIFlMMFC8M7EYDH0Wm94BrgAY9CTtINKCO6MfuoAR//kwQWHjR5QNMUTF QJ11tyY6RmJMXC/vTYtLE7Jow7M2zyCaYdqifp2OIUDuuOAfkFtuNRWoFz7FDsnAbXPBiprY267 90i6YbN7Xlp1OV X-Received: by 2002:a17:903:28c:b0:2b4:5b82:a8e3 with SMTP id d9443c01a7336-2bd7e8fdd1emr162494125ad.24.1779109394031; Mon, 18 May 2026 06:03:14 -0700 (PDT) Received: from lgs.. ([101.36.106.88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d2360e8sm159283565ad.82.2026.05.18.06.03.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 06:03:13 -0700 (PDT) From: Guangshuo Li To: Mirela Rabulea , Mauro Carvalho Chehab , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Hans Verkuil , imx@lists.linux.dev, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: imx-jpeg: avoid double free on video register failure Date: Mon, 18 May 2026 21:02:59 +0800 Message-ID: <20260518130259.1001956-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mxc_jpeg_probe() allocates a video_device with video_device_alloc() and releases it from the err_vdev_register error path if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) mxc_jpeg_probe() -> err_vdev_register -> video_device_release(jpeg->dec_vdev) Use video_device_release_empty() while registering the device so that registration failure paths do not free jpeg->dec_vdev through vdev->release(). mxc_jpeg_probe() then releases jpeg->dec_vdev exactly once from err_vdev_register. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: 2db16c6ed72c ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encod= er/Decoder") Signed-off-by: Guangshuo Li --- drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media= /platform/nxp/imx-jpeg/mxc-jpeg.c index b442dcba02e7..fe8a373576ef 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c @@ -2943,7 +2943,7 @@ static int mxc_jpeg_probe(struct platform_device *pde= v) jpeg->dec_vdev->fops =3D &mxc_jpeg_fops; jpeg->dec_vdev->ioctl_ops =3D &mxc_jpeg_ioctl_ops; jpeg->dec_vdev->minor =3D -1; - jpeg->dec_vdev->release =3D video_device_release; + jpeg->dec_vdev->release =3D video_device_release_empty; jpeg->dec_vdev->lock =3D &jpeg->lock; /* lock for ioctl serialization */ jpeg->dec_vdev->v4l2_dev =3D &jpeg->v4l2_dev; jpeg->dec_vdev->vfl_dir =3D VFL_DIR_M2M; @@ -2962,6 +2962,8 @@ static int mxc_jpeg_probe(struct platform_device *pde= v) dev_err(dev, "failed to register video device\n"); goto err_vdev_register; } + jpeg->dec_vdev->release =3D video_device_release; + if (mode =3D=3D MXC_JPEG_ENCODE) v4l2_info(&jpeg->v4l2_dev, "encoder device registered as /dev/video%d (%d,%d)\n", --=20 2.43.0